public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Larry Cleeton <Larry.Cleeton@microsoft.com>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Breaking change issue with NetworkPkg/Ip6Dxe/Ip6ConfigImlp.[c, h]
Date: Tue, 2 Aug 2016 20:55:19 +0000	[thread overview]
Message-ID: <BL2PR03MB242798497A98FB649CDFD9CE1050@BL2PR03MB242.namprd03.prod.outlook.com> (raw)

This commit (fdc4b0b147b386e966e99893526181dfae9eaeef) changed a data structure that is stored in an NVRAM variable. 
See NetworkPkg/Ip6Dxe/Ip6ConfigImpl.[c,h]

This data structure:

typedef struct {
  UINT16                    Offset;
  UINTN                     DataSize;
  EFI_IP6_CONFIG_DATA_TYPE  DataType;
} IP6_CONFIG_DATA_RECORD;

Is now:

typedef struct {
  UINT16                    Offset;
  UINT32                     DataSize;    <---------------- changed size in 64bit environments
  EFI_IP6_CONFIG_DATA_TYPE  DataType;
} IP6_CONFIG_DATA_RECORD;

Unfortunately with a 64bit implementation this current structure is now *not* compatible with an existing NVRAM variable written with the previous version of the structure. It's causing me considerable grief so I'm just sharing the discovery.  It would only impact you if you update some 64bit machine's firmware with a new version containing this change.

--Larry


             reply	other threads:[~2016-08-02 20:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-02 20:55 Larry Cleeton [this message]
2016-08-05  3:24 ` Breaking change issue with NetworkPkg/Ip6Dxe/Ip6ConfigImlp.[c, h] Ye, Ting
2016-08-05 15:34   ` Larry Cleeton
2016-08-05 16:12     ` Cohen, Eugene
2016-08-05 19:03       ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BL2PR03MB242798497A98FB649CDFD9CE1050@BL2PR03MB242.namprd03.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox