From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on070b.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe45::70b]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B27DA1A1DFC for ; Fri, 5 Aug 2016 08:34:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=aGnYN4P6xAz6mj8G+BIua4OE9yJKLB6bmmShQ4bpuFs=; b=hve/Mh0WL3RnXLaDwehoTQtiEfnxbhvftrdOHENXdh2eyvUP+qtGqcXnen3YsfwOPTj5FFcmVR94UMWx5qE81kuZ9i0wUi0XIUUZXLIJU2p9DsNFfuI1FX4NmAQCUUq+3QYVb0a/YleMJCYODSJXN9Ck0iOXsoc5MqU0EPUclJ8= Received: from BL2PR03MB242.namprd03.prod.outlook.com (10.255.231.18) by BL2PR03MB241.namprd03.prod.outlook.com (10.255.231.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15; Fri, 5 Aug 2016 15:34:35 +0000 Received: from BL2PR03MB242.namprd03.prod.outlook.com ([169.254.4.48]) by BL2PR03MB242.namprd03.prod.outlook.com ([169.254.4.48]) with mapi id 15.01.0549.023; Fri, 5 Aug 2016 15:34:33 +0000 From: Larry Cleeton To: "Ye, Ting" , "edk2-devel@lists.01.org" Thread-Topic: Breaking change issue with NetworkPkg/Ip6Dxe/Ip6ConfigImlp.[c, h] Thread-Index: AQHR7sj0B1HZ11GncEeG22KXrjVQkKA6fNGQ Date: Fri, 5 Aug 2016 15:34:33 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Larry.Cleeton@microsoft.com; x-originating-ip: [2001:4898:80e8:2::d1] x-ms-office365-filtering-correlation-id: 737ddf4c-c253-4a56-9652-08d3bd46003f x-microsoft-exchange-diagnostics: 1; BL2PR03MB241; 6:pLpnHyaBGEkmulRrdjauCDiV9CPt6YetEk2noLUynT2SOF/GfJhI+FEqFi+35I5mlJaSGXa5vzi8X9YmUzqfFa1e/jAAFCVa2akEqwpfZ+XffwEu/Qg2E2ysHXMwRueoEeo0/x/B9jQT7gsAZBpekm/oael2tuoGHKYs/c5C8tHjWZoMJiZrqd+Wy1i8sFHZMHNbpb+t+jJkq/39sj86+agunFq30zy9bU9MOiJj40XLsXgrisjueOVqfyHjee0OMuQH1C9l8a7bdg3VqiZ9kOgKviu25qH3uW4R2HxJUMDvIlA6ZQhTHY3wVVFBTO4yR/znY8+1CRyBJ0M/ErfRVQ==; 5:yEzlvRvHn9FX1zsfUdtO739osMlWyy6hlXAxog3bRmhMN7BfmlbKsZ1SNBe96GfsIW+lxvT5vvbVpjFqgLpFu2EKRC/Lkq1UkAYCB0EoTBrINQaN9CMa6mnlJrsjHMG05B5tBvL4Q78DYMEIdZK7Rw==; 24:CwPKG+Ow5tvA0210vzQF0wE1G2Rukz3UBC3aq3JSCMM8sGH6Y3zBcjo0ax0ZcEfj8LmNBTpsmxDEniHWpbIrLYwzm3r7zXEP4t2s68lG5qQ=; 7:nf9g0QjTprFxsskzxPy8XVXLLIXfs3G1D2N9tFnSjN650/F5iHPN2rd6lyz9pIdlbrV/09Tymh2YFG5xVJa8jO4Ou04mnIx6qKNmYXFNJxgJ1UJOmNePQTqxUSd0O5YLqVtVe48FsLXfvefkmeXZ6v/i3YMpRV4E7D6YPUWV9OMBTg2RF48j2Wk02ROUlzaSWTDWzJcBrsLgQU9vx1zV3CIRvRapDYzpyHXB8MdQa4uQy1aCkEUwBVdkUYcGDNPm x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB241; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(61425038)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(61426038)(61427038); SRVR:BL2PR03MB241; BCL:0; PCL:0; RULEID:; SRVR:BL2PR03MB241; x-forefront-prvs: 0025434D2D x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(7916002)(199003)(51694002)(76104003)(189002)(377454003)(13464003)(101416001)(106356001)(8676002)(575784001)(9686002)(3660700001)(586003)(81166006)(81156014)(8936002)(2906002)(86362001)(19580405001)(10090500001)(5002640100001)(5005710100001)(10400500002)(10290500002)(19580395003)(305945005)(3280700002)(8990500004)(74316002)(122556002)(189998001)(15975445007)(50986999)(76576001)(33656002)(106116001)(2900100001)(2950100001)(7696003)(54356999)(105586002)(76176999)(68736007)(7736002)(107886002)(92566002)(99286002)(7846002)(102836003)(86612001)(6116002)(5001770100001)(97736004)(87936001)(2501003)(3826002); DIR:OUT; SFP:1102; SCL:1; SRVR:BL2PR03MB241; H:BL2PR03MB242.namprd03.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2016 15:34:33.6669 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB241 Subject: Re: Breaking change issue with NetworkPkg/Ip6Dxe/Ip6ConfigImlp.[c, h] X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Aug 2016 15:34:39 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I agree with your assessment about leaving the data structure as it is. I= just wanted to highlight it as it may impact others. =20 The bottom line is my development group is entirely responsible for vetting= any changes coming from the EDK2 into our product. This one slipped by us= . --Larry -----Original Message----- From: Ye, Ting [mailto:ting.ye@intel.com]=20 Sent: Thursday, August 4, 2016 8:25 PM To: Larry Cleeton ; edk2-devel@lists.01.org Subject: RE: Breaking change issue with NetworkPkg/Ip6Dxe/Ip6ConfigImlp.[c,= h] Hi Larry, We are very sorry about the impact you suffered today. We made the change i= n early 2013 to support the existing NVRAM variable when firmware image was= updated from IA32 to X64. Unfortunately we introduced an incompatibility i= ssue as you raised. Now we prefer to keep the existing definition, since if= we change it back that would introduce another similar incompatibility iss= ue. What do you think about this? Best Regards, Ye Ting -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Larr= y Cleeton Sent: Wednesday, August 03, 2016 4:55 AM To: edk2-devel@lists.01.org Subject: [edk2] Breaking change issue with NetworkPkg/Ip6Dxe/Ip6ConfigImlp.= [c, h] This commit (fdc4b0b147b386e966e99893526181dfae9eaeef) changed a data struc= ture that is stored in an NVRAM variable.=20 See NetworkPkg/Ip6Dxe/Ip6ConfigImpl.[c,h] This data structure: typedef struct { UINT16 Offset; UINTN DataSize; EFI_IP6_CONFIG_DATA_TYPE DataType; } IP6_CONFIG_DATA_RECORD; Is now: typedef struct { UINT16 Offset; UINT32 DataSize; <---------------- changed size in= 64bit environments EFI_IP6_CONFIG_DATA_TYPE DataType; } IP6_CONFIG_DATA_RECORD; Unfortunately with a 64bit implementation this current structure is now *no= t* compatible with an existing NVRAM variable written with the previous ver= sion of the structure. It's causing me considerable grief so I'm just shari= ng the discovery. It would only impact you if you update some 64bit machin= e's firmware with a new version containing this change. --Larry _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel