public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Kurt Kennett <Kurt.Kennett@microsoft.com>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Leif Lindholm <leif.lindholm@linaro.org>
Subject: [PATCH] ArmPkg-Drivers/CpuDxe: Fix Mmu Initialization Problem.
Date: Mon, 26 Sep 2016 22:49:02 +0000	[thread overview]
Message-ID: <BL2PR03MB433CD85371C0E459A0AE40F9CCD0@BL2PR03MB433.namprd03.prod.outlook.com> (raw)

During Mmu initialization in the CpuDxe, for a page table any bits set 
in the 'NextSectionAttributes' are garbage and were set from bits that 
are actually part of the pagetable address.  We clear it out to zero 
so that the SyncCacheConfigPage will use the page attributes instead 
of trying to convert the (bogus) section attributes into page 
attributes.

Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by: Kurt Kennett <mailto:kurt.kennett@microsoft.com>
---
ArmPkg/Drivers/CpuDxe/Arm/Mmu.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c 
b/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c index 63da8ba..64ef1bb 100644
--- a/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c
+++ b/ArmPkg/Drivers/CpuDxe/Arm/Mmu.c
@@ -297,6 +297,11 @@ SyncCacheConfig (
       }
       NextRegionLength += TT_DESCRIPTOR_SECTION_SIZE;
     } else if (TT_DESCRIPTOR_SECTION_TYPE_IS_PAGE_TABLE(FirstLevelTable[i])) {
+      // In this case any bits set in the 'NextSectionAttributes' are garbage and were set from
+      // bits that are actually part of the pagetable address.  We clear it out to zero so that
+      // the SyncCacheConfigPage will use the page attributes instead of trying to convert the
+      // section attributes into page attributes
+      NextSectionAttributes = 0;
       Status = SyncCacheConfigPage (
           i,FirstLevelTable[i],
           NumberOfDescriptors, MemorySpaceMap,
--
2.9.0.windows

K2



             reply	other threads:[~2016-09-26 22:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-26 22:49 Kurt Kennett [this message]
2016-09-26 22:51 ` [PATCH] ArmPkg-Drivers/CpuDxe: Fix Mmu Initialization Problem Ard Biesheuvel
  -- strict thread matches above, loose matches on Subject: below --
2016-09-26 17:22 Kurt Kennett
2016-09-26 22:05 ` Ard Biesheuvel
2016-09-26 17:08 Kurt Kennett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BL2PR03MB433CD85371C0E459A0AE40F9CCD0@BL2PR03MB433.namprd03.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox