Re: [edk2-devel] [PATCH 1/5] MdePkg: Add definition for NVMe Over Fabric Device Path

["Sachin Ganesh via groups.io" <sachinganesh=ami.com@groups.io>]

Hi Felix,

Corrected and resent the patch.

Thank You,
Sachin.

-----Original Message-----
From: Felix Polyudov <Felixp@ami.com>
Sent: Monday, April 15, 2024 11:04 PM
To: Sachin Ganesh <sachinganesh@ami.com>; devel@edk2.groups.io
Cc: gaoliming@byosoft.com.cn; michael.d.kinney@intel.com; zhiguang.liu@intel.com; Dhanaraj V <vdhanaraj@ami.com>
Subject: RE: [PATCH 1/5] MdePkg: Add definition for NVMe Over Fabric Device Path

Sachin,

> +#define MSG_NVME_OF_NAMESPACE_DP  0x20

UEFI Specification defines this as 34, which is 0x22 Refer to https://uefi.org/specs/UEFI/2.10/10_Protocols_Device_Path_Protocol.html#nvme-over-fabric-nvme-of-namespace-device-path

>
> +typedef struct {
>
...
> +  /// Unique identifier of an NVM subsystem
>
> +  ///
>
> +  CHAR8                       *SubsystemNQN;
>

This should be:
CHAR8                       SubsystemNqn[];

Here is why:
1. According to edk2 coding conventions, only first latter of the acronym is capitalized Refer to section 4.3.4.3 @ https://tianocore-docs.github.io/edk2-CCodingStandardsSpecification/release-2.20/4_naming_conventions/43_identifiers.html#43-identifiers
2. The structure contains the actual string, not a pointer to the string.

> +} NVME_OF_NAMESPACE_DEVICE_PATH;
>
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117806): https://edk2.groups.io/g/devel/message/117806
Mute This Topic: https://groups.io/mt/105540403/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-