From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4B81AD8083D for ; Mon, 15 Apr 2024 20:27:05 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=O5qdcgmS4EoD3ozKEiIGwXU+nXljJTfxPOCSqLmv330=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1713212823; v=1; b=WezDn2Tv0FqcRMET9BePIUMTiFQhYk09H+m5mt/gLPLG+n5np8WNrjaVGyeEAvy8Fr0hcjrP qf/A5PisQq8XF8l/FZpz/FzItgXo8bC3Zrf+aYVitMg1QEjQQwXE61d+uGfQTSNsg49KQQNx2ct As0AeDwz+tKlC28CM3XHt8uqVonVzhZ5sd5SW4zHpdPNIPpym2pP/NoJ+QDAAi5tSlNCEq/xaAF 40BCKov7WjWw1yu6+WCd6l/bLs9pnOS0/jTLtKG0nIohP6Ak85gxCEt2VqZVl+UO/8QJr3pF4NI sEhQmmVfKZKRp+RXoVmmG6NI0ui8rYHomW16DklCsqRYQ== X-Received: by 127.0.0.2 with SMTP id mlf4YY7687511xWGZe4SmTec; Mon, 15 Apr 2024 13:27:03 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.125]) by mx.groups.io with SMTP id smtpd.web11.2747.1713211146710542939 for ; Mon, 15 Apr 2024 12:59:07 -0700 X-Received: from BL3PR10MB6161.namprd10.prod.outlook.com (2603:10b6:208:3bc::16) by CO1PR10MB4674.namprd10.prod.outlook.com (2603:10b6:303:9c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Mon, 15 Apr 2024 19:59:03 +0000 X-Received: from BL3PR10MB6161.namprd10.prod.outlook.com ([fe80::78e5:e1a1:9770:f20a]) by BL3PR10MB6161.namprd10.prod.outlook.com ([fe80::78e5:e1a1:9770:f20a%5]) with mapi id 15.20.7452.049; Mon, 15 Apr 2024 19:59:03 +0000 From: "Sachin Ganesh via groups.io" To: Felix Polyudov , "devel@edk2.groups.io" CC: "gaoliming@byosoft.com.cn" , "michael.d.kinney@intel.com" , "zhiguang.liu@intel.com" , Dhanaraj V Subject: Re: [edk2-devel] [PATCH 1/5] MdePkg: Add definition for NVMe Over Fabric Device Path Thread-Topic: [PATCH 1/5] MdePkg: Add definition for NVMe Over Fabric Device Path Thread-Index: AQHaj1SROaEThGjqQUSkcgbBR1587rFpl3cAgAAfXQA= Date: Mon, 15 Apr 2024 19:59:02 +0000 Message-ID: References: <20240415164627.2464-1-sachinganesh@ami.com> <20240415164627.2464-2-sachinganesh@ami.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BL3PR10MB6161:EE_|CO1PR10MB4674:EE_ x-ms-office365-filtering-correlation-id: cea78ba3-e888-44ee-b13d-08dc5d867fb9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: Ufngq1nxaTAsPeG2rRaGBKV+K+F/lpRujyxi7r4+kXxUGYuBzCNZ/VLUqZUH193OJE1KbDwJeJqpt00CC2nYfj3aXxt8dl2Lhkq1exrfx3+zoc31n3PlteUeJwq76IJwk4Rc2Xx5p7vI9GUHX9RAPuycJ3BPOzUVHV3mJQnJTZSe+KFzLYXqV6BmqmW8tbtmvFTrzFw4ekFxASCB8zu5BiMrHwRtHNPrEmCLzg3veqgr/7k2U5FVXg21Ud9fmnnzLClNvUpYAKJQEm4y8lpAmTYCDkW+K5mIslywnLF+wl4AlgFzsiWSaWvZ2UC0BszI51RGRIQneBI/ZMTeO0kWI8qudrk1v9O/Msm0wzZQCEYWpvmIedDZ7t4a3UpmR3FJZ4oFbmzlAo7hwMVNGYsM+VC6Jp+BNbt2gsrFul93IitgoF8VVlpzAqbMWOZu/QPNdpowLYmW9MlkDDq4jGpQvR0hDBxwlPLgOrTLljZ9dHaW1EGhJhGvqiBtAUXJMVm5PoSgn+qxd33+T4QDsJQivBSjamvxLCIaD+Ecw7WWjN8Knj+TprjxYj6X9cJtQ8J9B8EMVvKMu8V8T5y3ZEOAD0lvQpevEGf0wlJG303LnVU0bQWjeYovyrAyU2WQwKmzeUcZLBXccnj11dRFkNFO69uEDFIvqzZVrNtYH3sFnT4= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Cv/eoo9oh1N2TOc8ZVv6vw5jeRCH8Zsejz3NzDrZspwtemB+4x7CxqnL5bF6?= =?us-ascii?Q?0Qan8O8Txl1IAWnUzKzk4iR5JgQZOxZ+j3n/AZbJte5s+zM20vjfkjQRsrSy?= =?us-ascii?Q?mKomTPToKj+TxLC86iIjgdWgcI802ElZMS3DN2AkA5B85edb12HzanHFd5sT?= =?us-ascii?Q?V8Tl5pYhelF4/1Xr4GtmATurqzqR7GGbMkMNU7MBkAIs71tkCzI0QF6DyJIh?= =?us-ascii?Q?ghOXIXWcZpofQkDVGAJ9z18fZcIyrdhxDA7eH5b+hEV9wzpv1fqtJneRy4+P?= =?us-ascii?Q?8Um1bIn/FkQUKSHYF339iGBMNdD/qoAde3P4BX7LFyiLBg4W6/APQ67am7po?= =?us-ascii?Q?xj8PbwfWaVyOtg0FlMly5ELgPjaTeT7Wr1yuUnxpxak3L9ygEC9avh+jLSyJ?= =?us-ascii?Q?XoB5n9hvOZTIHMqRKoL+a78WGtf7nh9pHwRLwpTI2iDjbcoWfNSRTMvqR2Uy?= =?us-ascii?Q?9xTt5lOL475hvlOku6o4BuJQz0vV4IKtFEO0yFRkesDav5OhpcO1cWBHfqHz?= =?us-ascii?Q?HjAqoNnYqGogerPSI/RDmPF0Fop6e//9TaAUg3YlNsCAMaOGx3o4ARWYij6w?= =?us-ascii?Q?Cy9c0wkQVsEcB58Pzm7eji6PlteJFi7ak61l1fiJjs4pKPmwKuVouIjGXw2I?= =?us-ascii?Q?Z9CqUu4jWQzKY1TFPUOIUlqYVU798CjTWbhhbzVyM4gwkb9yHOIH5tsKZaPV?= =?us-ascii?Q?zz+WAhpJ/V/soThzepgbz1HAYn19WFVRwQ89A+ODR3IEqUYl4tH9udTvDN8y?= =?us-ascii?Q?pS1ipqIKu1l0EggyaBWPD6l48sblh9St6zKiizKBiAHBMedN/ed7EiZhjqL6?= =?us-ascii?Q?ySRmcRwjnDVJcBcCW2oYlZzx0ROu3garTRwEDTBkU7ofqbtOat/z3CTIbbhD?= =?us-ascii?Q?WmSs9Fay2CdaPSXgi4xnPVvuPW5Vo4kEZ6zkA06iCe813Y1B075BksJNnrkV?= =?us-ascii?Q?sDJWsaD2HJBuJ8SpKDCzS8GYsP3S4EjPES/V/fioAI0tXSYki2wHLBV862OJ?= =?us-ascii?Q?XdtEU/bAJcD0P2rWTMR30nepTwH9k9pK1quTOMplCPChDia+TgvpvNN/vIaW?= =?us-ascii?Q?7LLjxNBHkzVPhULIhKXrGIn6l38MaWtEP2WQpTUYmTJwzF+8Ig9xbpUpVewR?= =?us-ascii?Q?A1r5E0eoX9PWQMEJcghVwTws/ZdnOFFkuUMhGpia7U/UhnpiiZi6l4RLZXtX?= =?us-ascii?Q?5jyWJJMnTmY/xHLwyOT6By/alF1R4mXbRlwxfBvS3vTmRDweUSsK3L/puqbX?= =?us-ascii?Q?1I1ciT+Gn602LYQsnaZiQRAlQvTPNcOpW/blJCTZPGHrpHmb3EgVwDA+dm5O?= =?us-ascii?Q?yARY489ayQGDbB2WeKnsOYmjE0KbhgzT7LzQR+W+R7F6lLjNstwXjBzcn8JE?= =?us-ascii?Q?Gd3Y3rG4UaFElO4wifBnzSrivdfvPOZR+0TY6A/dxC48IgKy2XXHLPbYhFBX?= =?us-ascii?Q?dFrp0V+TCTubr6wrOydL87fSRGdo4yAJF8yJZlsPdj3pEpjj10ix86I5tZoZ?= =?us-ascii?Q?HGAkDy0O+kCjrNDQwscb+rXe94w8Kx4FvbsLZjrDA0c80k+br6SmA2LnRe36?= =?us-ascii?Q?NeROZX/QDKLFu1YN5XA+LYIfX1DhjVi/nHlIzbO6?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL3PR10MB6161.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cea78ba3-e888-44ee-b13d-08dc5d867fb9 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2024 19:59:02.9238 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: v1KnTvPGUVU2EESuBJZKVE8g++KkTqrsMYBbPXuSJyZKnDQcOdZbDeGxne+PijJRmvtQ/6dclWAD5R/ND750ew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4674 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 15 Apr 2024 13:26:58 -0700 Resent-From: sachinganesh@ami.com Reply-To: devel@edk2.groups.io,sachinganesh@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: KxtZK7OdTVT8Vb8v2heEYA9ux7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=WezDn2Tv; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=pass (policy=none) header.from=groups.io Hi Felix, Corrected and resent the patch. Thank You, Sachin. -----Original Message----- From: Felix Polyudov Sent: Monday, April 15, 2024 11:04 PM To: Sachin Ganesh ; devel@edk2.groups.io Cc: gaoliming@byosoft.com.cn; michael.d.kinney@intel.com; zhiguang.liu@inte= l.com; Dhanaraj V Subject: RE: [PATCH 1/5] MdePkg: Add definition for NVMe Over Fabric Device= Path Sachin, > +#define MSG_NVME_OF_NAMESPACE_DP 0x20 UEFI Specification defines this as 34, which is 0x22 Refer to https://uefi.= org/specs/UEFI/2.10/10_Protocols_Device_Path_Protocol.html#nvme-over-fabric= -nvme-of-namespace-device-path > > +typedef struct { > ... > + /// Unique identifier of an NVM subsystem > > + /// > > + CHAR8 *SubsystemNQN; > This should be: CHAR8 SubsystemNqn[]; Here is why: 1. According to edk2 coding conventions, only first latter of the acronym i= s capitalized Refer to section 4.3.4.3 @ https://tianocore-docs.github.io/e= dk2-CCodingStandardsSpecification/release-2.20/4_naming_conventions/43_iden= tifiers.html#43-identifiers 2. The structure contains the actual string, not a pointer to the string. > +} NVME_OF_NAMESPACE_DEVICE_PATH; > -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117806): https://edk2.groups.io/g/devel/message/117806 Mute This Topic: https://groups.io/mt/105540403/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-