From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.25349.1627266883724774338 for ; Sun, 25 Jul 2021 19:34:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=xxMthMJ5; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: heng.luo@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10056"; a="191737090" X-IronPort-AV: E=Sophos;i="5.84,269,1620716400"; d="scan'208,217";a="191737090" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2021 19:34:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,269,1620716400"; d="scan'208,217";a="504544794" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 25 Jul 2021 19:34:42 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sun, 25 Jul 2021 19:34:42 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sun, 25 Jul 2021 19:34:41 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Sun, 25 Jul 2021 19:34:41 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Sun, 25 Jul 2021 19:34:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KHqtmcDLokXXHabMErcI5VXoDVMSoPDUdZgs5fHHnA97ZiJB8nP9aA0fItdAEpWcr0ApJoMY5uzZvj5h6gJ8QrUNr6KyaiYo6R7XAahH1C9ESCsuUygHCDzD/dup3uWtV5G0Y1F8VOq03mhHkXJChgrmmIxxNWfVYtyjBm9E4wHzK3Gpn+0LYzlw7GUZBAX7lJgEX04iGsPKPQuHmLOJ2YD9DggaZ3xobRH7wfIkQtE5NDej7FMQN/DBLPOY7tHfuxvmnofCHy+6lge1rDyHZ4Qb3gN6sDDz1iIhWIaDXb6KjvF4fr+mXZLaYb03mYMJuBYh5h9g7a8vRuSiv2lVMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+74x23cLjeKAwYlO5P3fMciOw3EOxPc2nSDvY6WY0lg=; b=Wl8pNGukHjBrAs3ADeYJBJBs3ru/cb5L6mBOQi41uzaPJ4szyxYHCblUTT+lAxbADoKw3UaRcWxBc2AloV7+NChWPvcjV9k9vXQNgmMDyL2y0JEEYojIhB9XUDUdz6BlNjIHdMcdmwY+pWCsCMdztxeWkLqjeWTg3Pz12/4nCkfUOmn3pPsUNr1KWBpgfqgXGbemLnZ5sTu9C9E4eDH67U5/fSZoi29yrOD2Ws90e+CjerAUpsTlG6VdjwqRGGnDMyMUHa5fiKuGdQ3fwC47hSFevTahW53ZcXU8oibQmQ2creNjRGpQKbQjEe3et2BqUveoODKaLWwo4GeESQGZ6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+74x23cLjeKAwYlO5P3fMciOw3EOxPc2nSDvY6WY0lg=; b=xxMthMJ5laKiiKIb0IBc44PfSV0C4U3f9+ioZ/3ftoaA8vTr5VQxIHP1tb97AARNo7EoFmjRrg5frO1dEayDNUugZ4pRi72CGXkTUHtfme0C36gj5ZRrRs6PzgzIwz7U+IlOXC3gf4XEwOa0hQtOim3fsp1XU1b7AFOJS4BYG5w= Received: from BL3PR11MB5745.namprd11.prod.outlook.com (2603:10b6:208:352::9) by MN2PR11MB3584.namprd11.prod.outlook.com (2603:10b6:208:ef::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.28; Mon, 26 Jul 2021 02:34:40 +0000 Received: from BL3PR11MB5745.namprd11.prod.outlook.com ([fe80::e0b4:cd22:703a:388b]) by BL3PR11MB5745.namprd11.prod.outlook.com ([fe80::e0b4:cd22:703a:388b%9]) with mapi id 15.20.4352.031; Mon, 26 Jul 2021 02:34:40 +0000 From: "Heng Luo" To: "Clark-williams, Zachary" , "devel@edk2.groups.io" , "Rabeda, Maciej" , "Wu, Jiaxin" , "Fu, Siyuan" CC: "Goetz, Philippe C" , "Nagar, Rupa" , "Zhuang, Qihua" , "Lu, James" Subject: Re: Adding HTTP boot IO timeout programmability from PcdHttpIoTimeout Thread-Topic: Adding HTTP boot IO timeout programmability from PcdHttpIoTimeout Thread-Index: Add/cGjvDr7dHPKtQYa7jYciLQ4X6ACU6OxQ Date: Mon, 26 Jul 2021 02:34:39 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ba0a1f11-c2d0-4627-7d5f-08d94fddeb1e x-ms-traffictypediagnostic: MN2PR11MB3584: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3276; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aEyGFeyeLckMnqz+COW8dKnJUc8zmF7DE/JGLJCKIaU/oeG0Q0H7DWDm3vMCHrucTZj36JuEaVEw2ZIvD3WKhQ7KVGNzCTmGS3VVSNBx6Q6ZGnLVjlJoFf9vSUHn45NfdG8BkKky7Dz+ZZ3hkbkdCjqllmfdXtKEh0Ts2d55vEu7pmzsd6CD7aDYvas/a+VbWOzifWRRDIarUbjWgHf+/GK6nmAiejHFPHdBXCInwufuygE2+Vr6NIIwclLir9xZE8N8287HC3KXQcVvpU8SQx6v4K685UG6MjXLP47jSmaEAMXu25HRS2YWi10pV+l7ruH5VAFRg7f/ijR9amIU+uCpQYs4Ks2WYNpF7PUAlSapVSZG3jj8KUwr4f5oS/iPOB8Zs0E12cNs5M1eWT7vpTXiIYM8T/IJ9QaHzdsOcVQIR1izdp0dVqCfshdsFdrXOUyEQRkqECZyjnf8V+eOjmLRPQPUykFAmPdSm6j9R5xhT68MU0cWTWI0yI/6CGZklIiDR4uZ7NkeR8RV8+6MTJ56Wod+8LF6t1qsdl+hGesKiyP9C9UgJeiEkdbfD99UzOngmG+2yg2/h8qKTNuwkLZIRn5ryiXstUY9+ecc+Ik6lb0BxULnl+YMVT/JAGhcgpQ2xdbj6gMufYqE+BRq8g/tih7I+bBnEfVoVYx1TJTIy1D/Fr00bqkDuzPtKk1bMr/8XLknTuXsu8ShHXLweGXOSCtKrptxB9vBihx7iswETOGB/Qr9VnDqXvFrIyPH91W8jwUAULyG/kL5/oxsToQfX4lxltWUBaAMgIN5aamZJR1M/gJZPniFhzMkaYnVRR71jxILKrCr8c9Uelj+/A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL3PR11MB5745.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(366004)(7696005)(186003)(38100700002)(8676002)(66446008)(26005)(64756008)(66556008)(66476007)(122000001)(76116006)(66946007)(6636002)(33656002)(8936002)(5660300002)(52536014)(55016002)(83380400001)(316002)(2906002)(71200400001)(966005)(4326008)(6506007)(9686003)(166002)(86362001)(53546011)(54906003)(110136005)(107886003)(508600001)(38070700004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Q76S8vrOp2wXvzUbWj38PerKBK5awa4rGkiHHuUvcPRDRU2BnXO2UQnesaAa?= =?us-ascii?Q?bHynFaYWiOhqgVcWUlrlkktsoDEjM0XRyJyrT8eINr0nyWdXuj+8yYpCuJq5?= =?us-ascii?Q?4JKYN5oQchzTZSbVuGTGK4uqSItnWj9yHhbdUNMUgjlWiHyusJsrBl+RQgkE?= =?us-ascii?Q?ODub2LDS/RWOvtdTu73efBJlWL+0F5ay8SDtiXk/GRVZSOvKfdWKUYj5KwO2?= =?us-ascii?Q?qcU3sbm8RFsY2YJgGN5dFZIrJa0PodylEnPAaGk2sHYbpTjkN+YP/QEe9ZpN?= =?us-ascii?Q?BAL5sfwWTEuQmrGR5viXNvGyom5+srn2hh/0rnxOtBq6yA2zOD3UNHLkNZjH?= =?us-ascii?Q?oET3Sokq2hdFPLvgrZ8I27DQYCh1gRQkMGme+WKgywyEjiH8/RV8GRgo+2gY?= =?us-ascii?Q?I17Ld1TBFBMHGDmJsJxc8gJNZoWYGZtmdKkQRFdaQQlmCzbU7eHh4EBTzULu?= =?us-ascii?Q?rjbelMi7yAY2WiQDr9Zxt4V8tD+6f0xpMhvEvBpn+2DJaOi2yXNfKpTeYQ7m?= =?us-ascii?Q?nYpgUI1JeBg9RvKIgpDEbrX5Dvy1lwRY1Lhp4H5tx+nSxF7Ne/K6EBVUc92Q?= =?us-ascii?Q?3jRzkBnao96PtxnUIb+VRD7bpalLaxNYvcLNsxXjPksI1K46BfA5EdmgWuqA?= =?us-ascii?Q?u45BXsn/MiiT/9p0Pziqatl8pYTAfTtJHvd4pfhSmOOdPisZf3uVamMqAjcv?= =?us-ascii?Q?mVa2tbtZCYzdLOKBZhxNuYVHWxDB6d5j+cN+DNNJ3Wbm6PRTOjp9Ky2BKczw?= =?us-ascii?Q?t+rdLTLs8fRFhnbS07S42WV3Tad/6m3FFHZ5SI0qdWMz+9gM5CK7tZ58GqHu?= =?us-ascii?Q?eEHRTFKQ31KsIFgb85pPw/IdKJ2rF4JsMlhYxA5OHOTYhaiIps8MfYzW9Sc3?= =?us-ascii?Q?aNcoFQDKiHugrXjeltD3eY5cELuBocDDNAuQVmFdAMQv/3JOf2JzhKdghlW8?= =?us-ascii?Q?AZOyQ11yvP2tGQDJ5n9tFBIbngDg7QliwKFyWTlESG++3rwqWr7Br1M2ug/E?= =?us-ascii?Q?PW27CBi78PHDXLr1/55ZUSx2FEHlRSaRjDfSpJ/OSn+A5lAJdmGBisDi82Wk?= =?us-ascii?Q?kyqfXRnb9bw/dPxUJKzQL4TN0jMxkTDN3RBOtOsGwC9Wh9yDn3s02Fz9PsdG?= =?us-ascii?Q?mh1xjy/2kJc9D7rMk41W+wY9ceqDtji5UqUzAQleArBimQyjWPkLO4WnELW1?= =?us-ascii?Q?QKXoIW4k2ay2XShkfEFjNGORiUtMMXL3SrQeNi2T2c4SVCf+s+tGdihwJnUV?= =?us-ascii?Q?/C1JqySINKoJrhlVwO8iYhQTxirAEaKPaQYDewY2p86i0h4nVjg1uXtJ7LKs?= =?us-ascii?Q?zpAlLn6r7Md+gdXjCFpzPrzW?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL3PR11MB5745.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba0a1f11-c2d0-4627-7d5f-08d94fddeb1e X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2021 02:34:39.7490 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: E/lUtKkFmuAKjFPdIlf57R7fKFCektTt1gwwBog2z4FrsI6phTnXsIJDNytCTRGSgw3mQ3hGV0h2n0WwVGLy4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3584 Return-Path: heng.luo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BL3PR11MB574509D99C523C3A015915B693E89BL3PR11MB5745namp_" --_000_BL3PR11MB574509D99C523C3A015915B693E89BL3PR11MB5745namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable + NetworkPkg Maitainer/Reviewer Hi Zachary, I notice you pushed the patch to https://github.com/tianocore/edk2/pull/183= 4 But according to "The developer process for the EDK II project" In https:/= /github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process Normally we send the patch by mail, I recommend you send the patch by mail = too(use git send-email *.patch): The developer process for the EDK II project 1. Setup the EDK II tree if you do not have one * This is document on the SourceForge to Github Quick Start page 2. Create and checkout a topic branch for new feature or bug fix $ git checkout -b origin/master 1. Make changes in the working tree 2. Break up working tree changes into independent commits that do not br= eak git bisect * Commit-Partitioning * To stage all modifications: $ git add -u * To add new files: $ git add * To have git prompt you to selectively stage changes: $ git add -p 3. Follow the commit message template given below when writing commit me= ssages * Commit-Message-Format * To commit staged changes: $ git commit * Add the -s parameter to automatically append your Signed-off-by= tag to the commit message. 4. Use the 'PatchCheck.py' script under 'edk2\BaseTools\Scripts' directo= ry to verify the commits are correctly formatted * To check the latest changes: $ python BaseTools/Scripts/PatchCheck= .py - * For example, 2 changes would be: $ python BaseTools/Scripts/Pat= chCheck.py -2 * It is strongly recommended that you run PatchCheck.py after each c= ommit. You can then easily amend the commit to correct any issues. 5. Get the latest changes from origin $ git fetch origin Note: This updates origin/master, but not your local master branch. (origin= /master may have newer commits than master.) 1. Rebase the topic branch onto master branch $ git rebase origin/master 1. Create patch (serial) to the edk2-devel mailing list * Clean out any old patches: $ rm *.patch * Generate new patch files: $ git format-patch -M --thread origin/ma= ster * Add the --cover-letter parameter for long patch series. (Be sur= e to edit the cover-letter.) * Add the --subject-prefix=3D"PATCH v2" if you are sending out a = second version of the patch series. * $ git send-email *.patch 2. Modify local commits based on the review feedbacks and repeat steps 3= to 9 * For the latest commit, you can use $ git commit --amend * For multiple commits use $ git rebase -i origin/master * Consult your git gurus on edk2-devel or irc channel if you have qu= estions. Thanks, Heng From: Clark-williams, Zachary Sent: Friday, July 23, 2021 11:15 AM To: devel@edk2.groups.io Cc: Goetz, Philippe C ; Nagar, Rupa ; Luo, Heng ; Zhuang, Qihua ; Lu, James Subject: Adding HTTP boot IO timeout programmability from PcdHttpIoTimeout Hello, Please review the attached filed EDK2 tracker for feature enablement of pro= grammable timeout of the HTTP boot IO timer. NetworkPkg-HttpBoot: Making the HTTP IO timeout value programmable with PCD= . REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3507 HTTP boot has a default set forced timeout value of 5 seconds for getting t= he recovery image from a remote source. This change allows the HTTP boot fl= ow to get the IO timeout value from the PcdHttpIoTimeout. PcdHttpIoTimeout = value is set in the OneClickRecovery driver from the value provided by CSME= . PcdHttpIoTimeout minimum value 0.5 seconds PcdHttpIoTimeout maximum value 120 seconds PcdHttpIoTimeout default value 5 seconds Thank you, Zack --_000_BL3PR11MB574509D99C523C3A015915B693E89BL3PR11MB5745namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

+ NetworkPkg Maitainer/Reviewer

Hi Zachary,

I notice you pushed the patch to https://github.com/tianocore/edk2/pull/1834

But according to “The developer process for th= e EDK II project" In  https://github.com/tianoc= ore/tianocore.github.io/wiki/EDK-II-Development-Process

Normally we send the patch by mail, I recommend you = send the patch by mail too(use git send-email *.patch):

Th= e developer process for the EDK II project

  1. Setup the EDK II= tree if you do not have one
  2. Create and check= out a topic branch for new feature or bug fix

$= git checkout -b <new-dev-branch> origin/master

  1. Make changes in = the working tree
  2. Break up working= tree changes into independent commits that do not break git bisect
    • Commit-Partitioning
    • To stage all mod= ifications: $ git add -u
    • To add new files= : $= git add <path-to-new-file>
    • To have git prom= pt you to selectively stage changes: $ git add -p
  3. Follow the commi= t message template given below when writing commit messages
    • Commit-Message-Format
    • To commit staged= changes: $ git commit
      • Add the -s param= eter to automatically append your Signed-off-by tag to the commit message.
  4. Use the ‘P= atchCheck.py’ script under ‘edk2\BaseTools\Scripts’ direc= tory to verify the commits are correctly formatted
  5. To check the lat= est changes: $ python BaseTools/Scripts/PatchCheck.py -<N>=
    • For example, 2 c= hanges would be: $ python BaseTools/Scripts/PatchCheck.py -2
  6. It is strongly r= ecommended that you run PatchCheck.py after each commit. You can then easil= y amend the commit to correct any issues.
  7. Get the latest c= hanges from origin

$= git fetch origin

No= te: This updates origin/master, but not your local master branch. (origin/m= aster may have newer commits than master.)

  1. Rebase the topic= branch onto master branch

$= git rebase origin/master

  1. Create patch (se= rial) to the edk2-devel mailing list
    2. =
    • Clean out any ol= d patches: $ rm *.patch
    • Generate new pat= ch files: $ git format-patch -M --thread origin/master
    • Add the --cover-let= ter parameter for long patch series. (Be sure to edit the cover-letter.)
    • Add the --subject-p= refix=3D"PATCH v2" if you are sending out a second version of the patch series.
  2. $ git send-e= mail *.patch
  3. Modify local com= mits based on the review feedbacks and repeat steps 3 to 9
    • For the latest c= ommit, you can use $ git commit --amend
    • For multiple com= mits use $ git rebase -i origin/master
    • Consult your git= gurus on edk2-devel or irc channel if you have questions.

 

Thanks,

Heng

 

From: Clark-williams, Zachary <zachary.cla= rk-williams@intel.com>
Sent: Friday, July 23, 2021 11:15 AM
To: devel@edk2.groups.io
Cc: Goetz, Philippe C <philippe.c.goetz@intel.com>; Nagar, Rup= a <rupa.nagar@intel.com>; Luo, Heng <heng.luo@intel.com>; Zhuan= g, Qihua <qihua.zhuang@intel.com>; Lu, James <james.lu@intel.com&g= t;
Subject: Adding HTTP boot IO timeout programmability from PcdHttpIoT= imeout

 

Hello,

 

Please review the attached filed EDK2 tracker for fe= ature enablement of programmable timeout of the HTTP boot IO timer.

NetworkP= kg-HttpBoot: Making the HTTP IO timeout value programmable with PCD.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3507

HTTP boot has a default set forced timeout value of 5 secon= ds for getting the recovery image from a remote source. This change allows = the HTTP boot flow to get the IO timeout value from the PcdHttpIoTimeout. PcdHttpIoTimeout value is set in the OneClickRe= covery driver from the value provided by CSME.

PcdHttpIoTimeout minimum value 0.5=
 seconds

PcdH=
ttpIoTimeout maximum value 120 seconds


PcdH=
ttpIoTimeout default value 5 seconds


 


Thank you,


Zack
--_000_BL3PR11MB574509D99C523C3A015915B693E89BL3PR11MB5745namp_--