From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.2539.1626747545005143056 for ; Mon, 19 Jul 2021 19:19:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=bYw4CEra; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: heng.luo@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10050"; a="210885534" X-IronPort-AV: E=Sophos;i="5.84,253,1620716400"; d="scan'208";a="210885534" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2021 19:19:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,253,1620716400"; d="scan'208";a="468795944" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga008.fm.intel.com with ESMTP; 19 Jul 2021 19:19:03 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 19 Jul 2021 19:19:03 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 19 Jul 2021 19:19:03 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 19 Jul 2021 19:19:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S4IH8m3B3HjtSrQx/ShRxMqlKmN2awsc3q1fjH+JU1cEGMw9ukzb7vm0VxmZN7Ac4+tdURKxIcTAZF8LgqWRLzi8IxlQ6h58/C+wkLBZX7dWrzrv82mIoWSKYx+BOJ0qvobPWZJXIIgVz0tUjr3uy3UWDBiuLgItrf4cgjwJxTyKbkTLl+ArglGhI9jXUDQMx0yRym7S+rPaf8+F+Xb76sWDcZ9bMdiIOh2wqcukVU7j/BD2xKIZ7HI2U5w5ST9be5JOxoSJt+2bbiSIaLbl2rdwCSoBt0GdYC5vE+KEn2TmuxISqPHdvKPZyZemf6NxVhTp/HlpjyJmz9XnFuZ2mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LkqNx6rjosTZnoIAAeq5IMEsT5g8cbv6ycBgKoSQ6gI=; b=gyIVdhIHJekx2jsqOIzf2/hH8cR+yyvPBFTLhK5AS5fdN2rMKQkeeGclU5slblB9oaRHV5DkAQ9FxC0zUl0XWkRl4wqkoyk9sxwu4EVGTDccISSu9Uv/usnv02eVD7e0AAhRRadBu/reu62ZNbBMAUotUjzj6WURwxlhuFZIi+xOGt1vRnXNSswV1J9xK+G7J60kH/dAmbuzcIBbXu1tSWynTUYA+HorvT2zlRqYKH5RYkOu09alQCVUqZm3/IV5OR9AUljv3W7QeJbDsX53fVt41e4yHhtnNgx1ssnw8LEW+BZLkpZ09vRbWSni7sed4E2yNDts4V9C+yy7HiXXlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LkqNx6rjosTZnoIAAeq5IMEsT5g8cbv6ycBgKoSQ6gI=; b=bYw4CEra7REDdJ4FkUdnGegWwrLdC8vxkvsyxUmnz99k/kwMgGlrZhkFjh3pLXjwG6z9Tqpc2OFQ138n/5IXkjHT+tCC7QPu9bfIwRrizNUFwr6Im7LJBKkVKkvOZZiH4G8A6Py3jaxfDTL4Pq0cl85bb8BT89bwFCu2aYmsyIY= Received: from BL3PR11MB5745.namprd11.prod.outlook.com (2603:10b6:208:352::9) by MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21; Tue, 20 Jul 2021 02:19:02 +0000 Received: from BL3PR11MB5745.namprd11.prod.outlook.com ([fe80::e0b4:cd22:703a:388b]) by BL3PR11MB5745.namprd11.prod.outlook.com ([fe80::e0b4:cd22:703a:388b%9]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 02:19:02 +0000 From: "Heng Luo" To: "Wu, Jiaxin" , "devel@edk2.groups.io" CC: Maciej Rabeda , "Fu, Siyuan" Subject: Re: [PATCH] NetworkPkg: Add HTTP Additional Event Notifications Thread-Topic: [PATCH] NetworkPkg: Add HTTP Additional Event Notifications Thread-Index: AQHXfJaUJI4c1gbgX0OEHRhUylLM7KtLFIawgAANQVA= Date: Tue, 20 Jul 2021 02:19:01 +0000 Message-ID: References: <20210719120629.805-1-heng.luo@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0f10dbd4-de4a-4a5f-fc90-08d94b24bd90 x-ms-traffictypediagnostic: MN2PR11MB3821: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ahW4rKMaGQ+pSYHmqC7jnVUh4+xryUv5hz18cZ9P6csdvK3teQOUiYGdKM+OFvAveLrrXT6BtZUoi7eKi35PHgf224rRbvJvX3AQPIFyugoQv1MrkvlNPLj9PmnosxZ9bBUSG+3s5Pp9R033rbDO4ZxwjmZmZI+vV2W42HJqPE8JjzU3JfryPqvp9jr0TkJy4zoFTOofSqRxE5AoDCdMBnF+9Sm1gPH6+AOu5y//wcs9827DLmJJ62uHnGY7SAj6Lu1mu3LX4B00x7NlS+IvV4bA5kwDSaU2ne7n8Jfr6LqLaw1ICmFE/oLgIsOLOOzTRZxscisfValW8IBOuLg1O0uAO7B0kBTtSiF95W0c4TcKZr776yXH9fgYvog3rAaiWfZNr9OegOXIHzRxo4GrBwQlng3l8xuhQKi+IjfRv4CFSilthD5ZnrCFmaOjoKHbbgU75caSLr7EEk/7bq85CDpa4+1e97KNTxKEvW9EszqR0WMVFkyERpq3c88r5wmhuN94y4TEGLxVAg73rURsZ73isrLLZTwH103EFBmmX9B0+uqG1TCsRDwD6roiYGGtVZSuvndSu7PC3OvrfDL7Y6cJCJknA2Zb1Hu3ytxzrQ/oKjb/wI0GklpjWHv7IbhXAhtClKFS1vERtiPKVnnENsWd/hAwdDf004J1V755DHzahlNTdvnaLQZgvbnJ6BoDr17wogAiZ6f/urVUIZuhSA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL3PR11MB5745.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(376002)(396003)(136003)(39860400002)(346002)(52536014)(66556008)(71200400001)(15650500001)(64756008)(66446008)(66946007)(76116006)(66476007)(86362001)(5660300002)(6506007)(83380400001)(38100700002)(53546011)(33656002)(9686003)(478600001)(7696005)(55016002)(4326008)(2906002)(8936002)(122000001)(8676002)(186003)(26005)(54906003)(316002)(110136005)(38070700004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?g4bfLGsDm3ePcW73kJNjA/q1I+MiSdee7nEO+tOZ4DtoGbCQ5+E3+pa0lDdf?= =?us-ascii?Q?RzQ7w8d7JMh33m2MIYHSRrlBINen7GwO7cA/ew7npf3uJ/Ga+CViGUEnMbB3?= =?us-ascii?Q?hpx64PqILKhODORqDcfn/k+VMKs+nCKtour+gnFf7QnYmHTPB141KvRKzXsR?= =?us-ascii?Q?MTSCIwrKmGdS4ai1IOuWaFNqXhOdEwpSV7dCXqdatMsYziTXU6G6k06hyPsp?= =?us-ascii?Q?7qK07wZG4I3wXmNQiY68tyBNNfWRmk8duEhzgfO+qJXzXuNSD1RotEls5+l8?= =?us-ascii?Q?mn6ZUgl8sD5JRi20ULEhAnEkZ2QTLUXXwYWIYtWZ2UgCX2RxMhALFgfzEVd+?= =?us-ascii?Q?5uDJYsqEJ/wQUphJrF27ZDZDPzqmsDuBuN9QT+TGtbK2lTZSaTsUrgB5LkWx?= =?us-ascii?Q?IyE+0abKuZ+1aBLOkzQwRhT1/tumvCOsr7jdZ6bpa2Cks4gEOW12yo9KSOL5?= =?us-ascii?Q?ECsFWH7Zz8uqApLhqzynlPqda6bTK42dTwSEoxHyQej5esuiGpVumnd7pYZ0?= =?us-ascii?Q?9t8FSfh7lkPRCphTeaOnsVjoqKTkSBNe+tW08CL9wkkS85sJ4ZQ6Zh7RdM8x?= =?us-ascii?Q?QXzAXQR2YlN1zm5DEN9DMYB6W+scz0q5BVYWR2Gi5JBgjFbB/RTHw4HDFcXc?= =?us-ascii?Q?P7akotAL4yxiOCEr28GifEwkA/oDmLOi243MbiAWFALdlKDkqFyolEHeA3GD?= =?us-ascii?Q?WSzdhhi+zJ7nW9InJfrF8edCfqyVkBEPYVFb85XevzO+I+5iuymOEpxlbXsC?= =?us-ascii?Q?SDbTaj5tpAXYaHDEcB6G1T+TqW8aKucUV50mNe/4vUMZLJp1vi+c5V07KIQL?= =?us-ascii?Q?MhcqDVc3VnDL3Z6Dcfv7Bd+CC1Sw+PpiT8pWWRQJQubaLty/8eYcNijoUfL8?= =?us-ascii?Q?/1dQzAV5/+rkK3kbklcNpUHjoAx49NguBILUkql3hLK0MmGfc4K6V4zWoQsz?= =?us-ascii?Q?oesieSC/3Pdr6fg3unmPMpqyZRjJ3RG1okX3mKnRSVJSgEzhasTJTdKsMwDg?= =?us-ascii?Q?R7SNax3ESRB+I7FZwTDtV7HQh/92OZywvKVsXnQhPycpq0gBBXfyQaB+T+bv?= =?us-ascii?Q?qDZrdRT/qpnXy2Md4ONZPMsaqj8sUEsxmxcP7LhbUn2Nhfx9l5YOJd12hh/y?= =?us-ascii?Q?wwg/b0yDixSAdYtp3lbQ1f7ITUeEMt8glGXWg7RrmSn6V4KN1wgApYz0GeHK?= =?us-ascii?Q?y+RvtKPugL4JCutL0Ls2HPL5sBaAteqZ8Q7TYOPrbMxsvxpPTaY4N51eEUzd?= =?us-ascii?Q?UftZ45BtbX+cFNkPE9vW0akhfk38nhZJwNMuMVDM4GvV9aOTAn6UmxT6ilxP?= =?us-ascii?Q?8WoS/LYKkUwQ0Zsep6okRrn1?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL3PR11MB5745.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f10dbd4-de4a-4a5f-fc90-08d94b24bd90 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2021 02:19:01.9294 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xmmQ78pZ9djRvTuYp1MQ9iFSXYusyUEwIu3pTOpipy7K44xfZRnnzBB3q4t3RsA+Zl8G0CdFbzDkRxs305rIIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3821 Return-Path: heng.luo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thank Jiaxin, the patch V2 is sent out following Jiaxin's comment. > -----Original Message----- > From: Wu, Jiaxin > Sent: Tuesday, July 20, 2021 9:45 AM > To: Luo, Heng ; devel@edk2.groups.io > Cc: Maciej Rabeda ; Fu, Siyuan > > Subject: RE: [PATCH] NetworkPkg: Add HTTP Additional Event Notifications >=20 > For the below EDKII_HTTP_CALLBACK_EVENT definition: >=20 > All event is to retrieve the event Status, so the comments should be made= clearly > and align with code returned status, for example, >=20 > > + /// Retrieve the host address, EventStatus: >=20 > There might be the misunderstanding you want the host address, but actual= ly, > you only want the status. It's better to be: >=20 > > + /// The Status of DNS Event to retrieve the host address. >=20 > The same to all event. >=20 >=20 > With above changes, the patch is good to me. >=20 >=20 >=20 > Thanks, > Jiaxin >=20 >=20 >=20 >=20 > > > > +/// > > > > +/// EDKII_HTTP_CALLBACK_EVENT > > > > +/// > > > > +typedef enum { > > > > + /// > > > > + /// Retrieve the host address, EventStatus: > > > > + /// EFI_SUCCESS Operation succeeded. > > > > + /// EFI_OUT_OF_RESOURCES Failed to allocate needed resources. > > > > + /// EFI_DEVICE_ERROR An unexpected network error occurred. > > > > + /// Others Other errors as indicated. > > > > + /// > > > > + HttpEventDns, > > > > + > > > > + /// > > > > + /// Initiate a nonblocking TCP connection request, EventStatus: > > > > + /// EFI_SUCCESS The connection request is successfully in= itiated. > > > > + /// EFI_NOT_STARTED This EFI TCP Protocol instance has not be= en > > configured. > > > > + /// EFI_DEVICE_ERROR An unexpected system or network error > > occurred. > > > > + /// Others Other errors as indicated. > > > > + /// > > > > + HttpEventConnectTcp, > > > > + > > > > + /// > > > > + /// Connect one TLS session by finishing the TLS handshake process, > > EventStatus: > > > > + /// EFI_SUCCESS The TLS session is established. > > > > + /// EFI_OUT_OF_RESOURCES Can't allocate memory resources. > > > > + /// EFI_ABORTED TLS session state is incorrect. > > > > + /// Others Other error as indicated. > > > > + /// > > > > + HttpEventTlsConnectSession, > > > > + > > > > + /// > > > > + /// Initialize Http session > > > > + /// EFI_SUCCESS The initialization of session is done. > > > > + /// Others Other error as indicated. > > > > + /// > > > > + HttpEventInitSession > > > > +} EDKII_HTTP_CALLBACK_EVENT; > > > > +