From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web09.19069.1629688535447185540 for ; Sun, 22 Aug 2021 20:15:35 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=eNeBIaw+; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: heng.luo@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10084"; a="217053168" X-IronPort-AV: E=Sophos;i="5.84,343,1620716400"; d="scan'208";a="217053168" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2021 20:15:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,343,1620716400"; d="scan'208";a="535174529" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 22 Aug 2021 20:15:34 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sun, 22 Aug 2021 20:15:33 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Sun, 22 Aug 2021 20:15:33 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Sun, 22 Aug 2021 20:15:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LnUnyceHOL32KeaAgLT1fMpYjrLGeIJylwMei4L2BlCd7a2qC7LAJhPbhG1G63Ns6/fIt2041nZYoHYkFa5FtEpj0/BsMjKtQ3GZ31gn8XC07TnwNpjtIVeabB99+lEyRiMvjOmje00PtcC7/Fk/cZEmXebiQTGDqDE0J/htulKfA2NiBmMBpuGWgMht36YBbn7Q94zb/e6sQN9Q658l9RVgbUj0NSZbW9tH1eo73P8F/+YIB7XFgh1nRTMI3pgkRZyKGSMW18ENXx9E+/iGu4yyV0jmGR1w52o3dvr/vfTL5NFQsoMqgpYF24VVN5VhPx4eEQTpiqHo7yWn6hXQ8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4YjTAdddrVJTcA3m190+QA37xFQIroQLAd4V4atvwKY=; b=JU13nDNeGGnd5BeMQP/f99lSSW0bfDnoGlW5+QQgGAauAZArAFYr/qSjmv8XQKRsqFxrnX2uodqZzIvHXeHG2b43Ke7BeitfE6a+Pq2egaPRFL7fPgytjQlxbZ2sdn3KZ0DaEgbEkzZcWNo4YrRwtHknhHwiLQhanOb6vglxEl3HHWEhZdRmddXzuDAXchyd3Ai1NeN8OcwVZu7B431zAJQmL5P1mVsVyX54FffcSvrGMaXDCTY0gKypvEgCwy1NTS0bSWIHT3H3mA3LpCxVZAVB6xxnfQLtUKwKh7HxWJDhvHTMHxdX57EYSQtiNF+V42G/yvLnoHQOuLXP/oJNRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4YjTAdddrVJTcA3m190+QA37xFQIroQLAd4V4atvwKY=; b=eNeBIaw+MmngdPtMVQIwr0bDhD/KnGgTV6YIhdynocusaVsLjLsoojVJtAm8xyf59W8BH7BTWjK38sP+av+/gaUqSv9+iHbnM02N3tkHwDV/qfsE2lZNv3pinOtVx3bsMH/cxzszsrSDrchZIS7d/p4uG+Xv8VjrE4EghnfGe1A= Received: from BL3PR11MB5745.namprd11.prod.outlook.com (2603:10b6:208:352::9) by MN2PR11MB4728.namprd11.prod.outlook.com (2603:10b6:208:261::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19; Mon, 23 Aug 2021 03:15:32 +0000 Received: from BL3PR11MB5745.namprd11.prod.outlook.com ([fe80::a11b:a0c8:46ac:f391]) by BL3PR11MB5745.namprd11.prod.outlook.com ([fe80::a11b:a0c8:46ac:f391%9]) with mapi id 15.20.4436.024; Mon, 23 Aug 2021 03:15:32 +0000 From: "Heng Luo" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Desimone, Nathaniel L" Subject: Re: [edk2-platforms][PATCH v5 23/46] TigerlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib Thread-Topic: [edk2-platforms][PATCH v5 23/46] TigerlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib Thread-Index: AQHXiHh4iOhhIgGZLUGaEA+GGZCxTauAiUkg Date: Mon, 23 Aug 2021 03:15:32 +0000 Message-ID: References: <20210803150042.1150-1-mikuback@linux.microsoft.com> <20210803150042.1150-5-mikuback@linux.microsoft.com> In-Reply-To: <20210803150042.1150-5-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 365aefb5-d70e-4f26-a9f0-08d965e44481 x-ms-traffictypediagnostic: MN2PR11MB4728: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: joQRJ+TWCcelEmOo3m8Aoo12QaeWh1P0NFNO+gmqJkUu8BGX1BqYOF57v2GNcibbMEUKKzz8DR6aPnVRzbR0lVh1vTJmbTtZrJhxG7bDNARMIvONsrwtFdpW27YEeOufyD/PoREl3VT0i/AM/ILrni2e4/Exk8wWJaxY8rjfo55cOtpNwBn+qf79HAc2GdpXn8J0qqkWFpEZoscP3B+I7VF8X3RtuKgxBjxpG7QvGFX9q/r1j+E269IN4sUfYZH0t4asF8DPDoesfehsxjbWhmedwP5WFQ/4CYdb8Q4TErDiNi7Q61BDUZstnUtxrOP5qczM15pJ57y+9vLdBK4tNp67uFQJkEB0GnT78n1tgCVg3ohv8GfiAlHQ0trnpA9sAZCcIgBoiiJaKuMBGVxPgUbYK8PJhjjlNAhzhohkuoYAlbnRtD8AcwcKxiW+WBoBI0vVjDmacjfVBBzpLhQNC9cGLIglF1OkwbKvdFvkOudPuip+yWEeUJCRCMsbpdeDy0s7eRxjc/DcLQ+nseqymBBYzH4bR8oXfL+Zmdkv/oY9YU6XDzSSNFxiwUDbsL2F9/UkAGvgqf8p7OffkxGUHzeI0/WCJ42jUSjcELfsXUAi4c0Q+hqt6EIgt1Ro8mH1sJnOy9K3LbzGYNVYix8DrgfvcAjGzxziIBDybp8vMbpY8B6dmbveOW+8rehBj3UkAjLjvabDFdv4P8NeR3859HdWkU1+pKCNECjPi67o1PXbZFb4Unuj1SygfNXZuc92BA30GmHVTAWF9PR9XLgiwQ6nr09XUP4SX1kM1giUBBU= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL3PR11MB5745.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(8936002)(53546011)(5660300002)(55016002)(52536014)(66476007)(38100700002)(122000001)(38070700005)(66556008)(66946007)(64756008)(6506007)(71200400001)(2906002)(66446008)(9686003)(86362001)(4326008)(26005)(316002)(110136005)(33656002)(508600001)(107886003)(54906003)(76116006)(83380400001)(15650500001)(8676002)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1xN3i1bT5YuI+IxNf92BeeAbdv9XY/a1ie9jbS/i8XXWxBch/8a/yeWFsraQ?= =?us-ascii?Q?PElP1gXd8DP/vn2limsloYiJ9pyi8AVCJJLy5QZXPjGgQ3ZD6G5xmEORCkVx?= =?us-ascii?Q?ZS6Ta8NYdoSqVaXvvB2VJLeMuFPblBcE5arKfQK3Yg0GEZMOCf0B6/kEQjkv?= =?us-ascii?Q?uuv4J8g1MyNfwqLbmq1YGuswe5ICgYvqbh/xb/xJyNGRBK6esEZ674DSdbJA?= =?us-ascii?Q?h4CGFfzknNOzPlPFHJf9PyOqaGcS2ZywxEx9k4ZBTMoVWO65uhaTKRtz/G+B?= =?us-ascii?Q?u8fqzXleIHLOXXVG/5gdV5rZJz4zd2uoDGtXOW8vj1Z62gsvNH3WX9hzhYHt?= =?us-ascii?Q?8MROuwJPLs5urAPhBzhMM5Tj7k7VH0ZOGHXRLcCAiz5RwFWT1zWpKxHT0hE/?= =?us-ascii?Q?6RSPWUr23bUsj64GCke4DojsCnlF3YaQGwPRxQ2FIcfNOxomvz3OVHR12ZUa?= =?us-ascii?Q?Z/NI6s/aeWdUcBDHcPS9h2HEt8ZkPsGmZm4mZqoHsOQmNevyLIUp9+2OH3XN?= =?us-ascii?Q?hvRlH0EGlu1NIdJbKyCQG8KMc6JvIhN9bcYtMyuunoofGvBtWdyt/c+2Wx6G?= =?us-ascii?Q?24N5VpGsvkfDCJ4VS6vs0/xeBnOJUrO98twBZLYIC1ufRFGpFcH4SHV9O1zK?= =?us-ascii?Q?Pj1Xg4zS6G6p53WU+oyOLbyHDmFAQaYs+umH8ZsDDiWGTHpJ8R8dCDy2kqWa?= =?us-ascii?Q?NFbhrEGZu2IRU3gBctBb+pq2Zw0mOe9sdcUTywugpNPvXo34/Vx+403pxnkH?= =?us-ascii?Q?343jk1g6uc5iEcaaiPC5l61EIx7CS5tFfeDoqHBov3L09BgZILn4GRsES0AU?= =?us-ascii?Q?SRlS45vjz1TXDuIy2pRYd9x1Fl4s3Lyvo1IndJce+8cwAtfki/kMaGUFFx0a?= =?us-ascii?Q?j50LDHzbEO0WuL9r6cFcZYQaLb1lxDyJ0ZqJv7+AJZh0P2dDvRy6Hl7U3Tk4?= =?us-ascii?Q?rvUBm8JYhbCM8PNTUpP0UZzHuminqKOCB2arx3phAU/f5gSdb9U6LV9ecY6k?= =?us-ascii?Q?6OFB8SOHGZKg41VZgXaTpHWKRfZTYTKXYPjr2eTPpSVIyNdlmpHgqj0E48sy?= =?us-ascii?Q?K5BsTceKjksRGkdSvMH31OviwD168fRMYfXkBWKcj+LPSmFfk2WrESRqlTTJ?= =?us-ascii?Q?VN2X3uxORyy/BJLFMta7hgg0q0z/WN75Canj5dnbfWHPuRCqAGsorgA+WywL?= =?us-ascii?Q?HbY7dLVKcFmng/vEgyOOxjjYsRcvdkvoHi+LLUpHcD3Bc9P2mvGhTJTa1U1S?= =?us-ascii?Q?geYspLHNE3V1lJnI9lPiBIseJPSDbR3InNilZaVEzzQ8FZ7SwpGFG+bqENzg?= =?us-ascii?Q?MtORMCbcpETH2Bb5uAS1+Wyl?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL3PR11MB5745.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 365aefb5-d70e-4f26-a9f0-08d965e44481 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2021 03:15:32.4907 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VQ+Ixv8B2ZOo9HNEUp1c57Y9gq+zJVBCpNBaDiImPUMQmvRMGkBpNyTFFTfMx4mcY4sdh6lqmmiG44Mx5+HUVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4728 Return-Path: heng.luo@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Heng Luo > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Tuesday, August 3, 2021 11:01 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L ; Luo, Heng > Subject: [edk2-platforms][PATCH v5 23/46] TigerlakeOpenBoardPkg: Update > SpiFvbService & SpiFlashCommonLib >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 >=20 > Updates TigerlakeOpenBoardPkg to use the SmmSpiFlashCommonLib instance in > IntelSiliconPkg and the SpiFvbServiceSmm driver in IntelSiliconPkg. >=20 > Cc: Sai Chaganty > Cc: Nate DeSimone > Cc: Heng Luo > Signed-off-by: Michael Kubacki > Reviewed-by: Nate DeSimone > --- > Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc | 7 > +++++-- > Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fdf | 2 += - > 2 files changed, 6 insertions(+), 3 deletions(-) >=20 > diff --git > a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc > b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc > index 1adf63403450..758b966fee81 100644 > --- a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc > +++ b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.ds > +++ c > @@ -173,7 +173,7 @@ [LibraryClasses.X64] > !include $(PLATFORM_SI_PACKAGE)/SiPkgDxeLib.dsc >=20 > [LibraryClasses.X64.DXE_SMM_DRIVER] > - > SpiFlashCommonLib|$(PLATFORM_BOARD_PACKAGE)/Library/SmmSpiFlashCom > monLib/SmmSpiFlashCommonLib.inf > + > + > SpiFlashCommonLib|IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiF > + lashCommonLib.inf > !if $(TARGET) =3D=3D DEBUG >=20 > TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/Sm > mTestPointCheckLib.inf > !endif > @@ -297,6 +297,10 @@ [Components.X64] > !include $(PLATFORM_SI_PACKAGE)/SiPkgDxe.dsc > $(PLATFORM_SI_BIN_PACKAGE)/Microcode/MicrocodeUpdates.inf >=20 > +!if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly =3D=3D FALSE > + IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSmm.inf > +!endif > + > # > # SmmAccess > # > @@ -326,7 +330,6 @@ [Components.X64] > NULL|$(PROJECT)/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.i= nf > } >=20 > - $(PLATFORM_PACKAGE)/Flash/SpiFvbService/SpiFvbServiceSmm.inf > $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitSmm/PlatformInitSmm.inf >=20 > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf { diff --git > a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fdf > b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fdf > index e3b2f048524c..b802c2167d06 100644 > --- a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fdf > +++ b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fd > +++ f > @@ -434,7 +434,7 @@ [FV.FvOsBootUncompact] !if > gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly =3D=3D FALSE INF > $(PLATFORM_PACKAGE)/PlatformInit/SiliconPolicyDxe/SiliconPolicyDxe.inf > INF > $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitSmm/PlatformInitSmm.inf > -INF $(PLATFORM_PACKAGE)/Flash/SpiFvbService/SpiFvbServiceSmm.inf > +INF IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSmm.inf >=20 > INF UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf > INF $(PLATFORM_PACKAGE)/Acpi/AcpiTables/AcpiPlatform.inf > -- > 2.28.0.windows.1