* [edk2-platforms] [PATCH V1] TigerlakeOpenBoardPkg: Remove inaccurate comment
@ 2021-08-29 1:18 Nate DeSimone
2021-08-29 17:43 ` Chaganty, Rangasai V
2021-08-30 0:41 ` Heng Luo
0 siblings, 2 replies; 3+ messages in thread
From: Nate DeSimone @ 2021-08-29 1:18 UTC (permalink / raw)
To: devel; +Cc: Sai Chaganty, Heng Luo
A comment in OpenBoardPkgPcd.dsc states that FSP
dispatch mode is not supported, which is inaccurate.
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Heng Luo <heng.luo@intel.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
.../TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc | 1 -
1 file changed, 1 deletion(-)
diff --git a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc
index a048efcc18..ebbbc7b9f9 100644
--- a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc
+++ b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc
@@ -30,7 +30,6 @@
#
# 0: FSP Wrapper is running in Dispatch mode.
# 1: FSP Wrapper is running in API mode.
- # Note: Dispatch mode is currently NOT supported for this board.
#
gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-platforms] [PATCH V1] TigerlakeOpenBoardPkg: Remove inaccurate comment
2021-08-29 1:18 [edk2-platforms] [PATCH V1] TigerlakeOpenBoardPkg: Remove inaccurate comment Nate DeSimone
@ 2021-08-29 17:43 ` Chaganty, Rangasai V
2021-08-30 0:41 ` Heng Luo
1 sibling, 0 replies; 3+ messages in thread
From: Chaganty, Rangasai V @ 2021-08-29 17:43 UTC (permalink / raw)
To: Desimone, Nathaniel L, devel@edk2.groups.io; +Cc: Luo, Heng
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
-----Original Message-----
From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Sent: Saturday, August 28, 2021 6:19 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Luo, Heng <heng.luo@intel.com>
Subject: [edk2-platforms] [PATCH V1] TigerlakeOpenBoardPkg: Remove inaccurate comment
A comment in OpenBoardPkgPcd.dsc states that FSP dispatch mode is not supported, which is inaccurate.
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Heng Luo <heng.luo@intel.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
.../TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc | 1 -
1 file changed, 1 deletion(-)
diff --git a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc
index a048efcc18..ebbbc7b9f9 100644
--- a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc
+++ b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd
+++ .dsc
@@ -30,7 +30,6 @@
#
# 0: FSP Wrapper is running in Dispatch mode.
# 1: FSP Wrapper is running in API mode.
- # Note: Dispatch mode is currently NOT supported for this board.
#
gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0
--
2.27.0.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-platforms] [PATCH V1] TigerlakeOpenBoardPkg: Remove inaccurate comment
2021-08-29 1:18 [edk2-platforms] [PATCH V1] TigerlakeOpenBoardPkg: Remove inaccurate comment Nate DeSimone
2021-08-29 17:43 ` Chaganty, Rangasai V
@ 2021-08-30 0:41 ` Heng Luo
1 sibling, 0 replies; 3+ messages in thread
From: Heng Luo @ 2021-08-30 0:41 UTC (permalink / raw)
To: Desimone, Nathaniel L, devel@edk2.groups.io; +Cc: Chaganty, Rangasai V
Reviewed-by: Heng Luo <heng.luo@intel.com>
> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Sunday, August 29, 2021 9:19 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Luo, Heng
> <heng.luo@intel.com>
> Subject: [edk2-platforms] [PATCH V1] TigerlakeOpenBoardPkg: Remove
> inaccurate comment
>
> A comment in OpenBoardPkgPcd.dsc states that FSP dispatch mode is not
> supported, which is inaccurate.
>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Heng Luo <heng.luo@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
> .../TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git
> a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc
> b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc
> index a048efcc18..ebbbc7b9f9 100644
> ---
> a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd.dsc
> +++
> b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkgPcd
> +++ .dsc
> @@ -30,7 +30,6 @@
> #
> # 0: FSP Wrapper is running in Dispatch mode.
> # 1: FSP Wrapper is running in API mode.
> - # Note: Dispatch mode is currently NOT supported for this board.
> #
> gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0
>
> --
> 2.27.0.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-30 0:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-29 1:18 [edk2-platforms] [PATCH V1] TigerlakeOpenBoardPkg: Remove inaccurate comment Nate DeSimone
2021-08-29 17:43 ` Chaganty, Rangasai V
2021-08-30 0:41 ` Heng Luo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox