From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.1987.1667847995078245543 for ; Mon, 07 Nov 2022 11:06:35 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=jDQVDS7B; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: judah.vang@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667847995; x=1699383995; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=JCqNVXvvA1wf1FV67WKsppONZhvTOS4oc098gGiHMPY=; b=jDQVDS7BTaj/IEsLUzdU5rUaUbZDajqN/05meOc4B16WJj2Cg3yShgTH t5ChTywvDtOxy58WuCoDxGI1Gy8ODj0M5eCslOjdAYjVZ/Efd1bUYFotU 9hy6jVeJi21n26UjgFSRcFcLCwS2U8c54HB8dRpc1KTXQxf7rsMOzoMDm 8UbpITuJECpSvOV/k5UG1tdci278zDDmOTrEfbe2TPCnQKsafKOmqJ63v fhP8pk8QUfH/FbxFpxkUHw253X10CIIV9Rlmva8F/lOsYj5L9cJfp5P+r 5upjyI2Ycjh9AqA/GfCWCtVVheD43r4JFq7i4Sxcscdx/yn9LS2y8r/6i A==; X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="308120628" X-IronPort-AV: E=Sophos;i="5.96,145,1665471600"; d="scan'208";a="308120628" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Nov 2022 11:06:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="667293080" X-IronPort-AV: E=Sophos;i="5.96,145,1665471600"; d="scan'208";a="667293080" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga008.jf.intel.com with ESMTP; 07 Nov 2022 11:06:34 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 7 Nov 2022 11:06:34 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 7 Nov 2022 11:06:33 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 7 Nov 2022 11:06:33 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.42) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 7 Nov 2022 11:06:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fdIGHxIhwHutMhR1T2iNQcxClOFnLLO/wKa15D6gp5y1EortjTKhV+zgvrZUypMbLflhT9tSsqHQd2ZIxSWPCB733uYdFg6MfBJEHQD2j+Hu2beNIjRfj2uY1eFCHX+fv95qUN21Px1hXpulCTdmdBoxUaUuAQawMXgzJJShKVC//HjMvCtaEZG+MUd3jrM7f16wE/uqJ79fK87T/+sh9FVE4WKeyecOxMtGRS7hYUWBKyiGOPistutdj+0tcn78gttfUr70GU+HX2/T1Jick+4+ipQxAozLL7jOtj0mylRV4SWKdZECdCldCioF5jVNDv1JUOp/xNwNPYjahUI2AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hDnCvY+gzPWAGXem75l5XKJSQxHXV4oHytSy/31/FOs=; b=XB17wFiKbTWkGHCq5QppthKAVBDfGS6ysKQDO2dwN6w2EYVOXCSQ+R1Cqa/nY8+GY4LuO8Mx/0Ot4ildbpGcTd0EmQ56uLSFmozH5V9LZsBumQ03wYtP2qTKW1ML0ZslOCZ9pR5hb3pJ4jTAGIBrC+yEAAgqKqBhI47ZiEros5yDTNAm8++3G6GwpAi/KP/BchLtsdqOtOGMXSNNl1v8RhiVKoOhhTm/jrluhzKNzfb5Wn0+6mO8KyJXMwhLhevDovruwcbedTXfdnxi8Ow41CNaxLTx0oH1Jh/EFqpLbhmyNOHUqigD3kXDFW3Q4AiQLXkuHmkoWqqmGQDolxwXwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BL3PR11MB6434.namprd11.prod.outlook.com (2603:10b6:208:3ba::22) by SA0PR11MB4669.namprd11.prod.outlook.com (2603:10b6:806:99::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Mon, 7 Nov 2022 19:06:30 +0000 Received: from BL3PR11MB6434.namprd11.prod.outlook.com ([fe80::f352:7c4d:8b5:c701]) by BL3PR11MB6434.namprd11.prod.outlook.com ([fe80::f352:7c4d:8b5:c701%8]) with mapi id 15.20.5791.025; Mon, 7 Nov 2022 19:06:30 +0000 From: "Judah Vang" To: "Yao, Jiewen" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes Thread-Topic: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes Thread-Index: AQHY8tf+g2zM0QJ2c0KJBPi20xF8bK4zyr6ggAABk2CAAABTQIAABYrA Date: Mon, 7 Nov 2022 19:06:29 +0000 Message-ID: References: <20221107183640.3470-1-judah.vang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BL3PR11MB6434:EE_|SA0PR11MB4669:EE_ x-ms-office365-filtering-correlation-id: 9c094d94-9ed7-422f-072e-08dac0f32d81 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4n/bSR1anJpkgyyeKi2denFuW9w/cYQSon4WjWy1s+togJJGULp/VFteyY/Sd7IeLXwwxyipFjU5xbFAeAMj670Wgk6Lp7ymCD+TyUV3Hf55m+7cFlrYN4ytF40oW5Ht4/8UeYR/4HGYFiCpDTIRyrJ9a1SMjt9lTIrQyynXI7D6lDxGNLli+/Mlfy7RrKANv/pOkD6QjB9NJaNY4Smouj/8QcNinC6Xxn5r2OlfHB8pPUgB6U2jTgdgCUFr83U6CT/7EU0yHUEnV2ayZVhXyLhOsAmoH77SqJiWPcaqVMHr37MPOMZXf9i18pO8rY/yqG6qxU+VEO4guz8tbKhFDxkN+sf3gN7AXwYJoUPDLfBpC37ZomJ/1ktY3xxK9fcPNHn9Gpkviex7GWzS8Wj1XHIsC63VCpW6FoBk1ssSlg/vpik8J84HbzB5fWNQ+D3ry03DpmQsxVsAzxeHNB3o5jadij84B6v0hxUPhaCCUQtUCJY2+rS0OfdKT20CP24oO94vt9fbB/AUCuMJu7eF56nAfuzUHlDeyEAmmID1dX35ztqP52Kd+QVXlh3U9HrQhFS3QG6lCqxSwNbczOx9D/fyPyAyNMzAAhqbSilpWdkc+ABfi1d4dhDpm/k1rfIvpg9hXZWascmULj5jIfOmLSnss0NCD9MRhTigaJbBHOG2mb0qxzEdTPgXqWKn2LCYZAbCSlqQVZpirRH2/Jb5z/orbRyoO5oS88n2sX7MGnLwe4WNsas1DFoPUs4rxUvilYzRqGJn9eqkZ/Fg6AYh4e3H0GRcN2kDXvavPooRgv5fLihIWSBEIWtSO3XfgrXndn1bw9yOLF5pNaba0CZ5lQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL3PR11MB6434.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(346002)(396003)(136003)(376002)(451199015)(66899015)(966005)(33656002)(53546011)(71200400001)(2906002)(38100700002)(38070700005)(86362001)(478600001)(55016003)(82960400001)(9686003)(122000001)(7696005)(26005)(83380400001)(6506007)(186003)(8676002)(66946007)(76116006)(66446008)(64756008)(316002)(66556008)(66476007)(110136005)(41300700001)(52536014)(8936002)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6uMAMVpTVucNZUgCh+dn+dS/OcYF0FJS+pLyFJQG4wwi3M767U9bdRo6qphT?= =?us-ascii?Q?oOkppZDlSZKCHEw+1ZVWK8uVnS7CnXnHwQfr+NgdTBih7ei3GQwmVnTJoF4x?= =?us-ascii?Q?Dl7XnPCBMw69gbMG1Mlaz8xK9e/ZUKym0ZGVo5BZN1VyJNCMNhZO5LX5pUbQ?= =?us-ascii?Q?whUAcQW2Ffyga9WOVByxli0JysJ4O8t9XKSUofAVhdzO+xRo4NdcSFcEZmxI?= =?us-ascii?Q?3TIWsHxVY9E13FRdyN3bz0SY81FMc0A62CmjWUjk96sHb3JyvdMgAJfY+kMh?= =?us-ascii?Q?x7SRfunn2GtXrInOqSVO4sXt9vGgCuhwq3vq99pHC9T26kUJPhFP+hJFaU8y?= =?us-ascii?Q?uQ+OB6Kzhc9rGRZ0nLw4c2XhmSQi8OW4ndkP+q1N9YSzXXQhPJnjJEkjQ5av?= =?us-ascii?Q?7JIS4QexzDN9shDsgfQgGFphQuddBgeep94enflvnXC33Ec2250Z+yCmMed6?= =?us-ascii?Q?4rooJ/CCaOXr8nXTCCejj3BJjEljEwvuv9fbafaVkOiCFcHCsv2PLwWsmwdz?= =?us-ascii?Q?8Wy13COfnTLDuh4xK7yuFCi6Tlikwqj4sArL4l1igTenHFiJD4z68ftLLguk?= =?us-ascii?Q?YiTjJY6nNEbfEXUKmqRqK0VrbOMcoxGxvpiZx3HEqPFHbV8JFtRaFZBxXXBS?= =?us-ascii?Q?HM3mhG39374hhIqU6IhTODsIkrDScn1d/L8Jv1/sOsFluehEnHMTKz971MiC?= =?us-ascii?Q?HwmEV5jpIWW7MQ9hQJzQ++4BrAiXDjumzSOQQ/V9K5QqOorG7SectfWbrifL?= =?us-ascii?Q?1fgA8ww88RAxGCoE4MBY2nhqRjStR+lzYliPkvZUHw4aG0Kpn9okQ1XcV+lD?= =?us-ascii?Q?xys72TQKUr9K532liUpwCP2Mz3mW7LdldTt8ow5rGL4FKm59Qlr52v9j9wOd?= =?us-ascii?Q?ux6Hkp4EbFvpOXVbfptZvJ5qE0NVxos7TJZZCQWc0yHWEMes76n5Ofnzuc45?= =?us-ascii?Q?UbJ1y98qr+3AHtkTtmVqVdDLQtChtJ/n2/xmZsqx9STo5mkQgsrVNcs90Jeu?= =?us-ascii?Q?JoRM/WPEOwpYIQ2YzFMsCdKGsr7ssNLntm8k1nN0xDKr+4P0nTNrd65rvk5Z?= =?us-ascii?Q?TCzJFLuuNjYe4+n7/9po0lddOxB+PZ7f1ZkbEznb3LxiIfB/SP7MVevqEwoF?= =?us-ascii?Q?pbaFzf1Wdh27oda6DHZK7i8L4/CPcLtO7kcCD+oiF88d0qU8qPWOrO251nJW?= =?us-ascii?Q?upDjP83VM8yoK1nV3v1O/plG+x7MGb1Gwkg7gv5J0gv/fS/ZwXhYi8DQDxLq?= =?us-ascii?Q?XBzFvkdj/BCfTcgb7SVX7lyaEQlcTEJXcdCU0NNKoep/j66CotvLNNxpcFDA?= =?us-ascii?Q?v+GwqV5k8+2SqgjVOdMeoTRLoQX4HfaLcG8MQ9c0I42ti3mDJXy0S06kSlhd?= =?us-ascii?Q?k2QFKhWK6lBu3Mjkn3UlBkQRt+YaaP3EsV12B6g5pTMtKcAzRXZxu8s8VlBB?= =?us-ascii?Q?VDgbAghvUYcBSuqIxhboQAtPQFdHVs6Wu2i/DT+HoztLWOlsCQGRsd19knvb?= =?us-ascii?Q?R8RM6BnQhV/sSo4922G7mfwgd05wkIvtMMZtdH8GPxuOF2DBiN2bbw2P3i+T?= =?us-ascii?Q?OyUJ1S5pBxrZTgGJ3QKjZqQ1hM7RHroaucj6ARNC?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL3PR11MB6434.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c094d94-9ed7-422f-072e-08dac0f32d81 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2022 19:06:29.9206 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OFCMQGvujtRUsy8h7WtNzXOJBCmzujpiy+jJ16fnQc0k0WYzerEix6c5yPru1rpoVwGyMAkMaVgG/vdUzRnCvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4669 Return-Path: judah.vang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jiewen, Thanks. Running the CI now. https://github.com/tianocore/edk2/pull/3609 Judah -----Original Message----- From: Yao, Jiewen =20 Sent: Monday, November 7, 2022 10:48 AM To: Vang, Judah ; devel@edk2.groups.io Subject: RE: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes Also, please ensure your patch can pass tiano CI. I cannot find the PR to CI for those features. Would you please point to me= ? Thank you Yao Jiewen > -----Original Message----- > From: Vang, Judah > Sent: Tuesday, November 8, 2022 2:45 AM > To: Yao, Jiewen ; devel@edk2.groups.io > Subject: RE: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes >=20 > Sure, I can do that. I will resubmit as separate patches. >=20 > -----Original Message----- > From: Yao, Jiewen > Sent: Monday, November 7, 2022 10:42 AM > To: devel@edk2.groups.io; Vang, Judah > Subject: RE: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes >=20 > Hey > Would you please split this patch set to two different one? They are=20 > two different HSDs. >=20 > Please aware that we are in software freeze phase now. >=20 > I suggest we include 3991 in this release, because it is an important bug= fix. >=20 > I suggest we defer 3992 to next release, because it is feature enhancemen= t. >=20 > Comment is welcome! >=20 > Thank you > Yao, Jiewen >=20 >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Judah=20 > > Vang > > Sent: Tuesday, November 8, 2022 2:37 AM > > To: devel@edk2.groups.io > > Subject: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D3991 > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D3992 > > > > There is a #define to deprecate Sha1 functions but not all the Sha1=20 > > function are wrapped around this #define causing a build error. The=20 > > fix is to wrap all Sha1 functions with the #define. > > > > Need crypto AES to be supported for PEI phase and need crypto KDF to=20 > > be supported for SMM phase. Update Readme to show AES and HKDF=20 > > defaults. > > > > Judah Vang (2): > > CryptoPkg: Sha1 functions causing build errors > > CryptoPkg: Need to enable crypto functions > > > > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 2 +- > > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c | 14 ++++++++++- > > CryptoPkg/Readme.md | 26 +++++++++++----= ----- > > 4 files changed, 29 insertions(+), 15 deletions(-) > > > > -- > > 2.35.1.windows.2 > > > > > > > >=20 > >