From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.1727.1667846755779106707 for ; Mon, 07 Nov 2022 10:45:55 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=QqkD57+y; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: judah.vang@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667846755; x=1699382755; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=W/NDypaGzxlfquup8ygF9AmvhMDKW2Avm+twdSEdy1o=; b=QqkD57+ywjKTnVSFJ2JW0RPJCWBse8KsB8/8d0cztd7DUPT0TSjh/Oqc AqZcadW03gZXQXtd2rG0VPeh9B6ZSrytOk7NFS93BsBC73OYxqcNlHLqe 8aPAILxDp5EW7sZiwK4hwOUSdJn/OC1P3vdG5OfpYpeyQXMoM6aobvETa /Q7Axcg/4AMuIVBEfn3W+fI6j6y3IwQs59LNu96Vy2+M+F2//iyFo65fc +YyoHnHJN/Qz3/W7hAg05X1JVYYCQ4HeJhUFrPhjLD7LxthT05L6LTrJQ 9FGdY6ullk0n6L1X9Yp1vJan//Ancq9nIgkrE66vyqDuwrHnnzaSr1/+K g==; X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="298006514" X-IronPort-AV: E=Sophos;i="5.96,145,1665471600"; d="scan'208";a="298006514" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Nov 2022 10:45:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="810946511" X-IronPort-AV: E=Sophos;i="5.96,145,1665471600"; d="scan'208";a="810946511" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga005.jf.intel.com with ESMTP; 07 Nov 2022 10:45:16 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 7 Nov 2022 10:45:15 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 7 Nov 2022 10:45:15 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 7 Nov 2022 10:45:15 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 7 Nov 2022 10:45:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JCOd/sgyE9AafhAAjSnTix3SWzQYlgrQJofbfyQaJd+Q/hABGxQ85iV6EquNHQfannx3yjYw+igt6Gi/xD2zl8k7xu5hGHPhMOMGlAVpg+ff2odGxzVFr4E3ykN8t1c1xMTQJvjEm+WkBJPihHPeNX4NQ37cacVEXMlhPzt8EfI1aWvCl/zJfT+YggDdVoo351/gXaGqv/fduug8xrZLe0U/1PBO2uy+PAiln6MsifkLIKE3sbHg4QxJw+Ets+FpJFbA+4YPfclrO05krwynwGdAJUHcuJ27Ze5izfJA4UpFC0+wNuNNYDr6HmjhC2WBsBRTCOpOfEXe6MvBCt5dMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=56zgXPi4uBi6Y/mP9C1jbo0ephWP0X/dElDbtJUm+B8=; b=UF8NXD2+5sA3SPxKLrFi4zTbnPG4zAHjPhyHPsdMFZXV1cKqQWyfrBSAPMTepHcj4/um2F1duGCzizGOpcKzsYfECROtFYUUTw+g9xgeaehXHvRb1oarhiE5dK5cjAhSEqzVdNO5/UijFKDvq1M2hert8lisLC6WxgBv309QOKadzNvfpIhi6pKIrWPB2Sa6MwTVGTeAL9s9Lh4EpvEvc7v1/jNVI0eTs253tDMo4WYUlPFx17l9g49TusgDsknr53d9RzZ9oun3CcXwM+I4KDm5xndi+o6S74XiI35dhqx04uq4+rpp37P7ey6Z3uxdLbAp/W3MMnWnfrgBfEaygQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BL3PR11MB6434.namprd11.prod.outlook.com (2603:10b6:208:3ba::22) by DM4PR11MB5471.namprd11.prod.outlook.com (2603:10b6:5:39d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Mon, 7 Nov 2022 18:45:13 +0000 Received: from BL3PR11MB6434.namprd11.prod.outlook.com ([fe80::f352:7c4d:8b5:c701]) by BL3PR11MB6434.namprd11.prod.outlook.com ([fe80::f352:7c4d:8b5:c701%8]) with mapi id 15.20.5791.025; Mon, 7 Nov 2022 18:45:13 +0000 From: "Judah Vang" To: "Yao, Jiewen" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes Thread-Topic: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes Thread-Index: AQHY8tf+g2zM0QJ2c0KJBPi20xF8bK4zyr6ggAABk2A= Date: Mon, 7 Nov 2022 18:45:13 +0000 Message-ID: References: <20221107183640.3470-1-judah.vang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BL3PR11MB6434:EE_|DM4PR11MB5471:EE_ x-ms-office365-filtering-correlation-id: 2dc5047f-ed8d-44e7-cedc-08dac0f03481 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zVaYlKt6XKdr4ByEk2+SgSbIWSZO+Ng40ceAh0DEjYE/xWoK5WzzczUJzQG6TI8v9+xtiYQj+Yxv1Z++KUiEE/E+fX7CfR+/SUZWSaEFEm8pwnoLVKsldRIpUYHft6qax2SvwX0yJVdQfkna3OglpWD3c6rHBQPHkB/W2dZx2MabTNkD2GIAQ9bIWM7CLTQj0t/CcB/vYZy4TpX4Dx+W5DJXQFPqoMswmyIFxX2+M+wNFkJ/bOANNg0QieDEnvcqIzFVVcx5DDbUIuXWtW60URT3nZIMdyCfuMmCwtUnhPQqhmOwDLKOLvbDxX/T4pNM5oX6MXypFfREmmF8s9s7iuEwArQSnohT7xBv5slO7VeFgWguU0+dhsQRvp7pN/ZEkD7lBYy1HvF8NHgVarENR35pNlpiz31Sr3taSchw+Q1Mj+E03FWOI7pL6cFHQRYLS8AFUAHWMbXaQrPoJZvH6kDf0/BxqGt/6SBPdK83O1Pn6VwS9An+EtyiB3jGYxfxaIn6ZTjQPEqIH5lpxC6eEK1XjWhg9xlQbCzM/cmNEns0gBbDIlZ2TbPjUJjlYHNzv+RybN4PeedCbN2F8nzDfr4ilq8soRj7ReXLYNvXbXqGWMDzj1se1Ck0jbnL2xS3o5iR+dX14oMtfLfoixk9RYup2hNwgKGE7qvlAuUlt2AHYoAMENXGjn+EUawHtxjrpRMrIjdMpOfPTeDs2HM5+dVcchmITA23+72RxOm59kMoEfqGXKu3EVMFCcgMTbXBRGxUb9839bH94bTfCZyeShtRvrczp0DoXNu57G+U0kRliIjmv8J4tg5LEdE82sbEp0vRKgQ0niPJ/bjaK+f6JQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL3PR11MB6434.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(346002)(366004)(39860400002)(376002)(396003)(451199015)(83380400001)(186003)(38100700002)(26005)(9686003)(6506007)(53546011)(122000001)(7696005)(82960400001)(5660300002)(2906002)(55016003)(71200400001)(8936002)(966005)(478600001)(52536014)(41300700001)(64756008)(66946007)(316002)(66476007)(66446008)(110136005)(66556008)(8676002)(76116006)(66899015)(33656002)(38070700005)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CqqkBJ97BoBES+dQZQBnuhOtjbRA7XXCJjxSa7Ekg034lKk6M6U9DawmRVIc?= =?us-ascii?Q?1V4fOc55VC0a8U2rAB448U8TJVb7DIjiKQ6+0sU18D4wk4dv6VYlAbUBHPDr?= =?us-ascii?Q?hFM4j44uauaF5Ux0W1jhrfSn+BL/V3EdKWk314RNLb077+9CQ/8CopBRcTb4?= =?us-ascii?Q?4GoMr+QIlfRtNeCh6wT8xCZZtELVGk7viqWQmf/7xFB5WtTAy6v3KwQ0Osgz?= =?us-ascii?Q?gUTb7etpUwszU/HtMhBV+e9Vuwlxaa9FszMuhycaTlFu/+EJeC1CuSDl6TDV?= =?us-ascii?Q?+YLnNHT6hPUJm/J/0UI2QpIRpBldSuHzGoZ8F8BX2SctqKnnpXAQonV2cLuV?= =?us-ascii?Q?9/JsWo1sTQ04/OxCmUNeZyEzAwzKrlrdRqRmPktVLWUS98NkzrYCJsxtkQ27?= =?us-ascii?Q?3plIjflwlTfKTVbKAk1qN5O334+BmM+f9xVEuaHpWpTDENbNYp4/JmQ0gntD?= =?us-ascii?Q?Ewh9FLnStYCAtPlM9REwhAwA6UoZYfgky9w3rEc1lsGjHehfmCRJtWesORQ6?= =?us-ascii?Q?DjPi3i03h0+hDcAEeTDcssZsytrFwo4UBlF2umTbpPNCxbKtAxxnqVI+4kzL?= =?us-ascii?Q?ROylRrTJjuVQKIiFaoRsxl1B1+GJ8zfF0p/9gp+A22TLwYz5xuO9EaH9Ej2N?= =?us-ascii?Q?oMVoMgDYShTN8w7yMeiVhPS7lnW1kscmr9tujlS07nO61nVty50LrqA8eznM?= =?us-ascii?Q?OOyKUzyZVfMuZMX9O0pDxSxlI4bqc68olGb+iZoG0HYuDQuevLaFF7a9vzO4?= =?us-ascii?Q?YvMIqCzBrdYFRLEzCCbZkUpAE/pqGhsxu11xfPjoSFNR2YyP6Qwj8plIRVyI?= =?us-ascii?Q?eFxzNY19IseNofbdX0smjCLQuSvHUYPBmPFLw9DULg9LV6MfAPvcm64lSMqw?= =?us-ascii?Q?HOU8EvAolJoWjeAGvjxbh4UlRaGtAMnIZ5Ky+Yr647sHZHKqCwedjeRwIdlr?= =?us-ascii?Q?NNRL615e2+EAjF1odSWY4S33T8lLidJcxJQ6VGKz9uK+zYgDnxS6rfJsXEaK?= =?us-ascii?Q?JLqbvlC2hqHRU0YJ4r3WyQm8cI/c/RZmS9qk2Uhj8AkRFYTXQnp9H0rWuJPw?= =?us-ascii?Q?VEk/ccA8JPVl3JWio2ksKt+0DneEImDWoZJBj8Ew62kO5xx2Q30uIhwW5uWw?= =?us-ascii?Q?MH6tmv3CwGDNVQH7MUcwfVlJzudxZYUbCHib8PdwyAdzXqZaQf2gNGO/1nGs?= =?us-ascii?Q?E8rcMgWP5txxe4KnwjAAVE9S+HFilJNsbH+cYL/uCfsklQ15CngGbaN8yMXD?= =?us-ascii?Q?woHo5CsFvYbkQS9UaNGyzqYUuBcUFJrza3YI+59DEo3c10O5vKx8q3xYuKWu?= =?us-ascii?Q?rj0Dc+MQOXJcJXMPBNZ/W5J6RCK6rQCCzHa9QhmMyHlE2wRL/1Z5iiN+TpnS?= =?us-ascii?Q?rarl1mUr7tOqsah8fkLRJJvo6l0t8noSc3CNmdF+bxFu14uyZdy+ZOLJQgrm?= =?us-ascii?Q?ZcWpHuZKVdjzg/2Nlf1NMuH39oQeMW5Rnbh2yGjQnVsPjFOIvAIFJivG6jqv?= =?us-ascii?Q?NfuxK7FX7O3jcfMK0u6pRYMkXOGf3fa1Xrb2VcVlfjkvDCuZasROzsvQLhGv?= =?us-ascii?Q?su/drRm+WEm5YlYWgsBz36a/ShqW3X1RaSheI40n?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL3PR11MB6434.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2dc5047f-ed8d-44e7-cedc-08dac0f03481 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2022 18:45:13.1640 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: f0EvR1v1QHFcARpD3I/xm3SGR54hwtV0TDvc9SDv3nbS3vuzSQrtzE77jiwNY8K3NTwBCDLT3M1FtrTFS9+5dg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5471 Return-Path: judah.vang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sure, I can do that. I will resubmit as separate patches. -----Original Message----- From: Yao, Jiewen =20 Sent: Monday, November 7, 2022 10:42 AM To: devel@edk2.groups.io; Vang, Judah Subject: RE: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes Hey Would you please split this patch set to two different one? They are two di= fferent HSDs. Please aware that we are in software freeze phase now. I suggest we include 3991 in this release, because it is an important bug f= ix. I suggest we defer 3992 to next release, because it is feature enhancement. Comment is welcome! Thank you Yao, Jiewen > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Judah=20 > Vang > Sent: Tuesday, November 8, 2022 2:37 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D3991 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D3992 >=20 > There is a #define to deprecate Sha1 functions but not all the Sha1=20 > function are wrapped around this #define causing a build error. The=20 > fix is to wrap all Sha1 functions with the #define. >=20 > Need crypto AES to be supported for PEI phase and need crypto KDF to=20 > be supported for SMM phase. Update Readme to show AES and HKDF=20 > defaults. >=20 > Judah Vang (2): > CryptoPkg: Sha1 functions causing build errors > CryptoPkg: Need to enable crypto functions >=20 > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 2 +- > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c | 14 ++++++++++- > CryptoPkg/Readme.md | 26 +++++++++++------= --- > 4 files changed, 29 insertions(+), 15 deletions(-) >=20 > -- > 2.35.1.windows.2 >=20 >=20 >=20 >=20 >=20