From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id C1470740035 for ; Wed, 15 May 2024 15:01:49 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=uaPpWO5x81jlr8fvBLStt64SpvV6bNIVR2WbzK6ljII=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1715785308; v=1; b=ZAfTKPqkFCAkoTR2fpy8D77vLWxndqnGutzyU58qGBRXQwuMu3m/cher63CzIYx0BiaPivY9 DOoOdtDAnXCzsSG9KhKtAppRqD5VsU5CHgbv3VAUXMTIEcQsiLDRbq2zuujrlCrKTRbjgsMcVc1 ZgjiTNJrd/lxkvo97wv98ZMyspCUHPO3WRN6DkmykqfTkGcPu++MIaCWhy05pL2OjCmb7HE+IAf KCs5Hs3I4bL3rpqmxaRu/m9Z9c46WMPnRL0mfJI7fZoAwaWoocyS3Jkdughsx5wMEKdiP7AnonC Vn5MD6HyH6Ofh9SWd/iHkcNI89V4aXNggqy3ZTxDO6NHg== X-Received: by 127.0.0.2 with SMTP id ug2bYY7687511xWWj3E745eC; Wed, 15 May 2024 08:01:48 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.127]) by mx.groups.io with SMTP id smtpd.web10.18517.1715785306605430616 for ; Wed, 15 May 2024 08:01:47 -0700 X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by CO1PR10MB4417.namprd10.prod.outlook.com (2603:10b6:303:93::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.27; Wed, 15 May 2024 15:01:41 +0000 X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::a2d9:e61e:1692:34e7]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::a2d9:e61e:1692:34e7%5]) with mapi id 15.20.7587.026; Wed, 15 May 2024 15:01:40 +0000 From: "Igor Kulchytskyy via groups.io" To: Nickle Wang , "devel@edk2.groups.io" , "abner.chang@amd.com" CC: Nick Ramirez Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe Thread-Topic: [EXTERNAL] RE: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe Thread-Index: AQHapfvn0BQYUFTAcUSHTA1qLmVkLLGYYpCA Date: Wed, 15 May 2024 15:01:40 +0000 Message-ID: References: <20240418122730.18204-1-nicklew@nvidia.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=02042108-8add-4e61-9fed-ea197e2b5c86;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-04-22T02:10:33Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|CO1PR10MB4417:EE_ x-ms-office365-filtering-correlation-id: 44d36478-3bec-4298-66c3-08dc74efed5b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?o/K9JLvFIGOMudlmDtEU05gIWUU8pT26dRWGEEeAzhZTW7EosgoK5dCqcsJN?= =?us-ascii?Q?/k1oSrC1CPn3uVYYQInR39OrRXA7HZ1OZgIz2YXnphSYAcv5gRWSR5TKFjmd?= =?us-ascii?Q?b2P8VcTOZ8o//a6YCVATRCK/JqK7kbr/w56ZF0IpHTSi2F9lrcrg5/Ft3Tle?= =?us-ascii?Q?FGJylvtltk1ylg5q/DH+vwSaBoZt20VloGIrgMDenRT6SMa4AZC/m1DNpPe4?= =?us-ascii?Q?Uw/S7ZozTcaclEC1khTccOCNUh8h140aiFFHnJ5NAz20TzX6NZU/mahgDdO+?= =?us-ascii?Q?PBsXzFdGNbtYLmnlspqz7lQ2awZEKfDP+sPJ4QayAks/YROqrFpafEDA/pGI?= =?us-ascii?Q?m3GD0KaZHvhdGLW1lMfjrLmu0B9Vz3Rpob409j9oQXFR4BQd6363qFR+cesJ?= =?us-ascii?Q?sjAhYXrgVtXwCenIWo88+mlIUBlpDOlk4G8WLIfhz+UTfTtQXixDzcJJG7Qc?= =?us-ascii?Q?dxEm/3RpFO2Eqzq5ZNYCkru5q4mBIJCBUmfpJucDfSrRuVJeUWqIrPfWQNYZ?= =?us-ascii?Q?Ke/fgvYYdg330jNpzF6OxFKxtBDrZE8sVr0S6MOHS/LjdgyPPzV38wuDOBPi?= =?us-ascii?Q?iz4ASo8uq9QhcTR/8q5bGoAlbpMsW+KRjUAjX4lc33KkdHkYI2JoYcb2bVuT?= =?us-ascii?Q?17+d4o5WSDzY4AqpLr5yet+ZzwEFXbvEjG86W3nSUAcbDOL2jGaSFM1bQFTe?= =?us-ascii?Q?Lo34/F46C3/I7YxknLNeCzeMqAK0cL3gp8rnhKePXOoEBPxe3cevaTa4Urbp?= =?us-ascii?Q?5RL2Tqd9SXvklX+RCvEZRqnZkV8moqmpqP8APyRwlapCfGdMNY14ymEl/LES?= =?us-ascii?Q?Vv5VCK5LZQi8IpdCM2xo/apaQF278Lxxb0UDYDS8sMKGDXWvU5B5nUnxJeEq?= =?us-ascii?Q?by8C5CvhrGdctfhXDexET5rZ6TV0jjlDczjmqQzlvtHJqhy3mYLRZYX7ynJ7?= =?us-ascii?Q?NwfTRpwV/+rluYynxrQR3/brJ59cSY7fMoMn8bti/60JpqlTIjuq7zwxn8s2?= =?us-ascii?Q?V9gptaUTP4cMOrwbHDTKFc4UUHCXP5jL39SEl4eKLUe0iyRdXLBRqsMcJQh9?= =?us-ascii?Q?BerGwWJKfVkTHEGLljY5D04aPzpSm0abKQmnkG75c3Rul5Pol43A+tEtdJw0?= =?us-ascii?Q?GQd1KKR8pTmgp6uJuWtZbRQNqL+QZBXiLucPd5XJKejEmgAhPOUdN2xug8b0?= =?us-ascii?Q?hLrFlA2LU/+ElOiPuZRzsvSQ4lo3WjqcgM1VPAiS+iI/HOoFwnlNRyRP0JsT?= =?us-ascii?Q?D5Hz9Bd+4y3/sK7fLdgYR2N+bx42XjMLhzDbizQp0g=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?d63xq5Japof//q7Yyp3X+hXEaIjpElFqGmE736LsNIZPEv/Hm+oogl5Fp1oQ?= =?us-ascii?Q?6ncReq+QvaP8txoW4ZqoBl8zulaoYSG1nuUgN6MnU7VsE5y0nXc6FePZvevQ?= =?us-ascii?Q?G1yhUzaosvBHm0Gj2rno9c/fCEr8kQCY0fUgSBzklvZCGV4cEJRSVzuCUodH?= =?us-ascii?Q?mEgCnMh39XjCYb1wfJL9c9NAoKt3MQ4YfazKRGxSEV2O7O649eCy6cWoISO6?= =?us-ascii?Q?PytiljzIFm9RV4RuxI0qXNmGnwbYXzj27tc6vpOAtCXhIFu5oA7Iovy711ON?= =?us-ascii?Q?uCDqjVIhbrbaQ6E/hXOg/yKfhWHk9MTcaL37RysHtkpQlBI1vQmmvJ9kcmPs?= =?us-ascii?Q?576AxnGP14mPXAmcA3MA0GtFqK0l72CSudwmx1mjt7yrJMDuujd/oDROmfvx?= =?us-ascii?Q?oRQjDhySCy3jTvQNjn2HAEb84OLGJcb/f6s+ohY6uxBZVlBzPK4YFAZqclQf?= =?us-ascii?Q?l/rfbrRpRLURPl0nJddFTtswYBddVwG/sbhG8dznWtfnPQm6FPghw4pV/cM9?= =?us-ascii?Q?R2isovDvzlwwTmkuB8Biwz//Z6ON02mCbwLaNMalF1gdVXrk8mkvIROd7Co0?= =?us-ascii?Q?BTcim0cst02CEm8mS/7EswjzBcANM00U5WdKVXUBQHyJdqv8Du+zPmaxaXCJ?= =?us-ascii?Q?Vz9aD76yRzm7pafAAvLE7K6v1/CbnViGWUe8XJI46idakbCOMPegvP0L3cxM?= =?us-ascii?Q?II/l0pkAlp2y496tHv2Bb19NTBrbP8n32DXubQ/Q1CLDmsrsKsK4LupCBTTO?= =?us-ascii?Q?9pgjvkRVMDlgNPXsnTXDsTtdoSMjQ72xVu2vuFPUBu2WdhoqoEehhRupb8O+?= =?us-ascii?Q?Dm/6AZTowJ7XOwUup2zbbXOZ+fXN3i+HnoHsFMYSPvYlsrA23fomIPflJz03?= =?us-ascii?Q?7c/17rZikLsyMOqwjrguwNtRrheRXkI64QbJbmYkcGZ0eD4SWKjW5qkiIY5s?= =?us-ascii?Q?TYloTvqYYgCHDyiVGVyAo6DNmqDFnT8pY40m09tapJ/iaflTfDfJvnmsjJt9?= =?us-ascii?Q?P49OoLKp4tYFTel4/pLsSiDUKzccGJSBEuC/N5WPmjV5lS7MOaGQo4TUc3yp?= =?us-ascii?Q?RvnUeG9z6uYdYDXitG/PdqbaQIZmWLbzkRpHgWewuWPCwNzN5ZCxrm/8lgYq?= =?us-ascii?Q?SaYWApQR8wjEiURgLyiOQhb4UzUBcr8kVvJDa2xXPooYgDkVxFIKXvNxISg6?= =?us-ascii?Q?F0iLM3+Qq1ChmC6fXRkfMFB3tb7Ls4xp1tDE0m5Ff6X91D5ynhH8M109Keq1?= =?us-ascii?Q?4PZ/DMFjaHuj4tvyTgtZm6h66j2KHEt1nTCAy1AFnrIJ0empfy0A9PPooScM?= =?us-ascii?Q?KWYDvyES7rIDm+etiwdlPxBR7Xivhe7z5S3huA27tl4Gx9/mU9mZfOGZ2mDE?= =?us-ascii?Q?sDLxTw2BfeHdOnKwWinpoo2zb8BKJVDMDYHSgiaHi3cmbcWefqyVlvqK7fMZ?= =?us-ascii?Q?PH/D5Qxi6c7Pa2BO1XNMcuzYvgmCvMCxh8/+3pGZB+iZZJmM8DH/se3jrkkW?= =?us-ascii?Q?oPXx7dk9xccEtVUQiiWEvkMcQqLOdZt7YjXUdBdZbeOisrkbWibR32xIzrVK?= =?us-ascii?Q?LbmnfMLBcR4cZeXycMY=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44d36478-3bec-4298-66c3-08dc74efed5b X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2024 15:01:40.7840 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b8ZVZWsreR4pwkiYHuJtgy5h8g+KKCgfki+lMXsf//L+EvRZ/r+Q/hR9t1LY4hss X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4417 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 15 May 2024 08:01:47 -0700 Resent-From: igork@ami.com Reply-To: devel@edk2.groups.io,igork@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: WNqNYPwrLgMaBWPFwLAHzlpLx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=ZAfTKPqk; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Nickle, I have one more question to discuss regarding this driver. We have a bootstrap account and creation of this account controlled by Redf= ishCredentialDxe driver in RedfishPkg. But deletion of that bootstrap account is moved to RedfishClientPkg. What if we have another Redfish Client or some customer service which uses = RedfishPkg for the communication. Architecturally it is allowed. But then RedfishBootstrapAccountDxe module would delete account just based = on the RedfishClientPkg needs. Maybe we should consider moving RedfishBootstrapAccountDxe driver to Redfis= hPkg and have some register mechanism which will be used by interested driv= ers to notify that they finished their job and after that RedfishBootstrapA= ccountDxe driver would delete an account. What do you think? Thank you, Igor -----Original Message----- From: Nickle Wang Sent: Tuesday, May 14, 2024 8:40 AM To: devel@edk2.groups.io; abner.chang@amd.com; Igor Kulchytskyy Cc: Nick Ramirez Subject: [EXTERNAL] RE: [edk2-devel] [edk2-redfish-client][PATCH] RedfishCl= ientPkg: introduce RedfishBootstrapAccountDxe **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** Hi Abner, > Ok, then I don't have the problem with invoking GetAuthInfo again. Howeve= r, I > will suggest to add more description in GetAuthInfo function header, ment= ion that > we will keep the auth info in EFI variable until exist boot service. > Also, give some more descriptions on the code you invoke to GetAuthInfo. Thanks for your comment. I add descriptions to explain above before calling= GetAuthInfo(). Version 2 path is here: https://edk2.groups.io/g/devel/mess= age/118889 Regards, Nickle > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chang, Abn= er > via groups.io > Sent: Tuesday, April 23, 2024 3:42 PM > To: Nickle Wang ; Igor Kulchytskyy ; > devel@edk2.groups.io > Cc: Nick Ramirez > Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: > introduce RedfishBootstrapAccountDxe > > External email: Use caution opening links or attachments > > > [AMD Official Use Only - General] > > > -----Original Message----- > > From: Nickle Wang > > Sent: Tuesday, April 23, 2024 3:09 PM > > To: Igor Kulchytskyy ; Chang, Abner > > ; devel@edk2.groups.io > > Cc: Nick Ramirez > > Subject: RE: [EXTERNAL] RE: [edk2-redfish-client][PATCH] RedfishClientP= kg: > > introduce RedfishBootstrapAccountDxe > > > > [AMD Official Use Only - General] > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > Hi Igor, Abner, > > > > Thanks for your review. Please allow me to answer your questions togeth= er. > > > > > 1. We suppose acquire the credential before we start to communicate > > > with > > Redfish. Will Redfish credential driver create another bootstrap > > account here after provisioning? > > No, according to the RedfishPlatformCredentialIpmiLib implementation, > > Redfish credential driver requests credential from BMC and will keep > > it for later use. So only one credential is requested for BIOS Redfish > > feature drivers during POST time. > Ok, then I don't have the problem with invoking GetAuthInfo again. Howeve= r, I > will suggest to add more description in GetAuthInfo function header, ment= ion that > we will keep the auth info in EFI variable until exist boot service. > Also, give some more descriptions on the code you invoke to GetAuthInfo. > > > > > > 2. And why do we delete the credential after provisioning? How about > > > the > > later Redfish property updating process? > > In this driver, we listen to "AfterProvisioning" event. And this is > > the event triggered after Redfish feature driver finish all jobs. > > There is no feature driver which gets executed after this event. And > > since we finished all Redfish operations, we remove this account on BMC= . > Then this makes sense to me now. > > > > > > Why do we need to delete those credentials? According to spec BMC > > > should > > delete the bootstrap credentials automatically on host or service reset= . > > Yes, bootstrap credentials get deleted on host reset. In practice, > > server in datacenter usually takes long time running under OS before it= gets > rebooted. > > The bootstrap credentials are exposed to end user at > > "/redfish/v1/AccountService/Accounts". I got report that there is > > concern for end user to see this unused account. > This sounds to me reasonable as we will give bootstrap credential a high = privilege > to update Redfish resource. Leave this information in Account service see= ms not a > good idea. > > Thanks > Abner > > > > > So, I create this driver to allows us to remove bootstrap account at > > BMC after we finish Redfish jobs. And this also release the BMC > > account resource since this account won't be used for a long period of = time. > > > > Regards, > > Nickle > > > > > -----Original Message----- > > > From: Igor Kulchytskyy > > > Sent: Monday, April 22, 2024 11:03 PM > > > To: Chang, Abner ; Nickle Wang > > > ; devel@edk2.groups.io > > > Cc: Nick Ramirez > > > Subject: RE: [EXTERNAL] RE: [edk2-redfish-client][PATCH] RedfishClien= tPkg: > > > introduce RedfishBootstrapAccountDxe > > > > > > External email: Use caution opening links or attachments > > > > > > > > > Hi Nickle and Abner, > > > I also have the same question as Abner. > > > Why do we need to delete those credentials? > > > According to spec BMC should delete the bootstrap credentials > > > automatically > > on > > > host or service reset. > > > Thank you, > > > Igor > > > > > > -----Original Message----- > > > From: Chang, Abner > > > Sent: Sunday, April 21, 2024 10:25 PM > > > To: Nickle Wang ; devel@edk2.groups.io > > > Cc: Igor Kulchytskyy ; Nick Ramirez > > > > > Subject: [EXTERNAL] RE: [edk2-redfish-client][PATCH] RedfishClientPkg= : > > > introduce RedfishBootstrapAccountDxe > > > > > > > > > **CAUTION: The e-mail below is from an external source. Please > > > exercise caution before opening attachments, clicking links, or > > > following guidance.** > > > > > > [AMD Official Use Only - General] > > > > > > Hi Nickle, > > > One comment and few questions, > > > > > > > -----Original Message----- > > > > From: Nickle Wang > > > > Sent: Thursday, April 18, 2024 8:28 PM > > > > To: devel@edk2.groups.io > > > > Cc: Chang, Abner ; Igor Kulchytskyy > > > > ; Nick Ramirez > > > > Subject: [edk2-redfish-client][PATCH] RedfishClientPkg: introduce > > > > RedfishBootstrapAccountDxe > > > > > > > > Caution: This message originated from an External Source. Use > > > > proper caution when opening attachments, clicking links, or respond= ing. > > > > > > > > > > > > -Introduce RedfishBootstrapAccountDxe to delete bootstrap account > > > > from /redfish/v1/AccountService/Accounts after BIOS finished all > > > > Redfish jobs. The bootstrap account won't be available to other app= lication. > > > > So deleting bootstrap account helps to release resource at BMC. > > > > - After bootstrap account is deleted at BMC, the Redfish service > > > > instance is no longer usable. Close Redfish service instance to > > > > release the HTTP connection between BIOS and BMC. > > > > > > > > Signed-off-by: Nickle Wang > > > > Cc: Abner Chang > > > > Cc: Igor Kulchytskyy > > > > Cc: Nick Ramirez > > > > --- > > > > .../RedfishClientComponents.dsc.inc | 1 + > > > > .../RedfishBootstrapAccountDxe.inf | 53 +++ > > > > .../RedfishBootstrapAccountDxe.h | 58 ++++ > > > > .../RedfishBootstrapAccountDxe.c | 328 ++++++++++++++= ++++ > > > > RedfishClientPkg/RedfishClient.fdf.inc | 1 + > > > > 5 files changed, 441 insertions(+) create mode 100644 > > > > > > RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountDxe > > > > .inf > > > > create mode 100644 > > > > > > RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountDxe > > > > .h > > > > create mode 100644 > > > > > > RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountDxe > > > > .c > > > > > > > > diff --git a/RedfishClientPkg/RedfishClientComponents.dsc.inc > > > > b/RedfishClientPkg/RedfishClientComponents.dsc.inc > > > > index 42fc0c299..fe5248b62 100644 > > > > --- a/RedfishClientPkg/RedfishClientComponents.dsc.inc > > > > +++ b/RedfishClientPkg/RedfishClientComponents.dsc.inc > > > > @@ -20,6 +20,7 @@ > > > > RedfishClientPkg/HiiToRedfishMemoryDxe/HiiToRedfishMemoryDxe.inf > > > > RedfishClientPkg/HiiToRedfishBootDxe/HiiToRedfishBootDxe.inf > > > > RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosDxe.inf > > > > + > > > > > > RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountDxe > > > > .inf > > > > !endif > > > > # > > > > # Below two modules should be pulled in by build tool. > > > > diff --git > > > > > > a/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > xe.in > > > > f > > > > > > b/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > xe.in > > > > f > > > > new file mode 100644 > > > > index 000000000..4073e95f4 > > > > --- /dev/null > > > > +++ > > > > > > b/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > xe.in > > > > f > > > > @@ -0,0 +1,53 @@ > > > > +## @file > > > > +# This driver deletes bootstrap account in BMC after BIOS > > > > +Redfish finished # all jobs # # (C) Copyright 2021 Hewlett > > > > +Packard Enterprise Development LP
# Copyright (c) 2023, > > > > +NVIDIA CORPORATION & AFFILIATES. All rights reserved. > > > > > > > > > Not sure if you want to update the copyright to 2024. > > > > > > > > > > +# > > > > +# SPDX-License-Identifier: BSD-2-Clause-Patent # ## > > > > + > > > > +[Defines] > > > > + INF_VERSION =3D 0x0001000b > > > > + BASE_NAME =3D RedfishBootstrapAccountDxe > > > > + FILE_GUID =3D 87555253-2F7E-45FC-B469-FD35B2E512= 10 > > > > + MODULE_TYPE =3D DXE_DRIVER > > > > + VERSION_STRING =3D 1.0 > > > > + ENTRY_POINT =3D RedfishBootstrapAccountEntryPoint > > > > + UNLOAD_IMAGE =3D RedfishBootstrapAccountUnload > > > > + > > > > +[Packages] > > > > + MdePkg/MdePkg.dec > > > > + MdeModulePkg/MdeModulePkg.dec > > > > + RedfishPkg/RedfishPkg.dec > > > > + RedfishClientPkg/RedfishClientPkg.dec > > > > + > > > > +[Sources] > > > > + RedfishBootstrapAccountDxe.h > > > > + RedfishBootstrapAccountDxe.c > > > > + > > > > +[LibraryClasses] > > > > + BaseLib > > > > + BaseMemoryLib > > > > + DebugLib > > > > + MemoryAllocationLib > > > > + PrintLib > > > > + RedfishEventLib > > > > + RedfishFeatureUtilityLib > > > > + RedfishDebugLib > > > > + RedfishVersionLib > > > > + RedfishHttpLib > > > > + UefiLib > > > > + UefiBootServicesTableLib > > > > + UefiRuntimeServicesTableLib > > > > + UefiDriverEntryPoint > > > > + > > > > +[Protocols] > > > > + gEdkIIRedfishConfigHandlerProtocolGuid ## CONSUMES ## > > > > + gEdkIIRedfishCredentialProtocolGuid ## CONSUMES ## > > > > + gEfiRestExProtocolGuid ## CONSUMES ## > > > > + > > > > +[Depex] > > > > + gEdkIIRedfishCredentialProtocolGuid > > > > diff --git > > > > > > a/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > xe.h > > > > > > b/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > xe.h > > > > new file mode 100644 > > > > index 000000000..5262f1e6b > > > > --- /dev/null > > > > +++ > > > > > > b/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > xe.h > > > > @@ -0,0 +1,58 @@ > > > > +/** @file > > > > + Common header file for RedfishBootstrapAccountDxe driver. > > > > + > > > > + (C) Copyright 2021-2022 Hewlett Packard Enterprise Development > > > > + LP
Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All > > rights > > > reserved. > > > > + > > > > + SPDX-License-Identifier: BSD-2-Clause-Patent > > > > + > > > > +**/ > > > > + > > > > +#ifndef REDFISH_BOOTSTRAP_ACCOUNT_DXE_H_ #define > > > > +REDFISH_BOOTSTRAP_ACCOUNT_DXE_H_ > > > > + > > > > +#include > > > > +#include > > > > + > > > > +// > > > > +// Libraries > > > > +// > > > > +#include > > > > +#include #include > > > > + > > > > +#include #include > > > > + #include > > > > +#include > > > > +#include #include > > > > + #include > > > > +#include > > > > +#include #include > > > > + #include > > > > + > > > > + > > > > +#include > > > > +#include > > > > +#include > > > > + > > > > +#define REDFISH_BOOTSTRAP_ACCOUNT_DEBUG DEBUG_VERBOSE > > > > +#define REDFISH_MANAGER_ACCOUNT_COLLECTION_URI > > > > L"AccountService/Accounts" > > > > +#define REDFISH_URI_LENGTH 128 > > > > + > > > > +// > > > > +// Definitions of REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE // typedef > > struct > > > > +{ > > > > + EFI_HANDLE ImageHandle; > > > > + EFI_HANDLE RestExHandle; > > > > + REDFISH_SERVICE RedfishService; > > > > + EFI_EVENT RedfishEvent; > > > > + EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL Protocol; > > > > +} REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE; > > > > + > > > > +#define > > REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE_FROM_PROTOCOL(This) \ > > > > + BASE_CR ((This), REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE, > > > > +Protocol) > > > > + > > > > +#endif > > > > diff --git > > > > > > a/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > xe.c > > > > > > b/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > xe.c > > > > new file mode 100644 > > > > index 000000000..6fe4856f8 > > > > --- /dev/null > > > > +++ > > > > > > b/RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountD > > > > xe.c > > > > @@ -0,0 +1,328 @@ > > > > +/** @file > > > > + This driver deletes bootstrap account in BMC after BIOS Redfish > > > > +finished > > > > + all jobs. > > > > + > > > > + (C) Copyright 2021-2022 Hewlett Packard Enterprise Development > > > > + LP
Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All > > rights > > > reserved. > > > > + > > > > + SPDX-License-Identifier: BSD-2-Clause-Patent > > > > + > > > > +**/ > > > > + > > > > +#include "RedfishBootstrapAccountDxe.h" > > > > + > > > > +REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE *mBootstrapPrivate =3D NULL; > > > > + > > > > +/** > > > > + Close Redfish service instance by calling RestEx protocol to > > > > +release > > instance. > > > > + > > > > + @param[in] RestExHandle Handle of RestEx protocol. > > > > + > > > > + @retval EFI_SUCCESS The Redfish service is closed succ= essfully. > > > > + @retval EFI_INVALID_PARAMETER RestExHandle is NULL. > > > > + @retval Others Error occurs. > > > > + > > > > +**/ > > > > +EFI_STATUS > > > > +CloseRedfishService ( > > > > + IN EFI_HANDLE RestExHandle > > > > + ) > > > > +{ > > > > + EFI_REST_EX_PROTOCOL *RestEx; > > > > + EFI_STATUS Status; > > > > + > > > > + if (RestExHandle =3D=3D NULL) { > > > > + return EFI_INVALID_PARAMETER; } > > > > + > > > > + Status =3D gBS->HandleProtocol ( > > > > + RestExHandle, > > > > + &gEfiRestExProtocolGuid, > > > > + (VOID **)&RestEx > > > > + ); > > > > + if (!EFI_ERROR (Status)) { > > > > + Status =3D RestEx->Configure (RestEx, NULL); > > > > + DEBUG ((REDFISH_BOOTSTRAP_ACCOUNT_DEBUG, "%a: release RestEx > > > > instance: %r\n", __func__, Status)); > > > > + } > > > > + > > > > + return Status; > > > > +} > > > > + > > > > +/** > > > > + Callback function executed when the AfterProvisioning event > > > > +group is > > > > signaled. > > > > + > > > > + @param[in] Event Event whose notification function is being= invoked. > > > > + @param[out] Context Pointer to the Context buffer > > > > + > > > > +**/ > > > > +VOID > > > > +EFIAPI > > > > +RedfishBootstrapAccountOnRedfishAfterProvisioning ( > > > > + IN EFI_EVENT Event, > > > > + OUT VOID *Context > > > > + ) > > > > +{ > > > > + EFI_STATUS Status; > > > > + REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE *Private; > > > > + EDKII_REDFISH_CREDENTIAL_PROTOCOL *credentialProtocol; > > > > + EDKII_REDFISH_AUTH_METHOD AuthMethod; > > > > + CHAR8 *AccountName; > > > > + CHAR8 *AccountCredential; > > > > + CHAR16 TargetUri[REDFISH_URI_LENGTH]= ; > > > > + CHAR16 *RedfishVersion; > > > > + REDFISH_RESPONSE RedfishResponse; > > > > + > > > > + RedfishVersion =3D NULL; > > > > + > > > > + Private =3D (REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE *)Context; if > > > > + ((Private =3D=3D NULL) || (Private->RedfishService =3D=3D NULL)) = { > > > > + DEBUG ((DEBUG_ERROR, "%a: Redfish service is not > > > > + available\n", > > > > __func__)); > > > > + return; > > > > + } > > > > + > > > > + // > > > > + // Locate Redfish Credential Protocol to get credential for // > > > > + accessing to Redfish service. > > > > + // > > > > + Status =3D gBS->LocateProtocol ( > > > > + &gEdkIIRedfishCredentialProtocolGuid, > > > > + NULL, > > > > + (VOID **)&credentialProtocol > > > > + ); > > > > + if (EFI_ERROR (Status)) { > > > > + DEBUG ((REDFISH_BOOTSTRAP_ACCOUNT_DEBUG, "%a: No Redfish > > > > Credential Protocol is installed on system.", __func__)); > > > > + return; > > > > + } > > > > + > > > > + Status =3D credentialProtocol->GetAuthInfo ( > > > > + credentialProtocol, > > > > + &AuthMethod, > > > > + &AccountName, > > > > + &AccountCredential > > > > + ); > > > > > > HI Nickle, I am not quite understand why do we acquire a credential > > > here but delete it from the Redfish account service here after provis= ion. > > > 1. We suppose acquire the credential before we start to communicate > > > with Redfish. Will Redfish credential driver create another > > > bootstrap account here after provisioning? > > > 2. And why do we delete the credential after provisioning? How about > > > the > > later > > > Redfish property updating process? > > > Or do I misunderstand the code logic? > > > > > > Regards, > > > Abner > > > > > > > + if (EFI_ERROR (Status)) { > > > > + DEBUG ((DEBUG_ERROR, "%a: can not get bootstrap account > > information: > > > > %r\n", __func__, Status)); > > > > + return; > > > > + } > > > > + > > > > + // > > > > + // Carving the URI > > > > + // > > > > + RedfishVersion =3D RedfishGetVersion (Private->RedfishService); > > > > + if (RedfishVersion =3D=3D NULL) { > > > > + DEBUG ((DEBUG_ERROR, "%a: can not get Redfish version\n", > > __func__)); > > > > + return; > > > > + } > > > > + > > > > + UnicodeSPrint (TargetUri, (sizeof (CHAR16) * > > > > + REDFISH_URI_LENGTH), > > > > L"%s%s/%a", RedfishVersion, > > > REDFISH_MANAGER_ACCOUNT_COLLECTION_URI, > > > > AccountName); > > > > + > > > > + DEBUG ((REDFISH_BOOTSTRAP_ACCOUNT_DEBUG, "%a: bootstrap > > account: > > > > %a\n", __func__, AccountName)); > > > > + DEBUG ((REDFISH_BOOTSTRAP_ACCOUNT_DEBUG, "%a: bootstrap > > > > credential: %a\n", __func__, AccountCredential)); > > > > + DEBUG ((REDFISH_BOOTSTRAP_ACCOUNT_DEBUG, "%a: bootstrap URI: > > > > %s\n", __func__, TargetUri)); > > > > + > > > > + // > > > > + // Remove bootstrap account at > > > > + /redfish/v1/AccountService/Account > > > > + // > > > > + ZeroMem (&RedfishResponse, sizeof (REDFISH_RESPONSE)); Status > > > > + =3D RedfishHttpDeleteResource ( > > > > + Private->RedfishService, > > > > + TargetUri, > > > > + &RedfishResponse > > > > + ); > > > > + if (EFI_ERROR (Status)) { > > > > + DEBUG ((DEBUG_ERROR, "%a: can not remove bootstrap account at > > BMC: > > > > %r", __func__, Status)); > > > > + DumpRedfishResponse (__func__, DEBUG_ERROR, > > &RedfishResponse); } > > > > + else { > > > > + DEBUG ((REDFISH_BOOTSTRAP_ACCOUNT_DEBUG, "%a: bootstrap > > > account: > > > > %a is removed from: %s\n", __func__, AccountName, > > > > REDFISH_MANAGER_ACCOUNT_COLLECTION_URI)); > > > > + } > > > > + > > > > + // > > > > + // Clean credential > > > > + // > > > > + ZeroMem (AccountName, AsciiStrSize (AccountName)); ZeroMem > > > > + (AccountCredential, AsciiStrSize (AccountCredential)); > > > > + > > > > + // > > > > + // Since the bootstrap account is deleted at BMC, the Redfish > > > > + service instance > > > > is no longer usable. > > > > + // Close Redfish service instance to release the HTTP > > > > + connection between > > > > BIOS and BMC. > > > > + // > > > > + Status =3D CloseRedfishService (Private->RestExHandle); if > > > > + (EFI_ERROR (Status)) { > > > > + DEBUG ((DEBUG_ERROR, "%a: cannot close Redfish service instanc= e: > > > > + %r\n", > > > > __func__, Status)); > > > > + } > > > > + > > > > + RedfishHttpFreeResponse (&RedfishResponse); > > > > + > > > > + return; > > > > +} > > > > + > > > > +/** > > > > + Initialize a Redfish configure handler. > > > > + > > > > + This function will be called by the Redfish config driver to > > > > + initialize each > > > > Redfish configure > > > > + handler. > > > > + > > > > + @param[in] This Pointer to > > > > EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL instance. > > > > + @param[in] RedfishConfigServiceInfo Redfish service informaito= n. > > > > + > > > > + @retval EFI_SUCCESS The handler has been initia= lized > > successfully. > > > > + @retval EFI_DEVICE_ERROR Failed to create or configu= re the REST > > EX > > > > protocol instance. > > > > + @retval EFI_ALREADY_STARTED This handler has already be= en > > > > initialized. > > > > + @retval Other Error happens during the in= itialization. > > > > + > > > > +**/ > > > > +EFI_STATUS > > > > +EFIAPI > > > > +RedfishBootstrapAccountInit ( > > > > + IN EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL *This, > > > > + IN REDFISH_CONFIG_SERVICE_INFORMATION > > *RedfishConfigServiceInfo > > > > + ) > > > > +{ > > > > + REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE *Private; > > > > + > > > > + Private =3D REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE_FROM_PROTOCOL > > > > (This); > > > > + > > > > + Private->RedfishService =3D RedfishCreateService > > > > + (RedfishConfigServiceInfo); if (Private->RedfishService =3D=3D N= ULL) { > > > > + return EFI_DEVICE_ERROR; > > > > + } > > > > + > > > > + Private->RestExHandle =3D RedfishConfigServiceInfo- > > > > >RedfishServiceRestExHandle; > > > > + > > > > + return EFI_SUCCESS; > > > > +} > > > > + > > > > +/** > > > > + Stop a Redfish configure handler. > > > > + > > > > + @param[in] This Pointer to > > > > EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL instance. > > > > + > > > > + @retval EFI_SUCCESS This handler has been stoped su= ccessfully. > > > > + @retval Others Some error happened. > > > > + > > > > +**/ > > > > +EFI_STATUS > > > > +EFIAPI > > > > +RedfishBootstrapAccountStop ( > > > > + IN EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL *This > > > > + ) > > > > +{ > > > > + REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE *Private; > > > > + > > > > + Private =3D REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE_FROM_PROTOCOL > > > > (This); > > > > + > > > > + if (Private->RedfishService !=3D NULL) { > > > > + RedfishCleanupService (Private->RedfishService); > > > > + Private->RedfishService =3D NULL; } > > > > + > > > > + return EFI_SUCCESS; > > > > +} > > > > + > > > > +EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL mRedfishConfigHandler =3D > > { > > > > + RedfishBootstrapAccountInit, > > > > + RedfishBootstrapAccountStop > > > > +}; > > > > + > > > > +/** > > > > + Unloads an image. > > > > + > > > > + @param[in] ImageHandle Handle that identifies the ima= ge to be > > > > unloaded. > > > > + > > > > + @retval EFI_SUCCESS The image has been unloaded. > > > > + @retval EFI_INVALID_PARAMETER ImageHandle is not a valid image > > handle. > > > > + > > > > +**/ > > > > +EFI_STATUS > > > > +EFIAPI > > > > +RedfishBootstrapAccountUnload ( > > > > + IN EFI_HANDLE ImageHandle > > > > + ) > > > > +{ > > > > + EFI_STATUS Status; > > > > + > > > > + if (mBootstrapPrivate =3D=3D NULL) { > > > > + return EFI_SUCCESS; > > > > + } > > > > + > > > > + if (mBootstrapPrivate->RedfishEvent !=3D NULL) { > > > > + gBS->CloseEvent (mBootstrapPrivate->RedfishEvent); > > > > + } > > > > + > > > > + Status =3D gBS->UninstallProtocolInterface ( > > > > + mBootstrapPrivate->ImageHandle, > > > > + &gEdkIIRedfishConfigHandlerProtocolGuid, > > > > + (VOID *)&mBootstrapPrivate->Protocol > > > > + ); > > > > + if (EFI_ERROR (Status)) { > > > > + DEBUG ((DEBUG_ERROR, "%a: can not uninstall Redfish config > > > > + handler > > > > protocol: %r\n", __func__, Status)); > > > > + } > > > > + > > > > + FreePool (mBootstrapPrivate); > > > > + mBootstrapPrivate =3D NULL; > > > > + > > > > + return EFI_SUCCESS; > > > > +} > > > > + > > > > +/** > > > > + This is the declaration of an EFI image entry point. This entry > > > > +point is > > > > + the same for UEFI Applications, UEFI OS Loaders, and UEFI > > > > +Drivers including > > > > + both device drivers and bus drivers. > > > > + > > > > + @param[in] ImageHandle The firmware allocated handle for = the UEFI > > > > image. > > > > + @param[in] SystemTable A pointer to the EFI System Table. > > > > + > > > > + @retval EFI_SUCCESS The operation completed successful= ly. > > > > + @retval Others An unexpected error occurred. > > > > +**/ > > > > +EFI_STATUS > > > > +EFIAPI > > > > +RedfishBootstrapAccountEntryPoint ( > > > > + IN EFI_HANDLE ImageHandle, > > > > + IN EFI_SYSTEM_TABLE *SystemTable > > > > + ) > > > > +{ > > > > + EFI_STATUS Status; > > > > + > > > > + if (mBootstrapPrivate !=3D NULL) { > > > > + return EFI_ALREADY_STARTED; > > > > + } > > > > + > > > > + mBootstrapPrivate =3D AllocateZeroPool (sizeof > > > > (REDFISH_BOOTSTRAP_ACCOUNT_PRIVATE)); > > > > + if (mBootstrapPrivate =3D=3D NULL) { > > > > + return EFI_OUT_OF_RESOURCES; > > > > + } > > > > + > > > > + CopyMem (&mBootstrapPrivate->Protocol, &mRedfishConfigHandler, > > > > + sizeof > > > > (EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL)); > > > > + Status =3D gBS->InstallProtocolInterface ( > > > > + &ImageHandle, > > > > + &gEdkIIRedfishConfigHandlerProtocolGuid, > > > > + EFI_NATIVE_INTERFACE, > > > > + &mBootstrapPrivate->Protocol > > > > + ); > > > > + if (EFI_ERROR (Status)) { > > > > + DEBUG ((DEBUG_ERROR, "%a: can not install Redfish config > > > > + handler > > > > protocol: %r\n", __func__, Status)); > > > > + goto ON_ERROR; > > > > + } > > > > + > > > > + // > > > > + // Register after provisioning event to remove bootstrap account= . > > > > + // > > > > + Status =3D CreateAfterProvisioningEvent ( > > > > + RedfishBootstrapAccountOnRedfishAfterProvisioning, > > > > + (VOID *)mBootstrapPrivate, > > > > + &mBootstrapPrivate->RedfishEvent > > > > + ); > > > > + if (EFI_ERROR (Status)) { > > > > + DEBUG ((DEBUG_ERROR, "%a: failed to register > > > > + after-provisioning > > event: > > > > %r\n", __func__, Status)); > > > > + goto ON_ERROR; > > > > + } > > > > + > > > > + return EFI_SUCCESS; > > > > + > > > > +ON_ERROR: > > > > + > > > > + RedfishBootstrapAccountUnload (ImageHandle); > > > > + > > > > + return Status; > > > > +} > > > > diff --git a/RedfishClientPkg/RedfishClient.fdf.inc > > > > b/RedfishClientPkg/RedfishClient.fdf.inc > > > > index 154f641b2..47e5093f2 100644 > > > > --- a/RedfishClientPkg/RedfishClient.fdf.inc > > > > +++ b/RedfishClientPkg/RedfishClient.fdf.inc > > > > @@ -15,6 +15,7 @@ > > > > INF RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe= .inf > > > > INF RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.inf > > > > INF > > > > > > RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.inf > > > > + INF > > > > > > > > > RedfishClientPkg/RedfishBootstrapAccountDxe/RedfishBootstrapAccountDxe > > .inf > > > > INF RedfishClientPkg/Features/Memory/V1_7_1/Dxe/MemoryDxe.inf > > > > INF > > > > > > RedfishClientPkg/Features/MemoryCollectionDxe/MemoryCollectionDxe.inf > > > > INF > > > > > > > > > RedfishClientPkg/Features/ComputerSystem/v1_5_0/Dxe/ComputerSystemD > > xe. > > > > i > > > > nf > > > > -- > > > > 2.34.1 > > > > > > -The information contained in this message may be confidential and > > proprietary > > > to American Megatrends (AMI). This communication is intended to be > > > read > > only by > > > the individual or entity to whom it is addressed or by their > > > designee. If the > > reader > > > of this message is not the intended recipient, you are on notice > > > that any distribution of this message, in any form, is strictly > > > prohibited. Please > > promptly > > > notify the sender by reply e-mail or by telephone at 770-246-8600, > > > and > > then > > > delete or destroy all copies of the transmission. > > >=20 > -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118920): https://edk2.groups.io/g/devel/message/118920 Mute This Topic: https://groups.io/mt/105596648/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-