From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 58C9F7803CF for ; Tue, 5 Mar 2024 18:14:24 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=FQvEvR+3Z5+TeWUxqcTyeOfx/UU2/bvBhcMkU+qSbnQ=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1709662463; v=1; b=S9S2U/n+i4jNEO0Zzmr++xEtI9EvBbV4VSMeni+8q4JQt7JP8WK/MFvy22arwLIwXeinHJ1K EIsmujScHmEgbRVK9sYpbGMNZ0uNVnFAiHQwW0lRJxgrB1KRkQGIsBWMNMz0mH9eB/Oj2VlZOS5 LpC6ahEwuMfqZp9gN46gQNCb9d0Vd+d5YDPgA9HH05Sc9zBldIcUlklJ/Y3pg8sBBSmoYDNQ6oM 6y3IGiUKQBEdFzR3ROLQeUqJm3mp9F8CM17gMrZfYwfZNg/SSOfF/t5EOLDIhsUVSK3p+7Kum6S EnslQhtfgB+c5lOiN+92zKcNfsmyKioEqinR7fIHleixw== X-Received: by 127.0.0.2 with SMTP id vuEgYY7687511x60qgdWnnO0; Tue, 05 Mar 2024 10:14:23 -0800 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.120]) by mx.groups.io with SMTP id smtpd.web11.29.1709662462103677498 for ; Tue, 05 Mar 2024 10:14:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ldgd0TQ2nLZcOslwW/BSNU8zxm1OqPJG8zYLKfS0eDLtnN8KjfCPtiQgNuDnxVNqnPOjTf3Q2OSLLj1ifa9FYaZJF1vqaBmYsFURZWYNUcCCWxCXQl6OBPHHFfrDQHPBceyUUGF5DZEfX8kLn2aDc227xBOCGnfP8yWZ/ZGTKMByxobJHjaBA+0GdSwNwvyyziMsEOWQlztVIwFxXXU3wsqGy2W65jpvyvmwx5eedcOaWR3ZvgNUBNFsL8Zf2I9Y3CYJr+t44Xf9CuBX0LD4SIbCGlKCsVB+RakTXRID9/xYpB5Y7coRSvuK2IJZWkGLjOZ+fa3nQ8kIMramY5UYMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jlmfu0MndJiTH4S7z75QQxUtSGhUuU2zG4GxXQijaxU=; b=MFt8gVd9pFVcY8SkB9pPJk0MhikVXec05rpfh/5gmQK/Fb+pgcoWWJS20Htk1lU+fbQXrGGCuIsSgemCyoqdUTGpDgSpbNiZYjeZUB51P+16UcY1duevMUE3v3AsXJM/oJTs30gJgYobvHhx1zIwlrEWAovoNBSeLqmhjLjGfRVb37gn2Zgh1k9Az8FmpxiVQYBWp9z8hcSUzJGl3nOMaiJHpXEq4WC8tReVEhDhtdEj8s+oJHzg+ZdlWYU85A5ylMRtYJU9NR4fe3DC+eRW9sMLHTWmhQyrRdKYD7svYisJhhZkqN9fVvgDjex2sF5FE7EMQ7hIrm3zXSK9uY7Gig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by IA1PR10MB6218.namprd10.prod.outlook.com (2603:10b6:208:3a5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.39; Tue, 5 Mar 2024 18:14:16 +0000 X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::a03f:4d36:9713:33d0]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::a03f:4d36:9713:33d0%3]) with mapi id 15.20.7339.035; Tue, 5 Mar 2024 18:14:16 +0000 From: "Igor Kulchytskyy via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Abner Chang Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol Thread-Topic: [EXTERNAL] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol Thread-Index: AQHaauy7Mz/tmNybnUCvnkoEWYkFzrEpe6fQ Date: Tue, 5 Mar 2024 18:14:16 +0000 Message-ID: References: <20240229085248.111772-1-nicklew@nvidia.com> In-Reply-To: <20240229085248.111772-1-nicklew@nvidia.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|IA1PR10MB6218:EE_ x-ms-office365-filtering-correlation-id: 7ca19b7c-b87a-49bd-8b77-08dc3d4011ce x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: SR9khhvv2C2m5UhbosDzhQCm6ggMBLErwdT5ccuCEJEh1An0RRvz+/V+k56PMauzuzXrxq/NFv4oH3XwIdivd5ocCkO9V13B9HaRwL/tjXeQNnLrzLOqoOnclzM5PpZ5qX4fYquV1Cqk7PU4sijpm/8WwvRTlpuKdqw4wvUJP78dUGsxXQ3mJeUYFB6aG33xu/XlqZKvR3DaONy3xcVw+agyDUCToS0pfsWiaoUXDgVCEWWMLvcoiv0egtk1FhQJE4q1/BZE+SB43HNRgCexhGD1kBGRHVkjDzUbBgLUGV/yt9wKjDwVZh7uUSM9jDlgWE+nmX2VldpZHJwgX/qsfddPvfa4ZkZYXftSqRFvlyvYKGRG6SRgzJG6Rnohg2ys61JymoiCMqUdg4ZQKGTrjn78dQJGoUehQuYcTkhgCrCrwHA0iwicjoOOQPxRutgnMQ8CrYgp0iIv+xJ32suo7UrBLpIZ1k5eeSUNi5mYbryqP87W92O1ld1VTE/10HSgL6JwfcUnBUBPgh2HkHRTSBw6J8EP3QfSp5tHnSdIHkZ5/a2NTkQULDjPe3XC5d8PJruy8V3YcP1I035yjDfmH3vvuqNBz12AY7G5McuYYKRQBZxjV3FjWle0Qvy1yIp2R85oNeJkoQv13G+mwSTRi7YQJ12mshQtr8LrrgFQ+X0= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aLex84zoRutG8gl2HSE8StHJ+lTmdMVau6gXy+NabKqwDZjHZj8nguK2WO/f?= =?us-ascii?Q?JCm6YAtExbK0VVEc2mB+OKBu/iUde+NDuemGMDtLWu+AnYkIN2ySklYG+iyn?= =?us-ascii?Q?znmbL2snVDbbhOYlai1LWJJ4tdNEKUATT3SugRZWermAhAXH67B7fTsQZtKi?= =?us-ascii?Q?XQI3C+A6G2YgR7+V6HtSh3N5QFw1MTbM/jHxqXiuXUlkCnlQPwbW5oHLVOaS?= =?us-ascii?Q?OrDMl2nho9lSA6b35vzgY4TZTLeY6xsq9FDbcLKFiXqwVAXUsj0vwwHZQ4/k?= =?us-ascii?Q?TRxSgKuRw9MPNTd7fnFGmHL0HUu7CkPPqWvD7rHzLjm0/6rJH106kogiuPTS?= =?us-ascii?Q?dCQ3ZHGUDR+EBpRgCgNmrMcnMO0Cj31nYgruqGSuGFjIGAHQkERmAa9Yij7b?= =?us-ascii?Q?agWiWNK5BCPhrcxdhhbig5NErY8F1B8/WBbK35Fjv/MxWql/iuRttA8JPYE+?= =?us-ascii?Q?kPrmZ8MayvCwZ/6Ifprv8eRmOwWYmRNmvfciPx4WkKyF57FT+Dhg1qRgqgYS?= =?us-ascii?Q?aM6ZELebOBfV62gffsvE6gVBri27xW3mjvrXLP2+jjgCaglA9g2d6c1KSo5T?= =?us-ascii?Q?XzIKF4wZIen4aQtaORvmVrrxvD7grYX1J5ds//UgdENyUoTKpPFwCdQ+BxOX?= =?us-ascii?Q?5IKBvXcOfDrpPiUm75eqTtnot5SjjFjynCPPptJ8Cs/2wlIoES4pznMFj2ro?= =?us-ascii?Q?UUJlXAlbSNpNcBd713qTrDe0LHU8Kan5H66J0qFeQn3xUg9V0IS1mMJYc3F2?= =?us-ascii?Q?Uy2+VReQhzyg/BujIC6e2lW2X38iah3+jrqTz74Q8Tjc/MlSE09QhF4MrlPS?= =?us-ascii?Q?cS8eXESd1szX95yEAMaFhpcyMUK11SCxTDCXm/WE5NOb8leC4BtHqEOHbqhv?= =?us-ascii?Q?wVaOaS4U83zBP5+3acAm21zX3nE9RZxRVkvm/bJDMRv6Lt8AQwmlOMqCE2I9?= =?us-ascii?Q?uKrNYc2rJ/2Bgn16R1yZCYVJo2TDcS0c8mbMxAkPvHsftzWGU/22nh/Ou8W0?= =?us-ascii?Q?IYFTLJyHqrXxL/5i2Aoov3ytcolSlKJl1ik+1g/LgkMQ44nbdsUYPbaXJPKJ?= =?us-ascii?Q?FGUN6DSN/VgoJ24xiKgqUO+mXkk5Kpqf00lHwW8RNTo0P4J656vDTJlyx0MU?= =?us-ascii?Q?3RT8c1P8i/gsGBjJ7kQL0P7WYjCe5AKgQehwb39SAaXMdC2DQxHgNoNHZSQa?= =?us-ascii?Q?c6JtYuoK3yD9555I6mAJDkfsqJCMUziNswPFCpOm+MzZJ4j4daoHDWtovy+5?= =?us-ascii?Q?p5sCjN4P+36Xo2bLXbuxuvvLFTEHyRLSyoh61GDjXjbSGSG+c/1r01a3wiGk?= =?us-ascii?Q?Yu/ogZ+xTk0hQ28qt9RHfs/xL99c5onoU8L2WlzCr9Bg5dfFLaZRjT/JpCVt?= =?us-ascii?Q?4+2hoJIgxaHlRKLAlI76zj5RNjCMLo5rSz54UsGWcKRmpf3ozcRJLwMtqDg9?= =?us-ascii?Q?zgD1cDtu1DHw9BT8JIvW0ESREnH9gRgUJa6QYzaD8AlDUjkZuiPkSHXDrGGv?= =?us-ascii?Q?naYXcZN8pewlbBELcW+2345wLeTQbEKGs1LPwFGapZ1pvNAUZFByiSB0Hccl?= =?us-ascii?Q?Wse0lDqRsjzcfzQTIvo=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ca19b7c-b87a-49bd-8b77-08dc3d4011ce X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2024 18:14:16.5306 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tx/XtHAKWA8nyrGnww2UB4B2NuQ6xw/cEwiuuxLcsqnVlFFik82bdTrp35SrkITg X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6218 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,igork@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: YQPm1aaF7EE1ho6Nx1uI7qd5x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="S9S2U/n+"; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Igor Kulchytskyy Whole patch reviewed Regards, Igor -----Original Message----- From: Nickle Wang Sent: Thursday, February 29, 2024 3:53 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy Subject: [EXTERNAL] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP pro= tocol **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** Redfish HTTP protocol is introduced to edk2 RedfishPkg. Update RedfishClientPkg to use RedfishHttpLib. And remove the use of RedfishHttpCacheLib. I also replace several functions from RedfishLib with the function provided in RedfishHttpLib. In this way, there is no dependency on RedfishLib in RedfishClientPkg. I noticed that there is false alarm in uncrustify check. When there are deleted files, uncrustiry cannot check them and trigger uncrustify failure. Pull request is created here for testing CI: https://github.com/tianocore/edk2-redfish-client/pull/79 Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Nickle Wang (13): RedfishClientPkg/.github: do not run uncrustify to deleted file. RedfishClientPkg: remove RedfishHttpCacheLib RedfishClientPkg: ues RedfishHttpLib RedfishClientPkg/RedfishResourceConfigLib: ues RedfishHttpLib RedfishClientPkg/RedfishFeatureUtilityLib: ues RedfishHttpLib RedfishClientPkg/RedfishVersionLib: ues RedfishHttpLib RedfishClientPkg/BiosDxe: ues RedfishHttpLib RedfishClientPkg/BootOptionDxe: ues RedfishHttpLib RedfishClientPkg/BootOptionCollectionDxe: ues RedfishHttpLib RedfishClientPkg/ComputerSystemDxe: ues RedfishHttpLib RedfishClientPkg/ComputerSystemCollectionDxe: ues RedfishHttpLib RedfishClientPkg/MemoryDxe: ues RedfishHttpLib RedfishClientPkg/MemoryCollectionDxe: ues RedfishHttpLib RedfishClientPkg/RedfishClientPkg.dec | 1 - RedfishClientPkg/RedfishClientLibs.dsc.inc | 2 +- RedfishClientPkg/RedfishClientPkg.dsc | 1 - .../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 3 +- .../BootOption/v1_0_4/Dxe/BootOptionDxe.inf | 5 +- .../BootOptionCollectionDxe.inf | 5 +- .../v1_13_0/Dxe/ComputerSystemDxe.inf | 3 +- .../v1_5_0/Dxe/ComputerSystemDxe.inf | 3 +- .../ComputerSystemCollectionDxe.inf | 3 +- .../Features/Memory/V1_7_1/Dxe/MemoryDxe.inf | 3 +- .../MemoryCollectionDxe.inf | 3 +- .../EdkIIRedfishResourceConfigLib.inf | 2 +- .../RedfishFeatureUtilityLib.inf | 3 +- .../RedfishHttpCacheLib.inf | 48 -- .../RedfishVersionLib/RedfishVersionLib.inf | 3 +- .../Library/EdkIIRedfishResourceConfigLib.h | 4 +- .../Library/RedfishFeatureUtilityLib.h | 46 +- .../Include/Library/RedfishHttpCacheLib.h | 59 -- .../Include/RedfishCollectionCommon.h | 3 +- .../Include/RedfishResourceCommon.h | 3 +- .../RedfishFeatureUtilityInternal.h | 3 +- .../RedfishHttpCacheLibInternal.h | 63 -- .../Features/Bios/v1_0_9/Common/BiosCommon.c | 92 +-- .../Features/Bios/v1_0_9/Dxe/BiosDxe.c | 113 +-- .../v1_0_4/Common/BootOptionCommon.c | 45 +- .../BootOption/v1_0_4/Dxe/BootOptionDxe.c | 86 +- .../BootOptionCollectionDxe.c | 26 +- .../v1_13_0/Common/ComputerSystemCommon.c | 68 +- .../v1_13_0/Dxe/ComputerSystemDxe.c | 85 +- .../v1_5_0/Common/ComputerSystemCommon.c | 68 +- .../v1_5_0/Dxe/ComputerSystemDxe.c | 84 +- .../ComputerSystemCollectionDxe.c | 15 +- .../Memory/V1_7_1/Common/MemoryCommon.c | 86 +- .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c | 111 +-- .../MemoryCollectionDxe/MemoryCollectionDxe.c | 15 +- .../EdkIIRedfishResourceConfigLib.c | 6 +- .../RedfishFeatureUtilityLib.c | 182 +--- .../RedfishHttpCacheLib/RedfishHttpCacheLib.c | 774 ------------------ .../RedfishVersionLib/RedfishVersionLib.c | 24 +- .github/workflows/uncrustify-check.sh | 17 +- 40 files changed, 328 insertions(+), 1838 deletions(-) delete mode 100644 RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHtt= pCacheLib.inf delete mode 100644 RedfishClientPkg/Include/Library/RedfishHttpCacheLib.h delete mode 100644 RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHtt= pCacheLibInternal.h delete mode 100644 RedfishClientPkg/Library/RedfishHttpCacheLib/RedfishHtt= pCacheLib.c -- 2.34.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116405): https://edk2.groups.io/g/devel/message/116405 Mute This Topic: https://groups.io/mt/104640214/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-