From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 66C62740049 for ; Thu, 4 Apr 2024 13:33:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=8YDFP7t0K/7Uyt9KwwcSOoQI4eB8DVITsu/0ix8xfuk=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1712237625; v=1; b=M5gbDjYBLHjnwO5JULOD3K07VE7gazq2aY+VqUmxm7kOGTEqVUwCTFoV3GORZcW8TDWgJVEB dgM/V/tBJ5/86+kfTI6G7N1pcrd312QY0UDzoySV/cc7XHghOltp0xDpK42g57/itclUTeLs8D/ /2W6IwsmgAJ28xyNMWGjeQIz32e//tfQEn8ZFB2cjCfqeaEln8LQOXV96TP5MDYKJEJb7XA9Oza b5azn7it670TVQ3JRJcbSourlouNtqvYs8AeclVIe2tv5MC0dnXiZhHXKlZN110RTgDfMbzufLO D8ge9pRvXzFKAL/bcLCi5ru7YeA2Ymg07JXo06o0dIEPA== X-Received: by 127.0.0.2 with SMTP id cESYYY7687511x2gKOEDmoRi; Thu, 04 Apr 2024 06:33:45 -0700 X-Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.107.102.111]) by mx.groups.io with SMTP id smtpd.web11.38055.1712237624444776263 for ; Thu, 04 Apr 2024 06:33:44 -0700 X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by SJ0PR10MB5552.namprd10.prod.outlook.com (2603:10b6:a03:3da::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Thu, 4 Apr 2024 13:33:42 +0000 X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::a03f:4d36:9713:33d0]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::a03f:4d36:9713:33d0%5]) with mapi id 15.20.7409.042; Thu, 4 Apr 2024 13:33:42 +0000 From: "Igor Kulchytskyy via groups.io" To: "abner.chang@amd.com" , "devel@edk2.groups.io" CC: Nickle Wang Subject: Re: [edk2-devel] [PATCH V3 0/6] Config language searching algorithm enhancement and the bug fixes Thread-Topic: [EXTERNAL] [PATCH V3 0/6] Config language searching algorithm enhancement and the bug fixes Thread-Index: AQHahnlvcGuV9iX6Jku3wtF6yGFJabFYHHLg Date: Thu, 4 Apr 2024 13:33:42 +0000 Message-ID: References: <20240404101758.84-1-abner.chang@amd.com> In-Reply-To: <20240404101758.84-1-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|SJ0PR10MB5552:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: wNDKWU79If7694Zrp8rxSj4bMD0yVjF1vtCqcJtyWRixN9cMejlkrMy5+zJwd2u/VjemYxDyJ0R7lCqrYbo5yLCki5RApPLIp7ZEVBy0lbXVemlGH4kXX0z0eZImdDJBTb3fmrTd/LHzoXbyWGw34/BhLPiMW2r0sdNwyi3oSYj22MIKsg2G2W2ZiFXSbaiBQRanGaI113Td3yunrgKddG+hLAuvehA1qKmdzxGZCwjEUenjq+F1nm2ygivQBTFo+ip/i20UtXve/lpoIW5b5z1sTmL9hzJnGvX35Sh67RT3zjhnvSVXx7jLMPXk9iafNiCy2nF1ZiXnd8ZTu8KbVdkg23dZ36To90NR1bVLi7F0hTfgZbGPvynP8unPHR0b2epz0n8153n5673nTi5XkElCtlLRX8byZYYhhvBn15t+FndEFPEleMh+STnv2q8yEfvyfap1+mmDAc2nI6T/qxq82hqdXWzJ5Sr/uHWEXiMldXiz2+vcpQfkQ0NGCIzyMQXJTrWD+rk5zLG42ustu9Y/gBpahbYl4eOSdquVuLE1BOoa/TZoRX5VoYEYMESgptLRSBQlNmwFxeHMVgE9LMCKszsdWQIAIDpXzzcjs/Ccivj8SL/+RYNzoJ19NSJzY3GVUOlpvMmjlmFvsfx+5lkSpusJhrwjPmWiyx1HBbI= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?B9RsZsJWoEkMWJJyzEQup28+YqBiELt8EDKW7obel0x9UMpqnn9EH8GrA/DG?= =?us-ascii?Q?aHIwxvufaB1AGJblUndt0E/ElDpSuDW0D1GTQyFKj2+NSS+3MK4Geq76cYgy?= =?us-ascii?Q?tRkfcVlUPQ1TKt4XJHyN0p47ltKZqk781DBCbUWv6X1QEG1K5EJ10aypJF2k?= =?us-ascii?Q?IYxG6Lug9sOuuiX/r88ppxOgrHFBpskqvrk4THk8kDsoYdmCrArLPTY663xA?= =?us-ascii?Q?MOyrcEzidNo8UrQowLzFU7SS0f+vWADPxCQBNRfo0nR9TFIFPlrhOWa0QI5+?= =?us-ascii?Q?/6H/oxi0J7P8YQ7K4sna7Ro24UsCOlGU+gfxEYn7B5wxxcf8CCFOyMK0Fz8Q?= =?us-ascii?Q?jqy1sLBkQqTWStHd8pdHR/CoNc6ay9mEN8GRbscWVaiFivoEBRZUQTOxaFdh?= =?us-ascii?Q?SjJ6R897GmSBRLzKnaj8kwUpf3EiCk4M8CIami3ofXfjKaf29OH3XM4YJZ2Y?= =?us-ascii?Q?xkf90P1KoPWWKTeKwOMLhhlaBbSAz6B8a9Jkfr/AmlWN8066Kb4vT1IBgata?= =?us-ascii?Q?tmnxF2fEL3bXdjfhcmaNueSqB031s05fwQj9b8TXu6dJqjWesxHBusuPtuu3?= =?us-ascii?Q?Z9VQc9P/dKgJFgBdcIavaghpuiM2R1sOlX3SDGXR3wLfwuQVvN6l51XKBLg1?= =?us-ascii?Q?FS433WQ28jqBRSBThBdwbMlem69Xl9CmwqLK8KCfdiIJv2h0z+9T9aicgQBU?= =?us-ascii?Q?fhlZhQLH667bPA6hlIrJnXaHNBXxNKrtcbTyHqBExR0BUxAotQSsikGYIHQm?= =?us-ascii?Q?uY6V/+2QN7yhEMGkrYUp/qWZEIE5eqB08KQtZ44fI5tyX+onre19bSIZvCoJ?= =?us-ascii?Q?57EkrRkxbRJnLa2Fm2jxSW/C6JQnmt4r6DwaOKjxR3wglMK1yzOQC4AbZDqu?= =?us-ascii?Q?LRl+ozru+NuLYDy3WttQKH6qMcRT+NVCbeEOOklTFoRp+lOFAFq0AYfsxCVJ?= =?us-ascii?Q?XwTpdDh58+2VPS3apciX9k3K+G+bBbpr0Pg1/PSIA520JrsROpTjVEawi/xc?= =?us-ascii?Q?i3mMBAM/YN9/ggK4mGrowhm3lEFIp270GRV1s4+aDQSQxBOkUOHZwgOEyymE?= =?us-ascii?Q?FKcwGO4xXDPHgWH5Xpw1q1PxXZL3OGmCPJSJ3esbSdEECiSLkvUwCWvNjPmV?= =?us-ascii?Q?LSGOi3uSUVW2DX77X1tRLdOlrfjbeniZE+yuIV1a4Lx1RFB/SX0Txf0zk5xZ?= =?us-ascii?Q?ydVwjsVdQy4chT3WgfSwW7/ArcqWvePY+6cr+3zvm5tvb96vdXUKYzIHrd1h?= =?us-ascii?Q?lqKTIM3rXIPdahi+oi4mS98oZxQdt0wssIkhTYzXqfJRZgwKagHJ6byHuqXG?= =?us-ascii?Q?DElOdWqQpM6Ekxvuly+6a0TwvSCoGm1QYFGerqtcpXoYAk7XYpandb39OkPC?= =?us-ascii?Q?+hXAl/l0o8IdDuxcvLVkZ+sh71y74+sBsOEQBJYUOwh+tswQp7FQ1FKj1Zdx?= =?us-ascii?Q?GHxkCd8ihmHDQtlUCUTJOhPTsru27hr+LnkVedrx+ndcPUzGPqRSBpWnqxV1?= =?us-ascii?Q?pI8CP8RvUCY6CbVts5rekZigtQ6ac/w4L8opE4jae3xvFsK5GEiZrGJHlvNU?= =?us-ascii?Q?HpY/4bqAPMiSxkUXSsg=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b09087c-f12c-4826-5795-08dc54abd813 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2024 13:33:42.0971 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9dHQSDedSgg8IFSxmg6YlWaN8t0G2RyJ8ltN7uKweTsX23Z/yaisKvCX59ZxWmW5 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5552 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 04 Apr 2024 06:33:44 -0700 Resent-From: igork@ami.com Reply-To: devel@edk2.groups.io,igork@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: SQLbm4ldav1BIc5rIxcqhoVox7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=M5gbDjYB; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Igor Kulchytskyy Regards, Igor -----Original Message----- From: abner.chang@amd.com Sent: Thursday, April 4, 2024 6:18 AM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [EXTERNAL] [PATCH V3 0/6] Config language searching algorithm enha= ncement and the bug fixes **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** From: Abner Chang PR # 5517 In V3, adddressed comments from Nickle and Igor. In V2, add patch 6/6 contibuted by Nvidia for updating BIOS menu path implementation based on the performance improvement. In this patch set, 1 We enhance the config language searching algorithm. As the performance of searching config language using HII GetString is pretty slow. For the example, 1800 HII BIOS options takes over 30 mins to build up the metadata required for Redfish BIOS resource. With this improvement, it only takes 4 seconds. 2.Introduce the Redfish debug framework, there are three edk2 Redfish debug scopes. a. PcdDebugPrintErrorLevel, DEBUG_MANAGEABILITY to enable debug message for edk2 Redfish. b. PcdRedfishDebugCategory, enablement of individule edk2 Redfish component. Currently we only support RedfishPlatformConfigDxe module. c. PcdRedfishPlatformConfigDebugProperty, edk2 Redfish module debug scope. This PCD is used by RedfishPlatformConfigDxe debug enablement. 3 This patch set also fixes an issue that deletes HII string unexpectedly. Signed-off-by: Abner Chang Co-authored-by: Nickle Wang Cc: Igor Kulchytskyy Abner Chang (4): RedfishPkg/RedfishDebugLib: Introduce Redfish DEBUG macro RedfishPkg/RedfishPlatformConfigDxe:Add RefishDebugLib support RedfishPkg/RedfishPlatformConfigDxe: HII string is deleted unexpectedly EmulatorPkg/Redfish: Use edk2 Redfish debug PCDs Nickle Wang (1): RedfishPkg/RedfishPlatformConfigDxe: support menu path report abnchang (1): RedfishPkg/RedfishPlatformConfigDxe: Config language searching optimization RedfishPkg/RedfishPkg.dec | 24 + EmulatorPkg/EmulatorPkg.dsc | 21 + .../RedfishDebugLib/RedfishDebugLib.inf | 4 + .../RedfishPlatformConfigDxe.inf | 8 + RedfishPkg/Include/Library/RedfishDebugLib.h | 43 +- .../RedfishPlatformConfigDxe.h | 48 +- .../RedfishPlatformConfigImpl.h | 135 ++- .../Library/RedfishDebugLib/RedfishDebugLib.c | 55 +- .../RedfishPlatformConfigCapability.c | 58 ++ .../RedfishPlatformConfigDxe.c | 89 +- .../RedfishPlatformConfigImpl.c | 927 ++++++++++++++++-- 11 files changed, 1239 insertions(+), 173 deletions(-) create mode 100644 RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConf= igCapability.c -- 2.37.1.windows.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117431): https://edk2.groups.io/g/devel/message/117431 Mute This Topic: https://groups.io/mt/105326102/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-