From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A6AAA74004D for ; Thu, 4 Apr 2024 13:34:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=eNj6MpDRj9/PP3yHP05WLFuAk0KUy/+tNLphnOawkrU=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1712237659; v=1; b=42SqPHJWk50ZXZVvmuzY9Pa48oQ2253bY1etmglMqFcH8o/bhsJRnfkSi66NldwWg+9aD5Ua 2wumiJVEnt3lZzBh9fjOO6rWCSFxEYEgcOyJ0u/de3qM+agtEnRs2AxyTWN6Ee9J7h6W2x/AmAa GSVHLd+JyTgnQDrdI64cZqizOTmZkIp4C2jZ+y5TEOXuy3utx2WPLbuzrfcgZM/S2lgjpCHBHRx h8F7Y6tPtLoEt46CeJeoxtGUHp1Ly67Io7vR1p330ViLPIO1y9WuyKl/FdkL4+An5hchlDBKDj2 dz6RsEpyuBZ80Xd8UIuea+mfIFRTYZpFN+XCXfhGmoX1g== X-Received: by 127.0.0.2 with SMTP id pFLJYY7687511xiW51VUQEFT; Thu, 04 Apr 2024 06:34:19 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.108]) by mx.groups.io with SMTP id smtpd.web11.38076.1712237658689800495 for ; Thu, 04 Apr 2024 06:34:18 -0700 X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by DM6PR10MB4298.namprd10.prod.outlook.com (2603:10b6:5:21f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Thu, 4 Apr 2024 13:34:16 +0000 X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::a03f:4d36:9713:33d0]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::a03f:4d36:9713:33d0%5]) with mapi id 15.20.7409.042; Thu, 4 Apr 2024 13:34:16 +0000 From: "Igor Kulchytskyy via groups.io" To: "abner.chang@amd.com" , "devel@edk2.groups.io" CC: Nickle Wang Subject: Re: [edk2-devel] [PATCH V3 4/6] RedfishPkg/RedfishPlatformConfigDxe: HII string is deleted unexpectedly Thread-Topic: [EXTERNAL] [PATCH V3 4/6] RedfishPkg/RedfishPlatformConfigDxe: HII string is deleted unexpectedly Thread-Index: AQHahnl2FdWnLW7IKEe4uTM9f9j44rFYHJ2g Date: Thu, 4 Apr 2024 13:34:16 +0000 Message-ID: References: <20240404101758.84-1-abner.chang@amd.com> <20240404101758.84-5-abner.chang@amd.com> In-Reply-To: <20240404101758.84-5-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|DM6PR10MB4298:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: WStXtDTydZOY24WRJ6qfbppbiNSrs+YcMAL6XcNS2d3IWLWuNbnUBH6HlO4JZCURotRisNtb8K49u+KKyYWQV+0YKCc79OnnE8wJkJF+PoUqbx64wZcJC3QdqKWMlhuL1wRJ+T8vxo+Dpr13ywJT+rw6ZQOKzxxAtFxzeg0AUVRPo7nx3V2LrNPx9pXtKsTaGXmOAI+jIhxSJD7L5xCd3uIbM2F6OdOJiIM1qjULRzpK6osB8kJ/VVDFZAhig6NNL1Tgt4mfqlldMHSIrlzFHtRbxysEdLSo6hufXfa4JaDVC8jv8MSVVvMuzlWkCVOqVDXsvaPufKsTaivFuUxB6XQc8jxvsEH599y+Wh5IXHGqWGRJS8kH0ZYRVnKCV6HHjJEvWR3JZFobqMMqGS88zdatBlg0JBEbZa4At0Y/BZXTqbyxx46dVrS8kaE6gAj2xpfE3TBr6YbkYHmZpmN+xr5ml9FkvXNw21zOHEND+u1HuWVBcunIOCzSqZUiPslVzFNyL3IN0WGvm6T9Gw4O3vOxfnXDHsBOvIKWxTNMnacESFrJRfcQiN/aKGVLj/4CNY8aajaS66eR8z7n67qDM40ufzAHgsvNBn+vEreMYZ5mXdh8lLNOPr9xlQJQ2enI0IBqOanDudL2YKVjXIhHP3P9+kz41H9LjIoevFsUgko= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tt2gG0fj2nXWr8yaTDsf+zDzyCJWqlERjC2GjWPvahuX07IGSh5ASb1PmZ4O?= =?us-ascii?Q?mC//rk7MKCTGn9xfJUNrWPbL6F9USHySBdoBu/WjMoXYbiqKPe2ouKlbJ3Ba?= =?us-ascii?Q?M5lp2WaYKHghpYPL36R1UiOXdkNJ/wZHgPqkkFIDmQ0kDL2PpWBjGIph8TX5?= =?us-ascii?Q?goN7OWlNTsfendDvTKey07MSkP4I0hzAt5f+7c1ZkTxMhTtW8lG3+KURAXhL?= =?us-ascii?Q?wjMsYqF5tuJ+R5ZcVmGYZucYQW3NvczOE/RU0f1IKi+2lcgULGt+RCxBfQ0Q?= =?us-ascii?Q?thq/ujIcKqt+yw0cwvbW1tSW2K4vNmyecDICyed4ADXDoiNWJ18836tify5R?= =?us-ascii?Q?ifTwpdrTn/F7yByUta8naRjBGmVRAbIEgEDKwAFpjgSAwQ/sjvRfh8MOHYfr?= =?us-ascii?Q?LdaGtUUWj3Rgx2YDgaLRr5D1V3qKd5RMB21Ip9O3j+SU4qcrbJne2/2ZTS9y?= =?us-ascii?Q?gxTwt39UceLCXabANfmQi8EGPTFcbGgYGdf84NisMMYQurY+0IgxU0EzkZ4T?= =?us-ascii?Q?K/dEI7/k7N8VuSpbVtezv0Oz7AERnhPfnMRN+C/qcr5bAlfbKtOEcRyUE1zM?= =?us-ascii?Q?wFgfXcai9/X9E1Nwqe3FbdmI00anlDqsGZBgwW/o4VmyKe22iUr6SPPSEB+H?= =?us-ascii?Q?nwGpFlXkyFPKA2ylNiNO7TZrA+96J3ROnpXv3UMs0YFNwEm56G2s1IabPPd3?= =?us-ascii?Q?Kym8R9XasmD741p/5RSJcWZJudllWlKTAoEF/2RME9ffZQNm3lW65b4alL1j?= =?us-ascii?Q?d53C6c/wH+GJX1iX8Xj+g5ORWx7ZpQbYleKTHq5OYRSuV9Z3s5JGM63+96m/?= =?us-ascii?Q?jsgck432gep1+kA6QHqtUpR4EWctEOK+1G4uH6pPti/haBOdXgpQe4KsZzPN?= =?us-ascii?Q?bovrSWt0ZRetf3LrkNmHFShyt7mqsW5QfUuN5UI8CaLzn/C2zWbFVvOpMtgM?= =?us-ascii?Q?jzOWBYDrVp5mCoxzI4klO3ezWMfHXCf3dzwSRFPSMCGCFtOH3p2AZADlbnhx?= =?us-ascii?Q?+I7SzV8Q2weBn0xk+8SSqOl8gtdBBDrrigluzrGwqE5JOEHM0OQYX9dthSl/?= =?us-ascii?Q?h+o0erKQyyq4KMYL9awIzZAfeGFfO/WRIIIHqYQ+TjFeOLC/ALUoarcSdx3P?= =?us-ascii?Q?O27ATKRyAEqQXXNv6iMT7MCM9kB/dMz6ui2uczBHSbgEWba08AKl4RYQZKJC?= =?us-ascii?Q?kWM5ApuhE7QGRu9gIxlaM0fW5gjNufLajA97exP36jZey6GF0dQXfQv/8yxh?= =?us-ascii?Q?/hpVxFhUqBcUtMEZggS/XxW/R9FcDdWS5f2iteBhIBKn4hZi89YT54Ietoby?= =?us-ascii?Q?LyjpBOiOwAKGf0EIDD+eO3/+6gPx4F42BjRUOuBvX8YP9OBRVgB93jcqO7u0?= =?us-ascii?Q?oLUrx1vgVTM6W7/woGPvJw/Zpo9k011ggEclwIauZ/2DvZdiepPz6DdmKTkE?= =?us-ascii?Q?xX/jqCY0VyeAAjrlW19nG3luiuoGa7a747ErUQ+PM8ORTc2oIWkMIbYI8r1K?= =?us-ascii?Q?sH0nRU/DYBRNC80JrxrCM9jkuKskGjo6mz+xGMhNEx8k7cISH5Yo9lkYuBOj?= =?us-ascii?Q?zktMZmSoj9A7JmBQNK4=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe28c520-2e16-4395-d668-08dc54abecc7 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2024 13:34:16.7885 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LKVHJGhgxbEBey0UB5CGCz/TIiKCE8vVAEJH7pHiKS5o+F1KyAD+zP+nOeEYLcox X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4298 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 04 Apr 2024 06:34:18 -0700 Resent-From: igork@ami.com Reply-To: devel@edk2.groups.io,igork@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: dwEi9VDJGY5koK2bhFXzEttGx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=42SqPHJW; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Igor Kulchytskyy Regards, Igor -----Original Message----- From: abner.chang@amd.com Sent: Thursday, April 4, 2024 6:18 AM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [EXTERNAL] [PATCH V3 4/6] RedfishPkg/RedfishPlatformConfigDxe: HII= string is deleted unexpectedly **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** From: Abner Chang Add the condition check when delete HII string. Only when the HiiStatement operand equal to "EFI_IFR_STRING_OP" and the statement value type =3D EFI_IFR_TYPE_STRING. Signed-off-by: Abner Chang Co-authored-by: Nickle Wang Cc: Igor Kulchytskyy Reviewed-by: Nickle Wang --- .../RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c= b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c index 99e7827eeaf..86f5d3c4478 100644 --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c @@ -1873,8 +1873,11 @@ RedfishPlatformConfigSetStatementCommon ( DEBUG ((DEBUG_ERROR, "%a: failed to save question value: %r\n", __func= __, Status)); } - if (StatementValue->Value.string !=3D 0) { - HiiDeleteString (StatementValue->Value.string, TargetStatement->Parent= Form->ParentFormset->HiiHandle); + if ((TargetStatement->HiiStatement->Operand =3D=3D EFI_IFR_STRING_OP) &&= (StatementValue->Type =3D=3D EFI_IFR_TYPE_STRING)) { + if (StatementValue->Value.string !=3D 0) { + // Delete HII string which was created for HII statement operand =3D= EFI_IFR_STRING_OP and Type =3D EFI_IFR_TYPE_STRING. + HiiDeleteString (StatementValue->Value.string, TargetStatement->Pare= ntForm->ParentFormset->HiiHandle); + } } return Status; -- 2.37.1.windows.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117435): https://edk2.groups.io/g/devel/message/117435 Mute This Topic: https://groups.io/mt/105326107/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-