From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.59]) by mx.groups.io with SMTP id smtpd.web10.196579.1672281681953208299 for ; Wed, 28 Dec 2022 18:41:22 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ami.com header.s=selector1 header.b=LjzgP96w; spf=pass (domain: ami.com, ip: 40.107.93.59, mailfrom: igork@ami.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CYkiGpK+mgeOoRmAxagfXW5++EkfXSGHNuc/FaUUHZ3cVEqjmk26Xf0c8OWoOYUasKumBp//+4y3Lp3CwbrR403u5Nopee3Nd5UrIeHGfbpGA1VyINecNR3lXtpdiuA9sfqpKbMBsTH/xsGrop/ZYqwzM2WllBjIrLBe/BsgqyzoK6BEf58I1E5iw/T741PuORmXaDbGOKGQRnfz4fft7tlgqKVzmVD9xoBeXtM42qKS/MY0WnnKn5+v5Gr/tN63ImMebBvvqNiJcrTA11jyuoatHRdUyTtxGREWgz/lejzW/IdPx+BmXYuKshHILqQs7YqCdp6R7GaQwVHo3S60KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=28x3CO9QYbYDw520QoyOpM7/+OXBKc6RZhjAweLmqis=; b=Mt53rQiS8Q2ZzU/uKEAgkr/mF76KXDzM/bHw1tSScJyQoiuGMXGjl0yc0s1RBD4cuKSlUyyKNSuaXzbMl/fZbIMDnxS7k//0qJAwmP8u814teAMAU2R+uXBnh+QahPuqoF15rS3o25v19ne0wFrHneH2LSh775jRfMAqlMoptFnQDzc8/NyE14Vwdroj3mpngnEH8e5BMhZb78VkBtMeuXlF1auOXdX/xxMk97vKVvtP49XamFIh8Otc0yyRTiuxZDNP4PPNrHckUdNukSmUGDI10lO5unBL3wcjfafPtDBotkKUNR965ZZDWOeYtEQQfEDqX+bZLGjl23KdNPRfdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ami.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=28x3CO9QYbYDw520QoyOpM7/+OXBKc6RZhjAweLmqis=; b=LjzgP96wQLrUceDyfV+aRX1W+IzIlejptB48JuJeSmhXx0D4y4xm8/ZZIq8MbdmuluI7ZwpigD9HPayAMnpcppCFOscSmW2yQNXSKLp7L57E8DeZLdY02TynEwZhTbcpVL4GJyWoh2g3kRK0GRQ+ttmQCxXMgjCC1S7Jomw14po= Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by SJ0PR10MB4574.namprd10.prod.outlook.com (2603:10b6:a03:2dd::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.16; Thu, 29 Dec 2022 02:41:20 +0000 Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::f1ea:b179:62e1:8cb8]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::f1ea:b179:62e1:8cb8%8]) with mapi id 15.20.5944.016; Thu, 29 Dec 2022 02:41:20 +0000 From: "Igor Kulchytskyy" To: "Chang, Abner" , "devel@edk2.groups.io" Subject: Re: [PATCH 2/3] RedfishPkg/Include: Add Redfish IPMI definitions Thread-Topic: [EXTERNAL] [PATCH 2/3] RedfishPkg/Include: Add Redfish IPMI definitions Thread-Index: AQHZFsreUYXpPiwqnUaB4ud+IYoDFK57tzRggAhsbgCAAAzKQA== Date: Thu, 29 Dec 2022 02:41:20 +0000 Message-ID: References: <20221223123336.2014-1-abner.chang@amd.com> <20221223123336.2014-3-abner.chang@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-12-29T01:55:21Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=b3030d0a-b394-46fe-8c6b-84867ed2cb2e; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ami.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|SJ0PR10MB4574:EE_ x-ms-office365-filtering-correlation-id: b190c751-0b20-4db4-edde-08dae9462b02 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Z3PU5R3kUlnSr5S9qt8715ow7VHiQyMfBLCaU3yrGWwL03gyxK4dGxwxjxfsTLxOzBxnqCueZboy8NQEzfIAh9m4lVFStjfYRO7oDAYs3Ra9KOSMr1em7xTKxiPVkmUBXbclea5e590r1/MX+np9YC2o0e5Gaxq5xhpWaQLQOmmadDzAoLGdrf5MyBTngx8h74BPGS7PZ1sNzlNQyEQRcbISmvC+Rypl6v7tv5NK5ILkKHxJv0vBLSeRN8/CwRUcAero/80M1Jfw+wxtRNHWt+yUuKvDt8gPIkU7iZsisAq1Wyv4onn+TGBi4Gv+miF7S/mdn4KT/2PdVX5NQAmEVbK/+VYIQLsOJFts3GVKRv7SYRmVf+MBR5Yj0VuaY/nEIr9VMMzrCeh50Y8BgQLBQgKrxpaaiAHLbdVfZQUhTBndmGmSw7n+1voOp2qQth9W9juLVAhkI0524MaYl4GhyDeEDi3Z/F3kiXG9SGQ1cL0EYUCwo3hrzLF7kglGGYZxfADaW9fvN1ed5p8m60jqE1Lp4eKdGG54iw7FfMvF7ptP8GPzhKB6PcIrne2hbMXFCtZmtScOXAmWsv5TXtk3DYfwVRBTJ3byW0KlRdv5JZrTSA0GAjT2FzoWYgP++1wB5mXx3YgPo4U5RIolsV8X653Jzver3BR2VGDkXGW68ua20aI8J5SysN29sD+Ga0wt0n6w5taC+GNY5SZjSKGCdA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5185.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39850400004)(396003)(346002)(366004)(451199015)(83380400001)(33656002)(71200400001)(186003)(9686003)(478600001)(7696005)(40140700001)(55016003)(86362001)(26005)(38070700005)(38100700002)(122000001)(5660300002)(41300700001)(64756008)(66476007)(66946007)(53546011)(6506007)(66446008)(76116006)(2906002)(8936002)(8676002)(316002)(52536014)(110136005)(66556008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FpNxBKTVJwmNOdoY3DnmC6ajI9Y/bRvu7N2jKdhP4PM1QmXzvCT2gQjbesUS?= =?us-ascii?Q?Nltu3OTXhOdn1VC5NWAfIx83DoiGN3ftrtM3QiXQbGFacYp4pxFuFz2+KaOZ?= =?us-ascii?Q?3mXrcY1WPLHOGj3Vrt3EiJhYGiHhhhOtUKX6sx7btoOCYhgei/RAQfDwJ4TL?= =?us-ascii?Q?hdo13w0YE6flpLp3ZW8mvCeyjS6kg2eJE/xRM8JvrSLKi34Z9B+nivWOpK2B?= =?us-ascii?Q?29y0K8tYPiUMKLhMCIRQ+sqUjBH/WPzf6PqECLf6/++zeo8d9WIiCLln/0Cj?= =?us-ascii?Q?tb7B6p5kXf4psS30pFYzX6KZ+VdWmfEAXVpHDZT00GXD5oQFYWVkhWNGYWHh?= =?us-ascii?Q?wQnjfdwbQzxX9Zgcx3O7R3yYHOWT5piTTbpGQF2Ve3+PDp/9qXxh0W/fUx9y?= =?us-ascii?Q?dsQv7lYtjrEE+trKNSu+9dh6dROio1Qp7NBeGZnzigRCgX+KuaRbwsmh4ZVV?= =?us-ascii?Q?kK7/Y/QyK4zmeit4RcXoyeJbZX3GA22WQ03x8CZM3rCv7Tn27u9zyCJ0C0mJ?= =?us-ascii?Q?PuNmz0ohp+hn53zlI67gL0/heUWTjgFW7DyW3bSrS1299ZcPsA3hYfLN/Iz1?= =?us-ascii?Q?oIkP7NFNFS2QaWkr6+neV/JD3iie+Iigsb/X4YjPlVlnFjhgOwE3NCrEDM3v?= =?us-ascii?Q?yse8sleb+19v1JRrsW/CaJH8KgWWbEAS2yz1kQjIz1URkIsqtwxJSVAiQiCk?= =?us-ascii?Q?aorh71FD3PlfJoNI/i8Qor6vTa2S5u5db6HmgEKB7h1T5s6VvTawCCSxGBz/?= =?us-ascii?Q?v1cPGa7rB4cfu11VwwBKuGNfyCOIsGTaKvHc6yOEZHJi5RGRzBppURz/CfCe?= =?us-ascii?Q?WM9UdEs4HYltLYl9ntwXZ+4ScT8Ae9fgvvKaw82NRfcBZzQcaYbQJTr5p5nm?= =?us-ascii?Q?/GNCpUEHjDAH91W8RH/rA1NqLGuG7LoV0BGNGH4GrUy0DnvsorQRzv3sSyH8?= =?us-ascii?Q?p04mv8PRIrxUvXpq3A/VFgJf3PNmEZb+pe0kQP/Wq3rQ8U0mvPluqSGKxTp8?= =?us-ascii?Q?ZNqLtfZyEnE4SL8vSsbTHYKGWPQxzaNLvqUU0YGnFekmZ4SoKkY4sCFFIyV+?= =?us-ascii?Q?+kF9nOo8tFMl942KroZ9JPsKfP05thO51FYa2dfUndlmz5pBpAh8BFH98x7L?= =?us-ascii?Q?5nTAqvHEfV4exPwy2iH0tUsmdAM4rweQFEJ+D2IJ0DQzysjlFzKyJuqwf9OP?= =?us-ascii?Q?xppkCcqWbF0nhSPl/2KAnK+FVuVTV4zLwGxICuz6P85DdG73b7lEcy9BQhtn?= =?us-ascii?Q?QXfJPWLurB63KDnq+zy8qz7cigb3BS8tL0/Tp3ko3uVGl7YTZChsifMopznm?= =?us-ascii?Q?kJl33hYu/dDngyN90AfH13S67VzRxj/5i59vQQ/xfA8Nku80zTRgQQuXImfZ?= =?us-ascii?Q?2k/ao+ddzJnDx2roIbqe6YWWj23/p2NL3PmflVVRA1zZaV6rrDyojk/goBEC?= =?us-ascii?Q?JtUjh09dEyInoar7MQSxjmPQ6VROpnM5qJQvCu9YzRsXnA4Ori3I/9vP2Fkx?= =?us-ascii?Q?MEEKkcESlSQcerxQmcbVMpYpYukmPuki+Q04AfjmHuEdkUGXY5ZdAs3SYBf1?= =?us-ascii?Q?06aZSfjQhH6U6lt5QpA=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b190c751-0b20-4db4-edde-08dae9462b02 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2022 02:41:20.4628 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: u6hQBLNwXYptH2odtDpgQY07YOOfScaqRJxN+ectoWbkwMpKTaipSSA6RqEvfUi6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4574 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Got it, thanks! -----Original Message----- From: Chang, Abner Sent: Wednesday, December 28, 2022 8:55 PM To: Igor Kulchytskyy ; devel@edk2.groups.io Subject: RE: [EXTERNAL] [PATCH 2/3] RedfishPkg/Include: Add Redfish IPMI de= finitions [AMD Official Use Only - General] I forgot to address these comments on V2. The V3 just sent for this. Thanks Abner > -----Original Message----- > From: Igor Kulchytskyy > Sent: Saturday, December 24, 2022 1:20 AM > To: Chang, Abner ; devel@edk2.groups.io > Subject: RE: [EXTERNAL] [PATCH 2/3] RedfishPkg/Include: Add Redfish > IPMI definitions > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Hi Abner, > Please see my comments in the text below. > Thank you, > Igor > > -----Original Message----- > From: abner.chang@amd.com > Sent: Friday, December 23, 2022 7:34 AM > To: devel@edk2.groups.io > Cc: Abner Chang ; Igor Kulchytskyy > > Subject: [EXTERNAL] [PATCH 2/3] RedfishPkg/Include: Add Redfish IPMI > definitions > > > **CAUTION: The e-mail below is from an external source. Please > exercise caution before opening attachments, clicking links, or > following guidance.** > > From: Abner Chang > > Add the definitions of Redfish Host Interface credential bootstrapping > IPMI commands. > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > --- > .../RedfishHostInterfaceIpmi.h | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 > RedfishPkg/Include/IndustryStandard/RedfishHostInterfaceIpmi.h > > diff --git > a/RedfishPkg/Include/IndustryStandard/RedfishHostInterfaceIpmi.h > b/RedfishPkg/Include/IndustryStandard/RedfishHostInterfaceIpmi.h > new file mode 100644 > index 00000000000..892b744c458 > --- /dev/null > +++ b/RedfishPkg/Include/IndustryStandard/RedfishHostInterfaceIpmi.h > @@ -0,0 +1,50 @@ > +/** @file > + Redfish Host Interface IPMI command > + > + Copyright (c) 2022 NVIDIA CORPORATION & AFFILIATES. All rights reserve= d. > + SPDX-License-Identifier: BSD-2-Clause-Patent **/ > + > +#ifndef REDFISH_HOST_INTERFACE_IPMI_H_ #define > +REDFISH_HOST_INTERFACE_IPMI_H_ > + > +#include > +#include > + > +#define REDFISH_IPMI_GROUP_EXTENSION 0x52 > +#define REDFISH_IPMI_GET_BOOTSTRAP_CREDENTIALS_CMD 0x02 > +#define REDFISH_IPMI_BOOTSTRAP_CREDENTIAL_ENABLE 0xA5 > +#define REDFISH_IPMI_BOOTSTRAP_CREDENTIAL_DISABLE 0x00 > +#define REDFISH_IPMI_COMP_CODE_BOOTSTRAP_CREDENTIAL_DISABLED > 0x80 > + > +/// > +/// Per Redfish Host Interface Specification 1.3, The maximum lenght > +of /// username and password is 16 characters long. > +// > Igor: One '/' symbol missed > > +#define USERNAME_MAX_LENGTH 16 > +#define PASSWORD_MAX_LENGTH 16 > +#define USERNAME_MAX_SIZE (USERNAME_MAX_LENGTH + 1) // NULL > terminator > +#define PASSWORD_MAX_SIZE (PASSWORD_MAX_LENGTH + 1) // NULL > terminator > + > +#pragma pack(1) > + > +/// > +/// The definition of IPMI command to get bootstrap account > +credentials /// typedef struct { typedef struct { > Igor: Duplication of typedef > > + UINT8 GroupExtensionId; > + UINT8 DisableBootstrapControl; > +} IPMI_BOOTSTRAP_CREDENTIALS_COMMAND_DATA; > + > +/// > +/// The response data of getting bootstrap credential /// typedef > Igor: Duplication of typedef > > +typedef struct { > + UINT8 CompletionCode; > + UINT8 GroupExtensionId; > + CHAR8 Username[USERNAME_MAX_LENGTH]; > + CHAR8 Password[PASSWORD_MAX_LENGTH]; > +} IPMI_BOOTSTRAP_CREDENTIALS_RESULT_RESPONSE; > + > +#pragma pack() > + > +#endif > -- > 2.37.1.windows.1 > > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is > intended to be read only by the individual or entity to whom it is > addressed or by their designee. If the reader of this message is not > the intended recipient, you are on notice that any distribution of > this message, in any form, is strictly prohibited. Please promptly > notify the sender by reply e-mail or by telephone at 770-246-8600, and > then delete or destroy all copies of the transmission. -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= .