From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.60]) by mx.groups.io with SMTP id smtpd.web11.183879.1672241574787799511 for ; Wed, 28 Dec 2022 07:32:55 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ami.com header.s=selector1 header.b=CL4B96fT; spf=pass (domain: ami.com, ip: 40.107.92.60, mailfrom: igork@ami.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OFMumZRPOJgQXH4z70vwKZcXUHVOa7iCbZmbpDg+pygAoG3gUKpoDfSjx4y1mR3AkjjVfvvcRYo/q5ztriANj+TJ3XV88MnOxxLcYwhDkoYxJtl08EKQ+CrGpef/qHY3aaQw9tSyMOXp0RdPGrXd9io5LNVNZCI7bxkTC4EvHqVBD2VanA2cfemUif2YLSbvPRqeDqdS89Z9UAnvhUQVr+FUmCblKmTKL6QwvD9XLZ8ngHpU56D97YrAZqyLhOC1/GUbrwum50bXZShjSnajnA2QKmu1H0fK7gG/dB7YZZoIztpLrLuHZyWXF50ORcqm2r+AG2l8RfpxKXEcubrhtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pXh+BgsBYWPSCT40nYFWKHqqNOi4H1VKOXW6bYmN4/0=; b=meCD4vebuo0VcNNXFVpVxDtYVRojSxaEi7afdDN2DzIvi54KeZrO1mmANldhisD08qERkAgO1IteH7s909zK7ydCGSMhB4sfr6Fmc1ivgSzMEReMQEt+auN2tLori2fPdyM5Ms+7DEIaTdXmqyycPO07b4ZIzx3VnWR+vlXM8nXTPdhgdZdrRcqjfck8LUBOYG+KqYkMwRvU27D3TyqB48mgTAM2bvAy6YP4gK+upHwVPG+xmnCM7N+1as4lQkJBMlkbilyqfHNgZkJoC65xrOJ1JTKKBjuZbEaWZq+N+vBcH4HA9ExOs1+5NEdBggY9XTBv/QS+LeH7jcv58NzMzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ami.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pXh+BgsBYWPSCT40nYFWKHqqNOi4H1VKOXW6bYmN4/0=; b=CL4B96fTXAzIl+QRvUU1MTD1F/fOqhI2Bc9xSZeSOz52vH7IE6aAdtuCeGLKiGsRYS4Q+FTNBeFTOBr7MN5ORlm1iBxE3ydodTMESE0k9o5hVrOEY2ZHfTu+dh4NjWr24zuwM4/eG/Mj5Xy1EUFwRP3f77ml7/hVlYNg8pUMkpM= Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by IA0PR10MB7133.namprd10.prod.outlook.com (2603:10b6:208:400::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.16; Wed, 28 Dec 2022 15:32:50 +0000 Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::f1ea:b179:62e1:8cb8]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::f1ea:b179:62e1:8cb8%8]) with mapi id 15.20.5944.016; Wed, 28 Dec 2022 15:32:50 +0000 From: "Igor Kulchytskyy" To: Nickle Wang , "abner.chang@amd.com" , "devel@edk2.groups.io" Subject: Re: [PATCH V2 3/3] RedfishPkg/Include: Redfish USB Interface V2 update Thread-Topic: [EXTERNAL] RE: [PATCH V2 3/3] RedfishPkg/Include: Redfish USB Interface V2 update Thread-Index: AQHZGoWar/yJ7eV1qE6GphH/0xo2Sa6DbhcA Date: Wed, 28 Dec 2022 15:32:50 +0000 Message-ID: References: <20221228051336.1769-1-abner.chang@amd.com> <20221228051336.1769-4-abner.chang@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ami.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|IA0PR10MB7133:EE_ x-ms-office365-filtering-correlation-id: 19aee5b2-f879-44eb-bef8-08dae8e8c759 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9cxby0i4Au6EAcp5z9l6zMRJFDIDepJ1MHKtmHm5drEmVk0kDnVQmuPmqMVQt88asV+ebtxKQb5q85bfP9w1LrJlTBo2Nct7PJSXWtAd5DIMJvYu4cf7f/13sMfI37H32/lA21/aLDQzfjGZ7uJtdEW/jh1c5taU965D5yca2AHPwUCPbmau+IB/jbdhPlMR9jHicvqpRXped8WI1YH0L6JqiiJEwQGrJLBFG+cs5OmFlprXQmLxu3sEm2FV1wHlzhzHXAmsYNen0HQOM3MrVRjHCcg7Z3OsF+NHqASjb35iSzOxddTgLeoXqfrXjZqvXRXXEqWfIj29UAXuCiiGD+4fL5dmPKU/qugn8rwRR5BC3FRfsyn9rHjx83XyRdFHjoVrUfdBNOLko6mlbI3Sfc+WDYhXCrnlN+av7autj20MFS6LwqKA7KEz/7xE7IaoSjKZ9Jkpk5cmt6aCxTUYwKM4zh6Y/qPr/xz53BPDZ0uu4mbumjhtHcqHTO8T/RVEcWJs/LaVzMVW6LLOCD7L3KT7Qzcm99X4FDKKj8VU3ibg8Gdb5n01KTwwtloU7j9BufXaL2PQtlLqahhMyNFAFh5K2VIAdNyQ/JlY3nK4kyM4GkErn7LXuyQ+WiXj+bOh9TRW3ajvZm1wq1/OMsupvrptOH4YDSX0RmYtqh4NZ2bSTSS9Jrg970RWItyfT76wotooYBPdDrlpnJlO2i9C/w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5185.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39850400004)(396003)(346002)(366004)(376002)(451199015)(40140700001)(33656002)(52536014)(2906002)(122000001)(8936002)(41300700001)(5660300002)(15650500001)(38100700002)(38070700005)(86362001)(83380400001)(316002)(71200400001)(64756008)(8676002)(66556008)(66476007)(66946007)(110136005)(66446008)(7696005)(478600001)(6506007)(55016003)(76116006)(9686003)(186003)(26005)(53546011);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ait1Q/GOV+96vvc3M/3Ms2lszGD5cfChCDX6yWyVW659gntZgMwWdEVnNer0?= =?us-ascii?Q?dKaQY75tD7rL30AnJ78mSiqJfQvFmf3b6iYzjfREHxA6MtojZAe987VCZeY3?= =?us-ascii?Q?ETlku+NaTOiPPhTM1jMZvHmOZH7b9Hj2ydFlltfsRqAO8Tax7s7ryL+tqu50?= =?us-ascii?Q?Rn1jFTBDH73yvKr+4B477Qx1eOelvQEWN5xCaGbhsxQ7RvpgtPQJJLINWFN3?= =?us-ascii?Q?k7r+dgqpqPL9W1QhV6sNVfoTnx6JVzS1i59U89ukW99Swjh3nFxS8Jwu30yw?= =?us-ascii?Q?EqVInbDsln7Upah8OFE1rP0/of5yLWPIPHn9VI43jo9OoIac3jF1+rlPtb30?= =?us-ascii?Q?MM0q/gXN7x+YamfdVWFaDL7LVKYzAX3e33Kj024Isi5Knru9lmpa4qaizccl?= =?us-ascii?Q?Qt4NtYDWcUd1oKBkKd3MJz2QNB9gOtX4xKnYhp5/sHzD7Ma5Q55TR7BZLo2O?= =?us-ascii?Q?+Q3FhgAtE610GlO1UFPf++G5AcboMiWWGB8bhpycydk7xohk1vXjCyimBRjI?= =?us-ascii?Q?yg7NgjiyAQZQzaQjbK/LKObHzPJq1Bj88VD1CfdBwv1F0p/zKp3PAHA/nGY3?= =?us-ascii?Q?9c/XWuhW0uXDpHlJGKebF8hcjm5m7rcLRTqx1c5ZY+EpMQdHoFgMcz+U30ai?= =?us-ascii?Q?mJHYm/gNXF4sH8fy58GTcQKri2MyTJb5OgtGZmZN0CSiDV01cfd4RoXfb0vX?= =?us-ascii?Q?qt4zylvuQaveVavhv/jizjU8rZvyFQHLoNrXIqe+WeDevVqRnvRS/hE4brxO?= =?us-ascii?Q?k48CLdqpHuTqe/LmFaAIUGes9bKu95cdJVlzhPT/PG3Od2faTejMy2U5iE7Y?= =?us-ascii?Q?41qdpPRiD4DnCu7UPv8cynmp4DUyXmdEDhRkmM2ebsl0twxtgpF01VTZqC/i?= =?us-ascii?Q?o3QEadRyK/viMO4IUV8eEItzDt8XAueowAAei5F9PDNa2PnxFTZXoTyRBwUb?= =?us-ascii?Q?F4ECs7RLMh3p4GylvOVvSQvfA40+d7SaTA9t80vYAcPB5EhY/A8WfLYBm9RP?= =?us-ascii?Q?ICR3I8t8TRaaUAGcapLP0wtLnGjUNoankrybyjnuyEnwVe1JLs34p/dC2yMp?= =?us-ascii?Q?Zv4g4GVTZvsLYocipTA917VOMmjxhVm+qLj0TXx131jtQR1CH9KJ/JjtU3UZ?= =?us-ascii?Q?ID/RGLMFHEUrpxACvuLgBv+9zyX1lGZBDkC7dKMlgAuBM6WYSzr35+eUD3rm?= =?us-ascii?Q?S7z/dJkWHt483436z9OY6suEqlhESXSJVLBbArMRgi0CI8clJoXoClhnTjr1?= =?us-ascii?Q?LdG6fjR8wlSNWH8NdsW7a3Gnw4yw0zwfEzAC2vyRv09uh4I5heAFgMG3CzkE?= =?us-ascii?Q?lBoUxlADmOFixBa17H4MMkwkRYLVyfVkYj6UZYBeKiyflzl+U86Wa1Oj4Juj?= =?us-ascii?Q?0rgsyBRzhmasPUGPjyLt1LUZ8JiBfn/yssoBVh9M5N0j7eXRcWiDEm98LRjb?= =?us-ascii?Q?c9DOGhssSMRYc0at8vrHPQ3Ap6i1J13zh9Iv8FI7J0unNZF5DLyyhQ4p8r6S?= =?us-ascii?Q?2tW+qO3HQmc9xYrQNXbiN8wT2gNgLRKNEID1Zs3Obk8yNhMs+hN/fFPpbzJj?= =?us-ascii?Q?uDkDDlHTSTxdCMMmiQ0=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19aee5b2-f879-44eb-bef8-08dae8e8c759 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Dec 2022 15:32:50.0482 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OpnWnYAATXZTrH848vXqmrHpkZLAxLkU3JBTQsP9r0vdPfClxGC+QE6e3kIZtOyC X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB7133 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Igor Kulchytskyy -----Original Message----- From: Nickle Wang Sent: Wednesday, December 28, 2022 1:28 AM To: abner.chang@amd.com; devel@edk2.groups.io Cc: Igor Kulchytskyy Subject: [EXTERNAL] RE: [PATCH V2 3/3] RedfishPkg/Include: Redfish USB Inte= rface V2 update **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** Reviewed-by: Nickle Wang Regards, Nickle -----Original Message----- From: abner.chang@amd.com Sent: Wednesday, December 28, 2022 1:14 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [PATCH V2 3/3] RedfishPkg/Include: Redfish USB Interface V2 update External email: Use caution opening links or attachments From: Abner Chang Support USB_INTERFACE_DEVICE_DESCRIPTOR_V2 which is updated in Redfish Host= Interface spec v1.3. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../IndustryStandard/RedfishHostInterface.h | 25 ++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h b/R= edfishPkg/Include/IndustryStandard/RedfishHostInterface.h index 49b3ceee39c..022bd1f36ef 100644 --- a/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h +++ b/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h @@ -3,6 +3,7 @@ Copyright (c) 2019, Intel Corporation. All rights reserved.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (C) 2022 Advanced Micro Devices, Inc. All rights + reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -29,6 +30,18 @@ #define REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_IP4 0x01 #define REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_IP6 0x02 +/// +/// Definitions for IP assignment tyeps. +/// +typedef enum { + RedfishHostIpAssignmentUnknown, + RedfishHostIpAssignmentStatic, + RedfishHostIpAssignmentDhcp, + RedfishHostIpAssignmentAutoConfigure, + RedfishHostIpAssignmentHostSelected, + RedfishHostIpAssignmentReserved +} REDFISH_HOST_IP_ASSIGNMENT; + #pragma pack(1) /// /// Structure definitions of Host Interface device type 04h (USB Network I= nterface V2) @@ -40,12 +53,18 @@ typedef struct { ///< idVendor field of the USB = descriptor. UINT16 IdProduct; ///< The Product ID of the devi= ce, as read from the ///< idProduct field of the USB= descriptor. - UINT8 SecialNumberStr; ///< The string number for the = Serial Number of the + UINT8 SerialNumberStr; ///< The string number for the = Serial Number of the ///< device. The string data is= read from the ///< iSerialNumber.bDescriptorT= ype field of the USB ///< descriptor, and is convert= ed from Unicode to ASCII ///< and is NULL terminated. UINT8 MacAddress[6]; ///< The MAC address of the PCI= /PCIe network device. + + /// + /// Below is defined in Redfish Host Interface spec v1.3 /// + UINT16 Characteristics; ///< Additional device characte= ristics. + UINT16 CredentialBootstrappingHandle; ///< Credential bootstrapping h= andle. } USB_INTERFACE_DEVICE_DESCRIPTOR_V2; // @@ -74,6 +93,10 @@ typedef struct { /// /// Define union for the Host Interface Device Descriptor /// +#define USB_INTERFACE_DEVICE_DESCRIPTOR_V2_SIZE_1_3 0x11 ///< Leng= th USB interface device v2 defined in + ///< Redf= ish host interface spec v1.3 +#define USB_INTERFACE_DEVICE_DESCRIPTOR_V2_SIZE_1_2 0x0d ///< Leng= th USB interface device v2 defined in + ///< +Redfish host interface spec v1.2 typedef union { USB_INTERFACE_DEVICE_DESCRIPTOR_V2 UsbDeviceV2; ///< Devi= ce type USB V2 device discriptor. PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2 PciPcieDeviceV2; ///< Devi= ce type PCI/PCIe V2 device discriptor. -- 2.37.1.windows.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= .