From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (NAM04-MW2-obe.outbound.protection.outlook.com [40.107.101.82]) by mx.groups.io with SMTP id smtpd.web12.2389.1660188438758562913 for ; Wed, 10 Aug 2022 20:27:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ami.com header.s=selector1 header.b=e81F1cq+; spf=pass (domain: ami.com, ip: 40.107.101.82, mailfrom: igork@ami.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AIHEaInizb32hMY6Bj4sZrQGyhdX2xPoLuAgXwhGSdVkd5g5HuTtcdUvVoCcBDqRFh8mL7iicJkhrTX5rXlu5yK+FwkU3OE5tEzSUe1aE+NGLy1g66Xf7BEY1OR9DNMENsQShK03k1OIAug87D6wiG2HsLhSZYiDXpFEIEozSgW/KKx+t51kPgg1UqQAKhRLequEPEcRik8oGgf10u6ILvYO54LOtK3iIm/kEbFTUluVotmCkRog1lTxyLM97KSgxs+xLPuD7IoNZ3mtcQDYc2BVxwI0lPwfzb/W0SiOO030PThN148RH3bSrZxCB8WQinI7tiCMa6V9xB5VlFirjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=slSLpbqsHgPYnKy7e/t1po5mUaGW+Ofx5Cg/3oYi2Hg=; b=DVPHGFNQ45FwrWZlOElSpPUr14XVABqTjqotdDx8TSrg8Il/eYg28frTAiIVbfApf3ZADEulmRW/n64kg0sHE5vM4oMOgu4pxk5uSnssNTdzJQ0EfSlQGHAtkii15yWIB4kOXUof5D8v8H9b1pbDBbUcc4YM/oBXeYTLR3LO3cVC3pFZ8M+xicS8VP0nN01sWYpCSiiLj7RmT9QsyahYSNWfiFtsbg1Ta1Sk+YT6TGz0wEV9IF/PgfrnxOaxoAwAXJpAxTPUEE0DOx1si36KjsRJi3vMpmlNGf63nBsUZj35q+56e/JVWvqqQYsMpumwuHUcRUpiRxh32IZY0vNTmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ami.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=slSLpbqsHgPYnKy7e/t1po5mUaGW+Ofx5Cg/3oYi2Hg=; b=e81F1cq+L9cLqbzxC4pQuSo3T6qT9HFx6FYsTVKAoGnf08/5t9avl3plsn7f2aC19s8F15NEO6k1cEcYga2DbI2mxwKlL5lwfO/BsiQlXrsN+kss7S2QUa3j6Jhl18T7u2cZ2ftmNjIuGSVfS03QqhsCdH6h2pOrTzVaGT6ieu4= Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by CH0PR10MB5244.namprd10.prod.outlook.com (2603:10b6:610:d9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.10; Thu, 11 Aug 2022 03:27:16 +0000 Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::3007:4429:73e9:503e]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::3007:4429:73e9:503e%3]) with mapi id 15.20.5525.011; Thu, 11 Aug 2022 03:27:16 +0000 From: "Igor Kulchytskyy" To: "Chang, Abner" , "devel@edk2.groups.io" CC: "nickle.wang@hpe.com" Subject: Re: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported Thread-Topic: [EXTERNAL] RE: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported Thread-Index: AQHYqljLKVm7X4buzUSN71MsFikpzK2mL5pggAC4fKCAAFu9eYABmY9AgAAxpCA= Date: Thu, 11 Aug 2022 03:27:16 +0000 Message-ID: References: <1659875125-9504-1-git-send-email-igork@ami.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-08-11T00:32:48Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=816bbdc3-1f7c-4c19-b57d-48f3d5371476; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ami.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bc0d4474-abf6-417e-7ba4-08da7b49641a x-ms-traffictypediagnostic: CH0PR10MB5244:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LiMKoTLRxgNW9hay2eGHCPHzB1GqQmucjYKKj0t/tFhuB9DBShLNBQRzBfm3SOR6x12lelrMGWBc/qyKg3CKO7QG+CULeJfcdV1APTfQqiA8k8SjWddYJpJby/6Q0hOQvLdgkNjzhBPngveNGSC9O5TBMfRRAB3U5ZmL99HHwWyXJ2SXpyHtaC+ueN+NLa5yS7Bq57Dz0QRC/4syghJoQ2E7zZRYErfaefZwPWG20ehP6lFcEhb7+0XQlWerMulf7hUpiETYqXi0hACpV7EtTRBxm6Z2oYi8PiABLl1k88Lap6DWmONGUZx2cnK/nx3iUs8O73BXhVGg1HrbwAFF5+a+HMP0mdlKo1d54zWhy9VID81Bsu+WBpx8UMIy/HSNIKUfmLuPFq8H6wbLJifGmq6wydrsWIPvtu8gkD2c1DLf1is1/RBCEdiR9uk7qJKkJoa7UHpAfSdy2e5Y0nuQSM05W4k2TplQglOSX0mk2hh7tmWMpDNz3cx52nPizQRgw9GPj0GUeaG/hfOzDBnSOZasKMjioO4Te9TNs0KSJWgZv6nw2T/i0NABSjvZeZfTUz2geNrda+UYLncku6EloCe7cCV6wHddh7hSi5BGmBs7em64HCZlezV2EoShuykqcNMKqllDeOdHqaDCK70+YEBZ1sba+5yOE0/fzkqpAdxu/6ReIwnEYgs0+8dBnpG6+3tZzwZKgd2LBL+MEiuAyU8MCNbwgWS7+JMPnRuSSIdAPBEa2MgSiqfmT7pFhuimoF8XPOupdx4JX7KMRt2gfIy4dE0+taYdOgg0fWWThpsizHyRFOnQ0ZJQPiIjq4fzbI6j6YqFP+U3rWzHyFStTA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5185.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(39850400004)(366004)(136003)(396003)(376002)(71200400001)(45080400002)(478600001)(41300700001)(40140700001)(86362001)(9686003)(33656002)(26005)(7696005)(53546011)(186003)(38070700005)(110136005)(6506007)(55016003)(66446008)(52536014)(316002)(83380400001)(76116006)(66946007)(66476007)(8936002)(66556008)(64756008)(4326008)(8676002)(166002)(5660300002)(122000001)(9326002)(38100700002)(2906002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SvaOKg8IBtj1pYAr64+K85VXhZM1IDYXx8skIOvCw8g3n+9tg54jYrYs8sDm?= =?us-ascii?Q?3qrQTVN+ynD1irTd/a6HhoT61Tvw6iCCPH9fUnOKubLyM8Vs7TWF5S/he1w5?= =?us-ascii?Q?5jEacEfVt0GlCpyvz8RfxNMO98hwbqVJjoI157mkAifo+tasa0VJFk4ZGPgB?= =?us-ascii?Q?P9pHzyTcKNWjIBCmjIj8zeS9jFQToVNTjQsa7gBCEv1Ia1RDhHovI1oEBwu+?= =?us-ascii?Q?7RTrIAxbB/B9eKUaq4mjU1qmigUs06y0bR9bbpGHBXWsjg2K8wqJiqx57H3I?= =?us-ascii?Q?3VMvFMHxoL7riQfSQJI+SKldDqJRqzeDltjTIh7pPJnJ9tPSuSCba+twMARd?= =?us-ascii?Q?o29mGfddzYGwzLK6oXO/cRcmxNi3dDSsQLU7OLmKD0z7aUDX7cH50S1U/GdJ?= =?us-ascii?Q?DYG+9rww3bUJH9B6rUrMawMWWtb2xNVgqjY03KSNODTSF2zAER+O/o4fnBCs?= =?us-ascii?Q?J35qSynfil39mrPY+91fWdq1+fYnA5lJ4wPlogcm00Rh2oQg3b4NOry/cAre?= =?us-ascii?Q?R3AkhkQRHu1sfwbdPjp/82lbjxBOSUTtql77FkCgBGqPRgASW5DoGjrMyeWg?= =?us-ascii?Q?7gKhShpGcjJNzM/y0qy87ujbZi9CA6ukgkvcdJNdBNeFmHWFFHDFKqLvUbPk?= =?us-ascii?Q?a529Pwn4Zn8MesON6Ybey5XqvSEef4kJ21FEpPrs2GQzkxRiGsdr1+OqQQ4J?= =?us-ascii?Q?nax65YNaUbn1J3xy5dVSXhGyh4/n94ZvgBt7WehEKmtBakjz4uTZwjOyjKpw?= =?us-ascii?Q?/wA9LbBbl8dffc4T3YTY8/6OR7MpPyZ013iddq5fZHgcq9lRb+chdSldh6dJ?= =?us-ascii?Q?6hJHr10vcjdWdoPX8DMdpDa3JVsppcsAGQFofth1m/YWKsu/jZjcE6TdImTy?= =?us-ascii?Q?+zH5L/nKfSbEm/AwFtC5GXAc4kS3sshEPNPIvPJ2cY7CY+z53bnpSIn1GBfG?= =?us-ascii?Q?s14L0hiJ4sw1F2SNDXjr33CSR2XmFWVlAgGLeZ7FCBEm3uXQ2DDRXsqdRsKp?= =?us-ascii?Q?0iDKzU4tMGFUm76r2Drov/WjjxkoFGG7wbPgBkjfkVt+PHCgEE1Aki0/7fYg?= =?us-ascii?Q?t9m3XmnVwMm1Rxl3MNZPoM8OFvpDlvdBuCGpHOmnrzc03x9KlkcRG2oydW+r?= =?us-ascii?Q?yP7MR5ogeLlZ7J/dm+HGJYRRng/nVIXQ26vyl+5Jd58ZDuSjvVK9X9QK5eW5?= =?us-ascii?Q?GUjSs77iJSp81GE4Zri5vMv+WTmJP5M5T6CfAgRN7KsHR7YjPCX1Ziqj2sS6?= =?us-ascii?Q?XlIvQdnN4WwnXstVU7fJ+ZQHvuGcDq7RY+4OefIrO1neCRsX39J4rA1TmV3x?= =?us-ascii?Q?YmJPpP1WAcE+XCS2v5GGl1/hluMkQysWp+09KZ2V6sJhpt9nXVoTWu5VL12t?= =?us-ascii?Q?NGXN2TgWYiOBRWmwsXn+swhYGfICycfLItHG544WFwoWztdvLHu+6TIeT3sb?= =?us-ascii?Q?CdVr3XfcSi18lgFzthvIAarw8xEKJG5URAbk+RBareGv/vEcVJURRvSPiiGg?= =?us-ascii?Q?Fq2ts9E9XJ489oN93LhywENnKozksKYilPWPY/aAR0l2lXMM/3RAA/jy9SLJ?= =?us-ascii?Q?xBDgZObTIGKwD9Loe+k=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc0d4474-abf6-417e-7ba4-08da7b49641a X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2022 03:27:16.8463 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WOajeGXhIR6QrFiLHjw4ipymCQK4p3pOhk2Cm/h4XvVVmEwx2uVl9wBkmfNXMBNi X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5244 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BLAPR10MB51853A184F43D2702F798E4BA8649BLAPR10MB5185namp_" --_000_BLAPR10MB51853A184F43D2702F798E4BA8649BLAPR10MB5185namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Abner, I had the issues when I tried to check third patch with PatchCheck.py. And I've only fixed them and sent it now. Thank you, Igor From: Chang, Abner Sent: Wednesday, August 10, 2022 8:33 PM To: Igor Kulchytskyy ; devel@edk2.groups.io Cc: nickle.wang@hpe.com Subject: RE: [EXTERNAL] RE: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Red= fish host interface is not supported [AMD Official Use Only - General] Hi Igor, you sent two patches or three? Seems I only got two patches. If you missed the third one, then please resend it with the prefix [PATCH = V2 RESEND]. And please also have the numbered patch such as 1/3, 2/3 and 3= /3, you can have the numbered patch using git format-patch *without* --no-n= umbered assigned. That's fine if you will send the 3rd one separately, I will review these tw= o first. Thanks Abner From: Chang, Abner > Sent: Wednesday, August 10, 2022 8:05 AM To: Igor Kulchytskyy >; devel@edk2.grou= ps.io Cc: nickle.wang@hpe.com Subject: Re: [EXTERNAL] RE: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Red= fish host interface is not supported Yes, please create the new patch set with the prefix [PATCH V2]. Also, use = git move to move Redfish.h to Include\ to keep the commit history, this one= could be the patch 3. Thank you, Abner Get Outlook for Android ________________________________ From: Igor Kulchytskyy > Sent: Wednesday, August 10, 2022 3:21:46 AM To: Chang, Abner >; devel@e= dk2.groups.io > Cc: nickle.wang@hpe.com > Subject: RE: [EXTERNAL] RE: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Red= fish host interface is not supported [CAUTION: External Email] Hi Abner, Thank you for your feedback. I agree with you. What should I do to change it? Should I create a new patch? Thank you, Igor -----Original Message----- From: Chang, Abner > Sent: Tuesday, August 09, 2022 3:35 AM To: Igor Kulchytskyy >; devel@edk2.grou= ps.io Cc: nickle.wang@hpe.com Subject: [EXTERNAL] RE: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish= host interface is not supported **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** [AMD Official Use Only - General] Hi Igor, my feedback is inline. > -----Original Message----- > From: Igor Kulchytskyy > > Sent: Sunday, August 7, 2022 8:26 PM > To: devel@edk2.groups.io > Cc: Chang, Abner >; nickl= e.wang@hpe.com; Igor > Kulchytskyy > > Subject: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host > interface is not supported > > [CAUTION: External Email] > > Host Interface details are discribed by the SMBIOS Type 42 table. > The table is published by the RedfishHostInterfaceDxe driver. > That driver supports PCI-E and USB host interface types. > The table is consumed by the RedfishGetHostInterfaceProtocolData > function in the RedfishDiscoverDxe driver. > That function only supports PCI-E interface. > > > Cc: Abner Chang > > Cc: Nickle Wang > > Signed-off-by: Igor Kulchytskyy > > --- > RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c | 11 > ++++++++-- > - > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git > a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > index d79750b..a3b977f 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > @@ -65,10 +65,15 @@ RedfishGetHostInterfaceProtocolData ( > RecordTmp =3D (UINT8 *)Record + Offset; > > // > - // Check Device Type, only PCI/PCIe Network Interface v2 is supp= orted > now. > + // Check Device Type, PCI/PCIe and USB Network Interface v2 is s= upported. > // > - if (*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) { > - ASSERT (SpecificDataLen =3D=3D sizeof > (PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2) + 1); > + if ((*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) || (*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2)) { > + if (*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2){ > + ASSERT (SpecificDataLen =3D=3D sizeof > (PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2) + 1); > + } > + if (*RecordTmp =3D=3D > + REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2){ [Chang, Abner] We can do if-else here because we only support two types of network device = now. Abner > + ASSERT (SpecificDataLen > sizeof > (REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2) + 1); > + } > *DeviceDescriptor =3D (REDFISH_INTERFACE_DATA *)RecordTmp; > Offset =3D Offset + SpecificDataLen; > RecordTmp =3D (UINT8 *)Record + Offset; > -- > 2.6.1.windows.1 > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is > intended to be read only by the individual or entity to whom it is > addressed or by their designee. If the reader of this message is not > the intended recipient, you are on notice that any distribution of > this message, in any form, is strictly prohibited. Please promptly > notify the sender by reply e-mail or by telephone at 770-246-8600, and th= en delete or destroy all copies of the transmission. -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . --_000_BLAPR10MB51853A184F43D2702F798E4BA8649BLAPR10MB5185namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Abner,

I had the issues when I tried to check third patch w= ith PatchCheck.py.

And I’ve only fixed them and sent it now.=

Thank you,

Igor

 

 

From: Chang, Abner <Abner.Chang@amd.com>= ;
Sent: Wednesday, August 10, 2022 8:33 PM
To: Igor Kulchytskyy <igork@ami.com>; devel@edk2.groups.io
Cc: nickle.wang@hpe.com
Subject: RE: [EXTERNAL] RE: [PATCH] RedfishPkg: RedfishDiscoverDxe: = USB Redfish host interface is not supported

 

[AMD Officia= l Use Only - General]

 

Hi Igor, you sent two patches or three? Seems I only= got two patches.

If you missed the third one, then please resend it w= ith the prefix  [PATCH V2 RESEND].  And please also have the numb= ered patch such as 1/3, 2/3 and 3/3, you can have the numbered patch using = git format-patch *without* --no-numbered assigned.

That’s fine if you will send the 3rd one separately, I will review these two first.

 

Thanks

Abner

 

 

 

From: Chang, Abner <Abner.Chang@amd.com>
Sent: Wednesday, August 10, 2022 8:05 AM
To: Igor Kulchytskyy <igork@ami.= com>; devel@edk2.groups.io
Cc: nickle.wang@hpe.com Subject: Re: [EXTERNAL] RE: [PATCH] RedfishPkg: RedfishDiscoverDxe: = USB Redfish host interface is not supported

 

Yes, please create the new patch set with the prefix [PATCH V2]. Also,= use git move to move Redfish.h to Include\ to keep the commit history, thi= s one could be the patch 3.

 

Thank you,
Abner

From: Igor Kulchytskyy <igork@ami.com>
Sent: Wednesday, August 10, 2022 3:21:46 AM
To: Chang, Abner <Abner.Ch= ang@amd.com>; devel@edk2.groups.io <devel@edk2.groups.io>
Cc: nickle.wang@hpe.com &= lt;nickle.wang@hpe.com>
Subject: RE: [EXTERNAL] RE: [PATCH] RedfishPkg: RedfishDiscoverDxe: = USB Redfish host interface is not supported

 

[CAUTION: External Email]

Hi Abner,
Thank you for your feedback.
I agree with you.
What should I do to change it?
Should I create a new patch?
Thank you,
Igor

-----Original Message-----
From: Chang, Abner <Abner.Chang@a= md.com>
Sent: Tuesday, August 09, 2022 3:35 AM
To: Igor Kulchytskyy <igork@ami.com= >; devel@edk2.groups.io
Cc: nickle.wang@hpe.com
Subject: [EXTERNAL] RE: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish= host interface is not supported


**CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.**
[AMD Official Use Only - General]

Hi Igor, my feedback is inline.

> -----Original Message-----
> From: Igor Kulchytskyy <igork@ami.= com>
> Sent: Sunday, August 7, 2022 8:26 PM
> To: devel@edk2.groups.io > Cc: Chang, Abner <Abner.Chan= g@amd.com>; nickle.wang@hpe.com; Igor
> Kulchytskyy <igork@ami.com>=
> Subject: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host
> interface is not supported
>
> [CAUTION: External Email]
>
> Host Interface details are discribed by the SMBIOS Type 42 table.
> The table is published by the RedfishHostInterfaceDxe driver.
> That driver supports PCI-E and USB host interface types.
> The table is consumed by the RedfishGetHostInterfaceProtocolData
> function in the RedfishDiscoverDxe driver.
> That function only supports PCI-E interface.
>
>
> Cc: Abner Chang <Abner.Chang= @amd.com>
> Cc: Nickle Wang <nickle.wang= @hpe.com>
> Signed-off-by: Igor Kulchytskyy <i= gork@ami.com>
> ---
>  RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c | 11<= br> > ++++++++--
> -
>  1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git
> a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c
> b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c
> index d79750b..a3b977f 100644
> --- a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c
> +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c
> @@ -65,10 +65,15 @@ RedfishGetHostInterfaceProtocolData (
>          RecordTmp &= nbsp;     =3D (UINT8 *)Record + Offset;
>
>          //
> -        // Check Device Type, only= PCI/PCIe Network Interface v2 is supported
> now.
> +        // Check Device Type, PCI/= PCIe and USB Network Interface v2 is supported.
>          //
> -        if (*RecordTmp =3D=3D
> REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) {
> -          ASSERT (Specif= icDataLen =3D=3D sizeof
> (PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2) + 1);
> +        if ((*RecordTmp =3D=3D
> REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) || (*RecordTmp =3D=3D<= br> > REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2)) {
> +          if (*RecordTmp= =3D=3D
> REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2){
> +           &nb= sp;  ASSERT (SpecificDataLen =3D=3D sizeof
> (PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2) + 1);
> +          }
> +          if (*RecordTmp= =3D=3D
> + REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2){
[Chang, Abner]
We can do if-else here because we only support two types of network device = now.
Abner

> +           &nb= sp;  ASSERT (SpecificDataLen > sizeof
> (REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2) + 1);
> +          }
>            *Dev= iceDescriptor =3D (REDFISH_INTERFACE_DATA *)RecordTmp;
>            Offs= et            =3D Of= fset + SpecificDataLen;
>            Reco= rdTmp         =3D (UINT8 *)Record += Offset;
> --
> 2.6.1.windows.1
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is
> intended to be read only by the individual or entity to whom it is
> addressed or by their designee. If the reader of this message is not > the intended recipient, you are on notice that any distribution of
> this message, in any form, is strictly prohibited. Please promptly
> notify the sender by reply e-mail or by telephone at 770-246-8600, and= then delete or destroy all copies of the transmission.
-The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are on notice that any distribution of = this message, in any form, is strictly prohibited. Please promptly notify t= he sender by reply e-mail or by telephone at 770-246-8600, and then delete = or destroy all copies of the transmission.

-The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are on notice that any distribution of = this message, in any form, is strictly prohibited. Please promptly notify t= he sender by reply e-mail or by telephone at 770-246-8600, and then delete = or destroy all copies of the transmission. --_000_BLAPR10MB51853A184F43D2702F798E4BA8649BLAPR10MB5185namp_--