From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.41]) by mx.groups.io with SMTP id smtpd.web11.16066.1660072909770908006 for ; Tue, 09 Aug 2022 12:21:50 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ami.com header.s=selector1 header.b=AX7B17Ln; spf=pass (domain: ami.com, ip: 40.107.236.41, mailfrom: igork@ami.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jm7D2eXRCz3BC9lAlfwcz9nIS/HjCjyZpQt7ksaMVjTSRfTgmYSlsOohNALHIaUZcl2uatRKLNfn7ECSFbIlg0QDy2Jd3KxS2A4is7Dfa2g859MswTFawBTbxRUofWdcjmmGGLsmlBz4btRzCU6IkVzm7G9gm33piT0qYsJjru0BJKsRyJJGwr25F0VEWfyVCFOCz9qCSxzbiksLtr1QphqxOl4CLFMjhMcFP8b7aw/fqdndd9F62WiClYXpCHq+PWVeTJ0qJzxFE1ZYNtHMZIdzrajqzi3FfYm3yzrvKaYBKZTt56uFLcIGllcVYYF1ej1uRvKxO5FfZ9LcjV00jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g67Ig92BsohJCkr6m4RHuRx7v6MRNRE/KWl8KTRCdHU=; b=gqXW3n4GIEjCdkMz18BHQS/YiGA5L8XoJMREzC4dFVr2NAoenTxbtNCIGrBag/KlSt88zSfIZY6i9E/tTJMpNZvCcwkVlcEKMCwID72UhqK/jWVIOO5D0qOpFdkcLytkGENH89FKXUvCvxPGQfeQw7r1k8043hT0ckPcICOnsNWXEVhLfrDhIx0nczawolUcpBI+tJ5ERYF5QKg4Z3MU4jSmkVa4c96DiWF52rqI/7Iee9jUKyxoHAUKtbNoZqHZ1xvxpI4erjWdm/OZ0Lq0P4oIWjMhoshGRMza3lpIv1EcMGiy/9xjq+bBbK6XarCYCkHckVc/eYYFZdP+eXFVHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ami.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g67Ig92BsohJCkr6m4RHuRx7v6MRNRE/KWl8KTRCdHU=; b=AX7B17Ln8K+XOgYiGEcRqpaCjyEVDx4V9pXJVwHCKm7C40bMpFVJsPKGYBqTe8r49Xwun/F4/Nj3TPiViH38hm5HIlj5tGJ8bCmj39e9EzI6bojVCcAcfX2T0Yw14TYwuqsZXHoiWuzjjCvXEZLPf00w4mW8rZ2+fWeFkbKhjL8= Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by SJ0PR10MB4415.namprd10.prod.outlook.com (2603:10b6:a03:2dc::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Tue, 9 Aug 2022 19:21:46 +0000 Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::9da7:b02b:d292:d57c]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::9da7:b02b:d292:d57c%7]) with mapi id 15.20.5504.020; Tue, 9 Aug 2022 19:21:46 +0000 From: "Igor Kulchytskyy" To: "Chang, Abner" , "devel@edk2.groups.io" CC: "nickle.wang@hpe.com" Subject: Re: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported Thread-Topic: [EXTERNAL] RE: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported Thread-Index: AQHYqljLKVm7X4buzUSN71MsFikpzK2mL5pggAC4fKA= Date: Tue, 9 Aug 2022 19:21:46 +0000 Message-ID: References: <1659875125-9504-1-git-send-email-igork@ami.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-08-09T07:34:38Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=f57f22fa-0c6c-4d05-8dc5-6b8f4c3a70a8; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ami.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 50b6d17c-ea27-44da-d4f9-08da7a3c6680 x-ms-traffictypediagnostic: SJ0PR10MB4415:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8I0GZm7D0nzOpltHmk5kML2aii8LG+O6Fs7CyP4zSocs2UuckIfw1ep7BdL12/4lcsZ8UULymJ1lPspRaxUm+/LPQUgO+D130AbK23tee3yCyJsquF4bfozYWKQscNnyHiuFhIk8Y82621Xn+f87Z9VXeHkrtk0cz9y84bO34SQMEDASVSCMWSXl8LvzvlPgncUanaiTVxKxq/X79/yvxUUWEUYQe4tHz2ILCpfifPi7XWmMh3Ui7MsDw4XSv/CFQ7ZYU0GlT5zjnM9hv0aTPDdof046b7RUAbqHvsMyI66KjcyEox+JuZCedElbhEG1H0JqLn6ZIiXj90xzvnH4VmtS8C6r1EblIpwXkX/dGK4enCxRlZ7Qm4YISDW9VEuTHQxTqvezvsE8cZWbJvSho/6bY111bWWdUrrFCwP/Bvqq+j5hZIsSjquXr3gylxWKS+p42m+o1x2lVecdcWUmHvp7UfBDfJ1F9cEjIXwwenqrhTGo1x59QWybp7BvPO1TgE+XlJNm1MDpoJ0b+3FEs6eNFffjW4jVl1l89xJOQbuZiiZ1U1wEeFdwpbyOBcG26APVqpFrrFudEBfwgV7ekYk3EhrQrbMEqYQwCrPuDqOxDI2hdNLk+fjzLasGiiAY0IoC0ogR28m1rHfdRmAoRRTQzyByv9ugfBmhWO0D7LLZv7asXFN4thjrnziVWurhGknZrvmtC74nIV5noMDbZGAWd6Itz8VsojCW+srHLexg0eHrvY0N6/byi2QgvxuTQJDwWZ4ir/UeqaGeuIe3LPGlUncfcChVBBMa5P5V7VAWXeHzskPUNyl4bHZJHN7R x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5185.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(396003)(346002)(366004)(39850400004)(66476007)(64756008)(8936002)(66946007)(66446008)(86362001)(52536014)(8676002)(40140700001)(66556008)(4326008)(33656002)(76116006)(5660300002)(38070700005)(71200400001)(186003)(478600001)(55016003)(110136005)(41300700001)(316002)(38100700002)(83380400001)(9686003)(2906002)(26005)(7696005)(122000001)(53546011)(6506007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VyVrlq6sqe5GwM7UR8D/X/eVkX7+dMDxaPeGe8/6yR0v/jitP2FBN0pZIN+r?= =?us-ascii?Q?tWxsoU9qrWzBqFOQtDfLQScfw4mMKf5Nkb0n1TPCy11Rp1z16GQKRMahOUhJ?= =?us-ascii?Q?34r+hiMm3JPrxfqiF+zGGOF54zr8q38jQwBi1tESs6NpUk5a9YAGizi2fodX?= =?us-ascii?Q?uQqNGCmenDSZi6iKqKb1GN4G2JhIpPAUFi3Vh91Z6wCjccwkdRoAas1/7E3S?= =?us-ascii?Q?ichPD/TwmiBM6szjlBM9PBqT1JFgeWhgEwo5gGIIvWcSF7FeORkeA/9MQGVk?= =?us-ascii?Q?J2SZmekUgOXEqhE+8r+umMYpROEwrK7MtdavaqN18cjOm41SL3cMezliHNS8?= =?us-ascii?Q?dP3VaPgpNxHxlBF4AIl5B4zTYSS2G4O6+zl53ctxwcrGdzAhk38nFTtHLRqc?= =?us-ascii?Q?LKCw0ZZJ/jcJ+I/lY+0u8M0ch0khOQ7Ujlwt1whfvFgJfGY2a/4OKx1cgOKJ?= =?us-ascii?Q?HF3hGC5hVlY0ShXs1GROx5LP5+9dXZOPW4RtXqPOttyzT0QHcc6VlFXjTv1F?= =?us-ascii?Q?tavwWmJLtdV2ss/02mkm6HmV2xOW2vH4vGUfWeE2dSzIHgX+g8QSsQwHfkfz?= =?us-ascii?Q?+OWhq5uVHmZiCtrO819qhoHYEvZ9T9NlLZK9j0BlaXdw7LUfFCISuq8kQRZf?= =?us-ascii?Q?sa2Dw7iJZRkVLOnPScHgzLgS/34n26cxKu5u/38nzUwFFLLtdEnaceDYF/uQ?= =?us-ascii?Q?jaIRmcTHUSZtnGFuM8w2aUU+ZL+RggxnQEvJz/XgV67kqNximSvgPZk3aMex?= =?us-ascii?Q?n3GN1vsSJ2e+o9TOLshqkx2aoTrXH5h0V07Ed+o6eVd6XyvnKkHknyIPsAoY?= =?us-ascii?Q?dzT2LHz7Bg0lzC1+z97st42GJRsk87S3i8a/6IsDE5EHJC9493FAILV9xcFs?= =?us-ascii?Q?H4JcDeZZCwHc4WxgmWERnmsQhM+j50fs6EF4qVlPYVhuLfM6AOL5VJXbET87?= =?us-ascii?Q?q639koapNnrqhPzIc+D3wfOLb6DS+yA/xbVlO8/kjLx1M/raPKg3hcVWw9cE?= =?us-ascii?Q?DEGee9F1zyrlIjXChz723kcfA0z7mMmVYPr2C2gYjRXHjtD9fWGwiceZmffp?= =?us-ascii?Q?R38POWIWmTmsCvJE1ML50EaHpdqA+W2pSgZCyLTrExYqthIRHDBgjJJJihE1?= =?us-ascii?Q?6pD+PjPL3TU5YS+NAU6aj0ThDvotiQIjqMg4coVR0OXQgK7LgGM6ZSsfZ6b5?= =?us-ascii?Q?wVwQz9Bcpt6IEbL0N7boLb5f4ljnsVYJURcCb/pyKmIA+7SkUGJXfuGbjp6E?= =?us-ascii?Q?VKbtiPXFJkI5LdILjuJe/aGOm+dXI7XD5/GDPXZSFqHl2Nx2+xv5h5mGGFzZ?= =?us-ascii?Q?9rRAYY2mwHvaN1LyFcFrOQ6fX1UeQX7q1rp/dYjAJu10BoQqdUF9mX7FZEAG?= =?us-ascii?Q?2T/1wlYpCnM+4DuLjEjBbWwrqzfI+ocQ7+ujGejDHRrZW9YlsHEDWLMvKF30?= =?us-ascii?Q?h1fU8WkmAMwkHiA5JfjJ9JlyOoFrgBKmp1jUKT1WvV+TL4UdERLblFpDqZpB?= =?us-ascii?Q?biZPU3v2+XCZExOS/03bjcwuXbTpL7aZyo19SJ5QZneNEg/tuRZu5OuJXT6V?= =?us-ascii?Q?ZSTSC2F0al6a1ROWHG0=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50b6d17c-ea27-44da-d4f9-08da7a3c6680 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2022 19:21:46.2223 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QfS/2PAdXKGNTeN6tm0Q/uhwODyVIrDwwn7nqMoNcgbkS7XZONK0FjXHs9QZbkYD X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4415 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Abner, Thank you for your feedback. I agree with you. What should I do to change it? Should I create a new patch? Thank you, Igor -----Original Message----- From: Chang, Abner Sent: Tuesday, August 09, 2022 3:35 AM To: Igor Kulchytskyy ; devel@edk2.groups.io Cc: nickle.wang@hpe.com Subject: [EXTERNAL] RE: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish= host interface is not supported **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** [AMD Official Use Only - General] Hi Igor, my feedback is inline. > -----Original Message----- > From: Igor Kulchytskyy > Sent: Sunday, August 7, 2022 8:26 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nickle.wang@hpe.com; Igor > Kulchytskyy > Subject: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host > interface is not supported > > [CAUTION: External Email] > > Host Interface details are discribed by the SMBIOS Type 42 table. > The table is published by the RedfishHostInterfaceDxe driver. > That driver supports PCI-E and USB host interface types. > The table is consumed by the RedfishGetHostInterfaceProtocolData > function in the RedfishDiscoverDxe driver. > That function only supports PCI-E interface. > > > Cc: Abner Chang > Cc: Nickle Wang > Signed-off-by: Igor Kulchytskyy > --- > RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c | 11 > ++++++++-- > - > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git > a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > index d79750b..a3b977f 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > @@ -65,10 +65,15 @@ RedfishGetHostInterfaceProtocolData ( > RecordTmp =3D (UINT8 *)Record + Offset; > > // > - // Check Device Type, only PCI/PCIe Network Interface v2 is supp= orted > now. > + // Check Device Type, PCI/PCIe and USB Network Interface v2 is s= upported. > // > - if (*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) { > - ASSERT (SpecificDataLen =3D=3D sizeof > (PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2) + 1); > + if ((*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) || (*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2)) { > + if (*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2){ > + ASSERT (SpecificDataLen =3D=3D sizeof > (PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2) + 1); > + } > + if (*RecordTmp =3D=3D > + REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2){ [Chang, Abner] We can do if-else here because we only support two types of network device = now. Abner > + ASSERT (SpecificDataLen > sizeof > (REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2) + 1); > + } > *DeviceDescriptor =3D (REDFISH_INTERFACE_DATA *)RecordTmp; > Offset =3D Offset + SpecificDataLen; > RecordTmp =3D (UINT8 *)Record + Offset; > -- > 2.6.1.windows.1 > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is > intended to be read only by the individual or entity to whom it is > addressed or by their designee. If the reader of this message is not > the intended recipient, you are on notice that any distribution of > this message, in any form, is strictly prohibited. Please promptly > notify the sender by reply e-mail or by telephone at 770-246-8600, and th= en delete or destroy all copies of the transmission. -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= .