From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.62]) by mx.groups.io with SMTP id smtpd.web10.31448.1669858416880092330 for ; Wed, 30 Nov 2022 17:33:37 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ami.com header.s=selector1 header.b=KSFNK6RH; spf=pass (domain: ami.com, ip: 40.107.243.62, mailfrom: igork@ami.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XLg8fb0AAElFBRs+5uLBxnKIKLJmqVrK7ZBr+RcQIV6qD0V6sm4+bYV//HRFVApx/e5gkOuL4baZdHfyE/7rfiGzQbwYD9RwYqX2xm3QG6cTdYO/TdtN+fGKVIrWD1GV+xsVybI2EU9h8V0R44jHZV57MC5H+qJPF3w504yEoquMUV2UCP+h2TysaaI9vY6mK9XW3m12wb//13b9ikIqOTSsT2tgOfH55D250LRcp9T+bDMVmHFNwSqxdrDbjX+JzHaUsM9lNu1CqRcbqEOPdsWGjs58pKlvmkt+Aolch6OIEjlwOUxsdLukAA8uC5Fa6LzAVxYYKzKuXgeed9qqKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EfPdE5IY/qpE+fUfA3xQFJTrQ35oZN9k4q1O6qUFWA0=; b=XRCogGL2yUelkeZ/lHUX6dQJhaJ5/Mm5klaUGN//cIcrhRvCozgrRYmq9WqaB6mBSDVQg+b2qujhhMFfJ6c6JYjojC6qHFj9E3vw2Z49d/OXQHGiC4a0/VVUR6J/xAkCcVpStQhOcdNFp7q0v70rYZgIDlReAbHoJxhG3Q4ovPqilQZK0WzrAcXRwPuGhJLtsl8/gnw62Bur6n46V82T/Q3Fg2kW13IxqbyvMgysBThkw+0bl3fe4Gtzhnff5oKthyMITVbMEsc2ttpYaUgJNKO4hkKx7txdhHeNRCDL4UFdSIak4ED+a7oienKtBrL9E2Qx+Fog7aJb64x/svYOrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ami.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EfPdE5IY/qpE+fUfA3xQFJTrQ35oZN9k4q1O6qUFWA0=; b=KSFNK6RHc6WWxENO4poggOR5ZszODbRPQm7Ed23A95gxQBr9wpu9ZaqaE3f1XJYHqUU4BIyLUh8CFNq1IX2WJr0muKp+WEUQDfKJXqQBHDQ2F2IEdJVsQ/EQ74P9b+3bpunA8mTDrMA2fSxRNZb6LEHAXoC8bOBrPBH0poIcLBo= Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by BLAPR10MB5282.namprd10.prod.outlook.com (2603:10b6:208:30e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Thu, 1 Dec 2022 01:33:34 +0000 Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::473b:192f:7fa7:8bbf]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::473b:192f:7fa7:8bbf%6]) with mapi id 15.20.5880.008; Thu, 1 Dec 2022 01:33:34 +0000 From: "Igor Kulchytskyy" To: "Chang, Abner" , Nickle Wang , "devel@edk2.groups.io" CC: Nick Ramirez Subject: Re: [edk2-staging][PATCH] edk2-staging/RedfishClientPkg: Fix GCC build error Thread-Topic: [EXTERNAL] RE: [edk2-staging][PATCH] edk2-staging/RedfishClientPkg: Fix GCC build error Thread-Index: AQHZBR9XyoO1nBvw/Uei9bqa2wQNRK5YP25g Date: Thu, 1 Dec 2022 01:33:34 +0000 Message-ID: References: <20221130152418.361-1-nicklew@nvidia.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-12-01T00:53:21Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=8c483deb-f747-45d8-a2f1-2ac31e202e6e; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ami.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|BLAPR10MB5282:EE_ x-ms-office365-filtering-correlation-id: 09b9ff17-bcf0-42ec-0de4-08dad33c0fae x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fNS4SU0Pe0JdPxvN0hDqTPY96bCwsCtnBT6tggPMCstdVHHuB+WOF8jnJjfSqt+WLa9hd++Cj2mcuMsSavKt+ZGSZvw6S+YO77NmFLCbQ0ATB/l41z1FoAm1c2w5nePoewyGvmyC6tIi1u55CnDdFA/moHBpnSeNY4GTDrCxiiTDiiGLkVI9ka91huoH0b6eQkTc+3zc5mgiiEhHFyU+D8hy4ejMQXh9BxU8x3gI76wi7lo+7g1zzcvB3wA811DC0K5t/HQZ/Cr3xRtYcbSU9ZQy1R+QwGIbyQiEdnU/evFe1RLT2V/Et+ROLhEEk5iR19r200u5osBtq++ehA8ulgt+VvMG/TNm2y2ecSsi3Jab2FkqzmeeE+840PdFodRms3zNQEVhrVEPuTqoCnBSOpQtgsGz7u+Vn7ed/JSyt09KcShgijRC7rxU6Z+mWZ0rUEK6A8Icfz95id3Oi4ZJYJwd5DLfKjtqyearD6KdejpGFEopaNO5TyQr5k0/g38mbuhuex3aiAAxVQxL76NGXjcMtqjUABX9gVAcA1qAgLJL1jKVZv6u3uL/hvWa79j1LwcBLQtyjKrO6ULurh7gQT9rEFCjAnfplhNldMX4ZPPNojLm6buSjdCU8/KoHxvJb0qEVLuuE4aNzEFQXBHDPCcVjIckBsK0Jw730eB/+5i5mFY/9ZA6KgXkqTyOWOZ/GAzv3+dK2zfclXE/Az+xaQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5185.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(136003)(376002)(366004)(39850400004)(451199015)(2906002)(52536014)(30864003)(76116006)(86362001)(41300700001)(5660300002)(4326008)(66946007)(66556008)(66446008)(66476007)(33656002)(40140700001)(64756008)(8936002)(38070700005)(478600001)(38100700002)(53546011)(8676002)(55016003)(7696005)(83380400001)(316002)(71200400001)(110136005)(9686003)(6506007)(26005)(186003)(122000001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9OuNpLKHJtj1g1ekNz1ReImVayXwbCuHoWhpWSn6YhHDHzLn8HObL15FjMCj?= =?us-ascii?Q?A3blHy1edKoJpYLKja2TqxyjPotOW3a4URDJqjmpdRjcn334qH+wPB/01FAx?= =?us-ascii?Q?PVpnnNmQh7/dFGG6XZv2Wkm4MKgGACHC0WbJV8V6sahCe57E206UcevgVl+F?= =?us-ascii?Q?i92YJgbU9o9utzArGHWvrHTLTRdP/penB7U8sgECXKu5Ful9RWL4qb9jCM9m?= =?us-ascii?Q?RZ/zGFpXYWa+82e8Tl0O9ZycH3uCeobDE+14o//E0jbg6zpCzS8IXUpK39EN?= =?us-ascii?Q?8MYOH9uTF0frSYHCiAusgRK9/IX7hvVSu37IPq7rPyFnHPB2x9yu9kMoYaBi?= =?us-ascii?Q?9f1XREt8/71tueDaACVKFVKElYQx2zz523/y07rrtgb6gWYhsRC77v5gJrhw?= =?us-ascii?Q?u1rmYrK1b+shqGrGK3ySBPUpDJRxQWj5RxmAkR6goSfLZZr8LskXrb44NS/l?= =?us-ascii?Q?o8buVIhU63OlJ+k0ZtjDA6zr6b0RqmHJG1S2vLMyNg2R+McAu/O6Sm3GZXV6?= =?us-ascii?Q?wZkkl8C5DOYzyo30u5bcHTgp7PyPDo5o9c/wqT1Kww62+4JS7xLmago47FnB?= =?us-ascii?Q?hPukmXJs3JpWOniHthbMP6kQK9Hnl1fKLfjr6LMq6e6o1pTt2t0exw+b8+JN?= =?us-ascii?Q?w2jRA/7ne3pDjG5loBZrAKvWkuIvwOWTw+KJx6fIm5fh52cOI96/QHNHGTnx?= =?us-ascii?Q?WPlzEbLhQAyofShOvOcEDCfkWmNWjGx4R1oHy3fIuBqlypOAtUm9jtuKjkdL?= =?us-ascii?Q?nRkg8UjxXHjou1majwe7iN6i5yM9IFgR0lVp6IOJfUHk1p2T/0SesH/6KZBf?= =?us-ascii?Q?ZZ+YfED2dFuCsI0M5UBn4cGcTVnlRwzYqELYKc5eQ0ulFBDZ/hISU/eBR+C3?= =?us-ascii?Q?6Raup3yrHopwS/s1tl+/noeV9xwX9LGk97MwtVcZzKTK4boABPayr+j5aNA9?= =?us-ascii?Q?dJ6rMrnmAhfIHrFfKFxI/zhavB9Acf4MH0lhVoEGIY7vXsalBhhwQOA1jWFU?= =?us-ascii?Q?wszQ14jFtUGRHZ6noGyNxn1KcyiRq4KmzW1z1r16O936sqS90Dcn3B3PwNuR?= =?us-ascii?Q?50VTuFWNGIXidyl7rlWt5D/l6CcIt0H7H0oqtvo1rKzCVDvu2CKtZtvf0IOG?= =?us-ascii?Q?dQDfuI20a4AerfycNHYW0Y+LXC6K77jIqxxhVWayzeDPUpVECy8R9bBlA0ns?= =?us-ascii?Q?FWwWz7m6hzXsuc0E+7EutfMCE64lIObKRfS7v2QDx8ZBVtm2+hHWuLSM67sX?= =?us-ascii?Q?S12ZlzGnUcOXiyxQJGtLqrGQrGYloLdjFmt9r+GphrTl+qG6nxiws+AfwgC2?= =?us-ascii?Q?M7VXo5x4P9HjApEhz4jAYr2XT3i/3To1VYsXWuaFBsqw2Mv3a58xmFSRBn1q?= =?us-ascii?Q?XTyQFIu44oALpvv/bTzxnLvxZPCni7U7+dR72w23kEnCEv/2lUIlVY0NsDmK?= =?us-ascii?Q?78ww41hRNg8r34nU7smr3ipP+4YNiTM2+5yzq6GEyTEreb8rhiIXnrOc+bD2?= =?us-ascii?Q?P1SH0mjxgHdD1y5VdQUhRDWsElM5vMmhHZQlpdNZ+bggQ0WeMVVnP6Lr75a1?= =?us-ascii?Q?CVyOemltnG471/xtdu0=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 09b9ff17-bcf0-42ec-0de4-08dad33c0fae X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2022 01:33:34.0597 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aqOm/sBZWcSm9kdRuegwyWVxHqYcjhqK6h+cV1/jA6B9/9TQa7Odwhr3RRajnKa/ X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5282 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Igor Kulchytskyy -----Original Message----- From: Chang, Abner Sent: Wednesday, November 30, 2022 7:53 PM To: Nickle Wang ; devel@edk2.groups.io Cc: Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] RE: [edk2-staging][PATCH] edk2-staging/RedfishClientPkg= : Fix GCC build error **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Wednesday, November 30, 2022 11:24 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-staging][PATCH] edk2-staging/RedfishClientPkg: Fix GCC > build error > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Fix below GCC build error: > 1) "Head" dereference issue. > 2) "BooleanArrayBuffer" uninitialized variable issue. > 3) Multiple definition of mRedfishVariableGuid. > 4) Multiple definition of medfishResourceConfigProtocolHandle. > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > --- > RedfishClientPkg/Include/RedfishBase.h | 3 ++- > .../EdkIIRedfishResourceConfigLib.c | 9 +++++---- > .../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 5 +++-- > RedfishClientPkg/RedfishClientPkg.dec | 4 ++++ > .../RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c | 9 +++++---- > .../RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.inf | 2 ++ > RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c | 9 +++++---- > RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.inf | 2 ++ > 8 files changed, 28 insertions(+), 15 deletions(-) > > diff --git a/RedfishClientPkg/Include/RedfishBase.h > b/RedfishClientPkg/Include/RedfishBase.h > index cf320bb0eb..ea716d7054 100644 > --- a/RedfishClientPkg/Include/RedfishBase.h > +++ b/RedfishClientPkg/Include/RedfishBase.h > @@ -2,6 +2,7 @@ > Redfish base header file. > > (C) Copyright 2022 Hewlett Packard Enterprise Development LP
> + Copyright (c) 2022, NVIDIA CORPORATION & AFFILIATES. All rights reserv= ed. > > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -16,6 +17,6 @@ > /// > /// This GUID is used for an EFI Variable that stores the Redfish data. > /// > -EFI_GUID mRedfishVariableGuid =3D {0x91c46a3d, 0xed1a, 0x477b, {0xa5, > 0x33, 0x87, 0x2d, 0xcd, 0xb0, 0xfc, 0xc1}}; > +extern EFI_GUID gEfiRedfishClientVariableGuid; > > #endif > diff --git > a/RedfishClientPkg/Library/EdkIIRedfishResourceConfigLib/EdkIIRedfishR > esourc > eConfigLib.c > b/RedfishClientPkg/Library/EdkIIRedfishResourceConfigLib/EdkIIRedfishR > esourc > eConfigLib.c > index 0d733bc6d2..c1598ffda6 100644 > --- > a/RedfishClientPkg/Library/EdkIIRedfishResourceConfigLib/EdkIIRedfishR > esourc > eConfigLib.c > +++ b/RedfishClientPkg/Library/EdkIIRedfishResourceConfigLib/EdkIIRedf > +++ is > +++ hResourceConfigLib.c > @@ -2,6 +2,7 @@ > Redfish resource config library implementation > > (C) Copyright 2022 Hewlett Packard Enterprise Development LP
> + Copyright (c) 2022, NVIDIA CORPORATION & AFFILIATES. All rights reserv= ed. > > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -17,7 +18,7 @@ > #include > > EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL > *mRedfishResourceConfigProtocol =3D NULL; > -EFI_HANDLE medfishResourceConfigProtocolHand= le; > +EFI_HANDLE mCachedHandle; > EDKII_REDFISH_FEATURE_INTERCHANGE_DATA_PROTOCOL > mRedfishFeatureInterchangeData; > REDFISH_SCHEMA_INFO mSchemaInfoCache; > > @@ -254,7 +255,7 @@ GetRedfishResourceConfigProtocol ( > AsciiStrCmp (Schema->Minor, mSchemaInfoCache.Minor) =3D=3D 0 && > AsciiStrCmp (Schema->Errata, mSchemaInfoCache.Errata) =3D=3D 0) = { > if (Handle !=3D NULL) { > - *Handle =3D medfishResourceConfigProtocolHandle; > + *Handle =3D mCachedHandle; > } > return mRedfishResourceConfigProtocol; > } > @@ -298,7 +299,7 @@ GetRedfishResourceConfigProtocol ( > } > > if (Found) { > - medfishResourceConfigProtocolHandle =3D HandleBuffer[Index]; > + mCachedHandle =3D HandleBuffer[Index]; > mRedfishResourceConfigProtocol =3D Protocol; > CopyMem (&mSchemaInfoCache, Schema, sizeof (REDFISH_SCHEMA_INFO)); > if (Handle !=3D NULL) { > @@ -372,7 +373,7 @@ EdkIIRedfishResourceSetConfigureLang ( > EDKII_REDFISH_FEATURE_INTERCHANGE_DATA_PROTOCOL *Interface; > > Status =3D gBS->HandleProtocol ( > - medfishResourceConfigProtocolHandle, > + mCachedHandle, > &gEdkIIRedfishFeatureInterchangeDataProtocolGuid, > (VOID **)&Interface > ); > diff --git > a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtil > ityLib.c > b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtil > ityLib.c > index 61383e2310..bfd6fff2a7 100644 > --- > a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtil > ityLib.c > +++ b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeature > +++ Ut > +++ ilityLib.c > @@ -2,6 +2,7 @@ > Redfish feature utility library implementation > > (C) Copyright 2020-2022 Hewlett Packard Enterprise Development > LP
> + Copyright (c) 2022, NVIDIA CORPORATION & AFFILIATES. All rights reserv= ed. > > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -1932,7 +1933,7 @@ RedfishGetUri ( > // > // String which has no ConfigLang remaining > // > - if (Head !=3D '\0') { > + if (Head[0] !=3D '\0') { > StrCatS (ResultStr, MAX_REDFISH_URL_LEN, Head); > } > > @@ -3173,7 +3174,7 @@ AddRedfishBooleanArray ( > RedfishCS_bool_Array *BooleanArrayBuffer; > RedfishCS_bool_Array *PreArrayBuffer; > > - if (Head =3D=3D NULL || BooleanArrayBuffer =3D=3D NULL || ArraySize = =3D=3D 0) { > + if (Head =3D=3D NULL || BooleanArray =3D=3D NULL || ArraySize =3D=3D 0= ) { > return EFI_INVALID_PARAMETER; > } > > diff --git a/RedfishClientPkg/RedfishClientPkg.dec > b/RedfishClientPkg/RedfishClientPkg.dec > index 67929341df..d3c97ecf68 100644 > --- a/RedfishClientPkg/RedfishClientPkg.dec > +++ b/RedfishClientPkg/RedfishClientPkg.dec > @@ -2,6 +2,7 @@ > # Redfish Client Package > # > # (C) Copyright 2021-2022 Hewlett Packard Enterprise Development > LP
> +# Copyright (c) 2022, NVIDIA CORPORATION & AFFILIATES. All rights reserv= ed. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent ## @@ -51,6 +52,9 @@ > gEfiRedfishClientFeatureReadyToProvisioningGuid =3D { 0x77E4FC1C, > 0x2428, 0x47EE, { 0x9E, 0xEC, 0x8B, 0x77, 0xEF, 0x9D, 0x4E, 0xF0 } } > gEfiRedfishClientFeatureAfterProvisioningGuid =3D { 0xE547CB6F, 0x30= 6F, > 0x4226, { 0xAB, 0x70, 0xA0, 0x6E, 0x26, 0xF1, 0x2E, 0xD0 } } > > + ## Include/RedfishBase.h > + gEfiRedfishClientVariableGuid =3D { 0x91c46a3d, 0xed= 1a, 0x477b, > { 0xa5, 0x33, 0x87, 0x2d, 0xcd, 0xb0, 0xfc, 0xc1 } } > + > [PcdsFixedAtBuild] > > gEfiRedfishClientPkgTokenSpaceGuid.PcdMaxRedfishSchemaStringSize|32|UI > NT > 32|0x10000001 > > gEfiRedfishClientPkgTokenSpaceGuid.PcdMaxRedfishSchemaVersionSize|8|UI > N > T32|0x10000002 > diff --git > a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c > b/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c > index 2762bbefab..dbfb3aaf82 100644 > --- > a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c > +++ > b/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c > @@ -1,6 +1,7 @@ > /** @file > > (C) Copyright 2022 Hewlett Packard Enterprise Development LP
> + Copyright (c) 2022, NVIDIA CORPORATION & AFFILIATES. All rights reserv= ed. > > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -411,17 +412,17 @@ SaveConfigLangMapList ( > // > Status =3D GetVariable2 ( > VariableName, > - &mRedfishVariableGuid, > + &gEfiRedfishClientVariableGuid, > (VOID *)&Data, > NULL > ); > if (!EFI_ERROR (Status)) { > FreePool (Data); > - gRT->SetVariable (VariableName, &mRedfishVariableGuid, > VARIABLE_ATTRIBUTE_NV_BS, 0, NULL); > + gRT->SetVariable (VariableName, &gEfiRedfishClientVariableGuid, > + VARIABLE_ATTRIBUTE_NV_BS, 0, NULL); > } > > > - return gRT->SetVariable (VariableName, &mRedfishVariableGuid, > VARIABLE_ATTRIBUTE_NV_BS, VarSize, (VOID *)VarData); > + return gRT->SetVariable (VariableName, > + &gEfiRedfishClientVariableGuid, VARIABLE_ATTRIBUTE_NV_BS, VarSize, > + (VOID *)VarData); > } > > /** > @@ -457,7 +458,7 @@ InitialConfigLangMapList ( > // > Status =3D GetVariable2 ( > VariableName, > - &mRedfishVariableGuid, > + &gEfiRedfishClientVariableGuid, > (VOID *)&VarData, > &VariableSize > ); > diff --git > a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.inf > b/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.inf > index 9f19533815..821f05523c 100644 > --- > a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.inf > +++ b/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe > +++ .i > +++ nf > @@ -1,6 +1,7 @@ > ## @file > # > # (C) Copyright 2022 Hewlett Packard Enterprise Development LP
> +# Copyright (c) 2022, NVIDIA CORPORATION & AFFILIATES. All rights reser= ved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -41,6 +42,7 @@ > > [Guids] > gEfiEventExitBootServicesGuid ## CONSUMED ## > + gEfiRedfishClientVariableGuid ## CONSUMED ## > > [Depex] > TRUE > diff --git a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c > b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c > index 52015672f9..815071dfe9 100644 > --- a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c > +++ b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c > @@ -1,6 +1,7 @@ > /** @file > > (C) Copyright 2021-2022 Hewlett Packard Enterprise Development > LP
> + Copyright (c) 2022, NVIDIA CORPORATION & AFFILIATES. All rights reserv= ed. > > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -398,17 +399,17 @@ SaveETagList ( > // > Status =3D GetVariable2 ( > VariableName, > - &mRedfishVariableGuid, > + &gEfiRedfishClientVariableGuid, > (VOID *)&Data, > NULL > ); > if (!EFI_ERROR (Status)) { > FreePool (Data); > - gRT->SetVariable (VariableName, &mRedfishVariableGuid, > VARIABLE_ATTRIBUTE_NV_BS, 0, NULL); > + gRT->SetVariable (VariableName, &gEfiRedfishClientVariableGuid, > + VARIABLE_ATTRIBUTE_NV_BS, 0, NULL); > } > > > - return gRT->SetVariable (VariableName, &mRedfishVariableGuid, > VARIABLE_ATTRIBUTE_NV_BS, VarSize, (VOID *)VarData); > + return gRT->SetVariable (VariableName, > + &gEfiRedfishClientVariableGuid, VARIABLE_ATTRIBUTE_NV_BS, VarSize, > + (VOID *)VarData); > } > > /** > @@ -444,7 +445,7 @@ InitialETagList ( > // > Status =3D GetVariable2 ( > VariableName, > - &mRedfishVariableGuid, > + &gEfiRedfishClientVariableGuid, > (VOID *)&VarData, > &VariableSize > ); > diff --git a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.inf > b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.inf > index e29a10456e..4aecdb4191 100644 > --- a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.inf > +++ b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.inf > @@ -1,6 +1,7 @@ > ## @file > # > # (C) Copyright 2021 Hewlett Packard Enterprise Development LP
> +# Copyright (c) 2022, NVIDIA CORPORATION & AFFILIATES. All rights reser= ved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -40,6 +41,7 @@ > > [Guids] > gEfiEventExitBootServicesGuid ## CONSUMES ## Event > + gEfiRedfishClientVariableGuid ## CONSUMED ## > > [Depex] > TRUE > -- > 2.38.1.windows.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= .