From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.81]) by mx.groups.io with SMTP id smtpd.web11.424.1685456928452646806 for ; Tue, 30 May 2023 07:28:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ami.com header.s=selector1 header.b=bRlWvXYq; spf=pass (domain: ami.com, ip: 40.107.223.81, mailfrom: igork@ami.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CvYrEm4ntN5nKdLI3G/LPxXj18QaYzpVtzz/JAa7x9EFznAQZ4R2m2WstUKcNK/TRHrx7jl2jEayjRuHUIa/yJaMaa7ZzsCj2ejHG9yqxofzBF3U6tXjz3Wh144NYqGsYDcGsVQZiUIEaZx4+WEz3LaYbMo6muDA8FbsLE4xutCJB4AgVfP5FrSAgQRMdlHsZgm7rfwXWb9PX3fronEAjMIjX/1J+na/yNlkpYGL8tgNxWtryFersN4Iog9ND71lyfJMxV0ew0c+b8zKHSRHcX/dHBi503RncTWx+XDQw727wW8A5CcFVgab8cu/X+JkGvHyjIYms+rz8xUk7etfPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ASKpBdR9DJXKd1HO0jnefotw66wcR6d0N1bSpZR8vUg=; b=dEs3Y3m7oqfmzW2Bm5M7IK9PkZS+goQ4/qzj0c/CLLBboN68muWK2OP9JRezgRgtFn/C2HJ2+bQ86/cULsh1EhITIfPO/rN2FVTePF6CNDR/9xZNGBMCGjnKQ7pCow7eAaGRPlhD/fOaRpzJqfljyyKpNCIVyMUZuKTFuBiMjHRMv6y1r8X87cFZDVBDe/fIAZysRqzPN8MW2wSzenGllNw940CAcSLFhe61UzBCYVp6PH1LNlRVIoMkPFYNwlc2U2ujZrtD6TIfCEL5hCIHeTzBIkGU1z0sxUP2FRvLT62d7cQdi/XqCxRw/SHlZuPkH6qAZPQ6eCDAS+xonAZD9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ami.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ASKpBdR9DJXKd1HO0jnefotw66wcR6d0N1bSpZR8vUg=; b=bRlWvXYqoQcnZ9PXskA1EpQR71IDGNXyP1zOvnbeA3Mg5oSBY03EDHRAX7B2Escc91WLuL/AqpdOwcGERqMLCwop3abtGTpMzlw7UUF3kxo9E0x6yN5ocf1dFr9V/MEIlyT/NuyVIaUC5oqILvMzzw6kv7S64YrPTfDtKFwkHVE= Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by CH2PR10MB4310.namprd10.prod.outlook.com (2603:10b6:610:ab::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.23; Tue, 30 May 2023 14:28:43 +0000 Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::d79d:9060:94d8:b4b0]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::d79d:9060:94d8:b4b0%7]) with mapi id 15.20.6455.020; Tue, 30 May 2023 14:28:42 +0000 From: "Igor Kulchytskyy" To: Nickle Wang , "devel@edk2.groups.io" CC: Abner Chang Subject: Re: [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix value type issue. Thread-Topic: [EXTERNAL] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix value type issue. Thread-Index: AQHZkfYxld8z8BN+MEq//w8bfJ4/Qq9y4fwQ Date: Tue, 30 May 2023 14:28:41 +0000 Message-ID: References: <20230529062401.1263-1-nicklew@nvidia.com> In-Reply-To: <20230529062401.1263-1-nicklew@nvidia.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ami.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|CH2PR10MB4310:EE_ x-ms-office365-filtering-correlation-id: dac22bf0-5951-43a6-db23-08db611a2ae8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BYhgkjDBVfZ2QkZp9nGouk5QvgEEc1cO/27TbdMlTbnduRMjVsC1O8zu/sJop9yRzdz1ASJgKcLEfi0x60uKVh4Eu1UC/EIvit9tzZwtuMXtnwqTUrEATvQyaaCriW6A2JS8gfhLUzBwgEleEeHBk63R1przmikltBjZSQHnT/LJXxeOP9LpZSFklR52+EK/iz+ldsEqaUXyupY9SpdMZRCBMv2KYGcGoSrhn79KMalt08tuLM2JwkxgD400eNFy8qeyUTz0vpu3b6dWX9tLLOZdfQ53gYQ7FJ7ebaOR0aPWJMW8pIuTq4hOvjOLMtlPNqFhzgNc3a4C8Q2FvIhPEIBz1Mq1UJxV/pdLJ8Hywp2kNwj+e5xfw6rAFQEN7aCP8Bvfb+8wxJ9dYEyG1QhE1NpnarN+bMGyP49o7UOOfQzH8vgUl6+Z1b2LmWry3DLZsSD/m0aXU6Rtzdj3s4jsz5j9/KrcYvqVYl4Vgv4JRHn6Reo3NQZ2r7Y1QJeoCTA+3UPmPqLVUrmCuQwx+iF3g8nY2vrS5ZHG6oj4OgzVIvq6gwtp5GcNn18YhJ9XT6s+gMs9iN9EJVRZD2a34YSmbzFz4BA9lWMKCLPAglDY+ynxmJj5SZxYJPYa0SDaiOZk x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5185.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(346002)(39850400004)(396003)(376002)(366004)(451199021)(9686003)(53546011)(83380400001)(6506007)(26005)(52536014)(186003)(5660300002)(8676002)(8936002)(38100700002)(110136005)(122000001)(2906002)(478600001)(7696005)(41300700001)(38070700005)(86362001)(33656002)(71200400001)(40140700001)(316002)(76116006)(66946007)(64756008)(66556008)(66476007)(66446008)(4326008)(55016003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zT2iU0AFXo4FBXIw8qhXIbGeeGpLak1bjb1JDMwQENdqzYlytp0sXBp+GcV8?= =?us-ascii?Q?qd9FYkHzFdzx5hQ1u4Tre1V/z6Pi2o1K/XxIrkmJnyXUSMaeifmtG41hjBSA?= =?us-ascii?Q?iWX9VPsw+t+dIT5igzZMKSukDmeFtOwz+TFfJ7jny274NacmTghcceoZvHbk?= =?us-ascii?Q?53IRNxn4LpcwfR8J3iKbI1Q6UvA4joYackQeOSbyytR6DBMdqYyFDFF204VM?= =?us-ascii?Q?fM/zyCOioLkv6EFcgrt6TiljF+CyDeoXKPjQtkYARszReaeMUpkjcdXi2aXO?= =?us-ascii?Q?U7URaopLBorQlc9wufFRDeq2GLm0ZKIlPuz3PT/V7MM9mF1BfTTmYUUf9sFO?= =?us-ascii?Q?l5SnCpyIric1eh6O8x6+UpOLsT0+RjxQQc8aWe0IKjkUpDgO/JjEkmLpr9cp?= =?us-ascii?Q?oylCgoonQOq9N4WL6Vmj52fXxinWyV1dOdP+qy68hhoar6mrBK4a6KsWl2Qm?= =?us-ascii?Q?54A2ux/oTtJzqNh1rtFT82coS4kjj9Z7tY+xUMbSBWPHlx50Wfe8SZFpqGZa?= =?us-ascii?Q?KpLv6qD7KYJ6UYUesiTSRuvY7NDgNTFXw9eUMYx0V1G1fnWlDtdjKCFtN3gi?= =?us-ascii?Q?U9BSwZxj26dbzcqIgu1HK8Q+AVFyFXmcSQQ5xUtmZeRxiJiaLHaP/QL3idWf?= =?us-ascii?Q?TBbY5P7Ac1hVZdExqv30durvrvc7em1oUsTFXp+XnpK4ePsGzvaGu2ddGqRu?= =?us-ascii?Q?KKUkpH38C7cm6krIYNDH7kATreyKQClDtf8yaPM8vDuDv6BRjU5k6ftehv3x?= =?us-ascii?Q?LvI58vkn0vOD2GLOv+5ou7ZZ2ScRoQmPa2dIHfjfk/2vP9DgUCXbJ+DznMAl?= =?us-ascii?Q?ThXCnL4irp7/UEhkMUblhc4kOywYb6IMIIOK7eJxvMowerVvXAsXvnrt7Pkg?= =?us-ascii?Q?vPCvb70q7yRy5WN4v35VRDuGGxW5YgTim/bWc8XaxI+yvCkD0d+T9wytId+e?= =?us-ascii?Q?OCQ6VSNDY6ca7EVaMVBwwqr+rDMQ8p1y5Fg0HgLvUpTfTVT+XQ+WAuv4/crt?= =?us-ascii?Q?cefr/IzfYbC55kjStg3ptguLuvXoNZIpG53Ii1zXa8TaTNLM0LyAxOLpRLFC?= =?us-ascii?Q?0XSHfDUdteSroBukb2Rp/FqF9dlytuWN1djUV37x2MnbnOj7POwhi4mNlrN3?= =?us-ascii?Q?keFnnTWjzwBxZ4sTp5kWBdZP1wy2P7ilHVQLS1lEHtdTzpqCTkgd97+EVqQ+?= =?us-ascii?Q?8AX95tb71Wt23kmbVPUP+Cj/kn/1862QO3bBYo952r4UwDFxaBy1tukXQabl?= =?us-ascii?Q?GptvzJgl45vfR+JDjH5X9l4jB5R/tYK9NnLT2gTOiq2pIPZLYo7nYnRKyn/b?= =?us-ascii?Q?E1A7DsoTuZXjCEZnHg9ttQXqltvynyatw0yPsNFMMNE+lbhELPii3SyvPiPx?= =?us-ascii?Q?UfFF6veNOYiF4hfp21x+xgX44NciepIGJXXuoEwLpSSGYgdrTXpiZfcR7orp?= =?us-ascii?Q?pPN1F4HcNwJLEDli5iWcHenxRHr2Mvbp8+8bE8AgBdeoEs+22MaiynuxVz4Q?= =?us-ascii?Q?hasZTXp6TzqTZ6HLhVQN9mNFsJRSbnZF+HtrXjN24gaAFa1HVfQs/yJyWWXB?= =?us-ascii?Q?FpjOF5ad9MevFGiTRng=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dac22bf0-5951-43a6-db23-08db611a2ae8 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2023 14:28:41.7688 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PUb54I9VuABAJc9C54k07gpvewVu6G4WyuJSTF19/ZenyLjRBy8ER/gp11E5rxcq X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4310 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Igor Kulchytskyy -----Original Message----- From: Nickle Wang Sent: Monday, May 29, 2023 2:24 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy Subject: [EXTERNAL] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix value = type issue. **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** Fix incorrect value type issue for checked-box op-code. When the variable for checked-box is defined as UINT8 in varstore structure, IFR compiler assign its value type to EFI_IFR_TYPE_NUM_SIZE_8 instead of EFI_IFR_TYPE_BOOLEAN. However, the value type for checked-box is boolean value. Redfish service may return error because of incorrect value type passed to BIOS attribute registry. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../RedfishPlatformConfigDxe.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c= b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c index 1172d1094b06..462f269f6a3f 100644 --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c @@ -1221,6 +1221,16 @@ HiiValueToRedfishValue ( RedfishValue->Type =3D RedfishValueTypeString; break; case EFI_IFR_CHECKBOX_OP: + // + // There is case where HII driver defines UINT8 for checked-box opco= de storage. + // IFR compiler will assign EFI_IFR_TYPE_NUM_SIZE_8 to its value typ= e instead of + // EFI_IFR_TYPE_BOOLEAN. We do a patch here and use boolean value ty= pe for this + // case. + // + if (Value->Type !=3D EFI_IFR_TYPE_BOOLEAN) { + Value->Type =3D EFI_IFR_TYPE_BOOLEAN; + } + case EFI_IFR_NUMERIC_OP: Status =3D HiiValueToRedfishNumeric (Value, RedfishValue); if (EFI_ERROR (Status)) { -- 2.17.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= .