From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 73DE39412BD for ; Thu, 26 Oct 2023 13:09:24 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1b8u3EQzJrbmsBA3XFrECZf/Vd6jwfPBqkKn8/AueQ4=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698325763; v=1; b=qu98CSkj3b2niHdpZdm6IsX7NLPZoL/Xj9C8E/ObtS/LssnibMAmLQZXosDq1CBF+uPiLvSl ANXFMAwgcSC3AQnq9BJK9A5ea4Oqoqql1ExhI/Fq4tyjazPxtNngf4PlKMMbwn6/tMYC92Gp7B6 sT2NPd5ixcv9Mr+cHFdgJWEM= X-Received: by 127.0.0.2 with SMTP id kgsBYY7687511xQucil6ZjXy; Thu, 26 Oct 2023 06:09:23 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.66]) by mx.groups.io with SMTP id smtpd.web10.199614.1698325762071571918 for ; Thu, 26 Oct 2023 06:09:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g7RW5KqfNc77EnqT/RNv4KJZkK++kfsImq+4ux9TI0Nm+Rc1H+7j6Sh6N9aAWJYitpp+IrWSErF3fvHi2ScU7x3TgmXO/oP78HWu/+j2H9CGNeFS+Mf40O6HXIf5wr0eLbcvNLrjDHwkf9Zz9xmqHxFz29Ki2r2zQqvpGYu051EuDFB/tGMOwPgkLLXzu5iV4TxV75tkILqE32M74Tj1NjNRtMedePMLm4eD4kvGyZ+85cM0xKM+Jp794/GvZXOvXGIlUId+dNjgzDbrwIrtcl60kJel0pdAEC9b/wpFud0vCKwGDOekhnjoud4Z81RKx+1N4um+C5MtSFPecq+Q5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nz9OOUKW8vYd2blnyFVtLTY4RGK53BYTh28uSoK9nlU=; b=dRyu/JhM82D5tLoquv/zwZhSgzP8tyKwV837kYsCI/C4anUcffHR0O6VVQnsyR5A97Q5nd+wyvBGhEBlPG3s3Kr2Hwf6GanRLRGFnbfsKYZ/9oV7VgC4KlRWLaPscLliiF5CuXihcdBxsdys9E2E6C3e8dnm5WZJoFTYp8y17K7bqe0GXE3ggo6B9ZGhLfbb3BF631CghTXJTPFuUpj9Ggca7xWo5+gISPWI7dDzLu4CqtwDykFWu4kbQ2ICNEauQTU8JiCXHegWDaIGRG6203QrRalYpmhvhAZFZaj6Be1FF8t9mNO1CE4ZaHE4e8fX1G64HSSFGa8o5ND7IYying== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by BLAPR10MB5218.namprd10.prod.outlook.com (2603:10b6:208:306::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.22; Thu, 26 Oct 2023 13:09:18 +0000 X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::7126:faa8:8f0b:d58b]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::7126:faa8:8f0b:d58b%5]) with mapi id 15.20.6907.025; Thu, 26 Oct 2023 13:09:18 +0000 From: "Igor Kulchytskyy via groups.io" To: Nickle Wang , "Chang, Abner" , "devel@edk2.groups.io" CC: Nick Ramirez Subject: Re: [edk2-devel] [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller Thread-Topic: [EXTERNAL] RE: [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller Thread-Index: AQHaB9MPSKSfc77G1UahsvaYvRzZ/7BcBbaggAAC2oCAAALNkA== Date: Thu, 26 Oct 2023 13:09:18 +0000 Message-ID: References: <20231024083944.16275-1-nicklew@nvidia.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=cfbc3f75-dde8-4c77-a5a6-b619356f2f83;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-26T06:09:54Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|BLAPR10MB5218:EE_ x-ms-office365-filtering-correlation-id: 70f243fe-d5a8-4cef-ce7b-08dbd624c307 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 9PNE2Sk6L0tTNkXCsYG3ncYrIl2sLu58g2sZUxx/Mj0AQD3xu6RUHYhvh/b6lMXysdfKltUe697lRNnrme6Q+eT1yqfNsFbeVRLKoGM30qtm8rgJZKKU5Kgg0kjdLfEtWN4/QtA6uxttng4npD+h+Nrw/RQWpdCtXH608nfmRwESF1dL/X5rmL9QsKBi006f7r/kBYcitxOphMC3+sKWwgb/Pi033dxYmRB1iwcg9upRsUSUqxKo5+pCAm4eOKAUJqyzPOxMADtCWEglp1g5u0dPC7vV0pUnDALRwGuEglmbT8F9qNDLnLUHDf5EsZa6Ez+FLWZjsMFLbMUSgNd1fJ8nudb3jllKlS39YacxGKTz1s3V3tbWqCmsKpT+1CwXIr+WqAYVkIamhje+lc/gUn9YoG/cRSYR5iR6JloQfr7/UylisIdcsU2y/2hDILkAk8uKDE8ZmVV+LDjOCDYss/qXmpauiOASIx6SQZcXdb312FwboTViTk3WHxDXUY3voKDVFFQbu/KBYagBggPN5RvsOkAZLjc/udcdTx7YItOGh0TIhSZj3/iDkZlWxKlM87sBMvBjENz+cgB3VmvbT3su/ngwoMUuQ/MJAEpZt9Sk0pvZCX01arANeHCBlNVH x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?p6+J60PatRoa6MszIpvz5BsnLlCN6LF6FEzK06cP/U+K+wWnPkRwoSWxZ/OS?= =?us-ascii?Q?vjU/AHiWQ6EkGikWCD2iHnJqC30ezo+wDIJCv8vAVIe7Bn3Aws7gNbuOFLzu?= =?us-ascii?Q?D8jwuHRDyKJ4l2hPMei5Uc3rx6NL646+fho5IYRFilB6fdVkBMQdaZAd8VW4?= =?us-ascii?Q?XECSkVjz+gdzYY/Auy+whuU9/yNGNqYUmBbKvwJ6/FgkjXuJ1AnakAm02Lx1?= =?us-ascii?Q?t1tpZPzYWWiSgkCTNGupIfciNujse+zO3ZXRg3B2DxcgCXMZ4OJvkvPHaqCp?= =?us-ascii?Q?EMhSu2cYluarEtB86FmU+CIN4eoghqEvIpSka35hqpvpiZ6aonfIZ5qu90y+?= =?us-ascii?Q?4fh1tRaCtpLJfnKXFl9jiyOrrDeiOgXnlJHFnQqnKht7fMKU+pBpHn2tfFIT?= =?us-ascii?Q?S5BWmKphFwXWIrF3Ep/nO2wUDFbbasITZ8EPjNCwe78iKrOt1awiYO1qBp4G?= =?us-ascii?Q?i3s0nfyY3oDEvTsnsMrVo8bc/LSopx1MaNWbQgWqdyS667XHqbToLLolHdjs?= =?us-ascii?Q?3y0J0T4OHyDFTDcY0sVgyaGriF1nwt0wCWNlCGSRP6kxvQxqsAfm5paHfwB0?= =?us-ascii?Q?AtqJK6IczR3mIC0WRxglFkbUbjmQI+Pjaw68+8hC+ijk8OuRky1LPz41gvXL?= =?us-ascii?Q?Rnm0FnPLa4CWR3xVOJjQi+YP92kiaWF0Ts6fT2PYthijdJLjpV4tH5xly/v1?= =?us-ascii?Q?x5wcWMZpBWwnuyriQdOfdoTZIGrA7gdTMgeETzlcdVFvaw9OoqItf2aQcgZD?= =?us-ascii?Q?7WxkITG96hAj1oIqV7tjhWAr31/WDIr7j/1chH9J3SfyG7HfrV5S10kKU3+D?= =?us-ascii?Q?vWb9AeKz0Pq5mYHcRy7fALm7D052s8VG1fPdnKSjWFDq992UTKr91BeXQcuf?= =?us-ascii?Q?qthNwAULiJnxcawhTRB0xYWDbOZbNQMZUVZVp1MzQwT50VJvdidSngHDSmRZ?= =?us-ascii?Q?twvEp5vEbb0NnwP6fsjBo+QQhwaP7QAi8HKdAKtxKwjs9XkWNHzVp+l80D38?= =?us-ascii?Q?5YqvTuG4po0j7CuejMiJwgn62D3mXLI4qEBNYLCCpq26B2T6Za1cjYqPeFp+?= =?us-ascii?Q?6SoswKs2FKLVNSYdOZzx7k4mcrJfnDq2o5axojS7F/dGJzwDY8MXW6V3dB3d?= =?us-ascii?Q?vosa72X73xtCvAQwJ9oUz6SQkeYtFAlU2dffg74ULglHCokwWewqUF4K432y?= =?us-ascii?Q?oUcFd0RJQhvI426XMC6iN+sqVShhpXdVpfhQgGZdI8DgS4obiHvBZ+CAgENb?= =?us-ascii?Q?uViXluxC7c2Nwm2CrV9e3W30l0feA2ErCicz9GPkCmdthkfFWij3Cv6mtaSM?= =?us-ascii?Q?jG2qx3bpkqetbQoQ2KFiB0UHzuOnjTD+xNia/IFEFzMXoHeWo4p6cwFN8uFw?= =?us-ascii?Q?849106/aKVlXx0XDIlmJQuOkbVvWCtc/1qk019aQbk5O9LknlmL25z8tn/B/?= =?us-ascii?Q?tqLpYYTMLJ5taDu6vPXkKNJweqA6SKp3C2/7lawF2npu/xdYWg3578g98Ed0?= =?us-ascii?Q?OO/4G962VJTG+Izud91Jes+w9w0BwBJKY2L8LIt8As/ssoRHDiXWl8KUyYQ2?= =?us-ascii?Q?cV6kCS3A9GdDRKiBFmQ=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 70f243fe-d5a8-4cef-ce7b-08dbd624c307 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2023 13:09:18.1921 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: L4A+rnSVComBgmRXIoUvDU8kZjEGZGsHufOx16IBO4r/1EGW/F/dCHBUpKJYl3UF X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5218 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,igork@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 5z2iso5hTBwJ6ocXDz7wz6lex7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=qu98CSkj; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io You mean, for the Redfish task functionality other functions will be used? Thank you, Igor -----Original Message----- From: Nickle Wang Sent: Thursday, October 26, 2023 8:58 AM To: Igor Kulchytskyy ; Chang, Abner ; d= evel@edk2.groups.io Cc: Nick Ramirez Subject: RE: [EXTERNAL] RE: [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP = headers to caller Hi Igor, If the DELETE request to BMC is handled by Redfish task, we need to return = HTTP header to caller so caller can get Task URI. But from BIOS Redfish per= spective, I don't see this use case yet. Thanks, Nickle > -----Original Message----- > From: Igor Kulchytskyy > Sent: Thursday, October 26, 2023 8:50 PM > To: Chang, Abner ; Nickle Wang > ; devel@edk2.groups.io > Cc: Nick Ramirez > Subject: RE: [EXTERNAL] RE: [PATCH 3/3] RedfishPkg/RedfishLib: return HTT= P > headers to caller > > External email: Use caution opening links or attachments > > > Hi Nickle, > Just one quick question. > Is there any sense to return the headers for DELETE request? > Thank you, > Igor > > -----Original Message----- > From: Chang, Abner > Sent: Thursday, October 26, 2023 2:10 AM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Igor Kulchytskyy ; Nick Ramirez > Subject: [EXTERNAL] RE: [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP > headers to caller > > > **CAUTION: The e-mail below is from an external source. Please exercise > caution before opening attachments, clicking links, or following guidance= .** > > [AMD Official Use Only - General] > > Reviewed-by: Abner Chang > > > -----Original Message----- > > From: Nickle Wang > > Sent: Tuesday, October 24, 2023 4:40 PM > > To: devel@edk2.groups.io > > Cc: Chang, Abner ; Igor Kulchytskyy > > ; Nick Ramirez > > Subject: [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to > > caller > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > Call Ex interface to get HTTP headers and return to caller. > > > > Signed-off-by: Nickle Wang > > Cc: Abner Chang > > Cc: Igor Kulchytskyy > > Cc: Nick Ramirez > > --- > > RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c | 10 +++++++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > > b/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > > index f4045044829a..5e06d516ba84 100644 > > --- a/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > > +++ b/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > > @@ -356,7 +356,7 @@ RedfishGetByUri ( > > > > ZeroMem (RedResponse, sizeof (REDFISH_RESPONSE)); > > > > - JsonValue =3D getUriFromService (RedfishService, Uri, &Re= dResponse- > > >StatusCode); > > + JsonValue =3D getUriFromServiceEx (RedfishService, Uri, &= RedResponse- > > >Headers, &RedResponse->HeaderCount, &RedResponse->StatusCode); > > RedResponse->Payload =3D createRedfishPayload (JsonValue, > > RedfishService); > > > > // > > @@ -498,10 +498,12 @@ RedfishPatchToUri ( > > > > ZeroMem (RedResponse, sizeof (REDFISH_RESPONSE)); > > > > - JsonValue =3D (EDKII_JSON_VALUE)patchUriFromService ( > > + JsonValue =3D (EDKII_JSON_VALUE)patchUriFromServiceEx ( > > RedfishService, > > Uri, > > Content, > > + &(RedResponse->Headers), > > + &(RedResponse->HeaderCount), > > &(RedResponse->StatusCode) > > ); > > > > @@ -661,12 +663,14 @@ RedfishPostToUri ( > > > > ZeroMem (RedResponse, sizeof (REDFISH_RESPONSE)); > > > > - JsonValue =3D (EDKII_JSON_VALUE)postUriFromService ( > > + JsonValue =3D (EDKII_JSON_VALUE)postUriFromServiceEx ( > > RedfishService, > > Uri, > > Content, > > ContentSize, > > ContentType, > > + &(RedResponse->Headers), > > + &(RedResponse->HeaderCount), > > &(RedResponse->StatusCode) > > ); > > > > -- > > 2.17.1 > > -The information contained in this message may be confidential and propri= etary > to American Megatrends (AMI). This communication is intended to be read o= nly by > the individual or entity to whom it is addressed or by their designee. If= the reader > of this message is not the intended recipient, you are on notice that any > distribution of this message, in any form, is strictly prohibited. Please= promptly > notify the sender by reply e-mail or by telephone at 770-246-8600, and th= en > delete or destroy all copies of the transmission. -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110097): https://edk2.groups.io/g/devel/message/110097 Mute This Topic: https://groups.io/mt/102154017/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-