From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 877BB94163A for ; Mon, 18 Sep 2023 13:42:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=xaA+JFxVCAstGKTCl7q8DgUVnzi6Cq90uqYugoGNM0Y=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695044539; v=1; b=No/UHGrWiUGgQHg8oXreTJTPFjHMxMBhgg4QNaUAlfzm/Pjc2EhYeK/dCmbK4ZGmafaB7AcW jBksWz4cvEQbSAf5fyXzW5gUCkX9DepWUVNUZRl5ScVSombuwhsgfTVzL8OeUlDorGGnB2XTcB9 sDnYD1IeK/vIiWVnwoDEeABA= X-Received: by 127.0.0.2 with SMTP id U0KAYY7687511xey29f25SzJ; Mon, 18 Sep 2023 06:42:19 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.50]) by mx.groups.io with SMTP id smtpd.web10.51369.1695044537885946390 for ; Mon, 18 Sep 2023 06:42:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=atLjG0fWcwd1Htbily6+hBR6Ujn4cK1N7s+czkTt1Y4afcfWkoNcRGR+5F5SNk/R+qsFMZBIGbi0NgOQ4YenwJ/nqmzGn+b4PqCVFwUpeZUA85Z8PuSm88OALmtDTlHgKrbuu6R0tUwa67H8ImwS/N0oanR8vTaJg4UzsEZBwQpnlKg63D5giZpqWt3q5sUihJsj0k01GqtCMumwY0kO711dVMPwaluVnrbRdP0ZbyJOGl5ZHcOGlbFqwLHBMIQ0kzggLo1Q3RKqx9XfP/ebKjhQ4+VsZEmiwK5gTdv/TmtRXtZFkZTHAAX1Uy0/c0WC5YzPF6mvSMHb39H0qJRG9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MgipaNE0Hix1cNtnn3cvAZwXYCbZzG1qgfExBMj1O7E=; b=DiBjJ8EdIbJsydN4vvT7PLwUPFqEyniEJiuHw/fzaHrDWc+WBEYIUk0qVmJZQ0GMDgTitq703eg953Dh0blA+Sr7EeKiIx+QOTQ39ES4IM53qPD8O4uDBkkBlbOxbhk6QuDocWUbeJL/o2RhmOVO6Jl4NnfuUlIaWjBbRvRmhwi+7B718UiiawfTb9jHMmpcIm6scwj0dujqhM8iLqXKuYtnGgtUyVzvqcKXJ2XSOeBe4TZWZ7V0O7041u1H4tcxspum6SXBXa48vw7ZSKlqZety2+eqdfSM/tj8Iu+1YjP6yYxWX4z0ufCGutOk4nt5RSyqs5AQVhxBtfylMiENLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by PH7PR10MB7693.namprd10.prod.outlook.com (2603:10b6:510:2e5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.27; Mon, 18 Sep 2023 13:42:14 +0000 X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::dc2c:50e8:b23e:d010]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::dc2c:50e8:b23e:d010%7]) with mapi id 15.20.6792.026; Mon, 18 Sep 2023 13:42:14 +0000 From: "Igor Kulchytskyy via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Abner Chang , Nick Ramirez , Mike Maslenkin Subject: Re: [edk2-devel] [PATCH v2] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller. Thread-Topic: [EXTERNAL] [PATCH v2] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller. Thread-Index: AQHZ6jHwPFlyGgRUWUC/YweRJJXDKLAgl3RQ Date: Mon, 18 Sep 2023 13:42:14 +0000 Message-ID: References: <20230918131322.7761-1-nicklew@nvidia.com> In-Reply-To: <20230918131322.7761-1-nicklew@nvidia.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|PH7PR10MB7693:EE_ x-ms-office365-filtering-correlation-id: 720d4462-d5a9-4653-e44a-08dbb84d117d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: w0pLre7ye0ShA8Iyc5WlaY3s8pqgxt/lxmbkPMnSktG3UeQVbZMSQiW6uzXZ7igyT7nVYFpc3H5FJCuCeZMya8tw/wrMzdEX6g0K7SR2KfwfoTOW+8kymiiIGmYt+cVb9vQJP0iusm9+ATw785N5/8dj0RY3cksAbM+8za+BhKwHz+/HY7wOImxAAbZ5jcJ27D2DgurZj9jHYvUAP50zzZ3PxGyqlGOawyNt53xICbeaJWiCeTCp7ZP3INVGWSEQJWNTWNz38ApnnzfPflwwueECojX02scLAH6lsuFad5KGfz+vNAlH4J2qfLINJzpGN/TO/3QbCy4qDAnlWaPmfI5u/GsBgsy1PVVbNdmrpdMuNTCH0f9qxblO9tYRNP23SiY1MvLYKpbGcc456R8G2UnIHS0PAA1OSTF1SShtw/wG6dCp6hxzEcL3Hq4p9lgPg07GPd/SFdZUoqulpqJKTX/u9quU15kmTYGX3jWUG3zIYsb0GD/AiHf6TT76ibF3ojnZ8FcmTx49cDyFztKRBgRC8uaP1vjqMO7XkgejJSZzAmM0/lLPAM9ZrS6zlrrz0hciNtQAZc7+Ho26Pp/aGJjn25PDYHFo+u845Qlu/1FuMZlwB3HR1bHBhuoAM8/V x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?E5B7K2ZPQMRJatLXgzjk+5lL4BErtepNhlNlegQKyHQUotxcqsKJVppTlf4Y?= =?us-ascii?Q?j18Wd13qYzVD74d1aEcWl6NRyzCQ8HNdGAXEp2U4tdlVVbcbNLjVrQlWOHeF?= =?us-ascii?Q?LHdtlTc9eeq4W1gktL1JbyD8zYssvHy89xAZVIZ5iCVm38PsPobtPOe6t+Ml?= =?us-ascii?Q?DH5g70QZodglhMsoL143KHgWzMciHNgpSiSr4O/zQPjC8u+Hg1EHAPkF873D?= =?us-ascii?Q?I2TTbsEVmeNFEt5cupXYMZW59GNgPCBfB2641N2M6k77GVfXqG8CvbSJyq1t?= =?us-ascii?Q?G036JxqpFzabjlhCUF1RW4t3lrrMDXTQP1sc05ui91Suhv0tyjCTf5IKZadt?= =?us-ascii?Q?AVJjvtNX+wpuB1gm2qPAwcNVZWTv1gXlEbdQ+xD+3Vr5TDa/jAt3BDQZfzuA?= =?us-ascii?Q?iLjujBz1P3T9zPAfp0EeCI09AE0EuaepOCpYKtymJgLRPcXAjm5wkdfRwNmn?= =?us-ascii?Q?a/ypqfHrtDDWhi5vx+bi2IqsY5HHq6PagNQCYfei6rjm5zLnlfgJjqHi3PYC?= =?us-ascii?Q?CFvOy1JKIoOZ6PklPXQmhlDgwtfEVU+DwVT7fWzQSt8mETAVq0YoRxNjxzET?= =?us-ascii?Q?/6WoBkc1IB7tqh/QcEtJFwR0rFGFHTTK6ejdO8ulKE7HWAw3KmAJ7TnMN9Ul?= =?us-ascii?Q?KAqPEd+30zZyX7KucxUcZHopkTfK6WcVSkHF3r9YSXJNTmRLVWRdD3KJ2H7/?= =?us-ascii?Q?v932AfLNSWQJFki5RCmEqF5LJZOCgzvMRGmK/Sy96oswy5PIFtS0MThSLFH4?= =?us-ascii?Q?65g8w66h9pN24i7YhwpmQ3LBlFTUoOnBeFr6lqwbh4eJEkQlEczaXEjWregX?= =?us-ascii?Q?b7OjY187hIuReqmgqMbzTI/NP35zM3glS2Rq1u1K/u7ITsxVLqQMHvtoKZ4J?= =?us-ascii?Q?gycAFy9K/ADCNDUbRmY7IzC8jVJo/her1wT1OGOjTmy3fdY086MZhUTFsAps?= =?us-ascii?Q?ofUi5Gr3PAm2p0kTDxOHi7rks6A3E+zbCxNbs+p0q6Pe9j85/2ctaeXhpW5x?= =?us-ascii?Q?CN5k5aU9gLNKdPlusdKfkVdGen/Dgq/xR79KZOLJOBro3jBPUyCfWNumjvos?= =?us-ascii?Q?xb4zL0Tt7HfXSBZ3bfW7c+Qf6zjboeGP20n70VFZ0tcQThRKCc4cKXyhXOPG?= =?us-ascii?Q?uLpgGbN4X/9q2JZDy3Vru51Fr5Ht/p7MvN8e9G09gB2VQA2/UsGqc1wzBeiy?= =?us-ascii?Q?KVcpQKvKlmPjt3kGBX8d1uLq8WweDerzx8hUpOAGbHAHu6jq2XeXXQtAp/pQ?= =?us-ascii?Q?Fd/k4j8+QoOE5PJAPWQJRBs9j/kshOD3FADpQMlC74Ddoe3aWb/v3S4v4xrr?= =?us-ascii?Q?jl2saaG66CKR1KDPtZjIRgGb/WXR6Kf6wffX+sfLRl+wboI55+7xVKiEXSAt?= =?us-ascii?Q?W7k80VEVhqQEv9XGuDu0b1xHi18nRwIqi7O5irPLB83zaxfL0o7LPH1VssQj?= =?us-ascii?Q?J0CVIvyrGPCp7XIe2SF/MITJ/2DazVs0qCsUWXvIpMYML126n9mBMRxn6eC9?= =?us-ascii?Q?CxFviwdSOKBaNok9HQwsJDrq7ZmIJTAEIeLhlsy8vagl3m3PYQBeKtk1dHFn?= =?us-ascii?Q?a5MngStja84lCtxSE3I=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 720d4462-d5a9-4653-e44a-08dbb84d117d X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2023 13:42:14.8299 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9oE+fmMrSk+Mhf8EigLWw5aiEWJO3+VWoNrUzIbnKLpMgEeC20i9mU3V0dtXF6Hm X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB7693 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,igork@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ToQzCvB35ME0npV7tMDeir95x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="No/UHGrW"; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Igor Kulchytskyy Regards, Igor -----Original Message----- From: Nickle Wang Sent: Monday, September 18, 2023 9:13 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Ni= ck Ramirez ; Mike Maslenkin Subject: [EXTERNAL] [PATCH v2] RedfishPkg/RedfishRestExDxe: return HTTP sta= tus code to caller. **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** Return unsupported HTTP status code to caller so caller can handle HTTP error status code. Current implementation only return EFI error to caller. Without knowing the HTTP status code, caller has trouble to handle HTTP request failure. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Cc: Mike Maslenkin --- MdePkg/Include/Protocol/RestEx.h | 3 ++- .../RedfishRestExDxe/RedfishRestExProtocol.c | 27 ++++++++++--------- 2 files changed, 16 insertions(+), 14 deletions(-) diff --git a/MdePkg/Include/Protocol/RestEx.h b/MdePkg/Include/Protocol/Res= tEx.h index e9bc7be94f2c..da9f1c3f87ef 100644 --- a/MdePkg/Include/Protocol/RestEx.h +++ b/MdePkg/Include/Protocol/RestEx.h @@ -131,7 +131,8 @@ typedef struct { response when the data is retrieved from the service. RequestMessage con= tains the HTTP request to the REST resource identified by RequestMessage.Request.Url. T= he ResponseMessage is the returned HTTP response for that request, includin= g any HTTP - status. + status. It's caller's responsibility to free this ResponseMessage using = FreePool(). + RestConfigFreeHttpMessage() in RedfishLib is an example to release Respo= nseMessage structure. @param[in] This Pointer to EFI_REST_EX_PROTOCOL instance= for a particular REST service. diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c b/RedfishP= kg/RedfishRestExDxe/RedfishRestExProtocol.c index 90973619f2bc..5bcdade4b18c 100644 --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c @@ -29,7 +29,8 @@ EFI_REST_EX_PROTOCOL mRedfishRestExProtocol =3D { response when the data is retrieved from the service. RequestMessage con= tains the HTTP request to the REST resource identified by RequestMessage.Request.Url. T= he ResponseMessage is the returned HTTP response for that request, includin= g any HTTP - status. + status. It's caller's responsibility to free this ResponseMessage using = FreePool(). + RestConfigFreeHttpMessage() in RedfishLib is an example to release Respo= nseMessage structure. @param[in] This Pointer to EFI_REST_EX_PROTOCOL instance= for a particular REST service. @@ -320,6 +321,18 @@ ReSendRequest:; DEBUG ((DEBUG_ERROR, "This HTTP Status is not handled!\n")); DumpHttpStatusCode (DEBUG_REDFISH_NETWORK, ResponseData->Response.Stat= usCode); Status =3D EFI_UNSUPPORTED; + + // + // Deliver status code back to caller so caller can handle it. + // + ResponseMessage->Data.Response =3D AllocateZeroPool (sizeof (EFI_HTTP_= RESPONSE_DATA)); + if (ResponseMessage->Data.Response =3D=3D NULL) { + Status =3D EFI_OUT_OF_RESOURCES; + goto ON_EXIT; + } + + ResponseMessage->Data.Response->StatusCode =3D ResponseData->Response.= StatusCode; + goto ON_EXIT; } @@ -443,18 +456,6 @@ ON_EXIT: FreePool (ResponseData); } - if (EFI_ERROR (Status)) { - if (ResponseMessage->Data.Response !=3D NULL) { - FreePool (ResponseMessage->Data.Response); - ResponseMessage->Data.Response =3D NULL; - } - - if (ResponseMessage->Body !=3D NULL) { - FreePool (ResponseMessage->Body); - ResponseMessage->Body =3D NULL; - } - } - return Status; } -- 2.17.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108782): https://edk2.groups.io/g/devel/message/108782 Mute This Topic: https://groups.io/mt/101432753/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-