From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1991C9419E5 for ; Thu, 26 Oct 2023 12:49:43 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Mrut0ujkQcF6ePcMjqSQlaOC3roCRg9dIw2h1VHi8cw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698324582; v=1; b=VsMdnEFsnixnKAzji2ClVjXZMOk3eg41LjR3GdsGzExKsHrNbQYzioBXN+KzjkeORJw85ro5 quk+qF1ntGdXqRVZpDwsJKVEetCelEhPgjMBsr6wanRuvdXLyjf2zeG/TCHLDWruivrbkRq07/M B8dRs88nCYHvk2YHx0V6wFFg= X-Received: by 127.0.0.2 with SMTP id G57fYY7687511xGwq4AWTDOs; Thu, 26 Oct 2023 05:49:42 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.87]) by mx.groups.io with SMTP id smtpd.web10.199179.1698324581314739349 for ; Thu, 26 Oct 2023 05:49:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZCn25gknMdJsKQbRIPlXHfzFx0t4lbGFtUi365y9y0XekeHF7XdC1+7536UG4Kw/yqqbDJI4fzC3+uVB4UtCc+3jsocYysFtWXkeizzN7cWJLbZC79uLVdN+YzCT9iwgWLoX1c5b6io0OcGLgMCxhjpaNiYKT5wqJ2NnUDZSbBOT1BCBNeeZbYfdMKABNs7y4UXFo9iOKTSijk0+rqgjbU43EK+we8SXbCOgjXBMcrrUKJ93tD84gCObNqaekK0fZUtI1BlG+7WOeg5khq6tUgRYUwrz7zdFr0f6FOVS3rJMp2fZDJ27//zkIu1oDYCw6msWvuq8PJYz9hpY5Fvqiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wwn/71MP47Lf6yzEOARtt+peATy50RfWHi2ajp9TW8w=; b=XVmULD4z0b68ciYrNd62In1ZH9WdKPJwrS4hGkCg9YkcBqOEyoyI9g3aicYmJyHS0b4gXkE1s7Cx52wwHGK2BFvvC7Uepg+hBD9Lx/3Ey0tPWxIhDeM4D+CvGPL0w9+W0DUFdcySIC2hBs+1+TFgWvsejw1eSHX/H4ckAQfsZo27OChAI6O/zwqzU628IhzpPj/YNdn0nN8lqSN8eg4BhS2vKnDVcjFE+ZocXu6mIq3nFEpIjd3RX4yvb9h8wlr+8k3CMGkAJhNwJ0u+E3ItuWqGYECzHKU9vkXyEIj1G3vRyjORyV3umStL/6mmHIpEvGIj4u/RqyvO4Ap3+BBTOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by SA2PR10MB4505.namprd10.prod.outlook.com (2603:10b6:806:112::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.22; Thu, 26 Oct 2023 12:49:37 +0000 X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::7126:faa8:8f0b:d58b]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::7126:faa8:8f0b:d58b%5]) with mapi id 15.20.6907.025; Thu, 26 Oct 2023 12:49:37 +0000 From: "Igor Kulchytskyy via groups.io" To: "Chang, Abner" , Nickle Wang , "devel@edk2.groups.io" CC: Nick Ramirez Subject: Re: [edk2-devel] [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller Thread-Topic: [EXTERNAL] RE: [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller Thread-Index: AQHaB9MPSKSfc77G1UahsvaYvRzZ/7BcBbag Date: Thu, 26 Oct 2023 12:49:37 +0000 Message-ID: References: <20231024083944.16275-1-nicklew@nvidia.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=cfbc3f75-dde8-4c77-a5a6-b619356f2f83;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-26T06:09:54Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|SA2PR10MB4505:EE_ x-ms-office365-filtering-correlation-id: 2af3a5a2-a9b9-4ee6-afe6-08dbd622031c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: XZHa6x6n6wukBaU6d+f6KVWaif86iXTkHWvVKP6xoAIKeTOG/z90w+tX3S7QUOTf98ClyVY+18TZQOyPEukFRmAzIemk14S+j87gGRAzBtD/n/VepNapZNMB6b8NED+TWnMeZeZ9La2aQwz8vcCKNEPxj1tRucXh68eJTU+n/W9Lm38drrhEimca206256FIGA7eIUOxMM7/3bMvHzm/Vf+5oKUPVEiheXnHRh107snUY9B0N/TIYLvHbF/56RHzA/asTd40BNf4v2ujcYoNXWEB9V/xI03VN8usHswgIsCbw9ywmRDURKbzGBAXHSjWX5JNhwsANPQPm/FpxZR+OCudjNOkJHXkYWOWWcv9HEzVH2+lm9xAx9uejRytqK8mJaRGVtsx0mo4vV3J1jIQl04bBIng1syeqBQ8zaJuyjchg1Rp6AE5RzTaReOfZPvx1/UqdcJP7v8a64eFtvFpc8t9Br67RwycYHFkC4xw30gkrLvY09k16FhRFwzASduesLIwXb5GuTrcTXoW3CCRIcdVO89RKAfbqrSfR1cTLMjdE1HTbfOf8gtllKjw18k3PtHQ0cbBf7loGekRxB4k5tM2NmRCLqTfM/9oXpLCE/FZB/vOILQxAK0HAHgOy9YW x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HgZr6Zz7wAqDQ4YwjkSdCzKxJqWOxkd/7VSJ0KfdYEK10JraDctJ9TRPxu5j?= =?us-ascii?Q?B33aNarP9ewnEyVa8i1SCZMokH9lkqbt+rp3NbAy5TEIwOoSsgO6N56DBqF1?= =?us-ascii?Q?ypidQQfr83D2qBtqtYxb4ELsWR1k2b1yRPWsga2c+90YhzYGK4+lIBAAyC2S?= =?us-ascii?Q?2ewjEbXC9SMjc/BFdImalvhHrb8oF8yy7ipdr+08ag3a1VsU8X2fM8Xe4PnR?= =?us-ascii?Q?Y8SYHqW9PtYXL7MtR2NgkYr7UrbiD5M0fmUStRwDpgDjVbgjkZT5sXv+8uks?= =?us-ascii?Q?5W0Fo1xRiupUnBpaEIiEXXMjpGlZMsCnKISTo4irjfew6jF1PNC+Xx/SPldu?= =?us-ascii?Q?Z2Nsvm0KnAjckek9dNCSC6dTTh1tdB/GltqL5VChZ9eNfg/WjGw6nZhwY+cL?= =?us-ascii?Q?uv0vbfs9Kv5D1F/Z9f45iqsQ3UALkzy/npXlvogLMhVlWrLRC+hTjVUHwRtF?= =?us-ascii?Q?OKZ6qRQCTUmTGXibBNSXH+vPDjzKCEE2w9bHd7tC7qBAxmNtnHjFpvDMJZLQ?= =?us-ascii?Q?O4O8spph9Ea9pZrDamBJXdY4vIzBjOUhPx+EDkwE23I68Nczp2pSooTZf3hz?= =?us-ascii?Q?MmilycF2thnNCOJ40tfINl0H89D3in/7nRGAIN1kqDjk3pO2tmumL8vlzcQ6?= =?us-ascii?Q?h/jzi+R7r4D9TYIGl8y2g7gdg6UP/XPwrUdjEVTRq3eQ43vtif/CIzJCRKbM?= =?us-ascii?Q?5+zbf8A06CSVPWuS6yZbcGCSMKIGK2Sa2l45nUGT6cNoVSwO2/8ikGNEv5Wx?= =?us-ascii?Q?p/IYOKFi8QVZtizdLxnS7YbqmuuroExlPjKYfsufCqCUJBamCxIJ+oFmdcoo?= =?us-ascii?Q?z7sEpV76N/cNSZlM/NjLEBoChGwqE3qjOQWTPt3BnZ3AQQciv9VAuPAIiwMF?= =?us-ascii?Q?n7nvhDstttI6Eq9Qsu6GodqylX/Wg09n6X9tHdK8lPhKr07gR3uQGpt1PJnl?= =?us-ascii?Q?0puMLL8lUAzMgee+/CFJJxeRio3xHT7/nR4ntB58wtKDaT47wsSSLyejX7gs?= =?us-ascii?Q?DtPw5p/j7hfulVlN9u1EjKetNRaqPfRgAiOXsrmlB4KADDNcH0PNz1mURoXo?= =?us-ascii?Q?6L6FygGhpvEXo98DmDtdaCFi2ru+x6STjCEwXY5A2kMC3chCI0ADDADv/jqp?= =?us-ascii?Q?Vpv0KakQDs2nkuwgMzqk8t7csd4Rh0K8ux978XYF6qFskTte8Pi2dVIPfTgH?= =?us-ascii?Q?dxggfC+IwK8U2iYAqO1e1mf6JdRiTr0ZhRvMAQ7T4nFfZZrrDhx4KWLL2Joi?= =?us-ascii?Q?vRVA7xKpFEevgEfzk/e4WzD6WbHmuWFwLNGpkILrRSudLGmrENkpuPieIMR7?= =?us-ascii?Q?Quu5vRAT7/F+nxtu0vjzBgeFbSyjYYd6ob7JKqF/En0jkTRhSZ0Nh0ijuvCz?= =?us-ascii?Q?FW2SzM2HnkDV+WqlhDZqlP5N8KfUo3fXk7zGLiyObCbwy0lYOv4gHtW5I0+6?= =?us-ascii?Q?UTaw7LDWRzXSdazpHU6AXFJsWaH37uvMMDpETJ/wfc/W3mZ3o7zSH696kt9m?= =?us-ascii?Q?oZwBspNJOIxpNRwvtzwUhGGDu81tlboBYRetE5hC9icJnsQWqdKph4kJMw8t?= =?us-ascii?Q?gO1qvY8Vsp5zPxcxbk4=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2af3a5a2-a9b9-4ee6-afe6-08dbd622031c X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2023 12:49:37.2022 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qwX3Rd9wVDNZX5JfunXbcPEmGyenrr7hCneQgT18/1BVTd83FfikE1TGuNVB3Sn4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4505 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,igork@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: MbPoSEpGVoEZpFh3e5gy3bQxx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=VsMdnEFs; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Nickle, Just one quick question. Is there any sense to return the headers for DELETE request? Thank you, Igor -----Original Message----- From: Chang, Abner Sent: Thursday, October 26, 2023 2:10 AM To: Nickle Wang ; devel@edk2.groups.io Cc: Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] RE: [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP head= ers to caller **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Tuesday, October 24, 2023 4:40 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Call Ex interface to get HTTP headers and return to caller. > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > --- > RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > b/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > index f4045044829a..5e06d516ba84 100644 > --- a/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > +++ b/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > @@ -356,7 +356,7 @@ RedfishGetByUri ( > > ZeroMem (RedResponse, sizeof (REDFISH_RESPONSE)); > > - JsonValue =3D getUriFromService (RedfishService, Uri, &RedR= esponse- > >StatusCode); > + JsonValue =3D getUriFromServiceEx (RedfishService, Uri, &Re= dResponse- > >Headers, &RedResponse->HeaderCount, &RedResponse->StatusCode); > RedResponse->Payload =3D createRedfishPayload (JsonValue, RedfishServi= ce); > > // > @@ -498,10 +498,12 @@ RedfishPatchToUri ( > > ZeroMem (RedResponse, sizeof (REDFISH_RESPONSE)); > > - JsonValue =3D (EDKII_JSON_VALUE)patchUriFromService ( > + JsonValue =3D (EDKII_JSON_VALUE)patchUriFromServiceEx ( > RedfishService, > Uri, > Content, > + &(RedResponse->Headers), > + &(RedResponse->HeaderCount), > &(RedResponse->StatusCode) > ); > > @@ -661,12 +663,14 @@ RedfishPostToUri ( > > ZeroMem (RedResponse, sizeof (REDFISH_RESPONSE)); > > - JsonValue =3D (EDKII_JSON_VALUE)postUriFromService ( > + JsonValue =3D (EDKII_JSON_VALUE)postUriFromServiceEx ( > RedfishService, > Uri, > Content, > ContentSize, > ContentType, > + &(RedResponse->Headers), > + &(RedResponse->HeaderCount), > &(RedResponse->StatusCode) > ); > > -- > 2.17.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110095): https://edk2.groups.io/g/devel/message/110095 Mute This Topic: https://groups.io/mt/102154017/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-