From: "Igor Kulchytskyy via groups.io" <igork=ami.com@groups.io>
To: "Chang, Abner" <Abner.Chang@amd.com>,
Nickle Wang <nicklew@nvidia.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Nick Ramirez <nramirez@nvidia.com>
Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: rename x-uefi-redfish to x-UEFI-redfish
Date: Mon, 6 May 2024 12:48:39 +0000 [thread overview]
Message-ID: <BLAPR10MB518564CE6CD1BE4BDD8D6B9EA81C2@BLAPR10MB5185.namprd10.prod.outlook.com> (raw)
In-Reply-To: <LV8PR12MB94527827869FB3AF0F039DBDEA1F2@LV8PR12MB9452.namprd12.prod.outlook.com>
Reviewed-by: Igor Kulchytskyy <igork@ami.com>
Regards,
Igor
-----Original Message-----
From: Chang, Abner <Abner.Chang@amd.com>
Sent: Thursday, May 02, 2024 11:49 PM
To: Nickle Wang <nicklew@nvidia.com>; devel@edk2.groups.io
Cc: Igor Kulchytskyy <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
Subject: [EXTERNAL] RE: [edk2-redfish-client][PATCH] RedfishClientPkg: rename x-uefi-redfish to x-UEFI-redfish
**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**
[AMD Official Use Only - General]
Reviewed-by: Abner Chang <abner.chang@amd.com>
> -----Original Message-----
> From: Nickle Wang <nicklew@nvidia.com>
> Sent: Friday, May 3, 2024 9:57 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
> Subject: [edk2-redfish-client][PATCH] RedfishClientPkg: rename x-uefi-redfish
> to x-UEFI-redfish
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Rename x-uefi-redfish to x-UEFI-redfish to match the format of
> UEFI configuration namespace prefix.
>
> RFC: https://edk2.groups.io/g/rfc/message/849
>
> Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> Co-authored-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: Nick Ramirez <nramirez@nvidia.com>
> ---
> .../Features/Bios/v1_0_9/Common/BiosCommon.h | 2 +-
> .../v1_0_4/Common/BootOptionCommon.h | 2 +-
> .../v1_13_0/Common/ComputerSystemCommon.h | 2 +-
> .../v1_5_0/Common/ComputerSystemCommon.h | 2 +-
> .../Memory/V1_7_1/Common/MemoryCommon.h | 2 +-
> .../HiiToRedfishBootDxe/HiiToRedfishBootDxe.h | 2 +-
> .../EdkIIRedfishResourceConfigInternal.h | 2 +-
> .../RedfishFeatureUtilityInternal.h | 2 +-
> .../HiiToRedfishBootDxe/HiiToRedfishBootDxe.c | 4 +-
> .../Media/RedfishClientDriverStack.svg | 2 +-
> .../HiiToRedfishBiosDxeMap.uni | 16 +++---
> .../HiiToRedfishBootDxeMap.uni | 32 +++++------
> .../HiiToRedfishMemoryDxeMap.uni | 56 +++++++++----------
> RedfishClientPkg/Readme.md | 41 +++++++-------
> 14 files changed, 84 insertions(+), 83 deletions(-)
>
> diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.h
> b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.h
> index 9a6f9684b..50772d5da 100644
> --- a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.h
> +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.h
> @@ -24,7 +24,7 @@
> #define RESOURCE_SCHEMA_VERSION "v1_0_9"
> #define REDPATH_ARRAY_PATTERN L"/Bios/.*"
> #define REDPATH_ARRAY_PREFIX L"/Bios/"
> -#define RESOURCE_SCHEMA_FULL "x-uefi-redfish-Bios.v1_0_9"
> +#define RESOURCE_SCHEMA_FULL "x-UEFI-redfish-Bios.v1_0_9"
> #define REDFISH_SCHEMA_NAME "ComputerSystem"
>
> #endif
> diff --git
> a/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCom
> mon.h
> b/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCom
> mon.h
> index 83babf16f..9293d22cd 100644
> ---
> a/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCom
> mon.h
> +++
> b/RedfishClientPkg/Features/BootOption/v1_0_4/Common/BootOptionCom
> mon.h
> @@ -27,7 +27,7 @@
> #define RESOURCE_SCHEMA_VERSION "v1_0_4"
> #define REDPATH_ARRAY_PATTERN L"/BootOptions/\\{.*\\}/"
> #define REDPATH_ARRAY_PREFIX L"/BootOptions/"
> -#define RESOURCE_SCHEMA_FULL "x-uefi-redfish-BootOption.v1_0_4"
> +#define RESOURCE_SCHEMA_FULL "x-UEFI-redfish-
> BootOption.v1_0_4"
> #define REDFISH_BOOT_OPTION_PARAMETER L"?name="
> #define REDFISH_BOOT_OPTION_DEBUG_TRACE DEBUG_INFO
> #endif
> diff --git
> a/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/Compute
> rSystemCommon.h
> b/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/Compute
> rSystemCommon.h
> index 7b83d2939..b5e3fa919 100644
> ---
> a/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/Compute
> rSystemCommon.h
> +++
> b/RedfishClientPkg/Features/ComputerSystem/v1_13_0/Common/Compute
> rSystemCommon.h
> @@ -24,6 +24,6 @@
> #define RESOURCE_SCHEMA_VERSION "v1_13_0"
> #define REDPATH_ARRAY_PATTERN L"/Systems/\\{.*\\}/"
> #define REDPATH_ARRAY_PREFIX L"/Systems/"
> -#define RESOURCE_SCHEMA_FULL "x-uefi-redfish-
> ComputerSystem.v1_13_0"
> +#define RESOURCE_SCHEMA_FULL "x-UEFI-redfish-
> ComputerSystem.v1_13_0"
>
> #endif
> diff --git
> a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/Computer
> SystemCommon.h
> b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/Computer
> SystemCommon.h
> index a0eb41b8b..24a484d18 100644
> ---
> a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/Computer
> SystemCommon.h
> +++
> b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/Computer
> SystemCommon.h
> @@ -22,6 +22,6 @@
> #define RESOURCE_SCHEMA_VERSION "v1_5_0"
> #define REDPATH_ARRAY_PATTERN L"/Systems/\\{.*\\}/"
> #define REDPATH_ARRAY_PREFIX L"/Systems/"
> -#define RESOURCE_SCHEMA_FULL "x-uefi-redfish-
> ComputerSystem.v1_5_0"
> +#define RESOURCE_SCHEMA_FULL "x-UEFI-redfish-
> ComputerSystem.v1_5_0"
>
> #endif
> diff --git
> a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.
> h
> b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.
> h
> index c857868ea..2120dc0e4 100644
> ---
> a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.
> h
> +++
> b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.
> h
> @@ -22,6 +22,6 @@
> #define RESOURCE_SCHEMA_VERSION "v1_7_1"
> #define REDPATH_ARRAY_PATTERN L"/Memory/\\{.*\\}/"
> #define REDPATH_ARRAY_PREFIX L"/Memory/"
> -#define RESOURCE_SCHEMA_FULL "x-uefi-redfish-Memory.v1_7_1"
> +#define RESOURCE_SCHEMA_FULL "x-UEFI-redfish-Memory.v1_7_1"
>
> #endif
> diff --git a/RedfishClientPkg/HiiToRedfishBootDxe/HiiToRedfishBootDxe.h
> b/RedfishClientPkg/HiiToRedfishBootDxe/HiiToRedfishBootDxe.h
> index 40a41d01b..455140536 100644
> --- a/RedfishClientPkg/HiiToRedfishBootDxe/HiiToRedfishBootDxe.h
> +++ b/RedfishClientPkg/HiiToRedfishBootDxe/HiiToRedfishBootDxe.h
> @@ -36,7 +36,7 @@
>
> extern UINT8 HiiToRedfishBootVfrBin[];
>
> -#define COMPUTER_SYSTEM_SCHEMA_VERSION "x-uefi-redfish-
> ComputerSystem.v1_5_0"
> +#define COMPUTER_SYSTEM_SCHEMA_VERSION "x-UEFI-redfish-
> ComputerSystem.v1_5_0"
> #define COMPUTER_SYSTEM_BOOT_BOOTORDER
> L"/Systems/{1}/Boot/BootOrder"
>
> #pragma pack(1)
> diff --git
> a/RedfishClientPkg/Library/EdkIIRedfishResourceConfigLib/EdkIIRedfishReso
> urceConfigInternal.h
> b/RedfishClientPkg/Library/EdkIIRedfishResourceConfigLib/EdkIIRedfishReso
> urceConfigInternal.h
> index 51984738b..7416b0c85 100644
> ---
> a/RedfishClientPkg/Library/EdkIIRedfishResourceConfigLib/EdkIIRedfishReso
> urceConfigInternal.h
> +++
> b/RedfishClientPkg/Library/EdkIIRedfishResourceConfigLib/EdkIIRedfishReso
> urceConfigInternal.h
> @@ -38,7 +38,7 @@ typedef struct {
> REDFISH_SCHEMA_INFO SchemaInfoCache;
> } REDFISH_CONFIG_PROTOCOL_CACHE;
>
> -#define SCHEMA_NAME_PREFIX "x-uefi-redfish-"
> +#define SCHEMA_NAME_PREFIX "x-UEFI-redfish-"
> #define SCHEMA_NAME_PREFIX_OFFSET (AsciiStrLen
> (SCHEMA_NAME_PREFIX))
>
> #endif
> diff --git
> a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityInte
> rnal.h
> b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityInte
> rnal.h
> index b1c2ee468..54c5c6dea 100644
> ---
> a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityInte
> rnal.h
> +++
> b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityInte
> rnal.h
> @@ -39,7 +39,7 @@
> #define INDEX_VARIABLE_SIZE 64
> #define INDEX_STRING_SIZE 16
> #define INDEX_STRING L"{%d}"
> -#define SCHEMA_NAME_PREFIX "x-uefi-redfish-"
> +#define SCHEMA_NAME_PREFIX "x-UEFI-redfish-"
> #define SCHEMA_NAME_PREFIX_OFFSET (AsciiStrLen
> (SCHEMA_NAME_PREFIX))
> #define REDFISH_ROOT_PATH "/v1"
> #define REDFISH_ROOT_PATH_UNICODE L"/v1"
> diff --git a/RedfishClientPkg/HiiToRedfishBootDxe/HiiToRedfishBootDxe.c
> b/RedfishClientPkg/HiiToRedfishBootDxe/HiiToRedfishBootDxe.c
> index 3274aae9c..aa6563c04 100644
> --- a/RedfishClientPkg/HiiToRedfishBootDxe/HiiToRedfishBootDxe.c
> +++ b/RedfishClientPkg/HiiToRedfishBootDxe/HiiToRedfishBootDxe.c
> @@ -43,7 +43,7 @@ HII_VENDOR_DEVICE_PATH mHiiVendorDevicePath = {
> };
>
> /**
> - This function add 'x-uefi-' configuration language to given string ID.
> + This function add 'x-UEFI-' configuration language to given string ID.
>
> @param[in] HiiHandle HII handle
> @param[in] StringId String token ID
> @@ -80,7 +80,7 @@ UpdateConfigLanguageToQuestion (
> }
>
> /**
> - This function add 'x-uefi-' configuration language to given string ID.
> + This function add 'x-UEFI-' configuration language to given string ID.
>
> @param[in] HiiHandle HII handle
> @param[in] StringId String token ID
> diff --git a/RedfishClientPkg/Documents/Media/RedfishClientDriverStack.svg
> b/RedfishClientPkg/Documents/Media/RedfishClientDriverStack.svg
> index 913c941e7..1a0172388 100644
> --- a/RedfishClientPkg/Documents/Media/RedfishClientDriverStack.svg
> +++ b/RedfishClientPkg/Documents/Media/RedfishClientDriverStack.svg
> @@ -706,7 +706,7 @@
> x="11.39" dy="1em" class="st5">Redfish Collection
> Driver</tspan></text> </g>
> <g id="shape98-229" v:mID="98" v:groupContext="shape"
> transform="translate(67.3474,-432)">
> <title>Rounded Rectangle.98</title>
> - <desc>EDK2 HII UNI file #string STR_OPTION_A #language x-uefi-
> redfi...</desc>
> + <desc>EDK2 HII UNI file #string STR_OPTION_A #language x-UEFI-
> redfi...</desc>
> <v:userDefs>
> <v:ud v:nameU="CTypeTopLeftSnip" v:prompt=""
> v:val="VT0(0):5"/>
> <v:ud v:nameU="CTypeTopRightSnip" v:prompt=""
> v:val="VT0(0):5"/>
> diff --git
> a/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosDxeMap.uni
> b/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosDxeMap.uni
> index a41c65fef..6f50072de 100644
> --- a/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosDxeMap.uni
> +++ b/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosDxeMap.uni
> @@ -9,13 +9,13 @@
> **/
>
> /=#
> -#langdef x-uefi-redfish-Bios.v1_0_9 "Bios.v1_0_9"
> +#langdef x-UEFI-redfish-Bios.v1_0_9 "Bios.v1_0_9"
>
> -#string STR_BIOS_OPTION_1_PROMPT #language x-uefi-redfish-
> Bios.v1_0_9 "/Bios/Attributes/BiosOption1"
> -#string STR_BIOS_OPTION_2_PROMPT #language x-uefi-redfish-
> Bios.v1_0_9 "/Bios/Attributes/BiosOption2"
> -#string STR_BIOS_OPTION_3_PROMPT #language x-uefi-redfish-
> Bios.v1_0_9 "/Bios/Attributes/BiosOption3"
> -#string STR_BIOS_OPTION_4_PROMPT #language x-uefi-redfish-
> Bios.v1_0_9 "/Bios/Attributes/BiosOption4"
> +#string STR_BIOS_OPTION_1_PROMPT #language x-UEFI-redfish-
> Bios.v1_0_9 "/Bios/Attributes/BiosOption1"
> +#string STR_BIOS_OPTION_2_PROMPT #language x-UEFI-redfish-
> Bios.v1_0_9 "/Bios/Attributes/BiosOption2"
> +#string STR_BIOS_OPTION_3_PROMPT #language x-UEFI-redfish-
> Bios.v1_0_9 "/Bios/Attributes/BiosOption3"
> +#string STR_BIOS_OPTION_4_PROMPT #language x-UEFI-redfish-
> Bios.v1_0_9 "/Bios/Attributes/BiosOption4"
>
> -#string STR_BIOS_OPTION_1_ITEM_1 #language x-uefi-redfish-
> Bios.v1_0_9 "Item #1"
> -#string STR_BIOS_OPTION_1_ITEM_2 #language x-uefi-redfish-
> Bios.v1_0_9 "Item #2"
> -#string STR_BIOS_OPTION_1_ITEM_3 #language x-uefi-redfish-
> Bios.v1_0_9 "Item #3"
> +#string STR_BIOS_OPTION_1_ITEM_1 #language x-UEFI-redfish-
> Bios.v1_0_9 "Item #1"
> +#string STR_BIOS_OPTION_1_ITEM_2 #language x-UEFI-redfish-
> Bios.v1_0_9 "Item #2"
> +#string STR_BIOS_OPTION_1_ITEM_3 #language x-UEFI-redfish-
> Bios.v1_0_9 "Item #3"
> diff --git
> a/RedfishClientPkg/HiiToRedfishBootDxe/HiiToRedfishBootDxeMap.uni
> b/RedfishClientPkg/HiiToRedfishBootDxe/HiiToRedfishBootDxeMap.uni
> index 995fa45b2..e7920ea5e 100644
> --- a/RedfishClientPkg/HiiToRedfishBootDxe/HiiToRedfishBootDxeMap.uni
> +++ b/RedfishClientPkg/HiiToRedfishBootDxe/HiiToRedfishBootDxeMap.uni
> @@ -9,21 +9,21 @@
> **/
>
> /=#
> -#langdef x-uefi-redfish-ComputerSystem.v1_5_0
> "ComputerSystem.v1_5_0"
> +#langdef x-UEFI-redfish-ComputerSystem.v1_5_0
> "ComputerSystem.v1_5_0"
>
> -#string STR_BOOT_SOURCE_OVERRIDE_ENABLED #language x-uefi-
> redfish-ComputerSystem.v1_5_0
> "/Systems/{1}/Boot/BootSourceOverrideEnabled"
> -#string STR_BOOT_SOURCE_OVERRIDE_MODE #language x-uefi-redfish-
> ComputerSystem.v1_5_0 "/Systems/{1}/Boot/BootSourceOverrideMode"
> -#string STR_BOOT_SOURCE_OVERRIDE_TARGET #language x-uefi-redfish-
> ComputerSystem.v1_5_0 "/Systems/{1}/Boot/BootSourceOverrideTarget"
> +#string STR_BOOT_SOURCE_OVERRIDE_ENABLED #language x-UEFI-
> redfish-ComputerSystem.v1_5_0
> "/Systems/{1}/Boot/BootSourceOverrideEnabled"
> +#string STR_BOOT_SOURCE_OVERRIDE_MODE #language x-UEFI-
> redfish-ComputerSystem.v1_5_0
> "/Systems/{1}/Boot/BootSourceOverrideMode"
> +#string STR_BOOT_SOURCE_OVERRIDE_TARGET #language x-UEFI-
> redfish-ComputerSystem.v1_5_0
> "/Systems/{1}/Boot/BootSourceOverrideTarget"
>
> -#string STR_DISABLED #language x-uefi-redfish-
> ComputerSystem.v1_5_0 "Disabled"
> -#string STR_ONCE #language x-uefi-redfish-
> ComputerSystem.v1_5_0 "Once"
> -#string STR_CONTINUOUS #language x-uefi-redfish-
> ComputerSystem.v1_5_0 "Continuous"
> -#string STR_UEFI #language x-uefi-redfish-
> ComputerSystem.v1_5_0 "UEFI"
> -#string STR_LEGACY #language x-uefi-redfish-
> ComputerSystem.v1_5_0 "Legacy"
> -#string STR_TARGET_NONE #language x-uefi-redfish-
> ComputerSystem.v1_5_0 "None"
> -#string STR_TARGET_PXE #language x-uefi-redfish-
> ComputerSystem.v1_5_0 "Pxe"
> -#string STR_TARGET_USB #language x-uefi-redfish-
> ComputerSystem.v1_5_0 "Usb"
> -#string STR_TARGET_HDD #language x-uefi-redfish-
> ComputerSystem.v1_5_0 "Hdd"
> -#string STR_TARGET_BIOS_SETUP #language x-uefi-redfish-
> ComputerSystem.v1_5_0 "BiosSetup"
> -#string STR_TARGET_UEFI #language x-uefi-redfish-
> ComputerSystem.v1_5_0 "UefiTarget"
> -#string STR_TARGET_UEFI_HTTP #language x-uefi-redfish-
> ComputerSystem.v1_5_0 "UefiHttp"
> +#string STR_DISABLED #language x-UEFI-redfish-
> ComputerSystem.v1_5_0 "Disabled"
> +#string STR_ONCE #language x-UEFI-redfish-
> ComputerSystem.v1_5_0 "Once"
> +#string STR_CONTINUOUS #language x-UEFI-redfish-
> ComputerSystem.v1_5_0 "Continuous"
> +#string STR_UEFI #language x-UEFI-redfish-
> ComputerSystem.v1_5_0 "UEFI"
> +#string STR_LEGACY #language x-UEFI-redfish-
> ComputerSystem.v1_5_0 "Legacy"
> +#string STR_TARGET_NONE #language x-UEFI-redfish-
> ComputerSystem.v1_5_0 "None"
> +#string STR_TARGET_PXE #language x-UEFI-redfish-
> ComputerSystem.v1_5_0 "Pxe"
> +#string STR_TARGET_USB #language x-UEFI-redfish-
> ComputerSystem.v1_5_0 "Usb"
> +#string STR_TARGET_HDD #language x-UEFI-redfish-
> ComputerSystem.v1_5_0 "Hdd"
> +#string STR_TARGET_BIOS_SETUP #language x-UEFI-redfish-
> ComputerSystem.v1_5_0 "BiosSetup"
> +#string STR_TARGET_UEFI #language x-UEFI-redfish-
> ComputerSystem.v1_5_0 "UefiTarget"
> +#string STR_TARGET_UEFI_HTTP #language x-UEFI-redfish-
> ComputerSystem.v1_5_0 "UefiHttp"
> diff --git
> a/RedfishClientPkg/HiiToRedfishMemoryDxe/HiiToRedfishMemoryDxeMap.u
> ni
> b/RedfishClientPkg/HiiToRedfishMemoryDxe/HiiToRedfishMemoryDxeMap.u
> ni
> index be1b83328..0633de589 100644
> ---
> a/RedfishClientPkg/HiiToRedfishMemoryDxe/HiiToRedfishMemoryDxeMap.u
> ni
> +++
> b/RedfishClientPkg/HiiToRedfishMemoryDxe/HiiToRedfishMemoryDxeMap.u
> ni
> @@ -9,31 +9,31 @@
> **/
>
> /=#
> -#langdef x-uefi-redfish-Memory.v1_7_1 "Memory.v1_7_1"
> -
> -#string STR_MEMORY_1_BASE_MODULE_TYPE_PROMPT #language x-
> uefi-redfish-Memory.v1_7_1 "/Memory/{1}/BaseModuleType"
> -#string STR_MEMORY_1_BUS_WIDTH_BITS_PROMPT #language x-uefi-
> redfish-Memory.v1_7_1 "/Memory/{1}/BusWidthBits"
> -#string STR_MEMORY_1_CONFIGURATION_LOCKED_PROMPT #language x-
> uefi-redfish-Memory.v1_7_1 "/Memory/{1}/ConfigurationLocked"
> -#string STR_MEMORY_1_MODULE_PRODUCT_ID_PROMPT #language x-
> uefi-redfish-Memory.v1_7_1 "/Memory/{1}/ModuleProductID"
> -
> -#string STR_MEMORY_2_BASE_MODULE_TYPE_PROMPT #language x-
> uefi-redfish-Memory.v1_7_1 "/Memory/{2}/BaseModuleType"
> -#string STR_MEMORY_2_BUS_WIDTH_BITS_PROMPT #language x-uefi-
> redfish-Memory.v1_7_1 "/Memory/{2}/BusWidthBits"
> -#string STR_MEMORY_2_CONFIGURATION_LOCKED_PROMPT #language x-
> uefi-redfish-Memory.v1_7_1 "/Memory/{2}/ConfigurationLocked"
> -#string STR_MEMORY_2_MODULE_PRODUCT_ID_PROMPT #language x-
> uefi-redfish-Memory.v1_7_1 "/Memory/{2}/ModuleProductID"
> -
> -#string STR_MEMORY_3_BASE_MODULE_TYPE_PROMPT #language x-
> uefi-redfish-Memory.v1_7_1 "/Memory/{3}/BaseModuleType"
> -#string STR_MEMORY_3_BUS_WIDTH_BITS_PROMPT #language x-uefi-
> redfish-Memory.v1_7_1 "/Memory/{3}/BusWidthBits"
> -#string STR_MEMORY_3_CONFIGURATION_LOCKED_PROMPT #language x-
> uefi-redfish-Memory.v1_7_1 "/Memory/{3}/ConfigurationLocked"
> -#string STR_MEMORY_3_MODULE_PRODUCT_ID_PROMPT #language x-
> uefi-redfish-Memory.v1_7_1 "/Memory/{3}/ModuleProductID"
> -
> -#string STR_MEMORY_4_BASE_MODULE_TYPE_PROMPT #language x-
> uefi-redfish-Memory.v1_7_1 "/Memory/{5}/BaseModuleType"
> -#string STR_MEMORY_4_BUS_WIDTH_BITS_PROMPT #language x-uefi-
> redfish-Memory.v1_7_1 "/Memory/{5}/BusWidthBits"
> -#string STR_MEMORY_4_CONFIGURATION_LOCKED_PROMPT #language x-
> uefi-redfish-Memory.v1_7_1 "/Memory/{5}/ConfigurationLocked"
> -#string STR_MEMORY_4_MODULE_PRODUCT_ID_PROMPT #language x-
> uefi-redfish-Memory.v1_7_1 "/Memory/{5}/ModuleProductID"
> -
> -#string STR_MEMORY_RDIMM_PROMPT #language x-uefi-redfish-
> Memory.v1_7_1 "RDIMM"
> -#string STR_MEMORY_UDIMM_PROMPT #language x-uefi-redfish-
> Memory.v1_7_1 "UDIMM"
> -#string STR_MEMORY_SO_DIMM_PROMPT #language x-uefi-
> redfish-Memory.v1_7_1 "SO_DIMM"
> -#string STR_MEMORY_LRDIMM_PROMPT #language x-uefi-redfish-
> Memory.v1_7_1 "LRDIMM"
> -#string STR_MEMORY_MINI_RDIMM_PROMPT #language x-uefi-
> redfish-Memory.v1_7_1 "Mini_RDIMM"
> -#string STR_MEMORY_MINI_UDIMM_PROMPT #language x-uefi-
> redfish-Memory.v1_7_1 "Mini_UDIMM"
> +#langdef x-UEFI-redfish-Memory.v1_7_1 "Memory.v1_7_1"
> +
> +#string STR_MEMORY_1_BASE_MODULE_TYPE_PROMPT #language x-
> UEFI-redfish-Memory.v1_7_1 "/Memory/{1}/BaseModuleType"
> +#string STR_MEMORY_1_BUS_WIDTH_BITS_PROMPT #language x-UEFI-
> redfish-Memory.v1_7_1 "/Memory/{1}/BusWidthBits"
> +#string STR_MEMORY_1_CONFIGURATION_LOCKED_PROMPT #language
> x-UEFI-redfish-Memory.v1_7_1 "/Memory/{1}/ConfigurationLocked"
> +#string STR_MEMORY_1_MODULE_PRODUCT_ID_PROMPT #language x-
> UEFI-redfish-Memory.v1_7_1 "/Memory/{1}/ModuleProductID"
> +
> +#string STR_MEMORY_2_BASE_MODULE_TYPE_PROMPT #language x-
> UEFI-redfish-Memory.v1_7_1 "/Memory/{2}/BaseModuleType"
> +#string STR_MEMORY_2_BUS_WIDTH_BITS_PROMPT #language x-UEFI-
> redfish-Memory.v1_7_1 "/Memory/{2}/BusWidthBits"
> +#string STR_MEMORY_2_CONFIGURATION_LOCKED_PROMPT #language
> x-UEFI-redfish-Memory.v1_7_1 "/Memory/{2}/ConfigurationLocked"
> +#string STR_MEMORY_2_MODULE_PRODUCT_ID_PROMPT #language x-
> UEFI-redfish-Memory.v1_7_1 "/Memory/{2}/ModuleProductID"
> +
> +#string STR_MEMORY_3_BASE_MODULE_TYPE_PROMPT #language x-
> UEFI-redfish-Memory.v1_7_1 "/Memory/{3}/BaseModuleType"
> +#string STR_MEMORY_3_BUS_WIDTH_BITS_PROMPT #language x-UEFI-
> redfish-Memory.v1_7_1 "/Memory/{3}/BusWidthBits"
> +#string STR_MEMORY_3_CONFIGURATION_LOCKED_PROMPT #language
> x-UEFI-redfish-Memory.v1_7_1 "/Memory/{3}/ConfigurationLocked"
> +#string STR_MEMORY_3_MODULE_PRODUCT_ID_PROMPT #language x-
> UEFI-redfish-Memory.v1_7_1 "/Memory/{3}/ModuleProductID"
> +
> +#string STR_MEMORY_4_BASE_MODULE_TYPE_PROMPT #language x-
> UEFI-redfish-Memory.v1_7_1 "/Memory/{5}/BaseModuleType"
> +#string STR_MEMORY_4_BUS_WIDTH_BITS_PROMPT #language x-UEFI-
> redfish-Memory.v1_7_1 "/Memory/{5}/BusWidthBits"
> +#string STR_MEMORY_4_CONFIGURATION_LOCKED_PROMPT #language
> x-UEFI-redfish-Memory.v1_7_1 "/Memory/{5}/ConfigurationLocked"
> +#string STR_MEMORY_4_MODULE_PRODUCT_ID_PROMPT #language x-
> UEFI-redfish-Memory.v1_7_1 "/Memory/{5}/ModuleProductID"
> +
> +#string STR_MEMORY_RDIMM_PROMPT #language x-UEFI-
> redfish-Memory.v1_7_1 "RDIMM"
> +#string STR_MEMORY_UDIMM_PROMPT #language x-UEFI-
> redfish-Memory.v1_7_1 "UDIMM"
> +#string STR_MEMORY_SO_DIMM_PROMPT #language x-UEFI-
> redfish-Memory.v1_7_1 "SO_DIMM"
> +#string STR_MEMORY_LRDIMM_PROMPT #language x-UEFI-
> redfish-Memory.v1_7_1 "LRDIMM"
> +#string STR_MEMORY_MINI_RDIMM_PROMPT #language x-UEFI-
> redfish-Memory.v1_7_1 "Mini_RDIMM"
> +#string STR_MEMORY_MINI_UDIMM_PROMPT #language x-UEFI-
> redfish-Memory.v1_7_1 "Mini_UDIMM"
> diff --git a/RedfishClientPkg/Readme.md b/RedfishClientPkg/Readme.md
> index 1789dff6f..bfb9d116c 100644
> --- a/RedfishClientPkg/Readme.md
> +++ b/RedfishClientPkg/Readme.md
> @@ -106,7 +106,7 @@ On EDK2 open source, EDKII Redfish Platform Config
> Protocol accesses the
> platform configuration in EDK2 HII defined format. Below is driver stack
> diagram
> which implements EDKII Redfish Platform Config Protocol. The protocol driver
> leverages the HII interface to get or set the HII configuration on platform. By
> -following the x-uefi-redfish Configure Language defined in UNI file, protocol
> +following the x-UEFI-redfish Configure Language defined in UNI file, protocol
> driver can find corresponding HII question for given Redfish attribute. In this
> way, protocol driver creates the mapping between HII questions and Redfish
> attributes.
> @@ -177,24 +177,25 @@ scope, **EFI_IFR_FLAG_REST_STYLE** can be
> assigned to the HII options that
> indicate those options intend to interact with the REST service.
>
> ### EDK2 HII UNI file ***[[9]](#[0])***
> -x-uefi-redfish Configure Language is used in UNI file to associate HII option
> +By following the concept of [UEFI Configuration
> Namespace](https://uefi.org/namespace_instructions), x-UEFI-redfish
> Configure
> +Language is created and used in UNI file to associate HII option
> with the particular Redfish property. The Hii options interact with EDK2
> Redfish
> -Feature driver if the string of HII option is assigned with x-uefi-redfish
> +Feature driver if the string of HII option is assigned with x-UEFI-redfish
> Language as in below,
>
> ```C
> -x-uefi-redfish-$(NAMESPACE)
> +x-UEFI-redfish-$(NAMESPACE)
> where $(NAMESPACE) is the combination of Redfish ResourceTypeName and
> schema version.
> ```
> For example, if the HII option is mapped to the property in Processor.v1_0_0.
> -The x-uefi-redfish configure language is declared as below,
> +The x-UEFI-redfish configure language is declared as below,
> ```C
> -x-uefi-redfish-Processor.v1_0_0
> +x-UEFI-redfish-Processor.v1_0_0
> ```
> -#### x-uefi-redfish Configure Language format:
> -- The string declared with x-uefi-redfish configure language is a path to the
> property
> +#### x-UEFI-redfish Configure Language format:
> +- The string declared with x-UEFI-redfish configure language is a path to the
> property
> in Redfish schema.
> -- The root of path is the Redfish resource type indicated in x-uefi-redfish
> configure
> +- The root of path is the Redfish resource type indicated in x-UEFI-redfish
> configure
> language
> - The path is relative to root of [Redfish
> schema](https://redfish.dmtf.org/redfish/schema_index) defined by DMTF,
> not related to Redfish service root.
>
> @@ -202,29 +203,29 @@ language
> ```C
> Properties:
>
> -#string STR_BOOT_SOURCE_OVERRIDE_ENABLED_PROMPT #language
> x_uefi_redfish_ComputerSystem.v1_0_0
> "/Boot/BootSourceOverrideEnabled"
> -#string STR_BOOT_SOURCE_OVERRIDE_MODE_PROMPT #language
> x_uefi_redfish_ComputerSystem.v1_0_0 "/Boot/BootSourceOverrideMode"
> -#string STR_BOOT_SOURCE_OVERRIDE_TARGET_PROMPT #language
> x_uefi_redfish_ComputerSystem.v1_0_0 "/Boot/BootSourceOverrideTarget"
> +#string STR_BOOT_SOURCE_OVERRIDE_ENABLED_PROMPT #language x-
> UEFI-redfish-ComputerSystem.v1_0_0 "/Boot/BootSourceOverrideEnabled"
> +#string STR_BOOT_SOURCE_OVERRIDE_MODE_PROMPT #language x-UEFI-
> redfish-ComputerSystem.v1_0_0 "/Boot/BootSourceOverrideMode"
> +#string STR_BOOT_SOURCE_OVERRIDE_TARGET_PROMPT #language x-UEFI-
> redfish-ComputerSystem.v1_0_0 "/Boot/BootSourceOverrideTarget"
> ```
> ```C
> Properties in array object [NUM]:
>
> -#string STR_BOOT_ORDER_1_PROMPT #language
> x_uefi_redfish_ComputerSystem.v1_11_0 "/Boot/BootOrder/[1]/Boot0001"
> -#string STR_BOOT_ORDER_2_PROMPT #language
> x_uefi_redfish_ComputerSystem.v1_11_0 "/Boot/BootOrder/[2]/Boot0002"
> -#string STR_BOOT_ORDER_3_PROMPT #language
> x_uefi_redfish_ComputerSystem.v1_11_0 "/Boot/BootOrder/[3]/Boot0003"
> +#string STR_BOOT_ORDER_1_PROMPT #language x-UEFI-redfish-
> ComputerSystem.v1_11_0 "/Boot/BootOrder/[1]/Boot0001"
> +#string STR_BOOT_ORDER_2_PROMPT #language x-UEFI-redfish-
> ComputerSystem.v1_11_0 "/Boot/BootOrder/[2]/Boot0002"
> +#string STR_BOOT_ORDER_3_PROMPT #language x-UEFI-redfish-
> ComputerSystem.v1_11_0 "/Boot/BootOrder/[3]/Boot0003"
> ```
> ```C
> Properties in collection object {NUM}:
>
> -#string STR_MEMORY_1_BASE_MODULE_TYPE_PROMPT #language
> x_uefi_redfish_Memory.v1_7_1 "/Memory/{1}/BaseModuleType"
> -#string STR_MEMORY_2_BASE_MODULE_TYPE_PROMPT #language
> x_uefi_redfish_Memory.v1_7_1 "/Memory/{2}/BaseModuleType"
> -#string STR_MEMORY_3_BASE_MODULE_TYPE_PROMPT #language
> x_uefi_redfish_Memory.v1_7_1 "/Memory/{3}/BaseModuleType"
> +#string STR_MEMORY_1_BASE_MODULE_TYPE_PROMPT #language x-UEFI-
> redfish-Memory.v1_7_1 "/Memory/{1}/BaseModuleType"
> +#string STR_MEMORY_2_BASE_MODULE_TYPE_PROMPT #language x-UEFI-
> redfish-Memory.v1_7_1 "/Memory/{2}/BaseModuleType"
> +#string STR_MEMORY_3_BASE_MODULE_TYPE_PROMPT #language x-UEFI-
> redfish-Memory.v1_7_1 "/Memory/{3}/BaseModuleType"
> ```
>
> ### EDK2 Build Tool ***[[10]](#[0])***
> EDK2 Build is responsible to pull the necessary EDK2 Redfish JSON Schema to
> C
> Structure Convertors and EDK2 Redfish Feature drivers into edk2 build
> process
> -according to the x-uefi-Redfish config language used in the HII VFR forms.
> +according to the x-UEFI-redfish config language used in the HII VFR forms.
>
> ## EDK2 Redfish client feature driver
> 
> @@ -294,7 +295,7 @@ PCD is set to `TRUE`.
> The purpose of Redfish feature driver is to do the synchronization job
> between Redfish service and BIOS. The operation of synchronization can be
> simply divided into two types:
>
> #### Provisioning resource
> -Below is the flow diagram of provisioning platform configuration to Redfish
> service at BIOS resource. With the x-uefi-redfish
> +Below is the flow diagram of provisioning platform configuration to Redfish
> service at BIOS resource. With the x-UEFI-redfish
> configure language described in above section, Redfish feature driver collect
> all BIOS attributes from HII database and populated
> them to Redfish service.
> 
> --
> 2.34.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118599): https://edk2.groups.io/g/devel/message/118599
Mute This Topic: https://groups.io/mt/105880827/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2024-05-06 12:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 1:56 [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: rename x-uefi-redfish to x-UEFI-redfish Nickle Wang via groups.io
2024-05-03 3:49 ` Chang, Abner via groups.io
2024-05-06 12:48 ` Igor Kulchytskyy via groups.io [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BLAPR10MB518564CE6CD1BE4BDD8D6B9EA81C2@BLAPR10MB5185.namprd10.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox