From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B3D487803CC for ; Tue, 12 Sep 2023 19:07:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Ek+789ls1spJuzN7pTnvr4y6gl4JDVsbtMrLOmgmC9I=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694545646; v=1; b=Vvjtjx24GNpkatFewtOzSV/0IdtwTajQCtLfTGeeFpjAG4t9KUUDZRfZMpqO1Gyp0aIkRIzP 2iuOX2PVdt9ODWBxyoxYJXuaPFgoOyoe5oWl1cEWLLTZioan5jp6mHesO4OozP9316LFLrg+esT Nx8hUqkbk9nqS0fcx0hGlYcU= X-Received: by 127.0.0.2 with SMTP id m8a7YY7687511xP8WFcTwFtO; Tue, 12 Sep 2023 12:07:26 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.84]) by mx.groups.io with SMTP id smtpd.web10.3582.1694545645311225498 for ; Tue, 12 Sep 2023 12:07:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JphmGuQ2mW8GlShqfRvZcPrXQVE4vKYkKZghfLn4RN+t/4rskQwUEDC+HpgyaMpQhux+8b+w5tH2mVCcYvm21fk8Qr+SEHnLFyf444ombvQxdkdM97DMLX5KVVnkObO2oNVVCsgd3p6Ht4mYjHhHu/XX14txzGcO3LSoUibHgF90bRjzrs4+fI9epFj03dxHIi2qy5uxzHtFt7vlOVBXc56QPNIcXZ7Uc+vRBhtu6kVUTdnsIZYbjqqH+99Y3s9Imw609nmvIIHgjbDnOdbFPIlqnw+Lth16eEtldta6++wvEyXfA3hPmUHq0IHGqq0sk5IwyuGVh3RhKvlMM6EIkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MJSAeCj3jfaxYtouci0KCQHWBQdTFBevAbP492s+1xI=; b=Ty3JooLW/DGMJWZoh9ln1YIZOmfvDNoqe5s/BIc5golHIgHKa/TX86bOc4Zx0GzoqpiB0pFMdpp+twTM5l8bMu3RH2GVsHce2zP/LUap/68osp0uq+Njni8EK+x9Mph2jlEhvUDcq+dcAM4WzkByUEXdcvNXeU2jQylDD/EzrH5Cu9PA04g38SY5gr3F/fuC4hqo0SeFy/UowdX8hExGQKZe7ppBn0S1ZVLzMlaWhluWOxZgFbemDBhBUQdKnE2fjD3eFnT9BveWcbS9MCTkEeBrJfSjNiKror6FQnWXSdQWjBt2CiInzKIzpyL97sTBHPFPGw70dIjqAWZ7IrX7Gg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by MW4PR10MB6439.namprd10.prod.outlook.com (2603:10b6:303:218::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.37; Tue, 12 Sep 2023 19:07:19 +0000 X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::dc2c:50e8:b23e:d010]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::dc2c:50e8:b23e:d010%6]) with mapi id 15.20.6768.036; Tue, 12 Sep 2023 19:07:18 +0000 From: "Igor Kulchytskyy via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Abner Chang , Nick Ramirez Subject: Re: [edk2-devel] [PATCH v2 1/1] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue. Thread-Topic: [EXTERNAL] [PATCH v2 1/1] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue. Thread-Index: AQHZ5UcEKv+gPwwCskmJ3t6yBGD2drAXjbuA Date: Tue, 12 Sep 2023 19:07:18 +0000 Message-ID: References: <20230912070134.13729-1-nicklew@nvidia.com> In-Reply-To: <20230912070134.13729-1-nicklew@nvidia.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|MW4PR10MB6439:EE_ x-ms-office365-filtering-correlation-id: 8047dfcc-5617-4917-e280-08dbb3c37c4f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: Isw2B2yoS6aKdJ1jUzzJfdaWoD/iTgTdpjobQwTo/n8l1llOKBRDmIFNoQYtNnWu4iSia5dkqwE3AXeyXv1ioxhkHgtkq4K2TLwDuTuvSbdE7uQsGWDogU9cgxhBJ1UMzO8BlxjsbW+UUZaC+wkY4sOUv16Ag22KF+K0GqirlbvN47eS6rYkuFtFvljpUOLhnx6W6jF58e9LZQTxSOsoKjZvMDixf/WhfTSFQqqBruVaQ4F6yMQt62ds7vWZBufTijAYsCXoq4vo4yGvUcbS3J404pbjm8Quowv5TRCNfVm1KZ2qSSHxywDrLD8aIL6AfFHBrl96zcfZxaVkeF/R/okMctEfpLoF7v79OrzSGGlT+hPWRhG7z+FIxoUo5QNcIikAtCF7EHTJiIGyZm6CViaj43eWKQ7cUhwTymCr/lVf09EECt04unQOON8YBxONTsz7nNHMfk4yV0NxJW0Uqy8WdmkkdKW04YP8Ixm9pty0JQqWtW4BelqALqREl2LrzE0Hokyv2aXS67clbyzt6Qki7tC5lg7NSMD8v16yyT6NJ43vM2AVP83qJPURLuzJNjRTv4ppUoq6FQIxnLEYQombQ6ivznhrJnyQTU0vy93Ao6tzfpLOTXmnkZRbjvlJ x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Fzi43NTgLwNYn6V+QptbCE0b4HEX4XrKTliun3aHN/trNulqjMThTYgH8aOc?= =?us-ascii?Q?GbecVXowOeQDv0fQk4TnMgytflbKLsDGa0Kn0uZuyxwajSjoykNgz8lobCJP?= =?us-ascii?Q?EUWi45yqh3AwTs17ScbJCglmKAiV3XdZDoKPdL0oRJ4IY2rqg0eMWExwmKM7?= =?us-ascii?Q?eUl5HHyZvgHN6ZqYTUBoh0OdnymZXClR7HWksO6MRsySvNzwbSdj/T/HlX8M?= =?us-ascii?Q?hYNmKnftfU5U+IbBK6wTh4LL/rNQqxdOzHz3EvdAoQBVbwb/Cb1KVM0wNrLD?= =?us-ascii?Q?xnT/z4h052nqKMrLclJgBwUji0S5BpFotTSjPaALJwlWIkOpQMiMXLCc2Dpm?= =?us-ascii?Q?HbjsofuyQ7Fm3Fzuuv+LPTS/o7GP7B6oo8I19l7vhLui0d1wnJrAya2Zj1li?= =?us-ascii?Q?YhqTOgems7o9mg62Q7HP+kJ8oeIqI9vIuf/NIbZj3bLMsowyFjzOrieXMioF?= =?us-ascii?Q?NVQEUPYAqQMnxZDvAZAS/D8lZRnS3tl3n2iKoGfcdBKs/u7bGgtWvg/TIdKt?= =?us-ascii?Q?lPW6xBa7w59tOsuyPe4fJLG0OaEucyklkIt+nWce2erGO5vZoMw8JaKprgA1?= =?us-ascii?Q?lDqazG3v9LYYfXbEMnPZZ12VAeF6t9KnCv6JCu1Go2yKpbH7E6HdXi+278Cv?= =?us-ascii?Q?P8Hy2iLm/fEfALYul8pq3O4BSMXPK1E/iba2NXOh0hofxx7lw89NEF7LvA6w?= =?us-ascii?Q?PMhvyUPElmJtU3zauymRXXzZFV20KpBdxLgHrE1Dhvm1hhb5UMLZ5gbB7sxy?= =?us-ascii?Q?0Hj8jko7NqzQ/1jYbF4rq2j8vKKVfQ4VlOL5lEaqJwVkqeQ2xgYC2P1TbMsw?= =?us-ascii?Q?IdOoDhGsURsb0F/jxYZgJJz38pmeidrldyHTiUOsbtnAohp6eRlObR/wwuWP?= =?us-ascii?Q?UtgrcKPywpQq9LLpFJ6pE6iEYQh5j1HGQfp/rgBV91essKavY93IDcC2mZ4r?= =?us-ascii?Q?HXSSzeUqkmHqUb+BFsUepb1CC88oamKJoDvwRVeLIMPcCQTn22EGk5wZgoVT?= =?us-ascii?Q?i1n57j7tlZLaaejV1WPEpVj1d3l3WHgTeGNUMIIg7AIHKsm9fxWr61fBJrCf?= =?us-ascii?Q?2zux7jyoQED6Fk8IImj8s2OfPRN0/Y/bFZX0ckkwMMSc03rI0AcOjvLGtmUJ?= =?us-ascii?Q?qQVBs65vJgxoAjIe+4x8J305c4Z3ovihCeW0paBv10obfsMfbwDJvU1l/S0o?= =?us-ascii?Q?1uGnC72JOw1UCvpC8KAY10vUy3tc2zJcX3BSNgLXMgXinh1DN9bsIajQ19EP?= =?us-ascii?Q?1QR0CfU2/hgthMnzhuEQ7rsRww56hgnFd1HKNepfVrqRXFe8mz0oxF5Z9vYQ?= =?us-ascii?Q?k//xufxpamUXaap2tJPRhEljaQ6stRTAgPKaFUPSnziv8rkV0Hb53bOTKVqw?= =?us-ascii?Q?Ik7fe/R6a2gmomrG6Lz7uZL6+D1YXIWHBjmQeRBaR3h1NCX34E4OEQOU3PgD?= =?us-ascii?Q?hrIUKUcWdUAUBCDm79FdbBsQZdoFFvkzpS3reZ5yik7vLGLjIQAwWslKt3tf?= =?us-ascii?Q?dk8PcZj9QovCT+35WIlOfCxYqm6b4a80R6dr7tU9nu73C1y3C7TmC+SFLcQr?= =?us-ascii?Q?jKqYgxN4EK6OW1soxRQ=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8047dfcc-5617-4917-e280-08dbb3c37c4f X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Sep 2023 19:07:18.8133 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2fznNMrlcUFYQDUby99KZwPjcLIrknF2bSQ8jcREfOEGLE2dx3cunJuvwV6hYdtR X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB6439 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,igork@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: OLObxtkDixk33jOWpst84gIAx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Vvjtjx24; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Igor Kulchytskyy Regards, Igor -----Original Message----- From: Nickle Wang Sent: Tuesday, September 12, 2023 3:02 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Ni= ck Ramirez Subject: [EXTERNAL] [PATCH v2 1/1] RedfishPkg/RedfishPlatformConfigDxe: fix= can not set one-of option issue. **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** StatementValue->Buffer is converted from ASCII to Unicode by caller already so we don't have to convert it again. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishPlatformConfigDxe.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c= b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c index f2a8e77d9b00..30d2ef351eca 100644 --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c @@ -1660,12 +1660,11 @@ RedfishPlatformConfigSetStatementCommon ( // in string format from HII point of view. Do a patch here. // if ((TargetStatement->HiiStatement->Operand =3D=3D EFI_IFR_ONE_OF_OP) = && (StatementValue->Type =3D=3D EFI_IFR_TYPE_STRING)) { - TempBuffer =3D StrToUnicodeStr ((CHAR8 *)StatementValue->Buffer); - if (TempBuffer =3D=3D NULL) { - return EFI_OUT_OF_RESOURCES; - } - - FreePool (StatementValue->Buffer); + // + // Keep input buffer to TempBuffer because StatementValue will be + // assigned in HiiStringToOneOfOptionValue(). + // + TempBuffer =3D (EFI_STRING)StatementValue->Buffer; StatementValue->Buffer =3D NULL; StatementValue->BufferLen =3D 0; -- 2.17.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108551): https://edk2.groups.io/g/devel/message/108551 Mute This Topic: https://groups.io/mt/101310452/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-