From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B5B8B740047 for ; Thu, 22 Feb 2024 14:17:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=gT3kE1j+d8kgnnOXPduMMut2CyamL72ASa5PiiDp93U=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708611428; v=1; b=TTtBoGyrpPEcixkQMHgLW/WEG+WnTFIHMB1PO4uBmuKldxPu9g0mf9oh6st2ZeZRujUVDk5S qT+BF7745q9gjpyCIUgHlyZPzTYUHFcQR6b6p9QNb6Fhtq0BW4hYeSCt2E7VpnsJzVdPRAw23BI j1mwecHK07NIMbjjZ+8ldiso= X-Received: by 127.0.0.2 with SMTP id iPWKYY7687511xFxo4wYcAi5; Thu, 22 Feb 2024 06:17:08 -0800 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.130]) by mx.groups.io with SMTP id smtpd.web10.13693.1708611427388155601 for ; Thu, 22 Feb 2024 06:17:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BJNPbGtGMrPKVLEABagfaBNPowYtlezOG93AbtC3AXWzzMPSlc6QPsPpAj9gFtgpajfFnkNWkpeU/tXsRtEUqu+7mk5UoJxN9ylydujaxDLHEIg3H0KjKGzkeesdxKbN4Gi/XsZkDhsYSh9QX4tHzKTQFbp2R8M1gnhArzQnGx5gL0KYGtzWnAvOBgbZwtFKFj8wg6jXzCiSh3xUcYYVvfRJ/7PLkAzIkNKBsqyEvTK/lyanhk2V0ECrOtCa5bUhHuvc4zYBcHN8j9o7hknIZimvRzDtqZOA9/ur3ZjVPBXsXDWg5x6PZuPu8/WxPC/QJ6gqThZXnEmNbVSb8f7jSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/pBP8chAp0MnWQBvFEtzh2Tt6ZLv7PsI2MXmn4zCU9Q=; b=mlsSmYiEXIydp58sz5QdjC3UMGc+xbUfJtXoTr9KoXttnY0q2Cjod7aV9lmw2llbX8wI2Z5leX2RWKfXs5RiAr4EuIXU4aL5Z2jGNCO2abmgmtMZkOHrUTXtNkZvIilCTVUPyd/P+EVA8qBaKdfUkpF7tOuGgNIOZScDdcla9ay1dLretPNM5ZDwPMc80BbmDIQMI/6aWXnQBnYIodo/TRwKmawobnYpyM3MUs5K8UsgRWnDhbo7k1LmUYyrONelGyJwidKfDfThJ3/lyngYtWnknKqFolHpYudWpl+fvWdV5SGl0xyukSaEK36V2VWnuRh4OXjEhtlHOHXQz8R+fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by SA1PR10MB7709.namprd10.prod.outlook.com (2603:10b6:806:3a9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.24; Thu, 22 Feb 2024 14:17:02 +0000 X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::7840:c724:8a2a:4cf5]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::7840:c724:8a2a:4cf5%5]) with mapi id 15.20.7316.023; Thu, 22 Feb 2024 14:17:01 +0000 From: "Igor Kulchytskyy via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Abner Chang , Nick Ramirez Subject: Re: [edk2-devel] [PATCH v2 0/6] Introduce Redfish http protocol Thread-Topic: [EXTERNAL] [PATCH v2 0/6] Introduce Redfish http protocol Thread-Index: AQHaZW8cPiXr7TwXp0i0djHrXGs01rEWaD1Q Date: Thu, 22 Feb 2024 14:17:01 +0000 Message-ID: References: <20240222091102.536-1-nicklew@nvidia.com> In-Reply-To: <20240222091102.536-1-nicklew@nvidia.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|SA1PR10MB7709:EE_ x-ms-office365-filtering-correlation-id: 8cc4615c-91d6-4931-fbc4-08dc33b0f01e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: vpthE27HSETVmUNV9BUQHQoY6yaxNb5OZp9JSsV8Ax+O5zis4jpatD338/ZxiOtdNW5W/oFjWuE+3suAPpRKDS08f1ZJrruFvyyPj/vpTNpc8dUpBWS1DcW+NljB5oGHkLyaTo/cJmuyzRudIULdTe8BnoErC0dDbbQh3oUUO6953wSIcD9hC4JyULclw+2xUWyC3cHy1f1BLF4iN/yG9jfFOl/hJOPbxTrFfYLvpPhz92+6pUfrzROM+xXcHqKdFg9aF1vMY4WE+2wHIrRM3sbvhObGNrzbay2EqyjzWb1chKJbpik9zUSlB5r6SwFp0JXqYxsn8YUG+WNNvGGuXFAqdC/cVbkmJ2tMPz1jJK2ZOIlACS6JNOvvWr7oKRqFA8dYuTnibvlq8RpQ5Zr5i0xWFvLeZbWNYt2x4OSisTkICu/00I1/9xMjQzTS5V01a8SyjYw0Z0oV4z5VrJTQvcLD25ppKlzcKawo46nG3txYemjFk3MdFyp5/BqK14co5GrVCzIH4zqS1ymvt1R2Fzk3Swssa15mQQmzgZtAdyB4Z13xeq2mHmmoYtd6bKdkxhvdhlgxxtP+tcFwyAV9UkL3JhFwLC21qWAGTZMxtE8= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?U7qzAPMUU4p/Ntx8O3Bvf/ambzRXTEpbR6rpnecBRFJNhIa52IBIIbmEcDv+?= =?us-ascii?Q?q3fVSnX0ujb2naVGsPZIDHJEgO7Po6LbOqukzNqiFbKsEjyIWalrVoU93Hdg?= =?us-ascii?Q?0tQtKAfuq+w8TyYKCZesjz49z2t0cvJcieNITN3UB+avzBiwEbXcjwby88kK?= =?us-ascii?Q?XsB79MFa9N0L4j6Smv73J0zk1KHy6fHMhGW1bH+Q9tZIchgEZyzLm5p9F+V7?= =?us-ascii?Q?YP15HR1m3RDIgs7dyDGDheyykzBiBp7FgvBuguif5jGxOylI5gw0ItQJyAJF?= =?us-ascii?Q?ulc3oTdZC3dDCYeiETofIT+sXg9QqRn0CzrvWilJTjtDAV5EuqzkGR01FMFV?= =?us-ascii?Q?ZOYWmTx34PWrYvo8cvtSyvwnGNjpURdpLEz49V/L1qztuJ0VRVfs96cC3XnN?= =?us-ascii?Q?EHnHf8fQVFFmb6EHl9BIlPrgF457Ni5mbifPys3hO9RFWM+mZcvXKv4pBNAo?= =?us-ascii?Q?I3WSb/ug0/0Isy+oNdlzCgB5InRToL6crUHnqqyg9v6LhO2sX2EnjjPXPbk0?= =?us-ascii?Q?dhltuvi5NWS3IBKwlzAGP9NDaGlTWHeZ9Bg7RieN+OPifrS4zDett5IkPSt2?= =?us-ascii?Q?75WTXESRGQsUMq52HfGtg0juEy6YtweAU07Ay7aakJmFWqe+i9MuC9lp9vvU?= =?us-ascii?Q?L/1cynfgEI0cckOVOcXrOl63eDAP+5ugip0+zXT/9I0Q0UTrh6mBPColXi0z?= =?us-ascii?Q?o/lhRlZv/rK+WJzjQpr/kXcv0ahT/R2LYy8gMDaL9SoAP3EFirACtEzu3D+R?= =?us-ascii?Q?/i8zfdBg86q9WvzV7R6LhiF2OZmo6XhyyPcxAJ0jqhKebr9G7aFL29Alxysj?= =?us-ascii?Q?HVQPq/tJ/OL4vprs85TvJIBqOvKqK0Zw23pAo8hELJjpu5bw2COYwD/IFPJu?= =?us-ascii?Q?vmyWDdlKo+QBW0wv55tdzZCwn6WD2WDs8joU4XGMwgv0KXWm0t7YGkztC1x/?= =?us-ascii?Q?Cdv8sIKkHQ6vZzI05PBU3Bt1Q/K+yyvW1ATpYwVvOl4wSTRYyq29Z2rC394K?= =?us-ascii?Q?YJ7FL6eP6glnUlv9yb5gaMI75ZThObUfZxnwuBzD2iVm3zhZrq716J8ePE/M?= =?us-ascii?Q?WeleRCD+FV7NlO/BWgEBClC1W+VepygGCvMmZXXyQg8Ceb95Nw47B0fzPp38?= =?us-ascii?Q?4/cl1KT4vmrWuyffed14+H08AXKS+u22Gr9NTlgaRN0XI69HRvKVpsg0v5Ng?= =?us-ascii?Q?d45JI1GdbVtJoT3Tha+Di0O4prrgr7V9PxHHjaVODfuhDqwgPw4qQ3sFSvQE?= =?us-ascii?Q?0K+imAY0OkB3gr726yM2cpgCn/stcxiVyKYJtjI0xdfo2E3CB6pMNG8g/sxX?= =?us-ascii?Q?2eYSisK0wIbO6p+461gOU+eoA1g451ccA0M5NPS/nKo3leK3IHcq+C+v8spp?= =?us-ascii?Q?RY/7tKDqe7fNEUhx/0nx0GfzvlLHsZe+Y9p+K8YvdpRNf51L91tqoKi7VB1F?= =?us-ascii?Q?WnTi157ZzrDue2WhJkG/bMeLkOjvVgqRBimQw7FOl+s5Ft+eHx3N7xk8XEqd?= =?us-ascii?Q?pOh01lwrkICl7RrHJRZspOAyzzxp0Jb8GePjv8t0qnw9LhtG1C2dHAmQ42Ds?= =?us-ascii?Q?BFzvyk8BaeI1msMPiSM=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8cc4615c-91d6-4931-fbc4-08dc33b0f01e X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2024 14:17:01.5448 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BlPGePYHx/6/CLRtWzfxc8RewvIDfIL/PdzuwuA7pPM0Wp//rltosJsBxdegM13y X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB7709 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,igork@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: w4X592UKCkyjsE17S6ie3UBgx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=TTtBoGyr; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Igor Kulchytskyy -----Original Message----- From: Nickle Wang Sent: Thursday, February 22, 2024 4:11 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Ni= ck Ramirez Subject: [EXTERNAL] [PATCH v2 0/6] Introduce Redfish http protocol **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** v2: address review comments. 1) add comment to show the source file of MathFtol.c 2) update macro to follow file name in RedfishHttpOperation.h This patch series introduce Redfish HTTP protocol to RedfishPkg. This is to improve Redfish performance and communication stability between BIOS and Redfish service. Two big functions are introduced: 1) HTTP cache mechanism is implemented to reduce the number of communiocation between BIOS and BMC. 2) HTTP request retry mechanism is implemented to handle communication failure. With retry mechanism, Redfish feature driver can finish its job as best as possible. Several libraries are updated to fix build issues. Pull request is created: https://github.com/tianocore/edk2/pull/5348 Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Nickle Wang (6): RedfishPkg: introduce Redfish HTTP protocol RedfishPkg: implement Redfish HTTP protocol RedfishPkg: introduce RedfishHttpLib RedfishPkg/RedfishLib: include RedfishServiceData.h RedfishPkg/RedfishDebugLib: use RedfishHttpLib RedfishPkg/RedfishCrtLib: fix unresolved external symbol issue RedfishPkg/RedfishPkg.dec | 32 +- RedfishPkg/RedfishComponents.dsc.inc | 3 +- RedfishPkg/RedfishLibs.dsc.inc | 3 +- RedfishPkg/RedfishPkg.dsc | 5 +- .../RedfishDebugLib/RedfishDebugLib.inf | 4 +- .../Library/RedfishHttpLib/RedfishHttpLib.inf | 43 + .../RedfishCrtLib/RedfishCrtLib.inf | 7 +- RedfishPkg/RedfishHttpDxe/RedfishHttpDxe.inf | 73 + RedfishPkg/Include/Library/RedfishDebugLib.h | 2 +- RedfishPkg/Include/Library/RedfishHttpLib.h | 326 ++++ RedfishPkg/Include/Library/RedfishLib.h | 17 +- .../Protocol/EdkIIRedfishHttpProtocol.h | 308 ++++ RedfishPkg/Include/RedfishServiceData.h | 43 + RedfishPkg/RedfishHttpDxe/RedfishHttpData.h | 256 ++++ RedfishPkg/RedfishHttpDxe/RedfishHttpDxe.h | 44 + .../RedfishHttpDxe/RedfishHttpOperation.h | 76 + .../Library/RedfishDebugLib/RedfishDebugLib.c | 1 + .../Library/RedfishHttpLib/RedfishHttpLib.c | 585 +++++++ .../RedfishCrtLib/Ia32/MathFtol.c | 37 + RedfishPkg/RedfishHttpDxe/RedfishHttpData.c | 667 ++++++++ RedfishPkg/RedfishHttpDxe/RedfishHttpDxe.c | 1344 +++++++++++++++++ .../RedfishHttpDxe/RedfishHttpOperation.c | 693 +++++++++ RedfishPkg/Redfish.fdf.inc | 3 +- RedfishPkg/RedfishPkg.ci.yaml | 2 + 24 files changed, 4549 insertions(+), 25 deletions(-) create mode 100644 RedfishPkg/Library/RedfishHttpLib/RedfishHttpLib.inf create mode 100644 RedfishPkg/RedfishHttpDxe/RedfishHttpDxe.inf create mode 100644 RedfishPkg/Include/Library/RedfishHttpLib.h create mode 100644 RedfishPkg/Include/Protocol/EdkIIRedfishHttpProtocol.h create mode 100644 RedfishPkg/Include/RedfishServiceData.h create mode 100644 RedfishPkg/RedfishHttpDxe/RedfishHttpData.h create mode 100644 RedfishPkg/RedfishHttpDxe/RedfishHttpDxe.h create mode 100644 RedfishPkg/RedfishHttpDxe/RedfishHttpOperation.h create mode 100644 RedfishPkg/Library/RedfishHttpLib/RedfishHttpLib.c create mode 100644 RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c create mode 100644 RedfishPkg/RedfishHttpDxe/RedfishHttpData.c create mode 100644 RedfishPkg/RedfishHttpDxe/RedfishHttpDxe.c create mode 100644 RedfishPkg/RedfishHttpDxe/RedfishHttpOperation.c -- 2.34.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115817): https://edk2.groups.io/g/devel/message/115817 Mute This Topic: https://groups.io/mt/104505401/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-