From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.76]) by mx.groups.io with SMTP id smtpd.web10.49258.1670337132151318096 for ; Tue, 06 Dec 2022 06:32:13 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ami.com header.s=selector1 header.b=ZlO5xG03; spf=pass (domain: ami.com, ip: 40.107.92.76, mailfrom: igork@ami.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c+oKRLN6xQFLkptANO2ymdCaehndIhVvpqLMkRPUiTyhc5hTr3XL6y2y0uGbi31RPRrAVAbiIFTxi6eHzJWDk7W76iqlM9Fp3P2VCHgrbN0nZL3K5OhOnoVxfrSX2fUtw6hH+yMhheWBlLny3cqvf40e5OzYR+LkmWYlI35M8bKTkBefv+odscxT3eJM7FyeLMmeqEYGJWczQNz4Z34W3enxZoNUrkMwOne54k4G0Sv6Om3P9/f4Rak20GN1ENIvGBvvGJAh1Ctr7Bhra15Ev8MziK6HxW0pkkaBZ+YbSg4z5pHm2WI/c/20Gg2yz190aAQokbjrkzh1043ICqUibg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XzUMZnjavC2U9nJ+IFlxiNagXPv4GcuFCD+rg/e/pl8=; b=GJcAR8Wk4QSZn1yY/WnRlGM0N6n8ZRO8fJSDageZQoS24HSLsIwn2KHm5fEiQZzFj3M+mJtL++NzcrTR9I4WU4ud2hkUuENCLhl48SktG6ck0oXcDe5r9V6LFNr4Q4y9Dx56r++PtyeblDzd5i1yJY8Pmfp3L/nHCDng2HqkDNYk/j2gipo34ND/5QbtUyiacoxoHXCeEJqn1LYn1AdDcNtYSAtyDT3ru0L9xcH1kAoXnGrKmN9wUmKbon/Hcibs78YmsxVB7P4Rim/Box2txZUl2PS8QEp6xTcSECG0FyQsmXWFeoRyLCnUCKeRZXNSqKXH5iNXI28/3yceFI1RbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ami.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XzUMZnjavC2U9nJ+IFlxiNagXPv4GcuFCD+rg/e/pl8=; b=ZlO5xG032vxqsDQayjnil25Vghwk1CreeAWDrXgV+ZyLztHg+Wm4sVqQfev1qe/ZDqCKnFMT94VgHxtcLBdQAt/5rqB/xly6qEuXlYPvbFNNFhS40Vcjhmg0+76yvXdlTx+CJxrPeMOslsco677fug6oNIFiGWbI+dGXqDNcym0= Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by DS0PR10MB6752.namprd10.prod.outlook.com (2603:10b6:8:133::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.8; Tue, 6 Dec 2022 14:32:10 +0000 Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::473b:192f:7fa7:8bbf]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::473b:192f:7fa7:8bbf%6]) with mapi id 15.20.5880.014; Tue, 6 Dec 2022 14:32:09 +0000 From: "Igor Kulchytskyy" To: "Chang, Abner" , Michael D Kinney , "devel@edk2.groups.io" CC: Nickle Wang Subject: Re: [Patch 1/1] RedfishPkg: Remove overlapping private include path in DEC file Thread-Topic: [EXTERNAL] RE: [Patch 1/1] RedfishPkg: Remove overlapping private include path in DEC file Thread-Index: AQHZCUwXHFGmAqgnwEySW3zY0fw/mK5g7DoA Date: Tue, 6 Dec 2022 14:32:09 +0000 Message-ID: References: <20221206004446.12-1-michael.d.kinney@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ami.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|DS0PR10MB6752:EE_ x-ms-office365-filtering-correlation-id: 363dc87a-b135-4420-af3d-08dad796a86e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0iO9XV2UJQc7FxxextvotNZfH+9m7CeRIYoxYCywkIgRufsOvcvS2RLBpm2wWVRSzQuT+Z084TDvyhXe6re75PyrIClD8LLZrm8U4XBy6Rf+BXIIq9fl6wlBU3trz8fDxK75EwvkT0bJEFVxWTHFhpVneSPqnpMYoZdr3xZp8HHYH2LFOLtb3jB+iJX6E5E1XF1YTA6uQZXLpcIF+M2EoBoLJIN7PMQQrc0P8/PO8Epig+RBM4jroFEtmq6lLdzkpskExD7Bn6gYmbYWG/R/UoFEZ8iw3jTW7/oju3p8Jp+ekxyKmz9r8GXk/5K8AwfSZKs6h+nO8BZ8WoRue9wChf5Qirj0NAoRGjYa36WvpdeVVatBPpHTYOBiTVAWWwk57zI9XFXMjM9eDT1IUaxKGH7sr1VSCPDb3s7+Hyy83e5LifqkGY5PjetTrZ2yQFBJkUscFo8H2BEylq7QjTJS8t+khaeZuOheenzUYo+w80kBLYZF+OlW0Pej0HSySDAr0qWAhnlImdELSqHOxsRv7L3GZTncAQfIvtzo8Ef/aT/L3fj5TAS+OVC41e/mi3gkj4ZM2r9q3f0MIadZ8u65wzF2Mesk3NldpQjk3A6bnIVNwtdFfVtQp2tHeHFmmG1MgbOFiXggjRbkgo6c8B17cL+JT3eJ+l8XeNvHmPHDw5fiZLlyYr2+UyJcFuIl84FiKSk85F3bMl42i7YhC78xXJbYb9sxYIp+VEijPiCk1rM= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5185.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39850400004)(396003)(376002)(346002)(366004)(451199015)(55016003)(478600001)(86362001)(166002)(9686003)(316002)(7696005)(33656002)(40140700001)(110136005)(38070700005)(52536014)(8676002)(64756008)(66946007)(8936002)(76116006)(4326008)(91956017)(41300700001)(45080400002)(66446008)(66476007)(66556008)(26005)(2906002)(6506007)(53546011)(83380400001)(38100700002)(122000001)(5660300002)(71200400001)(186003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6HeCW+z34YQgrnuiTXZu/YKnxZ+JzjratQrPGtJQBrLdSNUu8IhcqCnqJVMT?= =?us-ascii?Q?LnrDp91kBT9UxWn241veuxZPV4tBWZyzBuFIXrYNFnZIWaoZmTFKuZ9ILvDc?= =?us-ascii?Q?pOPD+D2M17RqhbdkwEpkkkziPfnDl6+KxPAGgRWwgLc+YH1V4fAUViteLOtf?= =?us-ascii?Q?z5plDYANanaZSm1q33z3peLPY58W8ozez7ivZu5eAGl2mcYMhUr4UOp0U98C?= =?us-ascii?Q?w2qhhSdec7d+48hmk45HRVpYDiTu5x5GrCLdBoBD2gMeksYpXrVSAWpKi1EH?= =?us-ascii?Q?Lk/rScsHpMgjeKjE7ssPQD6UvQ4ZQhbR8Yjk6yhuLcjk4PGfCFykeSvF1DoK?= =?us-ascii?Q?GPhLEhrWALw7U9i1rY2atVhsfFXbnJ8w2YZSXojMRY9khoFqhQLMNp+vJti/?= =?us-ascii?Q?3y5uKn5zHYXhcpc/1h6Z7rollgVJD8OW99Kl1MTnK6QIOOjUb90IcBeknUTt?= =?us-ascii?Q?cGpWd6UEv/RJovIlZXd1B+0+6ddEWHsOJpzQA+tZd74bS2Ln+RjmNq4KC30g?= =?us-ascii?Q?yywqly1HIcxD1O5v+5+s+TUlmJvFonEQXoe9CY78H+Kg368Mg0nTai5ktQhF?= =?us-ascii?Q?I5EBgeaDx5jO3rhd98lJaRLCL/e8sLTW2ar8wl2GBGW+rB34rixHFjvKmUBg?= =?us-ascii?Q?3pJXt/Cg6010EesDLuqL2XoYqwYvn/Gmv8dCg3JfjqHorgVlA/iHlxR9gtHs?= =?us-ascii?Q?7hfui677HSbwLl2eQHrEFPjrvGVDkppJbeptSPxRI5MR8CSwXHHgYpbfk0Mb?= =?us-ascii?Q?PeB4Y52iIMQkWs+U1kSKO7wCOVbWpQmQSSToM5i6JIDQ+uWFNfuT/e38+3iL?= =?us-ascii?Q?AP2bAjvyx2wdCmzvP4l+RORmefJqqN2Lqbuszdf2ZAJb0fO3QEmQHzhtXB/1?= =?us-ascii?Q?eo4P12T4Wh62oGHHMiQwZ0l/V19I7IywHX/WHvlK+f1TlsD9MwY2SpRovYad?= =?us-ascii?Q?cJxLY7V0kqER/mLSE1alLfYVOlxKkL1C/0Lldlx2XPv37pUm8+Svu64QcoE5?= =?us-ascii?Q?45jIV+xbkvOz3Bp9iJo2V5zFOlTZfkdKp8GJT6OCnFuw7sURBY+gbKQXvMHw?= =?us-ascii?Q?KLOQDLzjJHQBkHXRR8l1lEgyyz9OvkhTSz9pvpTsAo//75H3l0je8sEc2/Jn?= =?us-ascii?Q?mgaYDjD64N8Mwml9OYl/mXf+6rYnIWVvsgMahdmO2lThmi0NJwwOr6vKyzYV?= =?us-ascii?Q?J7TvVOc9Ih7MnIQAMrb/cyR0ZsAmVtuor/rlRYEXjBSdkftuA1QKlJ0BYFBn?= =?us-ascii?Q?Dmtz4ZrwDSKdho9Bzoy4xpyAxnzk7SuvxHsZpjfE1cSE5KgDWSoAGzPqEYCY?= =?us-ascii?Q?VN+nY8ZhZqXGfq1dENKySnwCFq9EYJ4eo1o+DeKgRu4z1mvJv7aoMAr0K5LM?= =?us-ascii?Q?/wSUYqiD8L770Pu5V3OiwQ/oWE9unP2p2LS3K6/UuFGNBlOQWxU8hLIUAIBI?= =?us-ascii?Q?OtKPAha1iSgai8gwccfoJLZD+SIaI9P+XOkne1H/IBk9qrmndeRYxhIgBZ6v?= =?us-ascii?Q?aDEitWjjGphFEcHI2O8C6LCnSjsAoCkCH7zLiwN0pu0LMfeAz2JFnP9vemee?= =?us-ascii?Q?RnYpoYfBlIEoKzh2YTA2wqx5GOVPTkgnftf7scrA?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 363dc87a-b135-4420-af3d-08dad796a86e X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2022 14:32:09.6770 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nwJ6HZ1DQn2LyhcO/fyGFxfKKtcs1UZM1EBPlaCjZ5wOzF0J9H0Ec1TGafDGRjQv X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6752 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BLAPR10MB51859046C0CD518C5FAEB49CA81B9BLAPR10MB5185namp_" --_000_BLAPR10MB51859046C0CD518C5FAEB49CA81B9BLAPR10MB5185namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Igor Kulchytskyy > Get Outlook for Android ________________________________ From: Chang, Abner Sent: Tuesday, December 6, 2022 3:23:56 AM To: Michael D Kinney ; devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [EXTERNAL] RE: [Patch 1/1] RedfishPkg: Remove overlapping private = include path in DEC file **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Michael D Kinney > Sent: Tuesday, December 6, 2022 8:45 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Nickle Wang > ; Igor Kulchytskyy > Subject: [Patch 1/1] RedfishPkg: Remove overlapping private include path = in > DEC file > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Update ReadfishPkg.dec to remove PrivateInclude from the > [Includes.Common.Private] section. The PrivateInclude directory does not > contain any include files, and the PrivateInclude/Crt include path remain= ing in > the [Includes.Common.Private] section providing the include path required > to access the CRT related include files by components within the RedfishP= kg. > > Without this update, there are two forms of #include statements that can = be > used to include the CRT related include files. > Include files should only be available using one form of #include stateme= nts. > > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Michael D Kinney > --- > RedfishPkg/RedfishPkg.dec | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec index > 0aa26883e220..d2b189b13d8c 100644 > --- a/RedfishPkg/RedfishPkg.dec > +++ b/RedfishPkg/RedfishPkg.dec > @@ -17,7 +17,6 @@ [Includes] > Include > > [Includes.Common.Private] > - PrivateInclude # Private header files for C RTL. > PrivateInclude/Crt # Private header files for C RTL. > Library/JsonLib # Private header files for jansson > # configuration files. > -- > 2.37.1.windows.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . --_000_BLAPR10MB51859046C0CD518C5FAEB49CA81B9BLAPR10MB5185namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Igor Kulchytskyy <igork@ami= .com>
From: Chang, Abner <Abne= r.Chang@amd.com>
Sent: Tuesday, December 6, 2022 3:23:56 AM
To: Michael D Kinney <michael.d.kinney@intel.com>; devel@edk2.= groups.io <devel@edk2.groups.io>
Cc: Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igo= rk@ami.com>
Subject: [EXTERNAL] RE: [Patch 1/1] RedfishPkg: Remove overlapping p= rivate include path in DEC file
 

**CAUTION: The e-mail belo= w is from an external source. Please exercise caution before opening attach= ments, clicking links, or following guidance.**

[AMD Official Use Only - General]

Reviewed-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: Michael D Kinney <michael.d.kinney@intel.com>
> Sent: Tuesday, December 6, 2022 8:45 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Nickle Wang
> <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
> Subject: [Patch 1/1] RedfishPkg: Remove overlapping private include pa= th in
> DEC file
>
> Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding.
>
>
> Update ReadfishPkg.dec to remove PrivateInclude from the
> [Includes.Common.Private] section.  The PrivateInclude directory = does not
> contain any include files, and the PrivateInclude/Crt include path rem= aining in
> the [Includes.Common.Private] section providing the include path requi= red
> to access the CRT related include files by components within the Redfi= shPkg.
>
> Without this update, there are two forms of #include statements that c= an be
> used to include the CRT related include files.
> Include files should only be available using one form of #include stat= ements.
>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  RedfishPkg/RedfishPkg.dec | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec ind= ex
> 0aa26883e220..d2b189b13d8c 100644
> --- a/RedfishPkg/RedfishPkg.dec
> +++ b/RedfishPkg/RedfishPkg.dec
> @@ -17,7 +17,6 @@ [Includes]
>    Include
>
>  [Includes.Common.Private]
> -  PrivateInclude        =         # Private header files for C RTL= .
>    PrivateInclude/Crt     &nbs= p;      # Private header files for C RTL.
>    Library/JsonLib      &= nbsp;        # Private header files for = jansson
>            = ;            &n= bsp;         # configuration files.=
> --
> 2.37.1.windows.1
-The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are on notice that any distribution of = this message, in any form, is strictly prohibited. Please promptly notify t= he sender by reply e-mail or by telephone at 770-246-8600, and then delete = or destroy all copies of the transmission. --_000_BLAPR10MB51859046C0CD518C5FAEB49CA81B9BLAPR10MB5185namp_--