* [edk2-devel] [edk2-redfish-client][PATCH v2] RedfishClientPkg/RedfishFeatureUtilityLib: validate string array
@ 2023-12-04 9:40 Nickle Wang via groups.io
2023-12-04 16:44 ` Igor Kulchytskyy via groups.io
0 siblings, 1 reply; 2+ messages in thread
From: Nickle Wang via groups.io @ 2023-12-04 9:40 UTC (permalink / raw)
To: devel; +Cc: Abner Chang, Igor Kulchytskyy, Nick Ramirez
Add function ValidateRedfishStringArrayValues to validate Redfish
request for string array type. There is case that user request
invalid string array and feature driver can not find corresponding
HII option.
Signed-off-by: Nickle Wang <nicklew@nvidia.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Cc: Nick Ramirez <nramirez@nvidia.com>
---
.../Library/RedfishFeatureUtilityLib.h | 28 +++
.../RedfishFeatureUtilityLib.c | 187 ++++++++++++++----
2 files changed, 172 insertions(+), 43 deletions(-)
diff --git a/RedfishClientPkg/Include/Library/RedfishFeatureUtilityLib.h b/RedfishClientPkg/Include/Library/RedfishFeatureUtilityLib.h
index 6347585c..24f0ad24 100644
--- a/RedfishClientPkg/Include/Library/RedfishFeatureUtilityLib.h
+++ b/RedfishClientPkg/Include/Library/RedfishFeatureUtilityLib.h
@@ -990,4 +990,32 @@ GetPendingSettings (
OUT EFI_STRING *SettingUri
);
+/**
+ This function goes through Head and StringArray to check below:
+ 1) Check and see if value in Redfish string array can be found in HII
+ configuration string array. This is to see if there is any invalid
+ values from Redfish.
+ 2) Check and see if size of Head is the same as ArraySize.
+ 3) Check and see if value in Redfish string array are all the same as the one
+ from HII configuration.
+
+ @param[in] Head The head of string array.
+ @param[in] StringArray Input string array.
+ @param[in] ArraySize The size of StringArray.
+ @param[out] ValueChanged TRUE when The order of Head is not the same as the order of StringArray.
+ FALSE when Head and StringArray are identical.
+
+ @retval EFI_INVALID_PARAMETER Input parameter is NULL or ArraySize is 0.
+ @retval EFI_NOT_FOUND The element in Head cannot be found in StringArray. This is invalid request.
+ @retval EFI_BAD_BUFFER_SIZE The size of Head is not the same as the size of StringArray. This is invalid request.
+
+**/
+EFI_STATUS
+ValidateRedfishStringArrayValues (
+ IN RedfishCS_char_Array *Head,
+ IN CHAR8 **StringArray,
+ IN UINTN ArraySize,
+ OUT BOOLEAN *ValueChanged
+ );
+
#endif
diff --git a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
index 6652539c..07033488 100644
--- a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
+++ b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
@@ -866,6 +866,7 @@ ApplyFeatureSettingsStringArrayType (
EDKII_REDFISH_VALUE RedfishValue;
UINTN Index;
RedfishCS_char_Array *Buffer;
+ BOOLEAN ValueChanged;
if (IS_EMPTY_STRING (Schema) || IS_EMPTY_STRING (Version) || IS_EMPTY_STRING (ConfigureLang) || (ArrayHead == NULL)) {
return EFI_INVALID_PARAMETER;
@@ -886,61 +887,69 @@ ApplyFeatureSettingsStringArrayType (
}
//
- // If there is no change in array, do nothing
+ // Validate input string array from BMC to see:
+ // 1) String array from BMC is valid or not.
+ // 2) If there is no change in array, do nothing.
//
- if (!CompareRedfishStringArrayValues (ArrayHead, RedfishValue.Value.StringArray, RedfishValue.ArrayCount)) {
- //
- // Apply settings from redfish
- //
- DEBUG ((DEBUG_MANAGEABILITY, "%a: %a.%a apply %s for array\n", __func__, Schema, Version, ConfigureLang));
- FreeArrayTypeRedfishValue (&RedfishValue);
-
- //
- // Convert array from RedfishCS_char_Array to EDKII_REDFISH_VALUE
- //
- RedfishValue.ArrayCount = 0;
- Buffer = ArrayHead;
- while (Buffer != NULL) {
- RedfishValue.ArrayCount += 1;
- Buffer = Buffer->Next;
- }
+ Status = ValidateRedfishStringArrayValues (ArrayHead, RedfishValue.Value.StringArray, RedfishValue.ArrayCount, &ValueChanged);
+ if (!EFI_ERROR (Status)) {
+ if (ValueChanged) {
+ //
+ // Apply settings from redfish
+ //
+ DEBUG ((DEBUG_MANAGEABILITY, "%a: %a.%a apply %s for array\n", __func__, Schema, Version, ConfigureLang));
+ FreeArrayTypeRedfishValue (&RedfishValue);
- //
- // Allocate pool for new values
- //
- RedfishValue.Value.StringArray = AllocatePool (RedfishValue.ArrayCount *sizeof (CHAR8 *));
- if (RedfishValue.Value.StringArray == NULL) {
- ASSERT (FALSE);
- return EFI_OUT_OF_RESOURCES;
- }
+ //
+ // Convert array from RedfishCS_char_Array to EDKII_REDFISH_VALUE
+ //
+ RedfishValue.ArrayCount = 0;
+ Buffer = ArrayHead;
+ while (Buffer != NULL) {
+ RedfishValue.ArrayCount += 1;
+ Buffer = Buffer->Next;
+ }
- Buffer = ArrayHead;
- Index = 0;
- while (Buffer != NULL) {
- RedfishValue.Value.StringArray[Index] = AllocateCopyPool (AsciiStrSize (Buffer->ArrayValue), Buffer->ArrayValue);
- if (RedfishValue.Value.StringArray[Index] == NULL) {
+ //
+ // Allocate pool for new values
+ //
+ RedfishValue.Value.StringArray = AllocatePool (RedfishValue.ArrayCount *sizeof (CHAR8 *));
+ if (RedfishValue.Value.StringArray == NULL) {
ASSERT (FALSE);
- FreePool (RedfishValue.Value.StringArray);
return EFI_OUT_OF_RESOURCES;
}
- Buffer = Buffer->Next;
- Index++;
- }
+ Buffer = ArrayHead;
+ Index = 0;
+ while (Buffer != NULL) {
+ RedfishValue.Value.StringArray[Index] = AllocateCopyPool (AsciiStrSize (Buffer->ArrayValue), Buffer->ArrayValue);
+ if (RedfishValue.Value.StringArray[Index] == NULL) {
+ ASSERT (FALSE);
+ FreePool (RedfishValue.Value.StringArray);
+ return EFI_OUT_OF_RESOURCES;
+ }
- ASSERT (Index <= RedfishValue.ArrayCount);
+ Buffer = Buffer->Next;
+ Index++;
+ }
- Status = RedfishPlatformConfigSetValue (Schema, Version, ConfigureLang, RedfishValue);
- if (!EFI_ERROR (Status)) {
- //
- // Configuration changed. Enable system reboot flag.
- //
- REDFISH_ENABLE_SYSTEM_REBOOT ();
+ ASSERT (Index <= RedfishValue.ArrayCount);
+
+ Status = RedfishPlatformConfigSetValue (Schema, Version, ConfigureLang, RedfishValue);
+ if (!EFI_ERROR (Status)) {
+ //
+ // Configuration changed. Enable system reboot flag.
+ //
+ REDFISH_ENABLE_SYSTEM_REBOOT ();
+ } else {
+ DEBUG ((DEBUG_ERROR, "%a: apply %s array failed: %r\n", __func__, ConfigureLang, Status));
+ }
} else {
- DEBUG ((DEBUG_ERROR, "%a: apply %s array failed: %r\n", __func__, ConfigureLang, Status));
+ DEBUG ((DEBUG_ERROR, "%a: %a.%a %s array value has no change\n", __func__, Schema, Version, ConfigureLang));
}
} else {
- DEBUG ((DEBUG_ERROR, "%a: %a.%a %s array value has no change\n", __func__, Schema, Version, ConfigureLang));
+ DEBUG ((DEBUG_ERROR, "%a: %a.%a %s array value has invalid element, skip!\n", __func__, Schema, Version, ConfigureLang));
+ Status = EFI_DEVICE_ERROR;
}
for (Index = 0; Index < RedfishValue.ArrayCount; Index++) {
@@ -3817,6 +3826,98 @@ CompareRedfishPropertyVagueValues (
return TRUE;
}
+/**
+ This function goes through Head and StringArray to check below:
+ 1) Check and see if value in Redfish string array can be found in HII
+ configuration string array. This is to see if there is any invalid
+ values from Redfish.
+ 2) Check and see if size of Head is the same as ArraySize.
+ 3) Check and see if value in Redfish string array are all the same as the one
+ from HII configuration.
+
+ @param[in] Head The head of string array.
+ @param[in] StringArray Input string array.
+ @param[in] ArraySize The size of StringArray.
+ @param[out] ValueChanged TRUE when The order of Head is not the same as the order of StringArray.
+ FALSE when Head and StringArray are identical.
+
+ @retval EFI_INVALID_PARAMETER Input parameter is NULL or ArraySize is 0.
+ @retval EFI_NOT_FOUND The element in Head cannot be found in StringArray. This is invalid request.
+ @retval EFI_BAD_BUFFER_SIZE The size of Head is not the same as the size of StringArray. This is invalid request.
+
+**/
+EFI_STATUS
+ValidateRedfishStringArrayValues (
+ IN RedfishCS_char_Array *Head,
+ IN CHAR8 **StringArray,
+ IN UINTN ArraySize,
+ OUT BOOLEAN *ValueChanged
+ )
+{
+ UINTN Index;
+ UINTN ArrayIndex;
+ UINTN FirstMismatch;
+ RedfishCS_char_Array *CharArrayBuffer;
+
+ if ((Head == NULL) || (StringArray == NULL) || (ArraySize == 0) || (ValueChanged == NULL)) {
+ return EFI_INVALID_PARAMETER;
+ }
+
+ *ValueChanged = FALSE;
+ CharArrayBuffer = Head;
+ Index = 0;
+ FirstMismatch = 0;
+ while (CharArrayBuffer != NULL) {
+ //
+ // If the size of Head is bigger than StringArray, we still like to know how many
+ // element in Head. So we have this check to prevent buffer overflow.
+ //
+ if (Index < ArraySize) {
+ //
+ // Check to see if CharArrayBuffer and StringArray are identical at same position.
+ //
+ if (AsciiStrCmp (StringArray[Index], CharArrayBuffer->ArrayValue) != 0) {
+ if (*ValueChanged == FALSE) {
+ *ValueChanged = TRUE;
+ FirstMismatch = Index;
+ }
+
+ //
+ // CharArrayBuffer is not the same as the StringArray at Index. So the
+ // value is changed. But we still have to go through StringArray to see
+ // if CharArrayBuffer can be found in StringArray or not. If not, Head
+ // is invalid input from BMC.
+ //
+ for (ArrayIndex = FirstMismatch; ArrayIndex < ArraySize; ArraySize++) {
+ if (AsciiStrCmp (StringArray[ArrayIndex], CharArrayBuffer->ArrayValue) == 0) {
+ break;
+ }
+ }
+
+ if (ArrayIndex == ArraySize) {
+ DEBUG ((DEBUG_ERROR, "%a: input string: %a is not found in HII string list\n", __func__, CharArrayBuffer->ArrayValue));
+ return EFI_NOT_FOUND;
+ }
+ }
+ }
+
+ Index++;
+ CharArrayBuffer = CharArrayBuffer->Next;
+ }
+
+ //
+ // Check to see if the number of string from Redfish equals to the
+ // number of string returned by HII. HII only accepts the same
+ // number of string array due to the design or HII ordered list.
+ //
+ if (Index != ArraySize) {
+ DEBUG ((DEBUG_ERROR, "%a: input string size: %d is not the same as HII string list size: %d\n", __func__, Index, ArraySize));
+ return EFI_BAD_BUFFER_SIZE;
+ }
+
+ return EFI_SUCCESS;
+}
+
/**
Install Boot Maintenance Manager Menu driver.
--
2.17.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112025): https://edk2.groups.io/g/devel/message/112025
Mute This Topic: https://groups.io/mt/102967620/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [edk2-devel] [edk2-redfish-client][PATCH v2] RedfishClientPkg/RedfishFeatureUtilityLib: validate string array
2023-12-04 9:40 [edk2-devel] [edk2-redfish-client][PATCH v2] RedfishClientPkg/RedfishFeatureUtilityLib: validate string array Nickle Wang via groups.io
@ 2023-12-04 16:44 ` Igor Kulchytskyy via groups.io
0 siblings, 0 replies; 2+ messages in thread
From: Igor Kulchytskyy via groups.io @ 2023-12-04 16:44 UTC (permalink / raw)
To: Nickle Wang, devel@edk2.groups.io; +Cc: Abner Chang, Nick Ramirez
Reviewed-by: Igor Kulchytskyy <igork@ami.com>
Regards,
Igor
-----Original Message-----
From: Nickle Wang <nicklew@nvidia.com>
Sent: Monday, December 4, 2023 4:41 AM
To: devel@edk2.groups.io
Cc: Abner Chang <abner.chang@amd.com>; Igor Kulchytskyy <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
Subject: [EXTERNAL] [edk2-redfish-client][PATCH v2] RedfishClientPkg/RedfishFeatureUtilityLib: validate string array
**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**
Add function ValidateRedfishStringArrayValues to validate Redfish
request for string array type. There is case that user request
invalid string array and feature driver can not find corresponding
HII option.
Signed-off-by: Nickle Wang <nicklew@nvidia.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Cc: Nick Ramirez <nramirez@nvidia.com>
---
.../Library/RedfishFeatureUtilityLib.h | 28 +++
.../RedfishFeatureUtilityLib.c | 187 ++++++++++++++----
2 files changed, 172 insertions(+), 43 deletions(-)
diff --git a/RedfishClientPkg/Include/Library/RedfishFeatureUtilityLib.h b/RedfishClientPkg/Include/Library/RedfishFeatureUtilityLib.h
index 6347585c..24f0ad24 100644
--- a/RedfishClientPkg/Include/Library/RedfishFeatureUtilityLib.h
+++ b/RedfishClientPkg/Include/Library/RedfishFeatureUtilityLib.h
@@ -990,4 +990,32 @@ GetPendingSettings (
OUT EFI_STRING *SettingUri
);
+/**
+ This function goes through Head and StringArray to check below:
+ 1) Check and see if value in Redfish string array can be found in HII
+ configuration string array. This is to see if there is any invalid
+ values from Redfish.
+ 2) Check and see if size of Head is the same as ArraySize.
+ 3) Check and see if value in Redfish string array are all the same as the one
+ from HII configuration.
+
+ @param[in] Head The head of string array.
+ @param[in] StringArray Input string array.
+ @param[in] ArraySize The size of StringArray.
+ @param[out] ValueChanged TRUE when The order of Head is not the same as the order of StringArray.
+ FALSE when Head and StringArray are identical.
+
+ @retval EFI_INVALID_PARAMETER Input parameter is NULL or ArraySize is 0.
+ @retval EFI_NOT_FOUND The element in Head cannot be found in StringArray. This is invalid request.
+ @retval EFI_BAD_BUFFER_SIZE The size of Head is not the same as the size of StringArray. This is invalid request.
+
+**/
+EFI_STATUS
+ValidateRedfishStringArrayValues (
+ IN RedfishCS_char_Array *Head,
+ IN CHAR8 **StringArray,
+ IN UINTN ArraySize,
+ OUT BOOLEAN *ValueChanged
+ );
+
#endif
diff --git a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
index 6652539c..07033488 100644
--- a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
+++ b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
@@ -866,6 +866,7 @@ ApplyFeatureSettingsStringArrayType (
EDKII_REDFISH_VALUE RedfishValue;
UINTN Index;
RedfishCS_char_Array *Buffer;
+ BOOLEAN ValueChanged;
if (IS_EMPTY_STRING (Schema) || IS_EMPTY_STRING (Version) || IS_EMPTY_STRING (ConfigureLang) || (ArrayHead == NULL)) {
return EFI_INVALID_PARAMETER;
@@ -886,61 +887,69 @@ ApplyFeatureSettingsStringArrayType (
}
//
- // If there is no change in array, do nothing
+ // Validate input string array from BMC to see:
+ // 1) String array from BMC is valid or not.
+ // 2) If there is no change in array, do nothing.
//
- if (!CompareRedfishStringArrayValues (ArrayHead, RedfishValue.Value.StringArray, RedfishValue.ArrayCount)) {
- //
- // Apply settings from redfish
- //
- DEBUG ((DEBUG_MANAGEABILITY, "%a: %a.%a apply %s for array\n", __func__, Schema, Version, ConfigureLang));
- FreeArrayTypeRedfishValue (&RedfishValue);
-
- //
- // Convert array from RedfishCS_char_Array to EDKII_REDFISH_VALUE
- //
- RedfishValue.ArrayCount = 0;
- Buffer = ArrayHead;
- while (Buffer != NULL) {
- RedfishValue.ArrayCount += 1;
- Buffer = Buffer->Next;
- }
+ Status = ValidateRedfishStringArrayValues (ArrayHead, RedfishValue.Value.StringArray, RedfishValue.ArrayCount, &ValueChanged);
+ if (!EFI_ERROR (Status)) {
+ if (ValueChanged) {
+ //
+ // Apply settings from redfish
+ //
+ DEBUG ((DEBUG_MANAGEABILITY, "%a: %a.%a apply %s for array\n", __func__, Schema, Version, ConfigureLang));
+ FreeArrayTypeRedfishValue (&RedfishValue);
- //
- // Allocate pool for new values
- //
- RedfishValue.Value.StringArray = AllocatePool (RedfishValue.ArrayCount *sizeof (CHAR8 *));
- if (RedfishValue.Value.StringArray == NULL) {
- ASSERT (FALSE);
- return EFI_OUT_OF_RESOURCES;
- }
+ //
+ // Convert array from RedfishCS_char_Array to EDKII_REDFISH_VALUE
+ //
+ RedfishValue.ArrayCount = 0;
+ Buffer = ArrayHead;
+ while (Buffer != NULL) {
+ RedfishValue.ArrayCount += 1;
+ Buffer = Buffer->Next;
+ }
- Buffer = ArrayHead;
- Index = 0;
- while (Buffer != NULL) {
- RedfishValue.Value.StringArray[Index] = AllocateCopyPool (AsciiStrSize (Buffer->ArrayValue), Buffer->ArrayValue);
- if (RedfishValue.Value.StringArray[Index] == NULL) {
+ //
+ // Allocate pool for new values
+ //
+ RedfishValue.Value.StringArray = AllocatePool (RedfishValue.ArrayCount *sizeof (CHAR8 *));
+ if (RedfishValue.Value.StringArray == NULL) {
ASSERT (FALSE);
- FreePool (RedfishValue.Value.StringArray);
return EFI_OUT_OF_RESOURCES;
}
- Buffer = Buffer->Next;
- Index++;
- }
+ Buffer = ArrayHead;
+ Index = 0;
+ while (Buffer != NULL) {
+ RedfishValue.Value.StringArray[Index] = AllocateCopyPool (AsciiStrSize (Buffer->ArrayValue), Buffer->ArrayValue);
+ if (RedfishValue.Value.StringArray[Index] == NULL) {
+ ASSERT (FALSE);
+ FreePool (RedfishValue.Value.StringArray);
+ return EFI_OUT_OF_RESOURCES;
+ }
- ASSERT (Index <= RedfishValue.ArrayCount);
+ Buffer = Buffer->Next;
+ Index++;
+ }
- Status = RedfishPlatformConfigSetValue (Schema, Version, ConfigureLang, RedfishValue);
- if (!EFI_ERROR (Status)) {
- //
- // Configuration changed. Enable system reboot flag.
- //
- REDFISH_ENABLE_SYSTEM_REBOOT ();
+ ASSERT (Index <= RedfishValue.ArrayCount);
+
+ Status = RedfishPlatformConfigSetValue (Schema, Version, ConfigureLang, RedfishValue);
+ if (!EFI_ERROR (Status)) {
+ //
+ // Configuration changed. Enable system reboot flag.
+ //
+ REDFISH_ENABLE_SYSTEM_REBOOT ();
+ } else {
+ DEBUG ((DEBUG_ERROR, "%a: apply %s array failed: %r\n", __func__, ConfigureLang, Status));
+ }
} else {
- DEBUG ((DEBUG_ERROR, "%a: apply %s array failed: %r\n", __func__, ConfigureLang, Status));
+ DEBUG ((DEBUG_ERROR, "%a: %a.%a %s array value has no change\n", __func__, Schema, Version, ConfigureLang));
}
} else {
- DEBUG ((DEBUG_ERROR, "%a: %a.%a %s array value has no change\n", __func__, Schema, Version, ConfigureLang));
+ DEBUG ((DEBUG_ERROR, "%a: %a.%a %s array value has invalid element, skip!\n", __func__, Schema, Version, ConfigureLang));
+ Status = EFI_DEVICE_ERROR;
}
for (Index = 0; Index < RedfishValue.ArrayCount; Index++) {
@@ -3817,6 +3826,98 @@ CompareRedfishPropertyVagueValues (
return TRUE;
}
+/**
+ This function goes through Head and StringArray to check below:
+ 1) Check and see if value in Redfish string array can be found in HII
+ configuration string array. This is to see if there is any invalid
+ values from Redfish.
+ 2) Check and see if size of Head is the same as ArraySize.
+ 3) Check and see if value in Redfish string array are all the same as the one
+ from HII configuration.
+
+ @param[in] Head The head of string array.
+ @param[in] StringArray Input string array.
+ @param[in] ArraySize The size of StringArray.
+ @param[out] ValueChanged TRUE when The order of Head is not the same as the order of StringArray.
+ FALSE when Head and StringArray are identical.
+
+ @retval EFI_INVALID_PARAMETER Input parameter is NULL or ArraySize is 0.
+ @retval EFI_NOT_FOUND The element in Head cannot be found in StringArray. This is invalid request.
+ @retval EFI_BAD_BUFFER_SIZE The size of Head is not the same as the size of StringArray. This is invalid request.
+
+**/
+EFI_STATUS
+ValidateRedfishStringArrayValues (
+ IN RedfishCS_char_Array *Head,
+ IN CHAR8 **StringArray,
+ IN UINTN ArraySize,
+ OUT BOOLEAN *ValueChanged
+ )
+{
+ UINTN Index;
+ UINTN ArrayIndex;
+ UINTN FirstMismatch;
+ RedfishCS_char_Array *CharArrayBuffer;
+
+ if ((Head == NULL) || (StringArray == NULL) || (ArraySize == 0) || (ValueChanged == NULL)) {
+ return EFI_INVALID_PARAMETER;
+ }
+
+ *ValueChanged = FALSE;
+ CharArrayBuffer = Head;
+ Index = 0;
+ FirstMismatch = 0;
+ while (CharArrayBuffer != NULL) {
+ //
+ // If the size of Head is bigger than StringArray, we still like to know how many
+ // element in Head. So we have this check to prevent buffer overflow.
+ //
+ if (Index < ArraySize) {
+ //
+ // Check to see if CharArrayBuffer and StringArray are identical at same position.
+ //
+ if (AsciiStrCmp (StringArray[Index], CharArrayBuffer->ArrayValue) != 0) {
+ if (*ValueChanged == FALSE) {
+ *ValueChanged = TRUE;
+ FirstMismatch = Index;
+ }
+
+ //
+ // CharArrayBuffer is not the same as the StringArray at Index. So the
+ // value is changed. But we still have to go through StringArray to see
+ // if CharArrayBuffer can be found in StringArray or not. If not, Head
+ // is invalid input from BMC.
+ //
+ for (ArrayIndex = FirstMismatch; ArrayIndex < ArraySize; ArraySize++) {
+ if (AsciiStrCmp (StringArray[ArrayIndex], CharArrayBuffer->ArrayValue) == 0) {
+ break;
+ }
+ }
+
+ if (ArrayIndex == ArraySize) {
+ DEBUG ((DEBUG_ERROR, "%a: input string: %a is not found in HII string list\n", __func__, CharArrayBuffer->ArrayValue));
+ return EFI_NOT_FOUND;
+ }
+ }
+ }
+
+ Index++;
+ CharArrayBuffer = CharArrayBuffer->Next;
+ }
+
+ //
+ // Check to see if the number of string from Redfish equals to the
+ // number of string returned by HII. HII only accepts the same
+ // number of string array due to the design or HII ordered list.
+ //
+ if (Index != ArraySize) {
+ DEBUG ((DEBUG_ERROR, "%a: input string size: %d is not the same as HII string list size: %d\n", __func__, Index, ArraySize));
+ return EFI_BAD_BUFFER_SIZE;
+ }
+
+ return EFI_SUCCESS;
+}
+
/**
Install Boot Maintenance Manager Menu driver.
--
2.17.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112047): https://edk2.groups.io/g/devel/message/112047
Mute This Topic: https://groups.io/mt/102967620/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-04 16:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-04 9:40 [edk2-devel] [edk2-redfish-client][PATCH v2] RedfishClientPkg/RedfishFeatureUtilityLib: validate string array Nickle Wang via groups.io
2023-12-04 16:44 ` Igor Kulchytskyy via groups.io
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox