From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.66]) by mx.groups.io with SMTP id smtpd.web10.196569.1672281658223547653 for ; Wed, 28 Dec 2022 18:40:58 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ami.com header.s=selector1 header.b=XfjLfEA7; spf=pass (domain: ami.com, ip: 40.107.93.66, mailfrom: igork@ami.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U+5eYp6+95KHo9ePMqWo3y77S0BqoCZoQHzsvJyEf4ltcRaU45jef3gZjZ3BojrmFRM2dMWFExiZJAh76kKMk+VJCU3fc53xaHnHuQJw5Zigi2h1rqNtHlEXlWI3Owdn2iNSjPPHqHB6lJ0ajh+4/rB0PsryrZ/pDFMDFlMX9hQm4i1tqSlDmE3a6ujpicN1ARJKUEdJwz5k0JHXnyp/bxGmcuWzdzV6YEaPG5LB5CzxK7k8dJN9+PLspb1NAv6S9apoKIXjIS4qo1OcHYEePUhXuyBSPt8WDooNEYjE43R2uIbRAfzmQGYBA801lg7JWEMAWVVe2dsqeZDngL7wug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ou9DLy5Z3HBwibI4R3PdgftVCTbc+ivbuGqdfQZosAg=; b=TVSfHDjTQL2+NjVI1nUt5xYaoiTn0Qh96gMCKxF8CZ3et97AO4GHYnMTuJdnbRNvHdlYQQJ4FZLeD1sI9J2pRcJ/TIggstvsLK23feV1YsKIIYKcnIPcqxmF7326PN1rLTmsXPRtaRL7UBAtrf+GJXMzcDIm9XOCnaWgWdFJY3Ukjb8kzSd1b0XNbhWUoK3C/HS6xe0xl+zFrnj5npGpsU57D+Nu9tPXS54FvJ9YGAojlEswqIt0wVNkh8AHLKcfmbjS6BRYVxlTW5pPohG+2+MDVZzHaAbx4K/YoNZJ/9AUM7bdNjRiHaEN+zb9QfG8nEBAdxduhQCZOi1FmctaUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ami.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ou9DLy5Z3HBwibI4R3PdgftVCTbc+ivbuGqdfQZosAg=; b=XfjLfEA75DE4yBTKi2CbYSfMKo+cEcGgfltwA0H+zRIEkuaSyJmrntaSDoHU8HF6FTKYOeZNgf7pp2iDrWW0sbJBXOxvaqlxuxBxyyGPLXkvBOyeS4CR26enDPzE37+uO+iv3YUmTdosLxJTYNgflFxM+NMA2OOd3ARy1u0N6GM= Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by SJ0PR10MB4574.namprd10.prod.outlook.com (2603:10b6:a03:2dd::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.16; Thu, 29 Dec 2022 02:40:56 +0000 Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::f1ea:b179:62e1:8cb8]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::f1ea:b179:62e1:8cb8%8]) with mapi id 15.20.5944.016; Thu, 29 Dec 2022 02:40:56 +0000 From: "Igor Kulchytskyy" To: "abner.chang@amd.com" , "devel@edk2.groups.io" CC: Nickle Wang Subject: Re: [PATCH V3 3/3] RedfishPkg/Include: Redfish USB Interface V2 update Thread-Topic: [EXTERNAL] [PATCH V3 3/3] RedfishPkg/Include: Redfish USB Interface V2 update Thread-Index: AQHZGyiY35kB+39jP0W/6ZCb5b4zHq6EJ5+g Date: Thu, 29 Dec 2022 02:40:56 +0000 Message-ID: References: <20221229015437.1353-1-abner.chang@amd.com> <20221229015437.1353-4-abner.chang@amd.com> In-Reply-To: <20221229015437.1353-4-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ami.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|SJ0PR10MB4574:EE_ x-ms-office365-filtering-correlation-id: e62a1466-8bb3-488c-7ee8-08dae9461cc3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wN2f672ApcIWD1Y1aktveRk75zMA7YFO2d5vip+bsQBtyllYQ047pWkUM/Mbts6uWlww54ziEdyH9cJUyfo5KqG/AijGrchDS/gLvzAZHZvaDvLgacFEKyeK2aQJDBN+6bu6GNrOE+4tF8FD9szrJMbatnNGAR3m7TR5EC8YMovZgOG0pOGgUzldlV2+DLkn1WgenG+O4DBD4yc5T+PvxaDqyZE2hOJ9xwh9nVwWZ6M+XwrT4cI/eneWCsTptCSeusg8KSovZb3FCrO9/aPENod2iY6FLhGT2TS97SlhfirnC06Mi4oFVtux7q+Cx5ppCGEOaY9DszHQn5T7+93lqD0a9i8YISoCgJa8kkIKa9xw6awLu0pfHUSN0lV1BmFRDTzDiqyeg8JzHvcipwTDSX+IwW3pF3L+D+QeODu5MxdtO3FuE35i1+6FJiDtr78IUzVka9uF2BPGpLepfjs3HsMhes8t/OFt5ujFQT4TZe2u52YjSiSxnpA/T1YITBxXUwUeTLZxaXzULHlNTi+uAmZprT3MCRLRCuiTLgiwuZES7Tmae/ryRuVNbEQqv9BCkLDllHdsQYtI3jBLJ3K2ULOmxqwajp1vA2V6CGNnG1NiuQXmwFWzLUerMDAa5STCvgMGi/4yU9k64KGj6WSjywRxRs/FSQqFc/5fKnC0MWcVnUKwfeGBiuSskReZ+xylMvxCml/NnscU/ikTvRUyDg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5185.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39850400004)(396003)(346002)(366004)(451199015)(83380400001)(33656002)(71200400001)(186003)(9686003)(478600001)(7696005)(40140700001)(55016003)(86362001)(26005)(38070700005)(38100700002)(122000001)(5660300002)(41300700001)(64756008)(66476007)(66946007)(53546011)(4326008)(6506007)(66446008)(76116006)(2906002)(8936002)(8676002)(15650500001)(316002)(52536014)(110136005)(66556008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?y+tFZ4nngiDsB/9eC5DoVHic+j+z1XgSm5cXar05j8xUCgfYIPKBJS0QwAKd?= =?us-ascii?Q?e1bhWLIaTa9m+ZenE/xMe5GEvL4lXqLTA//x6AI1EGzfZPTYNt7tcLwHQvA7?= =?us-ascii?Q?v49bqcoALRM+XVlAknHo7ot2LXAsX8cDp/bOI9y4uz4tpZDDS/T8lNwCvN/f?= =?us-ascii?Q?LZPfU4MSooVRFuCZDqHN9KaNiDj32hPdWDtkGD3r+Asxc2wq6YSEQi4pHDAF?= =?us-ascii?Q?gX9k3JjsJ4jFmw+pclz2KU8NlFRUiGQawqlupZqCR6hKIFKMmD/FEe5PsP0/?= =?us-ascii?Q?7o+L4UpeUSZPBCvex6LnF3Y31SiMyHr79EIXTAfVMchH5w6QZlUMUjkjPD1i?= =?us-ascii?Q?hhwzgqZy+lt/cnlAoeTynED84gRdMnQMh/JggzmKVq5NzsqWCQafVJsEFbdR?= =?us-ascii?Q?K9hfog0mrPUYa0H/7TC0N23cd7DCz5dtbVGc3MJ1wokbvRd2BNsnfrLEXz/D?= =?us-ascii?Q?Ec1A+Hf1KxAzLdDRxGiXyYbMbwWll/ajbWK6ukwzPbp8pqOnObgQfDu6eXAM?= =?us-ascii?Q?zEnr8QyoN00CbVmk+YK/NDHDlHKaHwc+Xxm6e5T1tyGcKIgcfBZQhAzpGgrM?= =?us-ascii?Q?v9s8cxDnhIuhd0Mc3u68y2cys2cWlOjwKmCvbR1L8NbMuvz98QDpGdKb4X9G?= =?us-ascii?Q?EhmD4M2S+JxiuX8qFN0Do/4jear3JfJm6MSXJYSbhoN4N5AnsMHlDD4DDPK/?= =?us-ascii?Q?PQTXstIsfe8APX3g+8MZfn+ftBzev5Vmeannnh/r3u8IwyLFwjGs9jACB7AD?= =?us-ascii?Q?ef4yYEMuUaF3FrQgvnGhNZU2dJsTBingQlJSi2i+TZQTp3sUd/wY/d0JlKqK?= =?us-ascii?Q?RppGrKZp6D2EBALj1SKrvH6WYa/xcK9w2OPChOOL/aH6K2QoTwiEd7+LPJzg?= =?us-ascii?Q?CjLWY1JiPaT5DqOWvObcpQyGQmKxEedRNX5XNAEUh6yOWeqLXC/RklYPiLHW?= =?us-ascii?Q?zCWvuaJPK8n0yb+4BG+AbQFRkEIqVwxHBeptjfcpQ/1n6jtsvA4iN6dCqTag?= =?us-ascii?Q?3GVqmWpygIh/4aJCferjoOMvSv29F0Y8lKHDOwAo6ol0XIXs7NgnA0mO3hJN?= =?us-ascii?Q?lnt9C445PZDPswTmvqxRkbVTd4Jiu7sqZXZzfTmfjO0IKV5mCPmSydeDX3cZ?= =?us-ascii?Q?E/Jc0BqVnGhKJTJChqh3WIZYr/9FMrcJQwQFw0ILCpCFTqKBIGVnxpF8k7tD?= =?us-ascii?Q?vK6yDGE+Xj/wSleONuxmZ/WWNJ94e4o00Sz1RHwy+D989SDRAsFMpLmik1FD?= =?us-ascii?Q?bdlIAcfiXRvavB/KNNra7JO+sLFFpPcXpYahveI2bXNGh6rAv9lromkCfL1M?= =?us-ascii?Q?WqEHDkYEw95XoClggksjok2dZaqkybCVmuQ19KA83vQdkZ6X4J+idknWj3f8?= =?us-ascii?Q?+SACF03JTigVzvp0xLTrJSktX0C31vFaTOaJaVWcJ7qUYANWnB9oBYEh/mM7?= =?us-ascii?Q?0ExyiZquGgENMAwhYvjhA1UhVCerdpDn4cPb9rvPhkA77vJ31sfZFgKQPTG1?= =?us-ascii?Q?u2ato9gY+yCjI7rlVNeiE6S3NlInRUYxJ9VbTrrjG+aRyjuB4HfwIaQyJP7g?= =?us-ascii?Q?vurUqGv3CnNZU/OYqnY=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e62a1466-8bb3-488c-7ee8-08dae9461cc3 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2022 02:40:56.5277 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +TX3P0iueffB6Fnl3zJKOQ+cXr7xkajJnngDL+DmKlRl/G3iJKEGhhrXnQH0WFEm X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4574 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Igor Kulchytskyy -----Original Message----- From: abner.chang@amd.com Sent: Wednesday, December 28, 2022 8:55 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [EXTERNAL] [PATCH V3 3/3] RedfishPkg/Include: Redfish USB Interfac= e V2 update **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** From: Abner Chang Support USB_INTERFACE_DEVICE_DESCRIPTOR_V2 which is updated in Redfish Host= Interface spec v1.3. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Reviewed-by: Igor Kulchytskyy Reviewed-by: Nickle Wang --- .../IndustryStandard/RedfishHostInterface.h | 25 ++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h b/R= edfishPkg/Include/IndustryStandard/RedfishHostInterface.h index 49b3ceee39c..022bd1f36ef 100644 --- a/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h +++ b/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h @@ -3,6 +3,7 @@ Copyright (c) 2019, Intel Corporation. All rights reserved.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (C) 2022 Advanced Micro Devices, Inc. All rights + reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -29,6 +30,18 @@ #define REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_IP4 0x01 #define REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_IP6 0x02 +/// +/// Definitions for IP assignment tyeps. +/// +typedef enum { + RedfishHostIpAssignmentUnknown, + RedfishHostIpAssignmentStatic, + RedfishHostIpAssignmentDhcp, + RedfishHostIpAssignmentAutoConfigure, + RedfishHostIpAssignmentHostSelected, + RedfishHostIpAssignmentReserved +} REDFISH_HOST_IP_ASSIGNMENT; + #pragma pack(1) /// /// Structure definitions of Host Interface device type 04h (USB Network I= nterface V2) @@ -40,12 +53,18 @@ typedef struct { ///< idVendor field of the USB = descriptor. UINT16 IdProduct; ///< The Product ID of the devi= ce, as read from the ///< idProduct field of the USB= descriptor. - UINT8 SecialNumberStr; ///< The string number for the = Serial Number of the + UINT8 SerialNumberStr; ///< The string number for the = Serial Number of the ///< device. The string data is= read from the ///< iSerialNumber.bDescriptorT= ype field of the USB ///< descriptor, and is convert= ed from Unicode to ASCII ///< and is NULL terminated. UINT8 MacAddress[6]; ///< The MAC address of the PCI= /PCIe network device. + + /// + /// Below is defined in Redfish Host Interface spec v1.3 /// + UINT16 Characteristics; ///< Additional device characte= ristics. + UINT16 CredentialBootstrappingHandle; ///< Credential bootstrapping h= andle. } USB_INTERFACE_DEVICE_DESCRIPTOR_V2; // @@ -74,6 +93,10 @@ typedef struct { /// /// Define union for the Host Interface Device Descriptor /// +#define USB_INTERFACE_DEVICE_DESCRIPTOR_V2_SIZE_1_3 0x11 ///< Leng= th USB interface device v2 defined in + ///< Redf= ish host interface spec v1.3 +#define USB_INTERFACE_DEVICE_DESCRIPTOR_V2_SIZE_1_2 0x0d ///< Leng= th USB interface device v2 defined in + ///< +Redfish host interface spec v1.2 typedef union { USB_INTERFACE_DEVICE_DESCRIPTOR_V2 UsbDeviceV2; ///< Devi= ce type USB V2 device discriptor. PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2 PciPcieDeviceV2; ///< Devi= ce type PCI/PCIe V2 device discriptor. -- 2.37.1.windows.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= .