* [edk2-staging][PATCH V2] edk2-staging/RedfishClientPkg: Fix typo @ 2022-12-01 3:29 Nickle Wang 2022-12-01 3:30 ` [edk2-devel] " Chang, Abner 0 siblings, 1 reply; 6+ messages in thread From: Nickle Wang @ 2022-12-01 3:29 UTC (permalink / raw) To: devel; +Cc: Abner Chang, Igor Kulchytskyy, Nick Ramirez Fix typo in RedfishPlatformConfigImpl.c Signed-off-by: Nickle Wang <nicklew@nvidia.com> Cc: Abner Chang <abner.chang@amd.com> Cc: Igor Kulchytskyy <igork@ami.com> Cc: Nick Ramirez <nramirez@nvidia.com> --- RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c index 525e666b6c..b2bb5f64e4 100644 --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c @@ -1,6 +1,6 @@ /** @file - The implementation of EDKII Redfidh Platform Config Protocol. + The implementation of EDKII Redfish Platform Config Protocol. (C) Copyright 2021-2022 Hewlett Packard Enterprise Development LP<BR> -- 2.38.1.windows.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [edk2-staging][PATCH V2] edk2-staging/RedfishClientPkg: Fix typo 2022-12-01 3:29 [edk2-staging][PATCH V2] edk2-staging/RedfishClientPkg: Fix typo Nickle Wang @ 2022-12-01 3:30 ` Chang, Abner 2022-12-01 14:25 ` Igor Kulchytskyy 2022-12-05 15:16 ` Rebecca Cran 0 siblings, 2 replies; 6+ messages in thread From: Chang, Abner @ 2022-12-01 3:30 UTC (permalink / raw) To: devel@edk2.groups.io, nicklew@nvidia.com; +Cc: Igor Kulchytskyy, Nick Ramirez [-- Attachment #1: Type: text/plain, Size: 1643 bytes --] [AMD Official Use Only - General] Reviewed-by: Abner Chang <abner.chang@amd.com> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nickle > Wang via groups.io > Sent: Thursday, December 1, 2022 11:29 AM > To: devel@edk2.groups.io > Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy > <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com> > Subject: [edk2-devel] [edk2-staging][PATCH V2] edk2- > staging/RedfishClientPkg: Fix typo > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Fix typo in RedfishPlatformConfigImpl.c > > Signed-off-by: Nickle Wang <nicklew@nvidia.com> > Cc: Abner Chang <abner.chang@amd.com> > Cc: Igor Kulchytskyy <igork@ami.com> > Cc: Nick Ramirez <nramirez@nvidia.com> > --- > RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c > b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c > index 525e666b6c..b2bb5f64e4 100644 > --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c > +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c > @@ -1,6 +1,6 @@ > /** @file > > - The implementation of EDKII Redfidh Platform Config Protocol. > + The implementation of EDKII Redfish Platform Config Protocol. > > (C) Copyright 2021-2022 Hewlett Packard Enterprise Development LP<BR> > > -- > 2.38.1.windows.1 > > > > > [-- Attachment #2: winmail.dat --] [-- Type: application/ms-tnef, Size: 17750 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [edk2-staging][PATCH V2] edk2-staging/RedfishClientPkg: Fix typo 2022-12-01 3:30 ` [edk2-devel] " Chang, Abner @ 2022-12-01 14:25 ` Igor Kulchytskyy 2022-12-05 15:16 ` Rebecca Cran 1 sibling, 0 replies; 6+ messages in thread From: Igor Kulchytskyy @ 2022-12-01 14:25 UTC (permalink / raw) To: Chang, Abner, devel@edk2.groups.io, nicklew@nvidia.com; +Cc: Nick Ramirez Reviewed-by: Igor Kulchytskyy <igork@ami.com> -----Original Message----- From: Chang, Abner <Abner.Chang@amd.com> Sent: Wednesday, November 30, 2022 10:30 PM To: devel@edk2.groups.io; nicklew@nvidia.com Cc: Igor Kulchytskyy <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com> Subject: [EXTERNAL] RE: [edk2-devel] [edk2-staging][PATCH V2] edk2-staging/RedfishClientPkg: Fix typo **CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.** [AMD Official Use Only - General] Reviewed-by: Abner Chang <abner.chang@amd.com> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nickle > Wang via groups.io > Sent: Thursday, December 1, 2022 11:29 AM > To: devel@edk2.groups.io > Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy > <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com> > Subject: [edk2-devel] [edk2-staging][PATCH V2] edk2- > staging/RedfishClientPkg: Fix typo > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Fix typo in RedfishPlatformConfigImpl.c > > Signed-off-by: Nickle Wang <nicklew@nvidia.com> > Cc: Abner Chang <abner.chang@amd.com> > Cc: Igor Kulchytskyy <igork@ami.com> > Cc: Nick Ramirez <nramirez@nvidia.com> > --- > RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c | 2 > +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c > b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c > index 525e666b6c..b2bb5f64e4 100644 > --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c > +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c > @@ -1,6 +1,6 @@ > /** @file > > - The implementation of EDKII Redfidh Platform Config Protocol. > + The implementation of EDKII Redfish Platform Config Protocol. > > (C) Copyright 2021-2022 Hewlett Packard Enterprise Development > LP<BR> > > -- > 2.38.1.windows.1 > > > > > -The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [edk2-staging][PATCH V2] edk2-staging/RedfishClientPkg: Fix typo 2022-12-01 3:30 ` [edk2-devel] " Chang, Abner 2022-12-01 14:25 ` Igor Kulchytskyy @ 2022-12-05 15:16 ` Rebecca Cran 2022-12-05 16:00 ` Chang, Abner 1 sibling, 1 reply; 6+ messages in thread From: Rebecca Cran @ 2022-12-05 15:16 UTC (permalink / raw) To: devel@edk2.groups.io, abner.chang@amd.com, nicklew@nvidia.com Cc: Igor Kulchytskyy, Nick Ramirez Hi Abner, I see you created a PR for this change. But https://github.com/tianocore/edk2/pull/3712 is failing with a strange error, and I don't have the setting it's talking about so something seems to have gone wrong. "The merge-queue pull request can't be update Details: `Pull request can't be updated with latest base branch changes Mergify needs the author permission to update the base branch of the pull request. @bcran needs to authorize modification on its head branch. err-code: 85842`" -- Rebecca Cran On 11/30/22 20:30, Chang, Abner via groups.io wrote: > [AMD Official Use Only - General] > > Reviewed-by: Abner Chang <abner.chang@amd.com> > >> -----Original Message----- >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nickle >> Wang via groups.io >> Sent: Thursday, December 1, 2022 11:29 AM >> To: devel@edk2.groups.io >> Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy >> <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com> >> Subject: [edk2-devel] [edk2-staging][PATCH V2] edk2- >> staging/RedfishClientPkg: Fix typo >> >> Caution: This message originated from an External Source. Use proper >> caution when opening attachments, clicking links, or responding. >> >> >> Fix typo in RedfishPlatformConfigImpl.c >> >> Signed-off-by: Nickle Wang <nicklew@nvidia.com> >> Cc: Abner Chang <abner.chang@amd.com> >> Cc: Igor Kulchytskyy <igork@ami.com> >> Cc: Nick Ramirez <nramirez@nvidia.com> >> --- >> RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git >> a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c >> b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c >> index 525e666b6c..b2bb5f64e4 100644 >> --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c >> +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c >> @@ -1,6 +1,6 @@ >> /** @file >> >> - The implementation of EDKII Redfidh Platform Config Protocol. >> + The implementation of EDKII Redfish Platform Config Protocol. >> >> (C) Copyright 2021-2022 Hewlett Packard Enterprise Development LP<BR> >> >> -- >> 2.38.1.windows.1 >> >> >> >> >> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [edk2-staging][PATCH V2] edk2-staging/RedfishClientPkg: Fix typo 2022-12-05 15:16 ` Rebecca Cran @ 2022-12-05 16:00 ` Chang, Abner 2022-12-05 16:11 ` Rebecca Cran 0 siblings, 1 reply; 6+ messages in thread From: Chang, Abner @ 2022-12-05 16:00 UTC (permalink / raw) To: Rebecca Cran, devel@edk2.groups.io, nicklew@nvidia.com Cc: Igor Kulchytskyy, Nick Ramirez [-- Attachment #1: Type: text/plain, Size: 3987 bytes --] [AMD Official Use Only - General] Hi Rebecca, I think you replied to the wrong email thread? This is the typo fix on the edk2-staing but not the one you contributed to RedfishPkg. But yes, I tried to have a PR from your branch to edk2 in order to merge the patch from your repo, however, the PR is out of date and I can't have a rebase on your branch. So I cherry pick the change from your branch and created a PR from my personal GitHub. So your change is merged to edk2 now, please just ignore this error message. Or does it require my actions to fix the error? Thanks for the helps on this. Abner > -----Original Message----- > From: Rebecca Cran <rebecca@quicinc.com> > Sent: Monday, December 5, 2022 11:17 PM > To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>; > nicklew@nvidia.com > Cc: Igor Kulchytskyy <igork@ami.com>; Nick Ramirez > <nramirez@nvidia.com> > Subject: Re: [edk2-devel] [edk2-staging][PATCH V2] edk2- > staging/RedfishClientPkg: Fix typo > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Hi Abner, > > I see you created a PR for this change. But > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith > ub.com%2Ftianocore%2Fedk2%2Fpull%2F3712&data=05%7C01%7Cabn > er.chang%40amd.com%7C2751d64c172f465f91f308dad6d3bb0b%7C3dd8961f > e4884e608e11a82d994e183d%7C0%7C0%7C638058502132324738%7CUnknow > n%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha > WwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=RHJ7YdPlTwgLE9K > Mm%2Fm9pd%2B2pNRyTygsg5ZxpKCli1M%3D&reserved=0 is failing > with a strange error, and I don't have the setting it's talking about so > something seems to have gone wrong. > > "The merge-queue pull request can't be update > Details: `Pull request can't be updated with latest base branch changes > > Mergify needs the author permission to update the base branch of the pull > request. > @bcran needs to authorize modification on its head branch. > err-code: 85842`" > > -- > Rebecca Cran > > On 11/30/22 20:30, Chang, Abner via groups.io wrote: > > [AMD Official Use Only - General] > > > > Reviewed-by: Abner Chang <abner.chang@amd.com> > > > >> -----Original Message----- > >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > Nickle > >> Wang via groups.io > >> Sent: Thursday, December 1, 2022 11:29 AM > >> To: devel@edk2.groups.io > >> Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy > >> <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com> > >> Subject: [edk2-devel] [edk2-staging][PATCH V2] edk2- > >> staging/RedfishClientPkg: Fix typo > >> > >> Caution: This message originated from an External Source. Use proper > >> caution when opening attachments, clicking links, or responding. > >> > >> > >> Fix typo in RedfishPlatformConfigImpl.c > >> > >> Signed-off-by: Nickle Wang <nicklew@nvidia.com> > >> Cc: Abner Chang <abner.chang@amd.com> > >> Cc: Igor Kulchytskyy <igork@ami.com> > >> Cc: Nick Ramirez <nramirez@nvidia.com> > >> --- > >> RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c | 2 > +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git > >> a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c > >> b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c > >> index 525e666b6c..b2bb5f64e4 100644 > >> --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c > >> +++ > b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c > >> @@ -1,6 +1,6 @@ > >> /** @file > >> > >> - The implementation of EDKII Redfidh Platform Config Protocol. > >> + The implementation of EDKII Redfish Platform Config Protocol. > >> > >> (C) Copyright 2021-2022 Hewlett Packard Enterprise Development > >> LP<BR> > >> > >> -- > >> 2.38.1.windows.1 > >> > >> > >> > >> > >> [-- Attachment #2: winmail.dat --] [-- Type: application/ms-tnef, Size: 18510 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [edk2-staging][PATCH V2] edk2-staging/RedfishClientPkg: Fix typo 2022-12-05 16:00 ` Chang, Abner @ 2022-12-05 16:11 ` Rebecca Cran 0 siblings, 0 replies; 6+ messages in thread From: Rebecca Cran @ 2022-12-05 16:11 UTC (permalink / raw) To: devel@edk2.groups.io, abner.chang@amd.com, Rebecca Cran (QUIC), nicklew@nvidia.com Cc: Igor Kulchytskyy, Nick Ramirez Sorry, yes I replied to the wrong email thread. Thanks! -- Rebecca Cran On 12/5/22 09:00, Chang, Abner via groups.io wrote: > [AMD Official Use Only - General] > > Hi Rebecca, > I think you replied to the wrong email thread? This is the typo fix on the edk2-staing but not the one you contributed to RedfishPkg. > > But yes, I tried to have a PR from your branch to edk2 in order to merge the patch from your repo, however, the PR is out of date and I can't have a rebase on your branch. So I cherry pick the change from your branch and created a PR from my personal GitHub. > So your change is merged to edk2 now, please just ignore this error message. Or does it require my actions to fix the error? > > Thanks for the helps on this. > Abner > >> -----Original Message----- >> From: Rebecca Cran <rebecca@quicinc.com> >> Sent: Monday, December 5, 2022 11:17 PM >> To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>; >> nicklew@nvidia.com >> Cc: Igor Kulchytskyy <igork@ami.com>; Nick Ramirez >> <nramirez@nvidia.com> >> Subject: Re: [edk2-devel] [edk2-staging][PATCH V2] edk2- >> staging/RedfishClientPkg: Fix typo >> >> Caution: This message originated from an External Source. Use proper >> caution when opening attachments, clicking links, or responding. >> >> >> Hi Abner, >> >> I see you created a PR for this change. But >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith >> ub.com%2Ftianocore%2Fedk2%2Fpull%2F3712&data=05%7C01%7Cabn >> er.chang%40amd.com%7C2751d64c172f465f91f308dad6d3bb0b%7C3dd8961f >> e4884e608e11a82d994e183d%7C0%7C0%7C638058502132324738%7CUnknow >> n%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha >> WwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=RHJ7YdPlTwgLE9K >> Mm%2Fm9pd%2B2pNRyTygsg5ZxpKCli1M%3D&reserved=0 is failing >> with a strange error, and I don't have the setting it's talking about so >> something seems to have gone wrong. >> >> "The merge-queue pull request can't be update >> Details: `Pull request can't be updated with latest base branch changes >> >> Mergify needs the author permission to update the base branch of the pull >> request. >> @bcran needs to authorize modification on its head branch. >> err-code: 85842`" >> >> -- >> Rebecca Cran >> >> On 11/30/22 20:30, Chang, Abner via groups.io wrote: >>> [AMD Official Use Only - General] >>> >>> Reviewed-by: Abner Chang <abner.chang@amd.com> >>> >>>> -----Original Message----- >>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of >> Nickle >>>> Wang via groups.io >>>> Sent: Thursday, December 1, 2022 11:29 AM >>>> To: devel@edk2.groups.io >>>> Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy >>>> <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com> >>>> Subject: [edk2-devel] [edk2-staging][PATCH V2] edk2- >>>> staging/RedfishClientPkg: Fix typo >>>> >>>> Caution: This message originated from an External Source. Use proper >>>> caution when opening attachments, clicking links, or responding. >>>> >>>> >>>> Fix typo in RedfishPlatformConfigImpl.c >>>> >>>> Signed-off-by: Nickle Wang <nicklew@nvidia.com> >>>> Cc: Abner Chang <abner.chang@amd.com> >>>> Cc: Igor Kulchytskyy <igork@ami.com> >>>> Cc: Nick Ramirez <nramirez@nvidia.com> >>>> --- >>>> RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c | 2 >> +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git >>>> a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c >>>> b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c >>>> index 525e666b6c..b2bb5f64e4 100644 >>>> --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c >>>> +++ >> b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c >>>> @@ -1,6 +1,6 @@ >>>> /** @file >>>> >>>> - The implementation of EDKII Redfidh Platform Config Protocol. >>>> + The implementation of EDKII Redfish Platform Config Protocol. >>>> >>>> (C) Copyright 2021-2022 Hewlett Packard Enterprise Development >>>> LP<BR> >>>> >>>> -- >>>> 2.38.1.windows.1 >>>> >>>> >>>> >>>> >>>> ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-12-05 16:11 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-12-01 3:29 [edk2-staging][PATCH V2] edk2-staging/RedfishClientPkg: Fix typo Nickle Wang 2022-12-01 3:30 ` [edk2-devel] " Chang, Abner 2022-12-01 14:25 ` Igor Kulchytskyy 2022-12-05 15:16 ` Rebecca Cran 2022-12-05 16:00 ` Chang, Abner 2022-12-05 16:11 ` Rebecca Cran
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox