From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 82AE9D81112 for ; Tue, 9 Jan 2024 14:15:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=OhpzBmyJrLFIgjaMsSIGNxbf8SMCh01se71/2ZXDKus=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704809709; v=1; b=IN3UfvbTDueTUhtXU16rG9txzyB7ijbCdfEIeKzhrcNMyQTIWHiSeX0E+iCynyeFMXhSqHkT 0Fk8AkLiRbDdUZPOQCaKZMbT2RkC1FTy37edokbV8YDCESuzn4QWD+IeS68IekP/lJm/3FcQzFW GMn1SwxrAapy3d3f80MN5RaE= X-Received: by 127.0.0.2 with SMTP id u7fQYY7687511xxK3ZG2AcWR; Tue, 09 Jan 2024 06:15:09 -0800 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.88]) by mx.groups.io with SMTP id smtpd.web10.17732.1704809707876285166 for ; Tue, 09 Jan 2024 06:15:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IwZoQ1vbgS2XEuHZvpbXEN3JEttAgbaEjKNferae3MozwdCkXwgPf/LejFHbC6yX4btR7C4bgdz/vLNOWg+PQLYOpBswafw2KqKs4okvXIBM0iMkXEvGCeFGiyN0jXgf4LhqTrgyJpZQd9N85xKF3/iczPjGj9arndFlc4D+XMxT/Y6IShvvlpofrDyQ77z2106emhZMciRnBxj5Q75oZPT1KJ874Lb6w718L+1Pgcf3WEpqM+bEwt2N9cwYAGlpXy4Cw9X8Rptt7cwFlwwa9iMRvzLTP5fohcfMON/h3v94tX9tYPyLMOMiv6q2xqSotaVwLXW07ni8t1pEm4vkTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ryB2zAQmrG7SrdrsZg0PwRKXbtHXPZO89UUMKhpeuGs=; b=YdFD5p134bAcDTuYrc73V9pVJaMFEP7W2pA+fGChQvCq/FJq2/VDoiXM3tRANpGj1p4yTmgzYuoBSghOWuG1smFdmc+3qPcWb1abTjCYOWrkgEv5+paeL6x94x2Q6gCpKliwNFWk1EiNFgc3GK4wIW7YI1PTogIxel1zptQM+gJg+xwpKAF6IMArjthgP2IoTglxRMU2E8kAjcum9o07VL61zt2HcHQx17tTNT3yajSD3CqIinUWwE0w1I3SWZ2gGzgkvaWr6OIgPM47sGN//SuhUEoCe8I3Ma71+6ULmJ8X3WOGxxpiL3L/faQ5mG29RdOxvpAzDsHXuEhGy6Gkgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by DS0PR10MB6973.namprd10.prod.outlook.com (2603:10b6:8:14d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Tue, 9 Jan 2024 14:15:03 +0000 X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::9dc0:d4e1:1d40:3e33]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::9dc0:d4e1:1d40:3e33%5]) with mapi id 15.20.7159.020; Tue, 9 Jan 2024 14:15:03 +0000 From: "Igor Kulchytskyy via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Abner Chang , Nick Ramirez Subject: Re: [edk2-devel] [PATCH v2] RedfishPkg/RedfishDebugLib: add function to print buffer. Thread-Topic: [EXTERNAL] [PATCH v2] RedfishPkg/RedfishDebugLib: add function to print buffer. Thread-Index: AQHaQuzkS4MSMvjbiE6WmdxuThgWPrDRhn4g Date: Tue, 9 Jan 2024 14:15:03 +0000 Message-ID: References: <20240109111314.536-1-nicklew@nvidia.com> In-Reply-To: <20240109111314.536-1-nicklew@nvidia.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|DS0PR10MB6973:EE_ x-ms-office365-filtering-correlation-id: 28594e47-f876-4b08-4dd4-08dc111d5f67 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: rQgI/OxR3+n6bn5uSYhVuQWQUw+KftSVBgFSUXJarsKJss98uWyY5VX2cKcBP0ZeqmiFubsQHQym46B4MqV5kxiC9/eXahdrY/kZvXzr7sDK7903lMa3reWxYz0lrjcyU/W+1DrLEKMMDYZYaNAOD25DGdhyYZ71xuQJDRIZCxaP/pJl4XtsKsjxLXHd7nfDobC9xVr8qKK0Un2fHWSG9csKFhS5OPRwz8NJ/O9KLZpl1cI8qowovyOTBookb92B7MVyY1ulvMONJeE/pv4/S4cvfcU7H3JOfCZRc01D0FMaTythKpQ50aYgmem8rdbLwUOnV2lr9DRhVXnZsx2lSV0FFe3yvhSUcr2WYmMUyAwCndS7HuOUqGx9Jv1QLITh4S2wincvS/af/LHLguu1nzMBPiLpfaQ4sh5GR8CNer3TgZAwPxvRRccFzYw9gA3mYP2hEMsyAveNUHd/t+w/VxYqlj76nOPkT9b4QkzGF6EXvADXsO7I8osvLhIHyWK2auRiT3aJ875dPcefWkTUmMVn4tmdGN06FsuPOQed9YJcRYC0NNL/KzwmOkd86+zz4mTgJqquRpOoK1z56b/TDWv+lz1dB2AQnliuqIZaEZASIaiMQTwRFJ8tQ93GRiAwmj90LsHjPcBQm7WxwHfw16pXg/yAd7HCC98jwDkIkIE= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PrcNigoENLFuISAGNQ3SVK7YKO6QpK7JUYisRKxktTRe9MY/qvYcbwRQZ5Nm?= =?us-ascii?Q?2zBv2rjAZel5SKCwlK5AehKvWBiFfZP4ww5Fx0wuhNlDZoHCC0MX3OOF/UkX?= =?us-ascii?Q?5vM813r4dfV7Bkk2rejAkvrauJo7h2uuKUm3NehrzHhBYYvxScVPaaTauO4j?= =?us-ascii?Q?xT65tLmE0hmtpyV5Czx8TnMgGi5aFXrShe5mn3IKqx8JjZHGcfqopGBxluW3?= =?us-ascii?Q?0NcDiJJ0ZOKli2p4gF1Sm/WWKU7pP3rS3BajZo3LGzLVjkkBBolLbFqS6ZgU?= =?us-ascii?Q?o0LaDWmKJoWkAUwUeFBYUBAjjqTUZhu+Pef85xFrwH4FGQa5e5tHqpbOXAn/?= =?us-ascii?Q?ZciZ66uoM9HOtefcJCuPvk4vuH8Oe7N3baCSLZ69aPXZWnSlBqn24X8jgviO?= =?us-ascii?Q?MiVsUA3NvG/fvEcfQs+TtuLerkjGcxGQMv4dGAKjKPzDVYl8JSHRJeETrXdP?= =?us-ascii?Q?HcGDz3XG9R80yppnFwLEtuEqDtcOPfR1hubBhDZn+6rPP/eKxJhCH9oEMfAz?= =?us-ascii?Q?x4OCPOLvDQ5yJYiu+VPvS8ST9mOHSm/4C1F/vjSGMSn8RCVyfSkri27Y3u88?= =?us-ascii?Q?Nbey+IfAA1GQy7O+e8FmoXDXffQC31UBiQ8fUxuS2BdO40p5BqKhIni7VW6M?= =?us-ascii?Q?hasUM8Kt+TN/xu6c+TwQy53mm4Hm7me8YIF7vKdHOhkt+9JVs8DRVBCJ9sqb?= =?us-ascii?Q?RkRyGFjOsRQxuv3x7JydIs8LdKejvAgVcYCkLTLypNjJGoWrpzg4NKtQQy/R?= =?us-ascii?Q?6DeY2t8C3EiEvkNpHosgRhiC3OmBR6GNlHLAM3id6YH1023IckSswte40eG1?= =?us-ascii?Q?OW7CEffBtfm5Jqqr7KrPDnFekYFuJJOrI1ul/aZmpBHOrjtZ5jN1x50lgvNA?= =?us-ascii?Q?y4Mua1JKEJ8cI2EqsF0MOIulhPXsOhF77Rzww44G6N7QKrbQfIOZyNc1KlJh?= =?us-ascii?Q?l+sBGDbenK3S159iLW0jdFlP3uQYMVmndNe5Mct5GuA6NBI1zQ743C0KwAVJ?= =?us-ascii?Q?WsWn8vg6vpC2WmFde9jh445q/OaVsG+V19t7IYSI+Dtgb0wTsKPQYrolsVDh?= =?us-ascii?Q?CM9W4mxRWH3AzakX/phuzshAKzR8GfHEp4xzwrmuOktkYsnYBrIqHyxnu9PG?= =?us-ascii?Q?2C9tNGxkro1Vbxjp74qmbR+dp8cfzWbkvFSepopDx32PJC1hR2xEV34A/jmD?= =?us-ascii?Q?ZqqcrNmMdVgU6DB7wWI8xvbP+1qOFYUXvFBQcVOL0fD3mPAEFKYJeyQtzOTQ?= =?us-ascii?Q?FTNJWyJMP75JnpGs7zlgTZBv1AYasPSZnh0zTNw5q9iLTiZ7Y+Klp+biZBP5?= =?us-ascii?Q?vb8tuwfFOeCiKzDvJOsT8drEgBvGZur6i4mEC0GALdydW+qImBfb+Z4/qjmI?= =?us-ascii?Q?1kCi97LsvzrAbU+qCBj2F/bGY9nRPXcc3ii4RIj7IYPEvvWdbA0YjTPQYIqw?= =?us-ascii?Q?YjKSjhMbFeVvPZcDnmImrTIa57JeOqEp153irAaL4+YVvpDtZHm5SV24Tbfo?= =?us-ascii?Q?4yitvTx5rbrS1m/GnrQ8xhAIVv8r01irS5YsE3kKRQ2AULCpKuJv+uDtCl8V?= =?us-ascii?Q?UcfIOc19RQx0Ozl/s9o=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28594e47-f876-4b08-4dd4-08dc111d5f67 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2024 14:15:03.2050 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: l7OptFQGeHd4UaUXBFQZdiTJLzCnznm2IfEmzr7nFmq/5kob5votbq3a5noLnsFx X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6973 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,igork@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8tzQB2MHkfyEyZGJolXrRQqHx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=IN3UfvbT; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Igor Kulchytskyy Regards, Igor -----Original Message----- From: Nickle Wang Sent: Tuesday, January 9, 2024 6:13 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Ni= ck Ramirez Subject: [EXTERNAL] [PATCH v2] RedfishPkg/RedfishDebugLib: add function to = print buffer. **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** Introduce DumpBuffer function to print the buffer content. This helps developer to debug Redfish issue. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/Include/Library/RedfishDebugLib.h | 20 ++++++++- .../Library/RedfishDebugLib/RedfishDebugLib.c | 45 +++++++++++++++++-- 2 files changed, 61 insertions(+), 4 deletions(-) diff --git a/RedfishPkg/Include/Library/RedfishDebugLib.h b/RedfishPkg/Incl= ude/Library/RedfishDebugLib.h index 5f75bad12a..3430cf1d14 100644 --- a/RedfishPkg/Include/Library/RedfishDebugLib.h +++ b/RedfishPkg/Include/Library/RedfishDebugLib.h @@ -1,7 +1,7 @@ /** @file This file defines the Redfish debug library interface. - Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved= . + Copyright (c) 2023-2024, NVIDIA CORPORATION & AFFILIATES. All rights res= erved. SPDX-License-Identifier: BSD-2-Clause-Patent @@ -138,4 +138,22 @@ DumpIpv4Address ( IN EFI_IPv4_ADDRESS *Ipv4Address ); +/** + Debug output raw data buffer. + + @param[in] ErrorLevel DEBUG macro error level + @param[in] Buffer Debug output data buffer. + @param[in] BufferSize The size of Buffer in byte. + + @retval EFI_SUCCESS Debug dump finished. + @retval EFI_INVALID_PARAMETER Buffer is NULL. + +**/ +EFI_STATUS +DumpBuffer ( + IN UINTN ErrorLevel, + IN UINT8 *Buffer, + IN UINTN BufferSize + ); + #endif diff --git a/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.c b/Redfish= Pkg/Library/RedfishDebugLib/RedfishDebugLib.c index efa9a5ca13..3728f51213 100644 --- a/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.c +++ b/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.c @@ -1,7 +1,7 @@ /** @file Redfish debug library to debug Redfish application. - Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved= . + Copyright (c) 2023-2024, NVIDIA CORPORATION & AFFILIATES. All rights res= erved. SPDX-License-Identifier: BSD-2-Clause-Patent @@ -19,8 +19,9 @@ #define IS_EMPTY_STRING(a) ((a) =3D=3D NULL || (a)[0] =3D=3D '\0') #endif -#define REDFISH_JSON_STRING_LENGTH 200 -#define REDFISH_JSON_OUTPUT_FORMAT (EDKII_JSON_COMPACT | EDKII_JSON_INDEN= T(2)) +#define REDFISH_JSON_STRING_LENGTH 200 +#define REDFISH_JSON_OUTPUT_FORMAT (EDKII_JSON_COMPACT | EDKII_JS= ON_INDENT(2)) +#define REDFISH_PRINT_BUFFER_BYTES_PER_ROW 16 /** Debug print the value of StatementValue. @@ -366,3 +367,41 @@ DumpIpv4Address ( return EFI_SUCCESS; } + +/** + Debug output raw data buffer. + + @param[in] ErrorLevel DEBUG macro error level + @param[in] Buffer Debug output data buffer. + @param[in] BufferSize The size of Buffer in byte. + + @retval EFI_SUCCESS Debug dump finished. + @retval EFI_INVALID_PARAMETER Buffer is NULL. + +**/ +EFI_STATUS +DumpBuffer ( + IN UINTN ErrorLevel, + IN UINT8 *Buffer, + IN UINTN BufferSize + ) +{ + UINTN Index; + + if (Buffer =3D=3D NULL) { + return EFI_INVALID_PARAMETER; + } + + DEBUG ((ErrorLevel, "Address: 0x%p size: %d\n", Buffer, BufferSize)); + for (Index =3D 0; Index < BufferSize; Index++) { + if (Index % REDFISH_PRINT_BUFFER_BYTES_PER_ROW =3D=3D 0) { + DEBUG ((ErrorLevel, "\n%04X: ", Index)); + } + + DEBUG ((ErrorLevel, "%02X ", Buffer[Index])); + } + + DEBUG ((ErrorLevel, "\n")); + + return EFI_SUCCESS; +} -- 2.34.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113450): https://edk2.groups.io/g/devel/message/113450 Mute This Topic: https://groups.io/mt/103617651/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-