From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.107.95.40]) by mx.groups.io with SMTP id smtpd.web10.77678.1671815984607819354 for ; Fri, 23 Dec 2022 09:19:45 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ami.com header.s=selector1 header.b=SezhsZE2; spf=pass (domain: ami.com, ip: 40.107.95.40, mailfrom: igork@ami.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T16P9dQZluao0z/8RaVktllAbUZ5d08nvPKA2pM+JsoRVCEDoTGQqDBqOf+lSZGfyU57BRwMPM4Es1LMtexPpA9pvKnJoCu11p4/TXn1kp8Ey3AG1EvKFaL3MJlfvDpDAgbLSLHlHmTura37aMcd9p+yHy9R0ZteSdqk1nA22y5PIJiQKghVfz8RirErWV3bEiu/atYHufzyzWUsJdLaRT3G4qBiyjN3cHUV44PmkcuO17X/Xpx1GItLu+zgc396raZ/7vie18eYVPOpB6cykUMZhM6pbT8F+x9Ul8mXsi45vK1kxTqW3hx78SvvKCVQjXRicPwEqqF+uv5noNneNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m78zjDX9ETNs27vNUAi6lrK8uptxIjEeP6LD/dF4wQA=; b=Jxx6waG7J5Dj7rp9JAj+cGYIv0LDywnYQ169wMd+iikRK/dNdKoEL6iu95apA4J3eSRaA0UKMiFfMXe2tGaGoYqk5AxZCP/iMngVkHJ0H3L6pmnx9+9lJCkzugrysd/Nm9QRGUaSGfP6YQCAxtIgKqXjWoCBm2hjNaRUGLXsLo4KjHKV18cFyEatc6Be0bwgOzaXOPS9UNkEIgfghbFpZPzmv8oi6DUTzRebkCMfXVxQaN7g7CfVJCbG3jn3CqbR8CWcDQ+MnqsMkK5FebN50Dtqv4Uqfzk6YYn7449HuQRflBvwKzYf9Scy1FA3MyQVsPhOdbcF0GfIje2PW7rnXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ami.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m78zjDX9ETNs27vNUAi6lrK8uptxIjEeP6LD/dF4wQA=; b=SezhsZE2V0sSm78C0wS7hrQHJEZVVNLGGe4bVM3R2VKGV0AQAvj705kstS3ROha53cA9EzPiuZGIJkyGMAY0xviVMOMl4ZzUzH1jx+17eZ5DayUFlIrzbzX5weLpFo5nWiF2SgFPDW6CSLeNAmQRbD7ayeWYK5eG8G2NARekHL0= Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by CY8PR10MB6610.namprd10.prod.outlook.com (2603:10b6:930:56::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Fri, 23 Dec 2022 17:19:42 +0000 Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::f1ea:b179:62e1:8cb8]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::f1ea:b179:62e1:8cb8%7]) with mapi id 15.20.5924.016; Fri, 23 Dec 2022 17:19:42 +0000 From: "Igor Kulchytskyy" To: "abner.chang@amd.com" , "devel@edk2.groups.io" Subject: Re: [PATCH 2/3] RedfishPkg/Include: Add Redfish IPMI definitions Thread-Topic: [EXTERNAL] [PATCH 2/3] RedfishPkg/Include: Add Redfish IPMI definitions Thread-Index: AQHZFsreUYXpPiwqnUaB4ud+IYoDFK57tzRg Date: Fri, 23 Dec 2022 17:19:42 +0000 Message-ID: References: <20221223123336.2014-1-abner.chang@amd.com> <20221223123336.2014-3-abner.chang@amd.com> In-Reply-To: <20221223123336.2014-3-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ami.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|CY8PR10MB6610:EE_ x-ms-office365-filtering-correlation-id: f9f7cfe6-dbb4-4efe-da88-08dae509e122 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xyFWvNdNPTZMVS9xUd0DKdA1COapH8Zv3cDIyzYs7RfmqPsIvEkAL9YULzYrWE1ZvBTgv2aSEt0tYlHPvuwUVQpiyGVOcXUKxm7xhZpeT7uvilRU3aXv6dimHpYF2FmqAHRFRMBqRxk/e/k7NRDkvrFbhs1HTTnwol43ui+kpsG9B7gRS/H4VOJ8IpvtTM1YyDgGjcPP20u94GtcvlJFIEVDk9LFO10UPMdslNhGnIGvu+9KO4Li2Gxy75hq7e4G1B7IeqH/Xlo786b26U8yrW7mOpzEY3Oqs3x9l60lHoOZhDpxFbh5J6M41akdLVBK0IdsBUgEimLbQuOQvBPnOdj2yTEnOxZPqWiyyibg+zWZmjFR5mJC3Nek8bsqub0WnfuTkt8VvWjwsUJ9//F30aOXY7KYYX7kgsMWg2r10mh430lbrwZJcbANjasV9MrmYB5yO5EzEKTdOWsVqbIzIbSCoNVzT2YgC44r/0gKHHJ63Jra7eDlkSKrrN5lK4985SCpGmXyoXYPn/wRZLTyDOUWElkhwPPA14hdfjndsjRSerRh5Cm/KKwLc8dwTCz5PnQq0wrt9nLXADk1ViewaHDs98UGiUv8KnrRkb0GnHloPYbrdwBeWZ8j/jUN43yaUdcg1vfLG1aCKt5XRheDxNebeNg7jqacbI6BhgJ+lYNmYtJSIU+IK23ZNovpb6H8FSrfDc5AWZvMAz+i09wGZQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5185.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39850400004)(346002)(366004)(376002)(136003)(396003)(451199015)(66476007)(66946007)(86362001)(76116006)(66446008)(8676002)(64756008)(5660300002)(316002)(52536014)(66556008)(8936002)(40140700001)(33656002)(41300700001)(7696005)(6506007)(53546011)(9686003)(83380400001)(26005)(71200400001)(186003)(38070700005)(122000001)(55016003)(38100700002)(110136005)(478600001)(2906002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5PVvgOHTLVqtqoCppXryOCk05ekaG9eoq2V1cmp2U2eScpVeO5WhUxkh7jtQ?= =?us-ascii?Q?doSTJw/PqtJqb1+6WHHzvAHNC2z4Hf774kgrhsYyJWRtbVPpzViBHHL0mEn7?= =?us-ascii?Q?vieKZGrrwPHMjEGpja5DtGvcLziL2AkaEYaaQ4SQ6glqtO/CBHb3ESmseqHP?= =?us-ascii?Q?xADdrS0k7Kn+H33ENYIWrPHRuKXaYxKSNKPcD+ZUnRCT73MmbjUNmabnghht?= =?us-ascii?Q?xxGFMovSgaLB82BCyL3az7cEQignVeH2odRb2WLFhDfe4gx0Co8zipN1Ngoz?= =?us-ascii?Q?4exOniiJufDkUeP8GNMJeyzb7R2KFz8NB543nA1eYMBBeN9B3QJswTCm1O3q?= =?us-ascii?Q?N90oU33rlEp2OR95KhuadQNTN1iIgcPtBO0hJfG3HT44iBOitcaDnAKWVmlP?= =?us-ascii?Q?J3CLtwN/uKWJl9J8dMx0B+Rmt5D9t2oQXgocyKkHfggzqElskzCez6Kkp+Xo?= =?us-ascii?Q?bS27sOzHdmUdh0NyiN5SU0lzRRxPvYJ2mT19g6SC1NVd4CWr+ZetzfjA+Hsv?= =?us-ascii?Q?+CLQoiFnvnf6YX6MvMCF1wTV0pYc3rZlINzZMmYFvQVj05Xdx/y9F+zq2DYE?= =?us-ascii?Q?nGK7n4It/2lGCxywOBoJSbIA2pJu+Nd622BocimTVoJ0ciqqDiZoGbjiCMkT?= =?us-ascii?Q?DT76p3+KIWm2AGO8Nv29XyIwbH6HvKZsu6zSbrxHe7UhmsAPDrPZvUGG3LbY?= =?us-ascii?Q?xsiMzgx27ldG7/mCqnJnITbtwXyQpz84bDgy+13mw7KDqE2AJMhJkw1+FI3F?= =?us-ascii?Q?HHSjt6FW8i/de4ueThnKd8UFSNPmQd7lCGoEs5iHuK2drWNzSPxSX6xud36c?= =?us-ascii?Q?rQVe0EiDdzwslKCr/PyZ+fhDk0vQCBYfa+KSdfD6aXz8wLqSYg6gmIavXDQr?= =?us-ascii?Q?VN19i1gaPSghmCa/9/NI6yXMh+F1CL8Pg2fLLiPGnbJRbIkGqXWN+bPI3qkN?= =?us-ascii?Q?IkMVoaptGbLc8BjllHD2ERqMyuQlaOVhr9BL65X6PeY0Kr5p63h3AzAVJLZl?= =?us-ascii?Q?HpJgwS5bc3Z/RFV5aruBXCCwGV3rOnme/g1fxeZIlUPM2s34SvFmpqaT1JnE?= =?us-ascii?Q?a3B2PTENjlLRl8BEnc2MLQB85rBWJ6cVBpGJEsYJWBOgmZD7CtXetk6ArDu3?= =?us-ascii?Q?aEBQ1sOxbM8p6zrnbq+frghVIlBeywINusvjgh/INNH7kyJQ9jxFS392UzOb?= =?us-ascii?Q?m1BpVHxGsfHMP7bNfgLgXqG8bsNxc+wncxhrUPDpST+IdquOX6v1a8N6EIOw?= =?us-ascii?Q?lLCTUBkOo/BR4bmPbIATp6aDej8wii7uWibJwlvU38QDKABUA6y8RJLwORVs?= =?us-ascii?Q?WneDpbQhN6SCmUWur5q9UXNozReWGJmZabixOv/R8qyaKcaQfrcN2XubyFUD?= =?us-ascii?Q?hpyFqEAhWGWXRwGn/8h6LY490+Ps13w83zK7E1z7AyCaDBj8lc+df7L+QAEh?= =?us-ascii?Q?cdsnCqpHW7VNorOGaejtMp0m5QkXxZjNErkMgv+/dMmeziSG8MFHfVJiAykf?= =?us-ascii?Q?5j1V6FEffP6U2Wnm3QOsMMPoFwT33+Nz7Pef7htxnvQ2vePUyAaOci3Kk+1D?= =?us-ascii?Q?I7xaCRiKyW2HcQfT7OQ=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f9f7cfe6-dbb4-4efe-da88-08dae509e122 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2022 17:19:42.0346 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: S2Qnv71QsxFpxHJNCLgADD6+V178UOhnX1S9RnH5sQ0gfr+Y+CKTG5x50k1ipnI7 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6610 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Abner, Please see my comments in the text below. Thank you, Igor -----Original Message----- From: abner.chang@amd.com Sent: Friday, December 23, 2022 7:34 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy Subject: [EXTERNAL] [PATCH 2/3] RedfishPkg/Include: Add Redfish IPMI defini= tions **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** From: Abner Chang Add the definitions of Redfish Host Interface credential bootstrapping IPMI= commands. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- .../RedfishHostInterfaceIpmi.h | 50 +++++++++++++++++++ 1 file changed, 50 insertions(+) create mode 100644 RedfishPkg/Include/IndustryStandard/RedfishHostInterfac= eIpmi.h diff --git a/RedfishPkg/Include/IndustryStandard/RedfishHostInterfaceIpmi.h= b/RedfishPkg/Include/IndustryStandard/RedfishHostInterfaceIpmi.h new file mode 100644 index 00000000000..892b744c458 --- /dev/null +++ b/RedfishPkg/Include/IndustryStandard/RedfishHostInterfaceIpmi.h @@ -0,0 +1,50 @@ +/** @file + Redfish Host Interface IPMI command + + Copyright (c) 2022 NVIDIA CORPORATION & AFFILIATES. All rights reserved. + SPDX-License-Identifier: BSD-2-Clause-Patent **/ + +#ifndef REDFISH_HOST_INTERFACE_IPMI_H_ +#define REDFISH_HOST_INTERFACE_IPMI_H_ + +#include +#include + +#define REDFISH_IPMI_GROUP_EXTENSION 0x52 +#define REDFISH_IPMI_GET_BOOTSTRAP_CREDENTIALS_CMD 0x02 +#define REDFISH_IPMI_BOOTSTRAP_CREDENTIAL_ENABLE 0xA5 +#define REDFISH_IPMI_BOOTSTRAP_CREDENTIAL_DISABLE 0x00 +#define REDFISH_IPMI_COMP_CODE_BOOTSTRAP_CREDENTIAL_DISABLED 0x80 + +/// +/// Per Redfish Host Interface Specification 1.3, The maximum lenght of +/// username and password is 16 characters long. +// Igor: One '/' symbol missed +#define USERNAME_MAX_LENGTH 16 +#define PASSWORD_MAX_LENGTH 16 +#define USERNAME_MAX_SIZE (USERNAME_MAX_LENGTH + 1) // NULL terminator +#define PASSWORD_MAX_SIZE (PASSWORD_MAX_LENGTH + 1) // NULL terminator + +#pragma pack(1) + +/// +/// The definition of IPMI command to get bootstrap account credentials +/// typedef struct { typedef struct { Igor: Duplication of typedef + UINT8 GroupExtensionId; + UINT8 DisableBootstrapControl; +} IPMI_BOOTSTRAP_CREDENTIALS_COMMAND_DATA; + +/// +/// The response data of getting bootstrap credential /// typedef Igor: Duplication of typedef +typedef struct { + UINT8 CompletionCode; + UINT8 GroupExtensionId; + CHAR8 Username[USERNAME_MAX_LENGTH]; + CHAR8 Password[PASSWORD_MAX_LENGTH]; +} IPMI_BOOTSTRAP_CREDENTIALS_RESULT_RESPONSE; + +#pragma pack() + +#endif -- 2.37.1.windows.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= .