From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9B5C77803E4 for ; Wed, 18 Oct 2023 14:47:36 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=0dT0ma51LdKY2RUrxvvFV2o5ntrOjDWbA5nXWtyzxpA=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1697640455; v=1; b=ORaqGfjNqXxTzhWAfXJ411fN4gCQkIs4o+vUgAHLh3BLNSUNz026TajBuAQiFTP7w5Ok54PK WIezsa+IsSb99c9jwL8hEsEIODf+RS7eRQb950z2IhgnAMBXuud0rPmXKXJq7i0I1IDAuF5Zjnw m9vJecBsraERvd8WXLbcBCzg= X-Received: by 127.0.0.2 with SMTP id sLonYY7687511xjm8X45bxfg; Wed, 18 Oct 2023 07:47:35 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.51]) by mx.groups.io with SMTP id smtpd.web11.283043.1697640453980010586 for ; Wed, 18 Oct 2023 07:47:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bqAa9HCN1mGsKQKTfHDy3GZDuF9wXVbFMfimlxZqriUchjkj/wfS5dqDEgVLLlX2iNG5rHYlq5PlzCkfC9iMq41YTPjPf35Z8spmose6QsX6j2h838h17JFyfG6a05gckyS2Fzix15LVcs09RwQPCCZCGphYOLqQIwnb4Ao1KroTKNTBM9I8vFLP1hKF69n+FFVvV9iwKmM+vSVhAjazWY5qDBKFHuuG9ZZ25H0K3PUA+Yx3c1GpAqv+lZv9RxDY648bW8cn9IsNnOvkmwdpvy+zGAgpOLh89vhcj8VKeH+FoL58nTEljLcTqp4DRu6uOh0LPDR2kOMY2Yc3yPmc0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BU9cujLNH/2o8fJLqigVFnQnCd9LRoEGG0G4EiA5B9Q=; b=KogM1/uMOODnvXDdPJYwWkpY92gaBW9nL0p69yj3kBpQfunTXsKOZtR9W77QqTZj5MLV2NUE1p9acWOTUukEGJkfjKeLT4JnIzcru9w5F/t1Qu/O5Ut6bJmVMHD3rNW8AW3TOmLHJJbB+3Hk8D+pnU8lofOgwQhQitMc8h22eXHWWEy1E5Wt42aQmUgZ3/b2fJEDUyDIB2ao30EkhS0+raSEFPmxh3K4QaU3Fp5YSCgOa6NOyQ+tzqX+vLpt88e7NNWwFO+pamfpcx/QSh+sNqMOJZUwhI+g1LOCN7BEf5ToTYQmVUYRA9713jyqE9bBYr7KtLXt/P6Mn3YgucXQvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by CH3PR10MB7835.namprd10.prod.outlook.com (2603:10b6:610:1af::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.23; Wed, 18 Oct 2023 14:47:29 +0000 X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::7126:faa8:8f0b:d58b]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::7126:faa8:8f0b:d58b%5]) with mapi id 15.20.6907.021; Wed, 18 Oct 2023 14:47:28 +0000 From: "Igor Kulchytskyy via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Abner Chang Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: introduce PcdRedfishSendReceiveTimeout Thread-Topic: [EXTERNAL] [PATCH] RedfishPkg/RedfishDiscoverDxe: introduce PcdRedfishSendReceiveTimeout Thread-Index: AQHaAcQmQzhPOKl7nE2ZupoySgWUdbBPoFSQ Date: Wed, 18 Oct 2023 14:47:28 +0000 Message-ID: References: <20231018130743.7712-1-nicklew@nvidia.com> In-Reply-To: <20231018130743.7712-1-nicklew@nvidia.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|CH3PR10MB7835:EE_ x-ms-office365-filtering-correlation-id: 4eca4293-b147-496b-1ea8-08dbcfe926c8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: cLiu0o/hljsUupPYYeGVZb+kDd6eboxQVRi73QLGHAZOLkAVmPzWM8FcoJyGCJu2JmHS1G30CnxaxO1yz52iMpf1cO1Oeyw/fofobghpUuFNpn2cuBWvC+zD6vzfgg89h4ew/aVIFRK1dSppHciWBLjodYwSEeKLyc0YZxyYQUc0RH6gb8m8YZiJDVCQUZ6x0mx9EJJ3nY3LaoLygfjYGTfpML1EE2r4+cykQ4ca38Krfn8vWXNXunmTjAjA+si0pUpHE7/krGipaVmVwC5ww/hrUFe2c5XATERDPHdUHfiM6ddqcil7tpzdDC+GcUE1Gzubu88HTnrnJ8DCFfayr2n7wr8aG3jHMUeLnnzur6nWLO+pr6QmkZoT4HSO8+swoA9MLEHoZ663sLJGt39FUlIVOobbemLZCD71OjYc/g9fdGPvvuQEnhzJyztTI1ISAv1TmNDVTmIk6HwmvcfcHXrFcGt3ErtzwrG/vhr5v/N1+3mq2dkzTveXQsdclmwYLnvaC8dOMwXC+XA1DJXr1fGr9p3eXDhqeHPbKrOrTDwwfszy9KoMFgM4Y8u4t+6SgzC5T9HcT3fYJMyid53iuDcbyQWO7LRkOgNzsr2rJ3S+N2Gnf/CsdVUciDNrCf0asnDrsVcRun0pJlLUrheC3A== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BcTGVZe4LGdkQDXQvxLb4mR1MX0+BZL/Hipa2t4geAOrh2umQMRXrQP6OlWF?= =?us-ascii?Q?cWImpq23xNJTJehsCkxPb1TKrHRjgFgL0lxQn22sSUpPjmX1BbAVmUG1w1Of?= =?us-ascii?Q?+KoTlYztMk8WWr7aHkDtMZCn0wPJtIFekXNLPoALNBWb5yNBCzpUds6v3cV8?= =?us-ascii?Q?l/xwPuC3cf2cRftjlbPhiWhGVYONQA4nCM54R85QZuPd+5Ki7Uxiu38BXSG+?= =?us-ascii?Q?qmt0FFFPn3ZoY0jhuqTM5OAg70b1SVOPcfaKWBGUM1opeXMTk1+amPZxIJB8?= =?us-ascii?Q?HXHuAo+457Wd6KSZKd0sJA3yqj8CW+Nc+8uAHYKZpPn62mAkfmRxC1yxkedM?= =?us-ascii?Q?J/hFoCiypEBThb9f+Zy8eX1t9KKgD3Rc8BWbeA1FI/enDzaOCRCySBzA4NOj?= =?us-ascii?Q?bVqRUiDLHEqNaZxkg5USaMAu0pM2C2bJ+eGHnGxzZencYSKgZPP65+NrbG1H?= =?us-ascii?Q?p9JcsgQsVFsDDGppEonVCuJwjId/gYFA8pReyEoGX1iRb91FtxbZtgt9bs4A?= =?us-ascii?Q?N6/xRDJj17EaB8I8e6rUfW0SiVNV6DvHHg9+mgS1M7fUFSdIovtnYAQcNeSb?= =?us-ascii?Q?Y7m4eIf9AYm8H6cK1Wa4gsLZn7oFELdP8k3Deh/fs/WV2QWfl3yqQvVqbDkE?= =?us-ascii?Q?ULJdZG8L0CatT/d4lZoQrWL4SGZsB2BwQnB3J+G/PGS/BpJWPvNjy4xbcPiH?= =?us-ascii?Q?nf208ge0l/kBlXddn3Ev5+boIZaEuPfhSTiP7yX+AzZrR3gpGj2j3xVaZ+8D?= =?us-ascii?Q?cmz62UlgCuH6oBr8zCUELuX0+rkVbQ8rbANoDzdrTH1P2U87L5doEPUfPD7z?= =?us-ascii?Q?OqbbD9PB9+oPtvnWZg+P3iNCisN1+5hrfuJZhSNnGV9Jyktf8tN97c8csUuV?= =?us-ascii?Q?8Mf0xNbJ+hS7pT1n4A8xQg0aC6sgMJbtIkFc1iaHR7zjziaWxhmbfBmC6SKG?= =?us-ascii?Q?Fi9OW0hZquofksIK0WebNja0WSxDmH/IeZSRBiI1+cec0KWGwWd+3uiFNSnE?= =?us-ascii?Q?MSPAimtHMJ8SLWvXni3zsTj96Krb638kfNbh0ehSuXHTFmWt59FqRc+6PmXZ?= =?us-ascii?Q?v92HG8wEjoJrw4OhFwBGLCm02XpyWglchzX8UmxoHkAmTz/ONzos7oQLysQX?= =?us-ascii?Q?lmybiaCb/C6Ktw9kQeett5CfLpj4ll9c7zQ4R99TPUyMwfvSS1UnfbjAcER2?= =?us-ascii?Q?zPH5AhJgTR4HQEA0vrm88VAstpPzEaLBED9Bmm0vFr3p0ppKLEWXf+ieRMRA?= =?us-ascii?Q?+j9OGDoSYWTFIKe3d1lBng/+z8zWOi4DITth6470TQgVedFHMKBpNqoZAXde?= =?us-ascii?Q?GSIGltVhfo+3gsm6vrQtapWwCZGNTR+oueI8lefFxRsGcJTWm7jVD4/nEeFB?= =?us-ascii?Q?C2MosJLG9lTgqbw1S/qgW6lmpq2lmrEuHzqzdnYHBDiO0OVHkY27779n2f74?= =?us-ascii?Q?uYSVZSurxxqiYXtKAXSPHWBvrAAe1Q+x85pXe0/4Ld5++PuPxeGdFoQaEukD?= =?us-ascii?Q?2z4Dr7ha0gaPvtOFmyqIsZoaiashGdymCxF/uMksIm5cgnmAYbVMsRgMAJIG?= =?us-ascii?Q?IU2PjGVu90Fnr3k4LtI=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4eca4293-b147-496b-1ea8-08dbcfe926c8 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2023 14:47:28.7560 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uiIUiKCUKh1xrtp1XT61D6S79Vvn7WkPmxt8OdHbTgWhi6p47YXReTActpwJwl7h X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7835 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,igork@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: vbJBy3wzkbZbYCtoyDjdmoQHx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ORaqGfjN; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Igor Kulchytskyy -----Original Message----- From: Nickle Wang Sent: Wednesday, October 18, 2023 9:08 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy Subject: [EXTERNAL] [PATCH] RedfishPkg/RedfishDiscoverDxe: introduce PcdRed= fishSendReceiveTimeout **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** Introduce PCD PcdRedfishSendReceiveTimeout to RedfishDiscoverDxe driver. The SendReceiveTimeout is hard-code value in Redfish discover driver. With this PCD, platform owner can configure timeout value easily. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- RedfishPkg/RedfishPkg.dec | 5 +++++ RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf | 2 +- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec index cdb1528cedc9..0f18865cea0b 100644 --- a/RedfishPkg/RedfishPkg.dec +++ b/RedfishPkg/RedfishPkg.dec @@ -142,3 +142,8 @@ # This PCD indicates that if BMC bootstrap credential service will be di= sabled by BIOS or not. # gEfiRedfishPkgTokenSpaceGuid.PcdRedfishDisableBootstrapCredentialService= |FALSE|BOOLEAN|0x00001007 + # + # The EFI_REST_EX_HTTP_CONFIG_DATA.SendReceiveTimeout value that Redfish= DiscoverDxe driver + # set to EFI_REST_EX_PROTOCOL. + # + gEfiRedfishPkgTokenSpaceGuid.PcdRedfishSendReceiveTimeout|5000|UINT32|0x= 00001008 diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf b/Redfish= Pkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf index 950098bf6a0d..c982056fd700 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf @@ -54,4 +54,4 @@ [Pcd] gEfiRedfishPkgTokenSpaceGuid.PcdRedfishDiscoverAccessModeInBand ## CONSU= MES - + gEfiRedfishPkgTokenSpaceGuid.PcdRedfishSendReceiveTimeout ## CONSU= EMS diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index 17c88ad82db4..2f9e604f6cd6 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -877,7 +877,7 @@ AddAndSignalNewRedfishService ( goto EXIT_FREE_CONFIG_DATA; } - RestExHttpConfigData->SendReceiveTimeout =3D 5000; + RestExHttpConfigData->SendReceiveTimeout =3D PcdGet32= (PcdRedfishSendReceiveTimeout); RestExHttpConfigData->HttpConfigData.HttpVersion =3D HttpVers= ion11; RestExHttpConfigData->HttpConfigData.LocalAddressIsIPv6 =3D CheckIsI= pVersion6 (NetworkInterface); if (RestExHttpConfigData->HttpConfigData.LocalAddressIsIPv6) { -- 2.17.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109757): https://edk2.groups.io/g/devel/message/109757 Mute This Topic: https://groups.io/mt/102038456/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-