From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (NAM04-MW2-obe.outbound.protection.outlook.com [40.107.101.78]) by mx.groups.io with SMTP id smtpd.web11.77915.1671816709850044451 for ; Fri, 23 Dec 2022 09:31:51 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ami.com header.s=selector1 header.b=QYe1I4LQ; spf=pass (domain: ami.com, ip: 40.107.101.78, mailfrom: igork@ami.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ntMq6oZZvQAvKoLgbigT+IFQru1nV04wO63bHbMEMP/nrYeEwMasSjFli8igOnQabKHCfbQke9CM9lUrCIlGTRP8+dO/Tg+AAGKkeXuGdaPxO4EDr20bP4t6DKHS1vGQGivmm3EyBcQ5LSjILKhKMk5rcE5RoLmNIA7GJmT0eRSUs317stWNP8CiuWpRpqotmPoibrt8SROGCzvXgqhdYs+4ziB4lZfXhQxbYixkvrspZFB+vOuJpEGUEPaNhKdDHIN4vWxFetY5ctuhs4PXONMH6h8t8zXY9eFNmfpwmxYdfXuTYX5oxvKpN2YMrbOL+N7cEOG5jHSZ4n1b+zicaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OxVAoO2Z5/qGkJIuijdzC1b0mpWpB1rH+GB7adSpF3g=; b=JiBwRwPZCyxOPsKQF/qy3A7lGXK/dg6f7O5RyOOSn4kFwrwD8weoKm45AIsdn8K9U7rWDkKtigSPMFMZdfgvbpRnf6AOHROr1TB+2K/mJOUbArNW/BhWzUNcZdLhL+blyBXLkORKU4lPC1hjIUXuJmdVUg590QJngxaZISn4/ABwCeADbr+ckuaBCaaZygPknZX46ypGYpx/C6gAve9r4MxpPknvTmRqED8YFYR9xE5WHurtl4J6mmjqJY3Kpmvja1Ii1GQjl66vOIHQIBBMORXDeDOE9SUDL9oJsN84WyVWTw7/hURgD+M3JTBS/It/0cIZUvJyJvswlWCjL3J+jQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ami.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OxVAoO2Z5/qGkJIuijdzC1b0mpWpB1rH+GB7adSpF3g=; b=QYe1I4LQGN3id29kDCZd7iK73eNcMVn9OKq4v5MDt1lIeaFxxVwzaq0s3klIRgDHrF3AdIdB1VDS2Ui6WrtfJFgVgbB1WCY71uENM8vAfe9Sgu6etlde5sPZPZJcqNbo0H02E+W1vpsNviqkcMRuklLfNaVx1Uc0fOZHtOCj1mg= Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by MW4PR10MB5882.namprd10.prod.outlook.com (2603:10b6:303:18f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.13; Fri, 23 Dec 2022 17:31:48 +0000 Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::f1ea:b179:62e1:8cb8]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::f1ea:b179:62e1:8cb8%7]) with mapi id 15.20.5924.016; Fri, 23 Dec 2022 17:31:48 +0000 From: "Igor Kulchytskyy" To: "abner.chang@amd.com" , "devel@edk2.groups.io" CC: Nickle Wang Subject: Re: [PATCH 3/3] RedfishPkg/Include: Redfish USB Interface V2 update Thread-Topic: [EXTERNAL] [PATCH 3/3] RedfishPkg/Include: Redfish USB Interface V2 update Thread-Index: AQHZFsriWuHNRdWFikKBHHj+SUC/mK57uvfA Date: Fri, 23 Dec 2022 17:31:48 +0000 Message-ID: References: <20221223123336.2014-1-abner.chang@amd.com> <20221223123336.2014-4-abner.chang@amd.com> In-Reply-To: <20221223123336.2014-4-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ami.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|MW4PR10MB5882:EE_ x-ms-office365-filtering-correlation-id: 8e1e9d09-ad18-4873-59ca-08dae50b91ed x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: O495UqCQNYlUsWP5rDvlDChbZciCrTzg0nB0SzfM9sn9eaVhBsijDo69skch1ggE6Lm7CCzJhl/e4habjwDTQwFX0KFRG4BQwqrNNiipNd1mGe/dweLmDp3b97oeSjGvb4HQaBa2gnHPE+l+MBqI4mXXeTauMqMIprZQVf+pU7V/+yzhJ9iXTAlqJLidXUnALMcCbOGuup+KF6GNB7bgU0ft1n7PLIhaN6cyQ44Lbe9xRSwwv4j0SanP9ewbeJmJMTTsMqGUZtO8xv4fQUKrLNgJeV9okdSaXmCldXCjeKvyUJej0cqnV66RrSefq+3fAq2ShwZw5bcLN2G/ScXZ7mHWx0ss3CtxqBzweWjfETm6U7jQaGiIDNbEtd+MjmR2Hx6I/EAI4thYhg1vMVayJ01bGoe3xVtSVsk8+Y6FJe4TbumaU2BpUcUPZyvxBwzChkMAP/kXXzbimR4/p4KN6TRohRfBKIIAupV54yplKDcKtGVoQyk9LRRKsXdbxKibT6ULq4wLg12t0hi9T/6VBkpwEG8OJVNeHvuD01MWR0PLrydb8ybxYcw3XHAfTC+0TYRTFgQCe5o/w2WdWO1zJUD7WnIatdBN2bWxksT69spOKdFsCIOf6PuyPLRfWca2eAD/djw5eAgJabuTkOHdk6/1TO7VKW0RQW6rLqylMBI5swWQoynu42w+Mbxql6CUe/kFnSQN2bhiRUvF4eetIg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5185.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(366004)(39850400004)(376002)(136003)(396003)(451199015)(15650500001)(316002)(38070700005)(2906002)(110136005)(83380400001)(478600001)(53546011)(6506007)(86362001)(55016003)(52536014)(40140700001)(9686003)(71200400001)(33656002)(186003)(26005)(7696005)(8936002)(38100700002)(41300700001)(5660300002)(76116006)(122000001)(66476007)(64756008)(66946007)(66556008)(66446008)(4326008)(8676002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?i0acCa+WHX731IZ+tkvkDL2PoE7kYaoUTseiTUlXw3soo+4CzlKxQDWC+XQ3?= =?us-ascii?Q?2qIGUEUyFILwBRjb2NmMzEmBKLJlzJgHnYwP1x3qbvURLhPlpu7GuIg9JxRA?= =?us-ascii?Q?kLZqxHuW8IptxJ64ObdIs25PJoyVJhKPdLeYYUeZYzU0YQQyqMXUUDFYB6Ie?= =?us-ascii?Q?HqpyNFdpvEZsHAzAJ2q1wmJayEb0r0IsulIgkj8oizcyds4dFt9f/RKZeYPb?= =?us-ascii?Q?AV2Kqn+6Ek9sRXMVAh43gJHg2585AciCZX2T2JBR+GhFktW3kTg0M6AZggR7?= =?us-ascii?Q?La0+5IiERf/cvr/OnG8vOPrJRi5qBG73QxO2UTpVtj1Mlrcch/s24dpGSklq?= =?us-ascii?Q?xAoa1tVXUHyCe+SqTo2y6apP8fxK8rejL+mhPWEyU9Ow625RVDrkEldVF5ft?= =?us-ascii?Q?xK0a6I3xetGr2URqHmXcR34IGier2YXXP6FyM9CB/KtNu/LfKA+RpIkOPV7e?= =?us-ascii?Q?E1bkYFSoUfXX4QSnbhVJpWXU+31IwNqtKqqDSF6aw6UiE4hVdV/yfKs6SDyc?= =?us-ascii?Q?3xPPjtkyDGGzsjSm0Qa5qiXW/VLo4tzBmxgIwj257mlQdCEdoy3RngGAZYHD?= =?us-ascii?Q?Yg22cEOblwyRS9QCZwtukTPGOUW9UNrdwiKl+HEJNNFXwdFUDUBtWmQjiDwp?= =?us-ascii?Q?VNiyCXZPxBxaacOn4iUfkUw6UZzK49ZOzqq9dqBWs47TlMn5cclkWgSAyK54?= =?us-ascii?Q?rxBTqeV7NrFraDDy3X+CnKftAUlnteQwXOH65lwGzows0XwYeQSqWJsGAxvn?= =?us-ascii?Q?JJx/MNXv5UCbt2l5jXp6HKNVrAz4RfcWgBGCl1igzBb041y22Nlc5Zs0OFPI?= =?us-ascii?Q?RVfZS9FMny+UwuU+4EJCVg7gh76BHQW23JzhNCZxNMQF5GZns1WXvnf4F3Xm?= =?us-ascii?Q?DDlGhBp1wb0bF9IQcExvWJllWPwHc/JGfZp+DAMRlAtAII03ZcRL/QmnPy1W?= =?us-ascii?Q?W6RU4OkJmDW+79k7Dmf0Zbquqqhpkovd3VNnm9CAXs725OWp+xpczFNVBoQ3?= =?us-ascii?Q?Q2Ba3pEz/U4CAwcP8lHpqEQnH2XSSTwZrKhbNuZiFluUHWC8I+NX36WqUO+t?= =?us-ascii?Q?F20vFsi9h7Si30IXWnVZS09ruddwx93vyITmhMEtlSo84BwZuyer+PVKndYb?= =?us-ascii?Q?2VHX6sacICv24LEa12FTRRtpgamUtp+TjcMgtZeF753/i2SkUwdqOBkyE29C?= =?us-ascii?Q?kTChjQmVb61gDixmLbzce6Q4GN6LgiRu7h7kDK1gI6spsqmPC+6q6YMiO80t?= =?us-ascii?Q?+rDNcCVyPcKyaOPWHHVsc1NW82lPkgYlafSp04L7kXniE4JKyTVv55vDiRRL?= =?us-ascii?Q?Pfo8/y40JdxMXbwROOdVyfTa98EKC746RfYi6x1SqDSPFLj4krQgeGZ50XuQ?= =?us-ascii?Q?JOntztDQoBr42IOJu4ybJfPJ87RtOUVPPeUdxfu9DhAulze6Pl8Jrhlvfmix?= =?us-ascii?Q?Gs2ffd3dZNDeXzAqpnmaOXIyaJj56WhXZTIQKCfUFZEib/mCemlI7Xh/BNiD?= =?us-ascii?Q?oghz6jRhjt0K4W0OK0vAV+xso2mBE8miu1crG+JrE+TfQ4ZJdXtgWY7efOOu?= =?us-ascii?Q?8rV4sYJ+0Fm0FarkaYA=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e1e9d09-ad18-4873-59ca-08dae50b91ed X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2022 17:31:48.1529 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MVRBG4UBFqUdPKPIjBP6BoKZEmJzcV2rUUQDTvrAUpTHiPspjF1M8p+jYlA1Xzab X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5882 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Abner, I'm not sure if I did something wrong, but when I tried to apply that patch= I got an error: error: corrupt patch at line 30 Thank you, Igor -----Original Message----- From: abner.chang@amd.com Sent: Friday, December 23, 2022 7:34 AM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [EXTERNAL] [PATCH 3/3] RedfishPkg/Include: Redfish USB Interface V= 2 update **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** From: Abner Chang Support USB_INTERFACE_DEVICE_DESCRIPTOR_V2 which is updated in Redfish Host= Interface spec v1.3. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- .../IndustryStandard/RedfishHostInterface.h | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h b/R= edfishPkg/Include/IndustryStandard/RedfishHostInterface.h index 49b3ceee39c..5337c3234b2 100644 --- a/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h +++ b/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h @@ -3,6 +3,7 @@ Copyright (c) 2019, Intel Corporation. All rights reserved.
(C) Copyright 2020 Hewlett Packard Enterprise Development LP
+ Copyright (C) 2022 Advanced Micro Devices, Inc. All rights + reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -29,6 +30,18 @@ #define REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_IP4 0x01 #define REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_IP6 0x02 +/// +/// Definitions for IP assignment tyeps. +/// +typedef enum { + RedfishHostIpAssignmentUnknown, + RedfishHostIpAssignmentStatic, + RedfishHostIpAssignmentDhcp, + RedfishHostIpAssignmentAutoConfigure, + RedfishHostIpAssignmentHostSelected, + RedfishHostIpAssignmentReserved +} REDFISH_HOST_IP_ASSIGNMENT; + #pragma pack(1) /// /// Structure definitions of Host Interface device type 04h (USB Network I= nterface V2) @@ -46,6 +59,12 @@ typedef struct { ///< descriptor, and is convert= ed from Unicode to ASCII ///< and is NULL terminated. UINT8 MacAddress[6]; ///< The MAC address of the PCI= /PCIe network device. + + /// + /// Below is defined in Redfish Host Interface spec v1.3 /// + UINT16 Characteristics; ///< Additional device characte= ristics. + UINT16 CredentialBootstrappingHandle; ///< Credential bootstrapping h= andle. } USB_INTERFACE_DEVICE_DESCRIPTOR_V2; // @@ -74,6 +93,10 @@ typedef struct { /// /// Define union for the Host Interface Device Descriptor /// +#define USB_INTERFACE_DEVICE_DESCRIPTOR_V2_SIZE_1_3 0x11 ///< Leng= th USB interface device v2 defined in + ///< Redf= ish host interface spec v1.3 +#define USB_INTERFACE_DEVICE_DESCRIPTOR_V2_SIZE_1_2 0x0d ///< Leng= th USB interface device v2 defined in + ///< +Redfish host interface spec v1.2 typedef union { USB_INTERFACE_DEVICE_DESCRIPTOR_V2 UsbDeviceV2; ///< Devi= ce type USB V2 device discriptor. PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2 PciPcieDeviceV2; ///< Devi= ce type PCI/PCIe V2 device discriptor. -- 2.37.1.windows.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= .