From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 527DBD81113 for ; Tue, 27 Feb 2024 14:33:23 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=fU0Zy3WsI8dP8nXqCHB7ho+IOJ5FhGXM7CpH4Cd7XmI=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709044401; v=1; b=Wg9/+WD+N4rj1C7TjUOrscV1p45j8/pHUq2edMEMmh/ecJxZ+668o9x209V8Dx/04xPgVQy0 znmMz/vBu4jm3Qfao7tVbAjjYIDd3vyyPJhjqFTVy8lX9MbUhCXKSJ2yDQF+bilsAHvScrPlvWF 2nTdJrOpyCJ7/FrdtKV9SxDw= X-Received: by 127.0.0.2 with SMTP id At1QYY7687511xoOKy56O3JX; Tue, 27 Feb 2024 06:33:21 -0800 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.100]) by mx.groups.io with SMTP id smtpd.web10.13623.1709044401067003048 for ; Tue, 27 Feb 2024 06:33:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WJ0L+KUOXVcmQv2aqs+q3HRNryahKczouTutCJOZk9gtejrewVx0mgnf+Wo+lCjgylHIdovgtoUNcSLGWJSWL2B3F//Hwyk6pYqz6YQeY+/4Y5ClIwpgtaplb4ZbpFLzMZK7TUl2dd5Sex9siycNe9zQbfT0oPAB3rOBANmNft7afU8LA/MxtMpeFDLqMPfyJVN8wOTMlq62nKx/ONj35Ox/VJnNdavQ6ykXF11t7vySdPad9tl+FTaK/7FIHRdr7cQqMHLu6EMRld627sh/2lSx7IPpN68OAUvWZWaPE6wvhLYGcQO5udKo8Dzigai6KOUzGKOxEAbUSiefaeJgsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E221kyBQDc2VqkG4v6b4xkKhXHMPkhve7uuYy6rqJLQ=; b=V2Mdod0y9ytg4+PBXRX3GkKDUeYlCsBS7+9ytU3w7DE6W+ScomKOIV9TCPFLVVLGTv9qZrAjQjA7URIzPVWcLZiJjp+MXcF27CpZ19J+2FyVH5uht9MBmUIGg3+DTZyj/zYw66dQRieh6cLRAMhGj1iZGyDSIfwLxOfPedjWjLCYSi2LPS5/y/lvDeFIhvFGPfDdHzk/m9bdb8FYmPHjL8VKMhQokbskZY+oWSTGTnLc+cDBRe99zayQsMY2EbJxNciMRNgscjah6a0uVhsLbhpEA05ztc6CMQ6Ovdn/Da2TSuvceI8KiidD90wJR0YvIuKkLnqGCOXUjcKn7MhasA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by DS0PR10MB7152.namprd10.prod.outlook.com (2603:10b6:8:f1::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.37; Tue, 27 Feb 2024 14:33:16 +0000 X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::7840:c724:8a2a:4cf5]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::7840:c724:8a2a:4cf5%5]) with mapi id 15.20.7316.037; Tue, 27 Feb 2024 14:33:16 +0000 From: "Igor Kulchytskyy via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Abner Chang , Nick Ramirez Subject: Re: [edk2-devel] [PATCH v3 0/6] Introduce Redfish http protocol Thread-Topic: [EXTERNAL] [PATCH v3 0/6] Introduce Redfish http protocol Thread-Index: AQHaaRYssHFsBcq4S0a78Io2plTcCLEeQWWg Date: Tue, 27 Feb 2024 14:33:15 +0000 Message-ID: References: <20240227004425.3133-1-nicklew@nvidia.com> In-Reply-To: <20240227004425.3133-1-nicklew@nvidia.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|DS0PR10MB7152:EE_ x-ms-office365-filtering-correlation-id: 9e1ad358-ac50-42e3-d3ac-08dc37a108a5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: dEMhC3gkXYKxkbQTmJekqw71EEqqSUHyCDszeGxkmOPugRgzSAukQ6PprpOPHbv07dNWn9w3W8/gtdA54iA0MA9SsWu5OAJTLN7VTzMCD99OPOrKjrxB7w07S+IS479GUB/yYdy1C55yM+7bfpUl+u5lqN6Qp0QQoiI9AHJ3BKGPZnwxdFGNUC6w+DpVUkQ9pU2VouwLsV1VqK/EjKB14etSOIeIQ70WZIBgtFA8KJ57rJbDas1igLBUl1Zou13AKxkBXmRjYH9ji4FmjyD6f0t1CBffS8DIMET/b2XKySdpq9jUYpIR5ae9ZM7dKOVDS/p0IMYKZLf02m7DqP5ugS4NQHQwYGfDOSZikdEcmpjFMMSovXmodyRr1WPJVaqr996466PN+Yl+P7tGLIrE9VR2eOHgbCJJ7zzInJFplfTEQXJkhPdsyCCgMyJc1VI7m181awMBRcO9+tSO95lkx7AulGGFjpMxWb6X4Eyusol92SI+eald0dFqzbm/acmZN5RsjliG6/tr8vRDIeRJbls1k6Gs0ViRl2SxXCVbyGleTQ52gw1hYnbwGvGwHZXquLyS67em8ilysbYHqK+5p/jtKfnnh64nymMv8dNlrbpEZ4p9wapOUPOs7dO1bPlhpIrAi8CrkAKGAI0NID2QTpsMrkrEpdB5fkoDbN/wyAEMP+7eJlA6b1JvX5xT3cweWh/5ub64bMDGrkGzxhBisA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JRHWTboEUD6CTUl7RZKPx6soch642byx6WCmfUYmjCBRKttcBMoOHvkIJ6vG?= =?us-ascii?Q?X8juJJ5u26DE41beSjmg4uS0YygSFPlaX7U/o8oaNFh55A6YHEks8oIs8vw6?= =?us-ascii?Q?ZwCFIWCFJlwnHO6Fu/SwGbkdCT10Cl+Lml5ex7z7CoiLFs6yn6X+P6cyrBiQ?= =?us-ascii?Q?QhRBrGBVGwG7976ZPA7fWt0C19yqcK0GzOJDbFQ+SVnghEsfcPZoSj1j/Zja?= =?us-ascii?Q?IlJuR1I9Ys/LdmLjEV+5byvyQcjakVBSNL6jAJsDb9Wq0kU2ySh6Inq54UIR?= =?us-ascii?Q?lj+9fWMARCzylg49tmeibwEfhxQprrPcDDA08CcFo43MhYTeE78BjoJ3MBll?= =?us-ascii?Q?sg4gbI/pzqbzyLmBSYNSxLzgqWzn1e5Za55WTan8+1gIfAOsFPBWGRFokz6n?= =?us-ascii?Q?12HAunhz5Ush3Einsf9H1duT4nzxXrthss/MtpelvBoJsDRbShhaZP/3jh4x?= =?us-ascii?Q?5yC0IleiSd7HUVkPsk0CAkO+4PhTjSUiqy53/WSgJCQFAMAfmrLHgU1X+uJT?= =?us-ascii?Q?NmBvJoWixXQrftqM569ejMOax+De+UOBmAAjWu8/oA8SRHOSdBILQJT8VYCh?= =?us-ascii?Q?d71i498oDfmgPKONjbNQW/oUCwVElK8FfXDlEgYBRwsF6zO6wSGZ+iqHoJJ+?= =?us-ascii?Q?pIbDndTMRMbzdkUhlaD2yrVd4yWxfsWo376kwadePPmIpaRa3cn7TfQGf/zn?= =?us-ascii?Q?lKYd9dZ4/YEWQ/hq61j70p9VY6JiTKBYS55arZSt67BDlm1t/kMfY4EIu7Qx?= =?us-ascii?Q?dXRVFlxR3LvnNJZ/z1oz2KRzKTijT35IEWJTb8l9wAWX4MHuiIlcM880+1mA?= =?us-ascii?Q?ZiQc/BkOYMRU5FN45TI3BJL+aaFPDoMMOb/uyEGmrI1q85Ndy8t1xQr0PnjR?= =?us-ascii?Q?b/vdxSG/f17isJKVDXeEcKFVnXuBaZ1o4+6NOiGxzsrB0Yie2/FGqztqNqh/?= =?us-ascii?Q?pcTUXO6TjWgvsjPRex81t95qmQ4Q2QmOc+j3RtU+vcuJ17V3+ZPeH7pvCGyo?= =?us-ascii?Q?1/9CVHkfZRFLFpAT/eN2AiTGxyF0RzZA/KyKREJD7M/D5Y9DAhvjqPrfBiPN?= =?us-ascii?Q?U7qPnQMcKFONcV6uCxEpUDAF2o+SnaHrXimlCdSU9VEzodSLidkqLqubtw6L?= =?us-ascii?Q?fBeO/oVhqYyBqEQGiBdOA58z5Z0qAVUdul7lGWHUjz5i8O2wyeFmUiHEPnyZ?= =?us-ascii?Q?20R4sUQNV82NwxbBgOKlAUfRyY+v6XyKXVZV89oQzBoi4ovyP1eJwON3akn8?= =?us-ascii?Q?8VfpX2a2Y2fKilMPqhqBUIehGSgjLyAZS+zA4FZ79ZNSp4UhTqXdmnEkrWCO?= =?us-ascii?Q?YAiHFE0TxHVk1wf6gBWkrHTvAn2Qwz8OryXpxYW+um/JkbrplkHuTMj5D4cn?= =?us-ascii?Q?D4TNc1nhFXCwACrr3Jf3vr1KBnEIeMZaHOFaK+5ZdC05WVN7hHT5xHiYYSwQ?= =?us-ascii?Q?kopOQ60CUAIza7f0womD1snrPIbI2Ep9VYf4mqCwMRknMFdtPMh0mFyCmElo?= =?us-ascii?Q?RmehKeM+YVf8g72oCz2uml4ba3SBoJtizQb++rW9podZlF2UzlALCignaMpK?= =?us-ascii?Q?8OtIiAP7ayZhb1s5SPA=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e1ad358-ac50-42e3-d3ac-08dc37a108a5 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2024 14:33:15.4010 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cjeHcqRsbH4EWH9O3AJ+Vs97XqDFM8IUC2ZLpfdAuw212Tf5nuN0xJpvCW3lUh95 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7152 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,igork@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: vy0c1j4uyFSomjwGs8GRxjt7x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="Wg9/+WD+"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=pass (policy=none) header.from=groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Igor Kulchytskyy Reviewed the whole patch v3. Regards, Igor -----Original Message----- From: Nickle Wang Sent: Monday, February 26, 2024 7:44 PM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Ni= ck Ramirez Subject: [EXTERNAL] [PATCH v3 0/6] Introduce Redfish http protocol **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** v3: address review comments. 1) handle the condition while memory allocation failure happens to HTTP headers. Make sure that HTTP headers can be released properly while calling HttpFreeHeaderFields(). 2) Create macro ASCII_STR_DUPLICATE() to copy ASCII string. 3) Fix typos. v2: address review comments. 1) add comment to show the source file of MathFtol.c 2) update macro to follow file name in RedfishHttpOperation.h This patch series introduce Redfish HTTP protocol to RedfishPkg. This is to improve Redfish performance and communication stability between BIOS and Redfish service. Two big functions are introduced: 1) HTTP cache mechanism is implemented to reduce the number of communiocation between BIOS and BMC. 2) HTTP request retry mechanism is implemented to handle communication failure. With retry mechanism, Redfish feature driver can finish its job as best as possible. Several libraries are updated to fix build issues. Pull request is created: https://github.com/tianocore/edk2/pull/5348 Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Nickle Wang (6): RedfishPkg: introduce Redfish HTTP protocol RedfishPkg: implement Redfish HTTP protocol RedfishPkg: introduce RedfishHttpLib RedfishPkg/RedfishLib: include RedfishServiceData.h RedfishPkg/RedfishDebugLib: use RedfishHttpLib RedfishPkg/RedfishCrtLib: fix unresolved external symbol issue RedfishPkg/RedfishPkg.dec | 32 +- RedfishPkg/RedfishComponents.dsc.inc | 3 +- RedfishPkg/RedfishLibs.dsc.inc | 3 +- RedfishPkg/RedfishPkg.dsc | 5 +- .../RedfishDebugLib/RedfishDebugLib.inf | 4 +- .../Library/RedfishHttpLib/RedfishHttpLib.inf | 43 + .../RedfishCrtLib/RedfishCrtLib.inf | 7 +- RedfishPkg/RedfishHttpDxe/RedfishHttpDxe.inf | 73 + RedfishPkg/Include/Library/RedfishDebugLib.h | 2 +- RedfishPkg/Include/Library/RedfishHttpLib.h | 326 ++++ RedfishPkg/Include/Library/RedfishLib.h | 17 +- .../Protocol/EdkIIRedfishHttpProtocol.h | 308 ++++ RedfishPkg/Include/RedfishServiceData.h | 43 + RedfishPkg/RedfishHttpDxe/RedfishHttpData.h | 256 ++++ RedfishPkg/RedfishHttpDxe/RedfishHttpDxe.h | 44 + .../RedfishHttpDxe/RedfishHttpOperation.h | 77 + .../Library/RedfishDebugLib/RedfishDebugLib.c | 1 + .../Library/RedfishHttpLib/RedfishHttpLib.c | 585 +++++++ .../RedfishCrtLib/Ia32/MathFtol.c | 37 + RedfishPkg/RedfishHttpDxe/RedfishHttpData.c | 667 ++++++++ RedfishPkg/RedfishHttpDxe/RedfishHttpDxe.c | 1344 +++++++++++++++++ .../RedfishHttpDxe/RedfishHttpOperation.c | 692 +++++++++ RedfishPkg/Redfish.fdf.inc | 3 +- RedfishPkg/RedfishPkg.ci.yaml | 2 + 24 files changed, 4549 insertions(+), 25 deletions(-) create mode 100644 RedfishPkg/Library/RedfishHttpLib/RedfishHttpLib.inf create mode 100644 RedfishPkg/RedfishHttpDxe/RedfishHttpDxe.inf create mode 100644 RedfishPkg/Include/Library/RedfishHttpLib.h create mode 100644 RedfishPkg/Include/Protocol/EdkIIRedfishHttpProtocol.h create mode 100644 RedfishPkg/Include/RedfishServiceData.h create mode 100644 RedfishPkg/RedfishHttpDxe/RedfishHttpData.h create mode 100644 RedfishPkg/RedfishHttpDxe/RedfishHttpDxe.h create mode 100644 RedfishPkg/RedfishHttpDxe/RedfishHttpOperation.h create mode 100644 RedfishPkg/Library/RedfishHttpLib/RedfishHttpLib.c create mode 100644 RedfishPkg/PrivateLibrary/RedfishCrtLib/Ia32/MathFtol.c create mode 100644 RedfishPkg/RedfishHttpDxe/RedfishHttpData.c create mode 100644 RedfishPkg/RedfishHttpDxe/RedfishHttpDxe.c create mode 100644 RedfishPkg/RedfishHttpDxe/RedfishHttpOperation.c -- 2.34.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116046): https://edk2.groups.io/g/devel/message/116046 Mute This Topic: https://groups.io/mt/104594891/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-