From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E0290D81092 for ; Thu, 26 Oct 2023 13:30:47 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=MqLU+Hq9Up/bTQF5zvyOuEuBW52RzrKrMM9kyVqkPt0=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698327046; v=1; b=aLUDVPbt6k4agDkLg8ZakvYlNCqXcRqZBR1FReUX6XpUnepG6jg/lQMZT2w7r0gjI8gZsnRP pJP9veltneqQoQXear21KhCelW39xtzjLJCbO3wIWuH1hxa15yeBXvIpAFvFvQggQoVnjMD6cq5 pVjcMTMWzMeLLQz6ddjR7YIU= X-Received: by 127.0.0.2 with SMTP id grPSYY7687511xIddK8ysfJg; Thu, 26 Oct 2023 06:30:46 -0700 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.72]) by mx.groups.io with SMTP id smtpd.web11.70517.1698327045179564374 for ; Thu, 26 Oct 2023 06:30:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EnDbvrhh+pwvYpKxAWfrU0zM5Z1Nh8R94i9fmt1xO+mI4b6+cHMc0IkQFjwStfvKbCXYEbKM/g7vXzbum8veMZJ5vzLfMBgnrdAdEDW+voQCRO0eLRGoWhbnJvV2VWh8/8H0V1ORPq+u4QJ6PuNXJtJFN71+LJiZFbBiDjMBTsX28YD0V7SXGAx/l/m2QtiIcs6B92+O8AKEX0bjVGDG8/vUwCQceUZHN+8jCrSyrqYlKvtdm7+k1A99+k3LwfFgmsTMpeV1WHplQi4dQWIi8WZtAtQhctAQlJfZhgf9U1wy+k4eOJ12AyaosRe6ars2tXoVFFqwrXuQZkQ8fYmmMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9RXo+cjWVePFAP7IxPsEXQKke9QeDhn1EGz54eaMTlY=; b=oM0UQe8kq7YtR3YtdDC9MDCghZh3IwN0zpsx+twuCzz5CTnGdWILjAL0dcjTZasNrF3TdmhIefAVcejJ4/Tv1auH3XSqYTV683aapk04Is5sEYSOSeZVaI6mvHNmt4VkAJeMtae5gfReENnCd7Txq5sHRo7TjXjiNt7vqdOUx6Pzgr4TriWrYYIqPtGKQHwIFX0md5tlhtijNr5r/krShWWsGWi8MYqZvXlI33odtR89PC+JFlLZ5kAUauYm6BzLNlBqNI9fRRezviiGLut019w2Qsbnafi0/I2R6Ny2KUlyBn99MnEoxz8OM9fsW54ZVnT9NZX5eFL8UW4fXFhnXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by SJ0PR10MB6398.namprd10.prod.outlook.com (2603:10b6:a03:44a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Thu, 26 Oct 2023 13:30:40 +0000 X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::7126:faa8:8f0b:d58b]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::7126:faa8:8f0b:d58b%5]) with mapi id 15.20.6907.025; Thu, 26 Oct 2023 13:30:39 +0000 From: "Igor Kulchytskyy via groups.io" To: Nickle Wang , "Chang, Abner" , "devel@edk2.groups.io" CC: Nick Ramirez Subject: Re: [edk2-devel] [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller Thread-Topic: [EXTERNAL] RE: [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller Thread-Index: AQHaB9MPSKSfc77G1UahsvaYvRzZ/7BcBbaggAAC2oCAAALNkIAAA0+AgAACpbA= Date: Thu, 26 Oct 2023 13:30:39 +0000 Message-ID: References: <20231024083944.16275-1-nicklew@nvidia.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=cfbc3f75-dde8-4c77-a5a6-b619356f2f83;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-26T06:09:54Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|SJ0PR10MB6398:EE_ x-ms-office365-filtering-correlation-id: 056bd0aa-ea14-4ba0-aff7-08dbd627be84 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: iJ6nfjPcUSYdCIdrBqr6WufMNDCGe6Tsok1oaJaZtPM8apo/F3rxGEcijzYB6Ox/1FOpdT9BEltVf4hUGQVssZkz8SawVFC9g9kTYzyYH8xFoU1mzcD2gOcNR2hCPkOj7edrt2rl0kO4t+lGnpN3qOXk2xJapnzjRub6B2LAruKy8hW964MKSjkT2IKxMyMU474mcUKimMDzpq1TGC9MTr7aZmLHj714i+hxJa+nmkikxH034xSJhBphSRrcYImwTrRAP+0NOGHaYZ4+b9vSgY2uaXGGbnz1krYhr9ZM/vMWRBCX9CPuVqMfzTk2L03aBhyEC8kmtSMMBbrVUPb5yG5E9kefeCsI6KKmD9QlG9p4icYwuZsl5C/eVNkipj+XkUo4hT+9S7Ime1ZuOCM5Oon2IJ9mVG2wc9h1ymmaDENcxxRLA+dHQg+ZRYSmquLnjVEe+pw513Yegx+VKP3PsiBBctm8ZyOKiGrAFYaOB/7aqT0xwLY762l9d7X0WAZW40UnjNP2McSG+x9SzYSsLnZ4DmkjbA23oSZDf8NPnjMaUxJnXWx3A70iL3w6MAyYq20OTD1JNzwwlTRtXCTlaz/1Wa8BFAl5SUn0UU0xuOcfUqOGFTrZFwGB3/yBVUL6 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pvFiv9WwNHCpKwy1P7EnCJ/jaOXOJeFqNWFIRBEZPgrNQLA6e9dnWTAkl6Zu?= =?us-ascii?Q?wYgl0f68es8ldLpQwLcRLAQSGxPx/+TyH7K4WXAnTH1XwDHpKEDjtD+VHY+t?= =?us-ascii?Q?ePGHGWdeXkr7hJN5aGKn6/BMI/cyyWRX056vJMHnEE7hciIt+0g3TLM68OZV?= =?us-ascii?Q?Df4Ms24M0l84I1L7rgw8scAwcCqqbnC+XSf9VGglsEOFVHppI8Fh8X8+1hqI?= =?us-ascii?Q?n7Y7WHSegHPz+BellHl9uMHFoFbCASpf5JHzFSoudKzbABvxeH5MQC0pfT+T?= =?us-ascii?Q?l38G5DuVi9Q+kcMv2MtTg1VZMuPNczBxfzUEFUQFhE5K8UgYKJIWdHLiXPhf?= =?us-ascii?Q?ssXBXIWRXn9/qyPfAqCGCSEkhQtpkDRPaS88SaMgK7lo1Y0YLDBTk5qNCkhm?= =?us-ascii?Q?z/p3zDMJCt0oXnAZOfxFlDal6CKJzH55WlmAnKPV4CCVpdvam/Ywn6B6aTQg?= =?us-ascii?Q?7l1YAmULhz6APzlnm/Pqc47CwZgycYVhqZ6hsaqOdTGDSdVbAbYHtLGK1BgI?= =?us-ascii?Q?PwXwyUN0Lpoxel4CqHbFHBIFLVQFSSbGpxSXQkA88fNEOyMNcQZhLzAh3AGe?= =?us-ascii?Q?DgmYsbAw1M+xgrtbCgB+Jqm1wXymjrb0JlOxmdgbhdUCn2Ulc7ThkFkOOZnp?= =?us-ascii?Q?TJTz8fL8bDP605B4QZnMEQ4zrlxkW3KtcErmUNEFudwfjIr9COSYMNuVzWVf?= =?us-ascii?Q?Fm00VONptIoQqJ9LTEOR1vMnWgwjmnfuqbfgpmu4GLBoZmezbM1VjHtyAIvr?= =?us-ascii?Q?DI+C5tMChvXSVGvSCrvYHN5o9CzdQtrkQbYKLTNCPXkbKKWCuWHjn5eQvrut?= =?us-ascii?Q?bHdHaeQRXyKLlUaXSWkkUboDKkjZxS1pLGb0zooSAEADK5vpwbtg3XL8YKIz?= =?us-ascii?Q?/vuc8fo83nIY1PHRnvkQv7V99trRXg4mj+4vLF+mDgzhZ1k/BZeQ2ThvSDmS?= =?us-ascii?Q?k1KQPc5VSF6oODRnR/BuEfAFN+mKkTA0sMdHsky8XCIsU8sn0FP09DZalFDL?= =?us-ascii?Q?QHi9V9qOJeru4Pn+icaGj0xxRbXhcl2WpT/XeMJRUsqKX7oqt7atnNPSJWCo?= =?us-ascii?Q?XTGNCfwWSDg4848g7MnOb7zvNzKncv9OZf6Yl3K4rKgH+nJiVQJaYqHQ8hNz?= =?us-ascii?Q?Ar9eBt3eR5jrV7rHspauA3AQqJGDmcxsIxmuzqj2eRiO7nXyYFaoO4mNFdyq?= =?us-ascii?Q?CWL7+SDpPFMM0gpWy6LjpnfrcUmbKl7Z0nX0rdxdTID9DxJ1NVmIQB1aXwNq?= =?us-ascii?Q?msWYuRLhJ1DnSzrG+K7aek4RTvLlhsj+v0WOlO6+Jwhq/TZ0cd0ppsm94PhB?= =?us-ascii?Q?Rry0x93sC+pDXHuqmxKmZocwJAQIvwav1XGorvzf+mF+DUW9qtE7hpiFQHub?= =?us-ascii?Q?D6thDP42Zd06HSay0ULDevliPKNPcHsSL50UFJDKpa4hhR8IS+QxDeCt505b?= =?us-ascii?Q?uHmMNGmc8muDBu2TL61raDjSMbU75Tz99/soQsALKTYvKARxhr2JQlcBMuZr?= =?us-ascii?Q?TwvjgwkySDkaOL91QdgGmrtPUn200+XHEUuo1+ZW3EmWvucj4spLrEQHf3yU?= =?us-ascii?Q?Dvqi6TRVQUqle1SMgTE=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 056bd0aa-ea14-4ba0-aff7-08dbd627be84 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2023 13:30:39.0999 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PhCqJsGRz3SsY8awjZ55GaDYhTgmbeoDbiZpFq21SIAI9q0+ds4ZufOfgNUij+7t X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB6398 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,igork@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: HGMyRlon3dfrEExnfswDdSIfx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=aLUDVPbt; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Igor Kulchytskyy Reviewed the whole PATCH -----Original Message----- From: Nickle Wang Sent: Thursday, October 26, 2023 9:20 AM To: Igor Kulchytskyy ; Chang, Abner ; d= evel@edk2.groups.io Cc: Nick Ramirez Subject: RE: [EXTERNAL] RE: [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP = headers to caller According to my experience, BIOS Redfish is usually the owner to handle Red= fish task request, not the user to create task. So, I think that BIOS has n= o chance to read HTTP header in DELETE request/response. But from specification perspective, Redfish task URI can be returned in HTT= P header in DELETE request. Regards, Nickle > -----Original Message----- > From: Igor Kulchytskyy > Sent: Thursday, October 26, 2023 9:09 PM > To: Nickle Wang ; Chang, Abner > ; devel@edk2.groups.io > Cc: Nick Ramirez > Subject: RE: [EXTERNAL] RE: [PATCH 3/3] RedfishPkg/RedfishLib: return HTT= P > headers to caller > > External email: Use caution opening links or attachments > > > You mean, for the Redfish task functionality other functions will be used= ? > Thank you, > Igor > > -----Original Message----- > From: Nickle Wang > Sent: Thursday, October 26, 2023 8:58 AM > To: Igor Kulchytskyy ; Chang, Abner ; > devel@edk2.groups.io > Cc: Nick Ramirez > Subject: RE: [EXTERNAL] RE: [PATCH 3/3] RedfishPkg/RedfishLib: return HTT= P > headers to caller > > Hi Igor, > > If the DELETE request to BMC is handled by Redfish task, we need to retur= n HTTP > header to caller so caller can get Task URI. But from BIOS Redfish perspe= ctive, I > don't see this use case yet. > > Thanks, > Nickle > > > -----Original Message----- > > From: Igor Kulchytskyy > > Sent: Thursday, October 26, 2023 8:50 PM > > To: Chang, Abner ; Nickle Wang > > ; devel@edk2.groups.io > > Cc: Nick Ramirez > > Subject: RE: [EXTERNAL] RE: [PATCH 3/3] RedfishPkg/RedfishLib: return > > HTTP headers to caller > > > > External email: Use caution opening links or attachments > > > > > > Hi Nickle, > > Just one quick question. > > Is there any sense to return the headers for DELETE request? > > Thank you, > > Igor > > > > -----Original Message----- > > From: Chang, Abner > > Sent: Thursday, October 26, 2023 2:10 AM > > To: Nickle Wang ; devel@edk2.groups.io > > Cc: Igor Kulchytskyy ; Nick Ramirez > > > > Subject: [EXTERNAL] RE: [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP > > headers to caller > > > > > > **CAUTION: The e-mail below is from an external source. Please > > exercise caution before opening attachments, clicking links, or > > following guidance.** > > > > [AMD Official Use Only - General] > > > > Reviewed-by: Abner Chang > > > > > -----Original Message----- > > > From: Nickle Wang > > > Sent: Tuesday, October 24, 2023 4:40 PM > > > To: devel@edk2.groups.io > > > Cc: Chang, Abner ; Igor Kulchytskyy > > > ; Nick Ramirez > > > Subject: [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to > > > caller > > > > > > Caution: This message originated from an External Source. Use proper > > > caution when opening attachments, clicking links, or responding. > > > > > > > > > Call Ex interface to get HTTP headers and return to caller. > > > > > > Signed-off-by: Nickle Wang > > > Cc: Abner Chang > > > Cc: Igor Kulchytskyy > > > Cc: Nick Ramirez > > > --- > > > RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c | 10 +++++++--- > > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > > > diff --git a/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > > > b/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > > > index f4045044829a..5e06d516ba84 100644 > > > --- a/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > > > +++ b/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c > > > @@ -356,7 +356,7 @@ RedfishGetByUri ( > > > > > > ZeroMem (RedResponse, sizeof (REDFISH_RESPONSE)); > > > > > > - JsonValue =3D getUriFromService (RedfishService, Uri, &= RedResponse- > > > >StatusCode); > > > + JsonValue =3D getUriFromServiceEx (RedfishService, Uri, > &RedResponse- > > > >Headers, &RedResponse->HeaderCount, &RedResponse->StatusCode); > > > RedResponse->Payload =3D createRedfishPayload (JsonValue, > > > RedfishService); > > > > > > // > > > @@ -498,10 +498,12 @@ RedfishPatchToUri ( > > > > > > ZeroMem (RedResponse, sizeof (REDFISH_RESPONSE)); > > > > > > - JsonValue =3D (EDKII_JSON_VALUE)patchUriFromService ( > > > + JsonValue =3D (EDKII_JSON_VALUE)patchUriFromServiceEx ( > > > RedfishService, > > > Uri, > > > Content, > > > + &(RedResponse->Headers), > > > + &(RedResponse->HeaderCount), > > > &(RedResponse->StatusCode) > > > ); > > > > > > @@ -661,12 +663,14 @@ RedfishPostToUri ( > > > > > > ZeroMem (RedResponse, sizeof (REDFISH_RESPONSE)); > > > > > > - JsonValue =3D (EDKII_JSON_VALUE)postUriFromService ( > > > + JsonValue =3D (EDKII_JSON_VALUE)postUriFromServiceEx ( > > > RedfishService, > > > Uri, > > > Content, > > > ContentSize, > > > ContentType, > > > + &(RedResponse->Headers), > > > + &(RedResponse->HeaderCount), > > > &(RedResponse->StatusCode) > > > ); > > > > > > -- > > > 2.17.1 > > > > -The information contained in this message may be confidential and > > proprietary to American Megatrends (AMI). This communication is > > intended to be read only by the individual or entity to whom it is > > addressed or by their designee. If the reader of this message is not > > the intended recipient, you are on notice that any distribution of > > this message, in any form, is strictly prohibited. Please promptly > > notify the sender by reply e-mail or by telephone at 770-246-8600, and = then > delete or destroy all copies of the transmission. > -The information contained in this message may be confidential and propri= etary > to American Megatrends (AMI). This communication is intended to be read o= nly by > the individual or entity to whom it is addressed or by their designee. If= the reader > of this message is not the intended recipient, you are on notice that any > distribution of this message, in any form, is strictly prohibited. Please= promptly > notify the sender by reply e-mail or by telephone at 770-246-8600, and th= en > delete or destroy all copies of the transmission. -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110099): https://edk2.groups.io/g/devel/message/110099 Mute This Topic: https://groups.io/mt/102154017/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-