From: "Igor Kulchytskyy" <igork@ami.com>
To: "abner.chang@amd.com" <abner.chang@amd.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Jian J Wang <jian.j.wang@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Nickle Wang <nicklew@nvidia.com>,
Isaac Oram <isaac.w.oram@intel.com>,
Nate DeSimone <nathaniel.l.desimone@intel.com>
Subject: Re: [PATCH V2 0/3] Add NULL IpmiCommandLib instance
Date: Tue, 17 Jan 2023 16:47:17 +0000 [thread overview]
Message-ID: <BLAPR10MB5185FEE8F101D16CE9C0FCB2A8C69@BLAPR10MB5185.namprd10.prod.outlook.com> (raw)
In-Reply-To: <20230113060318.610-1-abner.chang@amd.com>
Series Reviewed-by: Igor Kulchytskyy <igork@ami.com>
-----Original Message-----
From: abner.chang@amd.com <abner.chang@amd.com>
Sent: Friday, January 13, 2023 1:03 AM
To: devel@edk2.groups.io
Cc: Jian J Wang <jian.j.wang@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Nickle Wang <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>; Isaac Oram <isaac.w.oram@intel.com>; Nate DeSimone <nathaniel.l.desimone@intel.com>
Subject: [EXTERNAL] [PATCH V2 0/3] Add NULL IpmiCommandLib instance
**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**
From: Abner Chang <abner.chang@amd.com>
BZ# 4231
In V2: Address the typos.
This patch adds a NULL instance of IpmiCommandLib to remove the dependence between edk2 and edk2-platform packages.
Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Abner Chang (3):
MdeModulePkg/Include: Add IpmiCommandLib header file
MdeModulePkg/IpmiCommandLib: Add NULL instance library
MdeModulePkg: Add IpmiCommandLib
MdeModulePkg/MdeModulePkg.dec | 5 +
MdeModulePkg/MdeModulePkg.dsc | 3 +
.../BaseIpmiCommandLibNull.inf | 34 +
MdeModulePkg/Include/Library/IpmiCommandLib.h | 683 ++++++++++++++++++
.../IpmiCommandLibNetFnApp.c | 252 +++++++
.../IpmiCommandLibNetFnChassis.c | 123 ++++
.../IpmiCommandLibNetFnStorage.c | 248 +++++++
.../IpmiCommandLibNetFnTransport.c | 100 +++
8 files changed, 1448 insertions(+)
create mode 100644 MdeModulePkg/Library/BaseIpmiCommandLibNull/BaseIpmiCommandLibNull.inf
create mode 100644 MdeModulePkg/Include/Library/IpmiCommandLib.h
create mode 100644 MdeModulePkg/Library/BaseIpmiCommandLibNull/IpmiCommandLibNetFnApp.c
create mode 100644 MdeModulePkg/Library/BaseIpmiCommandLibNull/IpmiCommandLibNetFnChassis.c
create mode 100644 MdeModulePkg/Library/BaseIpmiCommandLibNull/IpmiCommandLibNetFnStorage.c
create mode 100644 MdeModulePkg/Library/BaseIpmiCommandLibNull/IpmiCommandLibNetFnTransport.c
--
2.37.1.windows.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
prev parent reply other threads:[~2023-01-17 16:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 6:03 [PATCH V2 0/3] Add NULL IpmiCommandLib instance Chang, Abner
2023-01-13 6:03 ` [PATCH V2 1/3] MdeModulePkg/Include: Add IpmiCommandLib header file Chang, Abner
2023-01-13 6:03 ` [PATCH V2 2/3] MdeModulePkg/IpmiCommandLib: Add NULL instance library Chang, Abner
2023-01-13 6:03 ` [PATCH V2 3/3] MdeModulePkg: Add IpmiCommandLib Chang, Abner
2023-01-13 21:34 ` [edk2-devel] [PATCH V2 0/3] Add NULL IpmiCommandLib instance Isaac Oram
2023-01-17 16:47 ` Igor Kulchytskyy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BLAPR10MB5185FEE8F101D16CE9C0FCB2A8C69@BLAPR10MB5185.namprd10.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox