From: Fan Jeff <vanjeff_919@hotmail.com>
To: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] UefiCpuPkg/MpInitLib: Fix a bug that AP enters timer INT handler
Date: Fri, 5 Jan 2018 09:15:27 +0000 [thread overview]
Message-ID: <BLUPR19MB01313A686338AC77ACA770DED71C0@BLUPR19MB0131.namprd19.prod.outlook.com> (raw)
In-Reply-To: <20180105090850.232768-1-ruiyu.ni@intel.com>
Reviewed-by: Jeff Fan <vanjeff_919@hotmail.com>
Ray,thank you find/fix this issue!
发自我的 iPhone
> 在 2018年1月5日,下午5:08,Ruiyu Ni <ruiyu.ni@intel.com> 写道:
>
> When SourceLevelDebug is enabled, AP randomly executes the DXECORE
> timer handler logic. The root cause is the interrupts are not
> masked in AP wake up procedure.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jeff Fan <vanjeff_919@hotmail.com>
> ---
> UefiCpuPkg/Library/MpInitLib/MpLib.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpInitLib/MpLib.c
> index 0c2058a7b0..1a6cdb678e 100644
> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c
> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c
> @@ -1,7 +1,7 @@
> /** @file
> CPU MP Initialize Library common functions.
>
> - Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.<BR>
> + Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.<BR>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD License
> which accompanies this distribution. The full text of the license may be found at
> @@ -582,6 +582,10 @@ ApWakeupFunction (
> // We need to re-initialize them at here
> //
> ProgramVirtualWireMode ();
> + //
> + // Mask the LINT0 and LINT1 so that AP doesn't enter the system timer interrupt handler.
> + //
> + DisableLvtInterrupts ();
> SyncLocalApicTimerSetting (CpuMpData);
>
> CurrentApicMode = GetApicMode ();
> --
> 2.15.1.windows.2
>
prev parent reply other threads:[~2018-01-05 9:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 9:08 [PATCH] UefiCpuPkg/MpInitLib: Fix a bug that AP enters timer INT handler Ruiyu Ni
2018-01-05 9:15 ` Fan Jeff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BLUPR19MB01313A686338AC77ACA770DED71C0@BLUPR19MB0131.namprd19.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox