public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Felix Polyudov via groups.io" <felixp=ami.com@groups.io>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback in EFI_FORM_BROWSER2_PROTOCOL
Date: Fri, 29 Dec 2023 21:26:55 +0000	[thread overview]
Message-ID: <BN0PR10MB498133FA9B2CE93E6BA83361DE9DA@BN0PR10MB4981.namprd10.prod.outlook.com> (raw)
In-Reply-To: <BN0PR10MB4981F4C2E5673C5F95AF7ED7DE9FA@BN0PR10MB4981.namprd10.prod.outlook.com>

Reviewed by: Felix Polyudov <felixp@ami.com>

-----Original Message-----
From: Tan, Ming <ming.tan@intel.com>
Sent: Monday, December 25, 2023 3:20 AM
To: Felix Polyudov <Felixp@ami.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>; Ren, SuqiangX <suqiangx.ren@intel.com>
Subject: [EXTERNAL] RE: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback in EFI_FORM_BROWSER2_PROTOCOL


**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**

Hi:
  Would you like to review this patch?
  It is for your request: https://mantis.uefi.org/mantis/view.php?id=1908

  BR/Tan Ming.

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of SuqiangX Ren
Sent: Friday, December 22, 2023 2:33 PM
To: devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
Subject: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback in EFI_FORM_BROWSER2_PROTOCOL

Add status code return for BROWSER callback in EFI_FORM_BROWSER2_PROTOCOL to align with UEFI spec 2.10.

REF: UEFI spec 2.10 Table 35.6.3

Signed-off-by: RenSuqiang <suqiangx.ren@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Yi Li <yi1.li@intel.com>
---
 MdePkg/Include/Protocol/FormBrowser2.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/MdePkg/Include/Protocol/FormBrowser2.h b/MdePkg/Include/Protocol/FormBrowser2.h
index 436a7723c1da..bc214caa7d93 100644
--- a/MdePkg/Include/Protocol/FormBrowser2.h
+++ b/MdePkg/Include/Protocol/FormBrowser2.h
@@ -138,10 +138,13 @@ EFI_STATUS
   @retval EFI_SUCCESS           The results have been distributed or are
                                 awaiting distribution.

-  @retval EFI_OUT_OF_RESOURCES  The ResultsDataSize specified
+  @retval EFI_BUFFER_TOO_SMALL  The ResultsDataSize specified
                                 was too small to contain the
                                 results data.

+  @retval EFI_UNSUPPORTED       Uncommitted browser state is not available
+                                at the current stage of execution.
+
 **/
 typedef
 EFI_STATUS
--
2.26.2.windows.1






-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113002): https://edk2.groups.io/g/devel/message/113002
Mute This Topic: https://groups.io/mt/103314459/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      parent reply	other threads:[~2023-12-29 21:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1703226639.git.suqiangx.ren@intel.com>
2023-12-22  6:32 ` [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback in EFI_FORM_BROWSER2_PROTOCOL SuqiangX Ren
2023-12-23  2:02   ` 回复: " gaoliming via groups.io
2024-01-02  2:42     ` Ren, Suqiang
2024-01-08  7:43       ` Ren, Suqiang
     [not found]   ` <BN8PR11MB3713F6FB132DCC52140B38E69799A@BN8PR11MB3713.namprd11.prod.outlook.com>
     [not found]     ` <BN0PR10MB4981F4C2E5673C5F95AF7ED7DE9FA@BN0PR10MB4981.namprd10.prod.outlook.com>
2023-12-29 21:26       ` Felix Polyudov via groups.io [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN0PR10MB498133FA9B2CE93E6BA83361DE9DA@BN0PR10MB4981.namprd10.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox