From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id B2D3A7803D1 for ; Mon, 15 Apr 2024 17:33:59 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=zQVZdDuD1kgYl05vr2diOWzH6vjH50YEC/kHFx43uOg=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1713202438; v=1; b=f0Ma6Ek1gZ2sfo3HnWKSPHpT2OfOZpdvBCYFS7PA7f2aMVckjf+uqmmT5WrSKwo6RNiQ7UOB RVbkUmOaj3Kivpr9q2On6rj0WjTe3hlDUx4zyawMYeCK8dvFVd5YtRr7S+KV/dWCcp3ajiiAcdR zlMoDX/zmMQtrtTQYn8aF9X+Pj5iwFwUrqUDPL12QRVgUWUG+nZU3yJOfOOyUapaolOfbxVCzRX 71cS1C1A/F0aJTLLQgKaCZNQ82RcgH/Bh4SPq8VxktcQdw/19UFfsFdoY9SAnmKDxkpHEu8Cm9u Gp/9lSahpnAe0OBwaRwUqomMntWynHGtJ9MGtdaTErGiQ== X-Received: by 127.0.0.2 with SMTP id lvd2YY7687511xiuyABZcyX9; Mon, 15 Apr 2024 10:33:58 -0700 X-Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.107.95.106]) by mx.groups.io with SMTP id smtpd.web10.1440.1713202437445103414 for ; Mon, 15 Apr 2024 10:33:57 -0700 X-Received: from BN0PR10MB4981.namprd10.prod.outlook.com (2603:10b6:408:12d::16) by CH3PR10MB6882.namprd10.prod.outlook.com (2603:10b6:610:14e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Mon, 15 Apr 2024 17:33:44 +0000 X-Received: from BN0PR10MB4981.namprd10.prod.outlook.com ([fe80::1960:af5e:4775:9963]) by BN0PR10MB4981.namprd10.prod.outlook.com ([fe80::1960:af5e:4775:9963%6]) with mapi id 15.20.7452.049; Mon, 15 Apr 2024 17:33:44 +0000 From: "Felix Polyudov via groups.io" To: Sachin Ganesh , "devel@edk2.groups.io" CC: "gaoliming@byosoft.com.cn" , "michael.d.kinney@intel.com" , "zhiguang.liu@intel.com" , Dhanaraj V Subject: Re: [edk2-devel] [PATCH 1/5] MdePkg: Add definition for NVMe Over Fabric Device Path Thread-Topic: [PATCH 1/5] MdePkg: Add definition for NVMe Over Fabric Device Path Thread-Index: AQHaj1SXrjf94vmvDUu//KbQJAIH/7FpkZpA Date: Mon, 15 Apr 2024 17:33:44 +0000 Message-ID: References: <20240415164627.2464-1-sachinganesh@ami.com> <20240415164627.2464-2-sachinganesh@ami.com> In-Reply-To: <20240415164627.2464-2-sachinganesh@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN0PR10MB4981:EE_|CH3PR10MB6882:EE_ x-ms-office365-filtering-correlation-id: df809751-c834-449d-e40c-08dc5d723304 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: lcyy0SahdHjM+wjY7sHULXGGWJQGfTubZhpwEszKVsMZVMxaimlmlYhVFad+pC95pVbrH5Irp4GFVmCIgXih5W4hhuTqiTc3sZAZ3S76EfKkEuMSIGwxXpK1Ga0D/9H2xKHS/rhwlOQMOga9JzGbVrL+vlOMZrIxeI4sVwSa2nUWE3iek4ABBaD8gPKurlFNe8Qt2eQGw2PyvTIjk5pPY2ySul5/KCgp5GAEDFz9mskeLf4pKCXl5/SxrgveWCnTMMg9UzPv1gwwsh1ueMGf7AFlyFNf7OVkgkcNYpYH2W0mfBS00VGNYU6FZZSOF+uZfaZ45pUC8kOF1Y2d/WcLuSeY59T7Op7663m7sdJtl/vGp0R6xHtVzzMxKiRVW0PDDBgb1ZDWdDEZJGLIGluLOUL92FmYi+GDunnZ1/wQVdVFLM9JR7cjS/sg6OL9GeK+LillM+Id9U+yhap6IeBzHcY0ubSwZbCVCCG7vwYf70zi/Mh4hPPNwj3V4GXA6kxzPZDIZG25A5iPCdK8hppQfJtHK8jOSzuM9xY9x5GEhTxGldmWbsLS1cpyDlFI18A8BtQtWxsneDg9vjcv7YvC1u8ORRZ4mHTSwZSvLgcRaBVMb2CaBNZr7HExH8jY3VJHeWPyxq3IcjjG83rMXGc5vEmNm+TMYBDqZy2lge15d6k= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?E9NTCgl9bK4SKzkZCFkYeWtGyxe2/LgldYC8MOnvkhlIqanjw9cXeUnFCCrq?= =?us-ascii?Q?MFP5BdeqcDHWj0r/1a8mjqE3elzwBkhq1F1VA7abDbAF/OvOXlxZYiRGxOPQ?= =?us-ascii?Q?zlxXDIzbVdlsFRauk0vbQ1n1v7bcQCjATlTjAY1pnyKVVIUpBR6amyLKtD7J?= =?us-ascii?Q?dcFWTWVVL1H/omaQ3dNEgBOX0fCYcxGiSKACAEANyTqjy52m8tG/wwqco0i6?= =?us-ascii?Q?/kg7p6ugabQalPJzTNYKBGz6WRGYf9LvbB1JDHWUSJgeBxRM/Izu2BJc8uVl?= =?us-ascii?Q?/ZQ9wnYY83+lP75PiRU6xe+9JoZFO7F2v1odHfaA1ffcH3KQ2iUtDnsq0v+Z?= =?us-ascii?Q?nVyeQtKr1rb0fAOS9OjTkwCHi20IxzDaFiNSWFD0o6WanmOhoAS1Y3QX/o/1?= =?us-ascii?Q?ydGWsyOIQtV546/jOy7e/iN+K+jzoRpTw9QdDOZOAgvSnfuUnxo5JzA9YwTS?= =?us-ascii?Q?SYZ+fHF2RL/dqXkPRS6IFgnK9mfiow+Pve8D/cp7QkwUpcJXeBXPzd5Wj3dK?= =?us-ascii?Q?aD9fAt0kwDbEiQ2KuqqPMuoT9GCkwD78zDvcFoK2GXWsXvTW+qGilifqNiNj?= =?us-ascii?Q?Q7Gag56P2Vt5HYyBNy1oZuj9ZdmE4GT/1+rhLTrQCyQOwUCPDPZeRZ/lFzju?= =?us-ascii?Q?IMMcd8KEB094/Zvm/tWVcLW58zf8cyOy/r9Lx6xaK2iP6ElG4pzRj9iJ9XZL?= =?us-ascii?Q?yJdWtFhtQYQ+jIaXgfpzikz6I87ETfSM8Bl47MjvLv7wCnV6e6eDgje5AkGd?= =?us-ascii?Q?Qrx1n54kC7G3Ag/zAwb90rL0zR5bZ1aSxrkOvIwpfwhYDO2pnpTsZ776N6Do?= =?us-ascii?Q?Ds7xXITgtqEdDvZ5rRpPHdLdi6bF1za+D/ObFcmU4IfivABnBrPq9kJpPPC5?= =?us-ascii?Q?WoQfd26VRZLenRTBHnNKLqeQ9WzufH6skmU/Yqt22R81pMO0vEx9urSuqIPA?= =?us-ascii?Q?Tw+Vhln9q4TZinASGJHFBzC0eG7/CkDsdzZ+cq0KkF1hm0Lxk6le0Hy+sX6R?= =?us-ascii?Q?nrLiM0wQUSl28RLccNpohqOM3WaT6WhV2GN5YSL0pNB6R2ZTW7pV5YIM4CWi?= =?us-ascii?Q?OYeL2XiimbufWxs26L5dnxZIOraDbuCi/aRVSsat3NJha+k2uTRuEwOVEhCB?= =?us-ascii?Q?oh2GHAynUo7AYMD6HjypyEc4SwHjICn3nvsKgdI/n7eds56CvyXk8U52A9Mg?= =?us-ascii?Q?O5dITedbHGHolUufod2OVQNehYF0Agcc4QO3S+Z3q/n0UjWv9TuKYjo7Q5zf?= =?us-ascii?Q?0UPxzxxeo+zScvsapTwIyr9Co7Cr90mMN8Vklg15tgvcmkMCj3nkzxaifdsX?= =?us-ascii?Q?/+/ked6Kg1MHiU8tTIWb8E8fDBB0Ykp/2JDe4I5IpT4oTdq/JP7HxFfcgQdg?= =?us-ascii?Q?azMEd71OHfyu90Xqsw1cxG8dbktIUrTJ/W+VnTuoM5Th7hYSnDzPvqIjKDAi?= =?us-ascii?Q?LbQNN6EGRrQmwBJdpLbCI95e36PjzakubOFJL2VWWLEPaBQju/GN10ykKVDo?= =?us-ascii?Q?xZ32WV+rbIDbQTLpcfKrAd0ptJ0UPClM4LKjahXu10J4FGcUgLHVXfn8D8CL?= =?us-ascii?Q?bieEyFvuhBHOMR+QUzg=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB4981.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: df809751-c834-449d-e40c-08dc5d723304 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2024 17:33:44.3008 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EgUpnbhQlib/M4FPZQs9+8iTi94958YjDi984nkoAxfcJaD0CgM6zQ/36+FzYCG+ X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB6882 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 15 Apr 2024 10:33:57 -0700 Resent-From: felixp@ami.com Reply-To: devel@edk2.groups.io,felixp@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 0vTkUUY5BdqcEGMhMoSeh8YMx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=f0Ma6Ek1; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io Sachin, > +#define MSG_NVME_OF_NAMESPACE_DP 0x20 UEFI Specification defines this as 34, which is 0x22 Refer to https://uefi.org/specs/UEFI/2.10/10_Protocols_Device_Path_Protocol= .html#nvme-over-fabric-nvme-of-namespace-device-path > > +typedef struct { > ... > + /// Unique identifier of an NVM subsystem > > + /// > > + CHAR8 *SubsystemNQN; > This should be: CHAR8 SubsystemNqn[]; Here is why: 1. According to edk2 coding conventions, only first latter of the acronym i= s capitalized Refer to section 4.3.4.3 @ https://tianocore-docs.github.io/edk2-CCodingSta= ndardsSpecification/release-2.20/4_naming_conventions/43_identifiers.html#4= 3-identifiers 2. The structure contains the actual string, not a pointer to the string. > +} NVME_OF_NAMESPACE_DEVICE_PATH; > -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117801): https://edk2.groups.io/g/devel/message/117801 Mute This Topic: https://groups.io/mt/105540403/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-