public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* reg: clarification on Form Browser Action on save changes in IP4 and IP6 configuration
@ 2021-03-24 12:35 Sivaraman Nainar
  2021-03-25  3:12 ` 回复: [edk2-devel] " gaoliming
  0 siblings, 1 reply; 3+ messages in thread
From: Sivaraman Nainar @ 2021-03-24 12:35 UTC (permalink / raw)
  To: devel@edk2.groups.io, maciej.rabeda@intel.com
  Cc: RainChen [陳宇翔]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

Hello all:

In the IPV4 and IPV6 Configuration Page after the changes are applied the system proceed to boot to the boot device and its not staying in same form.

case KEY_SAVE_CHANGES:
      Status = Ip6ConvertIfrNvDataToConfigNvDataGeneral (IfrNvData, Instance);
      if (EFI_ERROR (Status)) {
        break;
      }
      *ActionRequest = EFI_BROWSER_ACTION_REQUEST_SUBMIT;
      *ActionRequest = EFI_BROWSER_ACTION_REQUEST_FORM_APPLY; //Modified code
      break;

If the browser action changed as above the control retained in the same page.

Is there any specific reason after the IP Configuration Settings applied it proceed to Boot?

-Siva

Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

[-- Attachment #2: Type: text/html, Size: 3503 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* 回复: [edk2-devel] reg: clarification on Form Browser Action on save changes in IP4 and IP6 configuration
  2021-03-24 12:35 reg: clarification on Form Browser Action on save changes in IP4 and IP6 configuration Sivaraman Nainar
@ 2021-03-25  3:12 ` gaoliming
  2021-03-29  6:19   ` sivaramann
  0 siblings, 1 reply; 3+ messages in thread
From: gaoliming @ 2021-03-25  3:12 UTC (permalink / raw)
  To: devel, sivaramann, maciej.rabeda
  Cc: 'RainChen [��宇翔]'

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 1948 bytes --]

Siva:

 This question prompt string is "Save Changes and Exit". So, its behavior is
to save and exit. In Edk2 MdeModulePkg SetupBrowser, exit behavior is to
exit current page and enter into its parent page.  Does your SetupBrowser
implement exit behavior to exit the whole UI?

 

Thanks

Liming

·¢¼þÈË: devel@edk2.groups.io <devel@edk2.groups.io> ´ú±í Sivaraman Nainar
·¢ËÍʱ¼ä: 2021Äê3ÔÂ24ÈÕ 20:35
ÊÕ¼þÈË: devel@edk2.groups.io; maciej.rabeda@intel.com
³­ËÍ: RainChen [êÓîÏè] <RainChen@ami.com>
Ö÷Ìâ: [edk2-devel] reg: clarification on Form Browser Action on save changes
in IP4 and IP6 configuration

 

Hello all:

 

In the IPV4 and IPV6 Configuration Page after the changes are applied the
system proceed to boot to the boot device and its not staying in same form.

 

case KEY_SAVE_CHANGES:

      Status = Ip6ConvertIfrNvDataToConfigNvDataGeneral (IfrNvData,
Instance);

      if (EFI_ERROR (Status)) {

        break;

      }

      *ActionRequest = EFI_BROWSER_ACTION_REQUEST_SUBMIT;

      *ActionRequest = EFI_BROWSER_ACTION_REQUEST_FORM_APPLY; //Modified
code

      break;

 

If the browser action changed as above the control retained in the same
page.

 

Is there any specific reason after the IP Configuration Settings applied it
proceed to Boot?

 

-Siva

P Please consider the environment before printing this email 

The information contained in this message may be confidential and
proprietary to American Megatrends (AMI). This communication is intended to
be read only by the individual or entity to whom it is addressed or by their
designee. If the reader of this message is not the intended recipient, you
are on notice that any distribution of this message, in any form, is
strictly prohibited. Please promptly notify the sender by reply e-mail or by
telephone at 770-246-8600, and then delete or destroy all copies of the
transmission.




[-- Attachment #2: Type: text/html, Size: 7353 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [edk2-devel] reg: clarification on Form Browser Action on save changes in IP4 and IP6 configuration
  2021-03-25  3:12 ` 回复: [edk2-devel] " gaoliming
@ 2021-03-29  6:19   ` sivaramann
  0 siblings, 0 replies; 3+ messages in thread
From: sivaramann @ 2021-03-29  6:19 UTC (permalink / raw)
  To: devel@edk2.groups.io, gaoliming@byosoft.com.cn,
	maciej.rabeda@intel.com
  Cc: RainChen [陳宇翔]

[-- Attachment #1: Type: text/plain, Size: 3096 bytes --]

Hello Liming:

Thanks for clarifying.

The Setup browser in EDK2 works as you said. The implementation of our Browser having difference in handling.

-Siva
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming
Sent: Thursday, March 25, 2021 8:42 AM
To: devel@edk2.groups.io; Sivaraman Nainar <sivaramann@ami.com>; maciej.rabeda@intel.com
Cc: RainChen [陳宇翔] <RainChen@ami.com>
Subject: 回复: [edk2-devel] reg: clarification on Form Browser Action on save changes in IP4 and IP6 configuration

Siva:
 This question prompt string is "Save Changes and Exit". So, its behavior is to save and exit. In Edk2 MdeModulePkg SetupBrowser, exit behavior is to exit current page and enter into its parent page.  Does your SetupBrowser implement exit behavior to exit the whole UI?

Thanks
Liming
发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> 代表 Sivaraman Nainar
发送时间: 2021年3月24日 20:35
收件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; maciej.rabeda@intel.com<mailto:maciej.rabeda@intel.com>
抄送: RainChen [陳宇翔] <RainChen@ami.com<mailto:RainChen@ami.com>>
主题: [edk2-devel] reg: clarification on Form Browser Action on save changes in IP4 and IP6 configuration

Hello all:

In the IPV4 and IPV6 Configuration Page after the changes are applied the system proceed to boot to the boot device and its not staying in same form.

case KEY_SAVE_CHANGES:
      Status = Ip6ConvertIfrNvDataToConfigNvDataGeneral (IfrNvData, Instance);
      if (EFI_ERROR (Status)) {
        break;
      }
      *ActionRequest = EFI_BROWSER_ACTION_REQUEST_SUBMIT;
      *ActionRequest = EFI_BROWSER_ACTION_REQUEST_FORM_APPLY; //Modified code
      break;

If the browser action changed as above the control retained in the same page.

Is there any specific reason after the IP Configuration Settings applied it proceed to Boot?

-Siva
P Please consider the environment before printing this email

The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

[-- Attachment #2: Type: text/html, Size: 9129 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-29  6:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-24 12:35 reg: clarification on Form Browser Action on save changes in IP4 and IP6 configuration Sivaraman Nainar
2021-03-25  3:12 ` 回复: [edk2-devel] " gaoliming
2021-03-29  6:19   ` sivaramann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox