From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C890F7803DA for ; Mon, 25 Mar 2024 10:54:23 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=KIZ3YOJHy1q7Cf1VY6YuiZ1etVwjmfRnoBhASW49LW4=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1711364062; v=1; b=pcrRxQPvMZLR6fkcgJdqyb2jce/YOgCzsJvj42hYoTJBQK6CSmjl9cT9Dd4rNLYKdD86jSvi AzJBpE9Jkp1QywuynUBEfZqxunTQkPrN6LygK+WG051IlhstpkUuHy+AWq1ZxxBzYvr9SCL0i+S ctT1/4rbbG7aEDD0hBz8gRQmAeaVYGo5McpHsgBL2skRI7kbl9IGptuMLdP8f1ASGCQb0W8wmjV L8lV8jYP2kG01u3RpwSyqaahFBw56iBfKFddtWhjlPA4CGC8PEYHPiSxRfdp82TjMgPRZz/ayiR n0EYDCTcaomRySRualC1EbOgUF6DFXWiu6rGeGbgyNwSA== X-Received: by 127.0.0.2 with SMTP id zPZiYY7687511xUtXjfHYQLi; Mon, 25 Mar 2024 03:54:22 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.101]) by mx.groups.io with SMTP id smtpd.web11.48868.1711364061117823095 for ; Mon, 25 Mar 2024 03:54:21 -0700 X-Received: from BN0PR10MB4981.namprd10.prod.outlook.com (2603:10b6:408:12d::16) by PH7PR10MB6673.namprd10.prod.outlook.com (2603:10b6:510:20b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.31; Mon, 25 Mar 2024 10:54:16 +0000 X-Received: from BN0PR10MB4981.namprd10.prod.outlook.com ([fe80::48eb:e11b:26b1:4083]) by BN0PR10MB4981.namprd10.prod.outlook.com ([fe80::48eb:e11b:26b1:4083%5]) with mapi id 15.20.7409.028; Mon, 25 Mar 2024 10:54:16 +0000 From: "Sivaraman Nainar via groups.io" To: "Kasbekar, Saloni" , "devel@edk2.groups.io" , Laszlo Ersek , Santhosh Kumar V , "Clark-williams, Zachary" CC: Raj V Akilan , Soundharia R Subject: Re: [edk2-devel] [PATCH] NetworkPkg:Resolved Consecutive Pxe-Http Boot Issue Thread-Topic: [EXTERNAL] Re: [edk2-devel] [PATCH] NetworkPkg:Resolved Consecutive Pxe-Http Boot Issue Thread-Index: AQHaZOmcTV48E41v9E6Ol22UcMz6DLEVdjGAgAAlbkCABtgbEIAipIrAgAVnJQCAA/vacA== Date: Mon, 25 Mar 2024 10:54:16 +0000 Message-ID: References: <20240221171347.1343-1-santhoshkumarv@ami.com> <21b2d17d-5de5-5f08-ef6b-a0a285b05917@redhat.com> <17B60D00FAC661AD.27859@groups.io> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN0PR10MB4981:EE_|PH7PR10MB6673:EE_ x-ms-office365-filtering-correlation-id: 3d89835e-f3c4-43b6-bcb8-08dc4cb9ea28 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: n8zDFwfwAYKZJF/SKZc+BoFXVsOp14Sn1DchkOYCQ+dvmHr4vIpQCaRm+QtoyJbXeBtJaKlagDVnb7Lqyf7Hh13x2294N3b9b6ZxV9AG8+S7X+zpHH460Qk4Nr/ooMyVq4JaW0le/dnzo5MGgvLy/qaXydPboas+pNuokYgKCC6NDzYR+rUktWrueXCh85eJzgSojmlMPOEEJXYgx9DgsxD+CNnIIslVAHady4m4//IRzNKefwLMDaI47/FxLQdRiP6e1qhvi/+NBnHXjfKWbxqIi7dEG9KuWmUNCniHixVHOfw5+CbYk6qr0S/5pFmbA9gK+S/UoGPmbuC8LJtvRGOFC+EC+q85BAUkqXHTPCloBxZLZZU1Q7FHjDuPJJ+8eTAcIv6DqoT2bQBnbwh5vE9uLhMHLtCLNWx1zDg7SOPwsIHy10l+kvZW3aLRIaaGl8A2sjQhh2MRnx+2MbjaM+KDAG/g9+0TQCIXumvleqUE+pjUkI/tqCYCdjjJPLCUr1l+ZnTkoG5KuTqj+tPV/7FbMYjJH0M9TRIZ/7+1x+UfYD1j2CMH8qBp3k8s7DK0/vxj7zN6KxVk/xqF2qZswID6QMMopDCaOnsMkpZI5/zn8AoHy51MEvHF8590pwUiafbSW0FWM8YIKLkNgJQZ9GyuJ2PDz+YNOiaNzq4D+Mc= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5VdrErzbbXaEQhG4ETo8Pg5xKm3R4+eWAzgCC8pY/0h5xAozYP2x/2N/GQ9g?= =?us-ascii?Q?mmsSl6q0OOJ9uW4JFxeYuLjYtcvIlClz4/pU4pH5ZDUu0LhWmUb6p0U4UOrX?= =?us-ascii?Q?2u5coVIGH834CQLp2TJSaobYURtc8NXT5SfB1CXHPPWsLzC8iLSGOWA53FJm?= =?us-ascii?Q?cLy8o83vJOx+x2bf1wwj8TD+FHu8ZaqqPk/cAgI2rcYpywQOG4hoZlyFGHth?= =?us-ascii?Q?nxPHUVteenQuF8eMpxEEHcVt/nKnQg/4iSsPzlFBYNBFjiHzhegAioEvls+u?= =?us-ascii?Q?MwinrMr0trfy5gfberusRXNzrS9o6FUslqrFusu82cB/VSkhuwAkLft8ajgj?= =?us-ascii?Q?HnJ/FKUXUBCO3kxNgK5rjuMPtq6rzGxTGwRyx4Uj/A3MVY4oalx5pDJG+3Ie?= =?us-ascii?Q?eXJ/Bt/jq84LHJgRcxtHpPb3oPyuRYkyAYl53kPX6EC+xbE/jEBQDOPH4rHu?= =?us-ascii?Q?E9obsWh+vYzjeAQudgeLSQSUkLGKeGY2UKADzveIpupVIeWQQMOqnT809u5O?= =?us-ascii?Q?xYXB3SzITdcxvbpVC6Gu0DR+bCrXo17HDn4lGrxUsnVo7yygYvQrASe9h+Us?= =?us-ascii?Q?BM4Jaj187iVxUEY0l015ggR6ymXz5TO+OME6Fp+LBKFROHN3eC4uWy0c8Zin?= =?us-ascii?Q?pA0THFWmssBJF3BfQKvDSdsVZO/XVXctAMQIzHPZRgH/ja+1DfCK4BUf93P4?= =?us-ascii?Q?AZbNZ7ozO3ObaOOLk/1kZHMNu6l9Xzt7WWMjRLRWlFABzJkm6ZI0TgG8CAtG?= =?us-ascii?Q?UXPO2vroSBfL0UjQXCHlZ2vG654683JxZphRuuC9+24DuGU0GmnHEYp943aB?= =?us-ascii?Q?EzyS9+mvLdlWY/vbsfr5XSHc5IUoUKqPQURF1YQctNA+k3axJSTVGErDZ+W2?= =?us-ascii?Q?qvbs1TPv/oBftcwinEV3/7w/llwK+WS8kbPsbnC5HGgLprKfoMTpzDurygY2?= =?us-ascii?Q?xg0xANXux2ossiNERinMX0Dh9UfPHncKp4qHFB64NFnH9CuLBkvHNycBiGri?= =?us-ascii?Q?jqjfKMuTzPK/wksz9lPw1C4MhFJ4InvN5FXU+CfnS4/JK5j0nGvBXcwvZWxl?= =?us-ascii?Q?1zWUTvcBeABweK+Pqzh118EhZltsgskKvio1t3J5MfVYnGi49cqMyrk5UsPM?= =?us-ascii?Q?6DyndInpQDwxOeLX6rmlsOAywLafAxpll6z2msgYagCbwYQ1kvgnp1gXIu6f?= =?us-ascii?Q?MQPZH15gLRHaWSVrPaTolg6io3X0WUr+LNH2SLOjFFqs0DKiKHwxWYten2P8?= =?us-ascii?Q?bh5GrVbqPUzXBTUdpRykp86y1wpKoPwqDNCv1HveGxHpSNueAWq995BnulLp?= =?us-ascii?Q?Sksd1nIi6tj1niTBD7ruUKr0tpcKt2iVJmSlq7AHqUrxrjrvpYmu4IwQybc0?= =?us-ascii?Q?fJs9FqjfMeR7q117qcb9Y9HD5OZKGep+KTX02Qqhg+1XY31d5v9hQ/l46mdj?= =?us-ascii?Q?2BjSPdeMt8g178iIga5C0aN5GuXXoqXkETMnSsazIqRX4tB/xlCQCoh5UtN+?= =?us-ascii?Q?azm5P6xe2xS8om36qGBwA/G1pFRCTVYwwBb9oIsv/GMQmDqnNaaiQqCT6QOq?= =?us-ascii?Q?CdVO+rxO/zbE/Wq82Pc=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB4981.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d89835e-f3c4-43b6-bcb8-08dc4cb9ea28 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2024 10:54:16.0630 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ggCIjpbqPryUjoe/Ye6kie86PF9DDYlgMad5lrafzEZOS7B3FSP/6mNgWTMm+CnHR2sI3AoPL0l6/l9WI11wyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6673 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 25 Mar 2024 03:54:21 -0700 Reply-To: devel@edk2.groups.io,sivaramann@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: MPwIW0bXvT141pG2L7o4Ykvlx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=pcrRxQPv; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Saloni: " On 2/27/24 05:49, Sivaraman Nainar wrote: > Hi Laszlo, > > We can see the issue not only with SLES, it can be seen with Ubuntu 22 al= so. > > Do we have any channel to work with grub team to fix this issue? No particular channel. Oliver has been participating in upstream grub2 deve= lopment (CC'd), so I figure bug analysis and bugfix posting should occur on= their normal development mailing list. Laszlo" This is the last update from Lazlo. I am not directly involved working with= Grub team. Thanks Siva -----Original Message----- From: Kasbekar, Saloni Sent: Saturday, March 23, 2024 3:33 AM To: Sivaraman Nainar ; devel@edk2.groups.io; Laszlo Ers= ek ; Santhosh Kumar V ; Clark-wi= lliams, Zachary Cc: Raj V Akilan ; Soundharia R Subject: RE: [EXTERNAL] Re: [edk2-devel] [PATCH] NetworkPkg:Resolved Consec= utive Pxe-Http Boot Issue Hi Siva, Have you looked into getting this fixed in grub as Laszlo suggested? What's= the expected timeline for this workaround? Thanks, Saloni -----Original Message----- From: Sivaraman Nainar Sent: Tuesday, March 19, 2024 4:32 AM To: devel@edk2.groups.io; Laszlo Ersek ; Santhosh Kumar = V ; Kasbekar, Saloni ; C= lark-williams, Zachary Cc: Raj V Akilan ; Soundharia R Subject: RE: [EXTERNAL] Re: [edk2-devel] [PATCH] NetworkPkg:Resolved Consec= utive Pxe-Http Boot Issue @Saloni Kasbekar, Can you please comment on the changes? Thanks Siva -----Original Message----- From: Sivaraman Nainar Sent: Monday, February 26, 2024 4:01 PM To: devel@edk2.groups.io; Sivaraman Nainar ; Laszlo Ers= ek ; Santhosh Kumar V ; Saloni K= asbekar ; Zachary Clark-williams Cc: Raj V Akilan ; Soundharia R Subject: RE: [EXTERNAL] Re: [edk2-devel] [PATCH] NetworkPkg:Resolved Consec= utive Pxe-Http Boot Issue @Saloni Kasbekar, @Zachary Clark-williams, Could you please add your feedback on the changes proposed? Thanks Siva -----Original Message----- From: devel@edk2.groups.io On Behalf Of Sivaraman Na= inar via groups.io Sent: Thursday, February 22, 2024 7:33 AM To: Laszlo Ersek ; devel@edk2.groups.io; Santhosh Kumar = V ; Saloni Kasbekar ; Za= chary Clark-williams Cc: Raj V Akilan ; Soundharia R Subject: [EXTERNAL] Re: [edk2-devel] [PATCH] NetworkPkg:Resolved Consecutiv= e Pxe-Http Boot Issue **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** Laszlo: Thanks for the detailed feedback on the changes for this issue. Since we ar= e not sure if this change are valid / violate some purpose of SNP driver, i= t mentioned as Workaround. @Saloni Kasbekar and @Clark-williams, Zachary can add more on these changes= . As you recommended, we can have PCD which controls these changes till the c= hanges are addressed in grub. @Santhosh Kumar V is this issue can be seen only in SLES 15 or it can be fo= und in any OS having Grub 2.x? Thanks Siva -----Original Message----- From: Laszlo Ersek Sent: Thursday, February 22, 2024 5:15 AM To: devel@edk2.groups.io; Santhosh Kumar V Cc: Sivaraman Nainar ; Raj V Akilan ; So= undharia R ; Saloni Kasbekar ; Zachary Clark-williams Subject: [EXTERNAL] Re: [edk2-devel] [PATCH] NetworkPkg:Resolved Consecutiv= e Pxe-Http Boot Issue **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** On 2/21/24 18:15, Santhosh Kumar V via groups.io wrote: > The customer has a server environment where PXE and HTTP service run in s= ame Linux Server. In this environment a SUT trying to boot to SLES 15 OS vi= a PXE from the Boot Menu. After PXE Boot file downloaded and grub Loaded wi= thout continuing for installation Exit is pressed and control back to Setup= . > Now the HTTP boot to SLES 15 OS tried in the same environment and failed = to download the file. If there is a reconnect -r performed before this HTTP= Boot then boot file download and installation is getting success. > Root cause of the issue is, when Exit from grub performed, boot Loader St= ops the SNP Driver and starts the same. This sentence feels like the key one. Are you saying that grub calls Snp->Start() just before it exits? If so, am I right to suspect that that's a grub bug? It sounds like a resou= rce leak, after all. Can you perhaps include a grub source code location / pointer in the commit= message? > During this process SNP is in Initialized State. When HTTP boot is perfor= med immediately after PXE Failure, the MNP configure method initiates the S= NP Start again. Since the SNP already started by grub it returns EFI_ALREAD= Y_STARTED and none of the upper Layer drivers are getting started. > As a work around in MNPConfigure(), if the SNP Start failed with Already = Started and in Initialized state we can return success so that rest of the = drivers can be loaded and HTTP boot can work. > > > Cc: Saloni Kasbekar > Cc: Zachary Clark-williams > > Signed-off-by: SanthoshKumar > --- > NetworkPkg/MnpDxe/MnpConfig.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/NetworkPkg/MnpDxe/MnpConfig.c > b/NetworkPkg/MnpDxe/MnpConfig.c index 93587d53aa..0f2df28d73 100644 > --- a/NetworkPkg/MnpDxe/MnpConfig.c > +++ b/NetworkPkg/MnpDxe/MnpConfig.c > @@ -1120,7 +1120,9 @@ MnpStartSnp ( > // Start the simple network. > > // > > Status =3D Snp->Start (Snp); > > - > > + if ((Status =3D=3D EFI_ALREADY_STARTED ) && (Snp->Mode->State =3D=3D > + EfiSimpleNetworkInitialized)) { > > + return EFI_SUCCESS; > > + } > > if (!EFI_ERROR (Status)) { > > // > > // Initialize the simple network. > The commit message does say this is a workaround, and I don't immediately a= ny see why this workaround (in the code) would be problematic in practice, = but it still leaves a bad taste in my mouth. Consider: the call path is the following: MnpConfigure() [NetworkPkg/MnpDxe/MnpConfig.c] -- public .Configu= re() protocol member function MnpConfigureInstance() [NetworkPkg/MnpDxe/MnpConfig.c] MnpStart() [NetworkPkg/MnpDxe/MnpConfig.c] // see notes! MnpStartSnp() [NetworkPkg/MnpDxe/MnpConfig.c] Notes: the MnpStartSnp() call in MnpStart() is conditional on two circumsta= nces (at the same time): - "If it's not a configuration update, increase the configured children num= ber." - "It's the first configured child, start the simple network." In other words, the MNP driver has just bound SNP "BY_DRIVER" (i.e., exclus= ively), installed the MNP service binding protocol for each vlan (IIUC), an= d one of those SB instances is now being used to create the first MNP insta= nce. I think that under these circumstances, it is reasonable for the MNP d= river to expect that the underlying SNP be in stopped state. :/ How long would NetworkPkg have to carry this workaround? (I.e., how long be= fore the grub issue is fixed, and the buggy version deprecated?) I'd prefer at least a comment in the code that the return path is a workaro= und for (I feel) an earlier SNP usage violation. A FeaturePCD to disable the workaround could be reasonable too (but the Net= workPkg maintainers could disagree about that). BTW, the commit message should be wrapped at 75 characters. These long line= s (in the body) will pass PatchCheck, but generate warnings. Those warnings= are tolerable for log quotes, URLs, etc, but for normal English text, wrap= ping is much preferred. Another comment on the commit message: the subject line should state someth= ing like NetworkPkg/MnpDxe: work aroung SNP state leak in grub Laszlo -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117085): https://edk2.groups.io/g/devel/message/117085 Mute This Topic: https://groups.io/mt/104498511/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-