From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.9122.1636680464193906421 for ; Thu, 11 Nov 2021 17:27:44 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=wHlocMph; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: ray.ni@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10165"; a="319256779" X-IronPort-AV: E=Sophos;i="5.87,227,1631602800"; d="scan'208";a="319256779" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2021 17:27:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,227,1631602800"; d="scan'208";a="733477933" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga006.fm.intel.com with ESMTP; 11 Nov 2021 17:27:42 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 11 Nov 2021 17:27:37 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 11 Nov 2021 17:27:37 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 11 Nov 2021 17:27:37 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 11 Nov 2021 17:27:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SvbskjEC9B7y1ablLXLYCGPdrQOTDuXds3dvP6Biycx7fIhuWWx7CM9i50A27vuK5NtteQ771Dt2/UZGuX4aMctNWuXGwDMjXy/kVaXQBQd5427X9BGUy8LL3JX75V69iEIy0saloo1L9kh3BiXOj4W1c2jWTZlFua2woIOefECIwO+Xxjkev4m+WxZ5XaLhCwcc6ylFy0lIlyBidT7rrif4BFvjDJGky/GR2toL0QnGYrRbfNSY2sSyUmGVC4z4yBI1hQ3vIT7vt3iLIKM+uvZ3YCYE+XK2b+/RHyZgHDlZw4c2ByqaAsw7KiqO0+CLO9tEQl03iTk3d7ARN8wX6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=07hh0ik0dO/8SHDjH/I2Lbqbowru0gsA0UpaciRgGTE=; b=AQw+wIlIw66bcy8w75O/anAsPa4CM/8Ds5PJLkRg7SeEZUgzdbecTZKjRDyackt2NRP4q9pHdqpSGLsk/JwmnnDzcfz4JLKkcfyqsZoltYTyquwYdIhI6TYc8CSZb05lYdDqHpLueJcxEUoUrwzIezkwhmpiwrZz5k2n5XYiHC4QUXcwJzFHAnpu0wdV4mgxPaOY8jbuUI6Z8qXAhdThak3ohqWQnrlQHwCW0PoQOcYd5dOrJzdDnjTR3FtgDB8Bmzjwg+WH9YK17A7eHbXmMeygnKkZ9+e1JLavNOHgYH26wNclt2jNvxQP8WrFDT8bTcgWsjlUwDcfwfrU8Q/Hqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=07hh0ik0dO/8SHDjH/I2Lbqbowru0gsA0UpaciRgGTE=; b=wHlocMph7ES2yzM10VhP9QkKx7xQ8fKD0+k/k5+rloXjavus31C5i4JVJtXarCrR5HNyZUo/d6Axnr24X1hOEefXte1CcqYExjR15M31NM/+wwrDqpP38kEXZZpEAv+YZRVM/ljvG+UxL7U8wcObitnuMMl9xmXM3gBpWr2Ig3U= Received: from BN0PR11MB5696.namprd11.prod.outlook.com (2603:10b6:408:14b::11) by BN6PR11MB1603.namprd11.prod.outlook.com (2603:10b6:405:10::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.13; Fri, 12 Nov 2021 01:27:36 +0000 Received: from BN0PR11MB5696.namprd11.prod.outlook.com ([fe80::317e:de35:e920:7778]) by BN0PR11MB5696.namprd11.prod.outlook.com ([fe80::317e:de35:e920:7778%3]) with mapi id 15.20.4669.013; Fri, 12 Nov 2021 01:27:36 +0000 From: "Ni, Ray" To: Brijesh Singh , "devel@edk2.groups.io" CC: James Bottomley , "Xu, Min M" , "Yao, Jiewen" , Tom Lendacky , "Justen, Jordan L" , Ard Biesheuvel , Erdem Aktas , "Michael Roth" , Gerd Hoffmann , "Kinney, Michael D" , Liming Gao , "Liu, Zhiguang" , "Kumar, Rahul1" , "Dong, Eric" , "Michael Roth" Subject: Re: [PATCH v12 22/32] UefiCpuPkg/MpInitLib: use PcdConfidentialComputingAttr to check SEV status Thread-Topic: [PATCH v12 22/32] UefiCpuPkg/MpInitLib: use PcdConfidentialComputingAttr to check SEV status Thread-Index: AQHX1oCMKCvO417nrESyom8jUE1cc6v/GxXQ Date: Fri, 12 Nov 2021 01:27:35 +0000 Message-ID: References: <20211110221457.2397234-1-brijesh.singh@amd.com> <20211110221457.2397234-23-brijesh.singh@amd.com> In-Reply-To: <20211110221457.2397234-23-brijesh.singh@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 62874f8c-7ace-44d4-3e9d-08d9a57b9bb3 x-ms-traffictypediagnostic: BN6PR11MB1603: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: taRbewxPxO4nlpp5DcaeDhUEFi7PqWG7cy8LmZ5/iP3/NarR5uoZ/KIol+x9q52aDv4QcwgZ+K7Mi+6Sxp7VZAPNq0ApKtim8v2TLnBs7WlRgzp3KCNkUXkEBYUiUOF4dscXla1VRRpVyrW9KmFWs++ijKgYi6uVlmIYKACmGTvUvsQ2EjDb8ri24rB9kzqBt9Q4/oHc/3ydJhdMUBFlqZH2rY2fzqpiCBrRUfjnz2Syo98j6kyKx2rcbqQlIOPPwoq0+uxKwVAbaKVx+bOjfMuxNOQJrb+sJfixHVBHLiTJMoHTwdS8DB/K7XmgQeCYC33JgpBUPbiidrnTrvGxSjlGE/SjWcNRLnHheJi2mlLqqTlCA/q11heDTbeVdflnhQuSk5F0fcbpNuOrSSTrlIa3FeL8rCe2ZrQgbLuixxchj/+eu4iKreVsWPM9PjbOIQnMSzsNOa7z8O0AY+Xz+KbNUkQnjluuRBGuRLZ6XrymykydRfrkQCsNnpyyu4KNHKWg6JgeWnzKpF7BZJLcDRVOstHOAU3y/zuzUigyj3aKbePwq/KBLtmjPzJtQQOi98AL7LkzHxen4ql82+XEVHX6hjLC9Ae2frJ48ouw5mSjszUqenR5hgVtVZZp9YTSamgU3eoukiQCdd4QhYsIqle+gbWCMJkuH4wDzv8v8gfeyJMSeoOxnYe8RgvT6sJA1236aR7uWZTrYCKhD9kkWQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN0PR11MB5696.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(366004)(110136005)(71200400001)(316002)(52536014)(54906003)(38100700002)(86362001)(8676002)(82960400001)(122000001)(9686003)(38070700005)(2906002)(66556008)(186003)(76116006)(66946007)(66446008)(66476007)(64756008)(4326008)(8936002)(7696005)(5660300002)(33656002)(6506007)(508600001)(26005)(4744005)(55016002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?anc34mzZObzf9gj4bqUqqHsCBpLm3kW4MoOG53wOylEeXi5WZ6tu9Ok/XHMS?= =?us-ascii?Q?C5GELqWw2FgZkKYCkvsjiKIwhjAMueENPuV8X0qsAXnO3TXr4MJ5nZx2WXj3?= =?us-ascii?Q?Jb67gBUcZaY+1Y4tWu8UoQG7GQOLHF9DKYHCjzHA2z51krCcYpRo8pcluE8L?= =?us-ascii?Q?55G/9VsOjT+Yz9NyCZAsu6/RAalkK8beHfVpNWjvWHCpOL2o0PriGDKqcO91?= =?us-ascii?Q?cBz5uZyTZLKn04cut2wnAPrFhcKOvwO7CePn3rn2RptxIbfyr3yPLrPC/0cV?= =?us-ascii?Q?yGiuP0KnUDRD77cDGu/UNARHVxpLRpW35O7YiW8P681Uf9DQIvdyg4ZiBTIc?= =?us-ascii?Q?fzsJjQZvwsfuMlAl4urnD0Bn2hrEluLdqIKNIe32QJ0CC49ZCySZVqfjZBFb?= =?us-ascii?Q?1q4UFdQGggIyscFAMhvTn9tKLd2CVp+ySlv/sWrL876DQcI24r+KIrp6Xxu1?= =?us-ascii?Q?A4JN4p6P+DYAZM+uGKzJR8+VBxkXbHFKfniIBCdOvGJFlnb0ayE2FgSgIRwu?= =?us-ascii?Q?lAKz+F1xmq6xwrrZQJz0qO9JSSw1GzjG1A6QMIWqARQ2vApEQKGm+d2VUiFA?= =?us-ascii?Q?SdhKZe3jlDgc5xhh+zavVj3MjV15vRu//Vfj7QqoDNVC2s/EwdINq++l7owa?= =?us-ascii?Q?31yEsBDmAQeAHdyNxZzO95ORQDDv4ZqzEZBdVULdIcXd4G94Gq4lUdBJmXF0?= =?us-ascii?Q?7cLZ+fWATFj/4OtnG6xAi3JfAgQb5nPPdeF1IiJSKG4XBoKaZ46gj3+9ounm?= =?us-ascii?Q?jMcCwF0TFRIiMs6HDrqEUKWASIpBgFg4FHwM8Pu0C8H5ACTHwNerZnreVJNk?= =?us-ascii?Q?CbyWUrU5yF9ihBdrRUtq3QGE8n1INtSp/U6ai8CJKkGhQNgeiPqk2BT+794F?= =?us-ascii?Q?Q6nlWydkSHBJqr4cElaohl+GvhjwZ6TtQfKyCYfXtaw2vqORRE6eSgqdLjI7?= =?us-ascii?Q?+3noxpp/Bq/JfawExo5MDdk6YvEX+GZkH/hcfVG1U6NhbaXOUleXLNSaWDQn?= =?us-ascii?Q?zbMQzqFI3OfQ2vvd58Q+8m2dUvRq1OGOSgKTSxslhKshpPi7qCje1vIQRE5c?= =?us-ascii?Q?xkLpsyV3bZwrf+mkJNKFZwxKgjYDxv1hi3it0FBtb0VizxToiXmprHETZIGv?= =?us-ascii?Q?6x6ioEkJPsiZXbu98t8SVisteCEXLElkZFji69d9HXzKgqzURjhCHId49svu?= =?us-ascii?Q?mqDeLTRoUcRmPKdeMCYfJU1qGyAPo1d6vB2DT5KHAx5hMPIvE/nP2kse2D+B?= =?us-ascii?Q?mzqfXeYvI52ccy52QnaSXfHe1hE1Rb0598ntrFZA4MA95zSXBNXJaF2vU1fs?= =?us-ascii?Q?/G57KJfi39eoWQHkg5hsQCBgjrUhUNDEjYOWF0NRILtzFQOAPySVVOacg5Z1?= =?us-ascii?Q?swJkPhW2A7M2YhyETF8KGX83F852a3j5cwmJpBfmGfGE8b1ITaaK5eK7ygNV?= =?us-ascii?Q?Mht8WYDzPgmuLPLcq+eb4aYoZ54WYXtbtXP5m+LA+hMqSh/IZIE4uHET7eUZ?= =?us-ascii?Q?rugdBf6c80aVwEeY/9Q8KC4Hn0DBepOyxDl0D7pdm0s2xQDACg2JKchXG3EM?= =?us-ascii?Q?QXTJ6KnddVsv50IK8fqVzuRnizzyymndxj9zChqopqA9YKAXl9ALuycFxwFv?= =?us-ascii?Q?fGB26CjU5QEkMem0qZWEsts=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5696.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62874f8c-7ace-44d4-3e9d-08d9a57b9bb3 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Nov 2021 01:27:35.9191 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gMjoQtEJJUwDXQL5lCIw84PNJOiiBqm3Tv8O0uvaywb/KtgTMRtiVfjc4blhnhFaQZBycTjCvZM/ODkL3WXcLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1603 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable 2 minor comments.=20 > + switch (Attr) { > + case CCAttrAmdSev: > + return CurrentAttr >=3D CCAttrAmdSev; > + case CCAttrAmdSevEs: > + return CurrentAttr >=3D CCAttrAmdSevEs; > + case CCAttrAmdSevSnp: > + return CurrentAttr =3D=3D CCAttrAmdSevSnp; 1. Can you put comments to explain that the relationship between the three= features? That can explain why ">=3D" is used here. You may use ">=3D" for SEV-SNP as well, in case AMD invents a more advanced= SEV.:) > + > + return (CurrentAttr =3D=3D Attr); 2. I guess a "BOOLEAN" type cast is needed.