From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.4445.1645664122586214314 for ; Wed, 23 Feb 2022 16:55:22 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Y4yB2DaC; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: guomin.jiang@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645664122; x=1677200122; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=8/eOZrX3NfTh9sxykhPFFjZ02sPR25rZa+6PWHjF140=; b=Y4yB2DaCq/MQNsP/6UkoERY8dr9hZ5po8rCv5+JF0ZTJkmPDBZuuHHoE /3Gxd21CtyEIqo6lAwnzj0W9QQX6F6Xh1+vySjPsUX/n/L55w7t6k5loq hvulwzB5k9E1iYAZwHqvwNgiZDjUyKzLIucANw/z+Jtv4mdZVtQF8SHaF hnx0Gt594wsevHy0xJAzRhtQNUavTkwkjsbZmEKChHvzn/fhuOEfW/O+E uKoxWy3lR/L5/+24xjZqBhfJW9Gt/Gh4nJmWCohovynzHckf4p2FQDIvs hLK1XzNvl+KizkQKxImZVLz97GQQYUXeu9ykuxW+F1ZPsvP7soes7xhX3 Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10267"; a="252311913" X-IronPort-AV: E=Sophos;i="5.88,392,1635231600"; d="scan'208";a="252311913" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2022 16:55:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,392,1635231600"; d="scan'208";a="707256681" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga005.jf.intel.com with ESMTP; 23 Feb 2022 16:55:21 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 23 Feb 2022 16:55:20 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 23 Feb 2022 16:55:20 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 23 Feb 2022 16:55:20 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 23 Feb 2022 16:55:20 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lVpEAGuduFC/ea3WFALrAwiMPDkj76HSb2VcjSExoY9tiQGpd4H4FSWLKncMsF6SsHcraReik75elzoMtucyRaOJvnSHrENGV7vkDakXPqGOnR+Bzko7VtC2zEgHLRV1X4EWUEVmaTPIh9i/oZRXDHTUkI5NRnFiuclYtaWFVNJYmTrcXpVMxnOQthbszuHBvarBX8XGefjIyprvPG9uTUNN4dPmF1PMXI7RI5wgPHffPEW+MW4K/S4M0xRZ8SKVYA43+nr4uIUOQxYtLyj89ABUUZ/cAUuQduIZ4WwMAeWFZKlnFnEtvneg0cZLIWlbcFl9m2gI2nyhh9tc2qtp2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hhvgajQbk+qTI9FQDnaoTKWEVco3raC5R5TkjoIfnrc=; b=IZd96XSlUE3AduJk6xW7P/PRrHKeDMdlk6RMEysiTjbnoL+n0vSMbjJOuSoiUFycyCpv1YhZA7ZksjgFmYG3TVDJxxAfepcT9b0GKyctZpLl+0WhlWDzLMr6xlIXSdt08PTSxV5mMOX3F786iZ5oqM54e7jc6ebL6rhDk1vQA/fGYZyup+qBB4HQ/gDxdyKl87Y3t10pnnfzX4M6ZUQBn7UgBWAT6o2Bkjb/l9sXccTiNnSowWAK2sIy0Ak3eAqXNJCg2Mhn4ohxEJciaUtY4aAqdjywBGAL20dZWmA+O5dg0hlcOnWuPWEr45AIysPK/vZIm4ZqrRJQb7L7SMECjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN0PR11MB5696.namprd11.prod.outlook.com (2603:10b6:408:14b::11) by SJ0PR11MB5600.namprd11.prod.outlook.com (2603:10b6:a03:3ab::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.23; Thu, 24 Feb 2022 00:55:18 +0000 Received: from BN0PR11MB5696.namprd11.prod.outlook.com ([fe80::f80c:f1ef:6d46:20ec]) by BN0PR11MB5696.namprd11.prod.outlook.com ([fe80::f80c:f1ef:6d46:20ec%2]) with mapi id 15.20.5017.022; Thu, 24 Feb 2022 00:55:18 +0000 From: "Guomin Jiang" To: "devel@edk2.groups.io" CC: Andrew Fish , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH 2/2] EmulatorPkg/EmuGopDxe: Set ModeInfo after Open successfully Thread-Topic: [edk2-devel] [PATCH 2/2] EmulatorPkg/EmuGopDxe: Set ModeInfo after Open successfully Thread-Index: AQHYJ54OxRsbinzxRkG0fc6wBkQZrqyh4vUQ Date: Thu, 24 Feb 2022 00:55:17 +0000 Message-ID: References: <20220222034038.966-1-guomin.jiang@intel.com> <16D5FEACC0A8B3B7.28921@groups.io> In-Reply-To: <16D5FEACC0A8B3B7.28921@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7a67c366-e9e9-45c1-ee55-08d9f7305382 x-ms-traffictypediagnostic: SJ0PR11MB5600:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ywcAWUyGLKgOWPeuNw0jsoSZonpCGM7oGclxhF9HXqKd9v0eaFWN9xeGtABJKoxahmIk+ii5rizbq0dTPsE66SY2cw+Z44EY/nxQhZRmZsBOvamFzdsaTTPHfmnn7psdQg0msOjYKSO1+CuvS2MdjLKCUWx8DouS5eSG/33ZE143kVclw6XxY/jyr3Ssi1Xx8x/4YYPG0MjP84YRPy3itTxZtfkyN1bH6Gc6myc34hKUZ9Jv4H3yAgVrgmMD9DDSR3v883RSSB5q5pVNbtHnS0rJJWgUnGxqMi+2K+I+lJAJPZllZiSujvhSBHH5hgGBmVd+b5SRLU72C+P6VRwFrdcqU3X/Tbif4NC27A+H/5mlMf66sL7S8DRJOTGu0Vg8bx+sYFsjNA9HLHo/b1tSV/oL+HzJwA6zop2DzL1RdwmGnE4U/+w16Kl2zL/d3jdKBeHKcDFgqlLhOH7DSgCnpBMzLe+lDMqxIRl93Mc9Tjot4UwL5KKv5vZmA3tNS5IM+l9iUu9DIsUokYKbnFkKYglgOzd3LMSoKToQmC4mmKnPd6ADWUXUGYBx0VQdvSaF2k1gZSjjf8Tlp/HERCKUTTXkWddMXriAKvZwQgWaHFvKcJt/Vone6SL7Oe7PIdFFVuvmnMYQCRLXoH0tMl9PoOGN5AFwkaWEcB9brVt1AAX9p+ihViM3SUhUgHVXAi2cLBRi5pOnNU8Pji+dhpVVBOZZQR8cTpyrtBFCoPAWm+pDBvK+BVLtTDftDcHmvkoCL3+ZMuSj/6XNAtathHosZ7tVtS2xOIhcebx/zCOxtAgg3gW3b+cv/JWSt4aIXGrQuC5Y0GNsAnTfIVkKG8F0hw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN0PR11MB5696.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(84040400005)(2906002)(6916009)(38070700005)(86362001)(9686003)(54906003)(5660300002)(82960400001)(38100700002)(122000001)(76116006)(8936002)(52536014)(66946007)(66556008)(66476007)(66446008)(4326008)(64756008)(316002)(71200400001)(8676002)(966005)(508600001)(53546011)(7696005)(6506007)(186003)(55016003)(33656002)(107886003)(83380400001)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RNJHgARJA5ln7jRBtz6b0EArEIGHjP3rt3nu5Io4wVXrZgawZEs6lFLDvCuS?= =?us-ascii?Q?LwL5bNxW5GySf5WrLmJmo7h0pGswZLqUOPQOvxBqBhtmfvA8QnvOEw5Uq91D?= =?us-ascii?Q?OGftuPhEbtf2VMk3DT206Hrfzqc6xfSkcwvEDs09gy3X42nIuKrI7Jwv3btY?= =?us-ascii?Q?j18bKoyJoFhQAzOZnX1LbqYIHIe6/mv4nwuPSQnJRXf7J48OSp+tbI9ysPSX?= =?us-ascii?Q?0sFleldqLHHbWrLYSkoVzFxiMG+9ahefEwO6dBqn/30JKFxqjUpIa4Qsu1Sc?= =?us-ascii?Q?EktHzTd3Z7DV8Dg7pjmnJJLKkRp0oAMKC6k2gnu3TOy2uQtl4yPftJNQh55B?= =?us-ascii?Q?LRkkQ21y3262cRR5iDT8XwCIkK/PLuGkG4WMYgKt5UQjHHwHkHQkISAWDKJz?= =?us-ascii?Q?S8X/MU1fxrsWkfq/ATs1WCYegQe2EsYfpbh0r2uMwM0w4csr1HOnalYI5N5j?= =?us-ascii?Q?ZpLb8f2YarvJbQ3P1ha72U//DbF19gxvUBu4zp670KeZd5X/u/c8lVrLi2s0?= =?us-ascii?Q?pHCac3HuWznl6mloucyLsvKs+yoRWTcXxd/V8zfzJ9UB5NYIeFesLmTn8Qzp?= =?us-ascii?Q?CqlPMdCXzl930hkJt1J6ym7+GFNUFb/QO6XpOMmAqwcfFRhoiFd/AYxblLpj?= =?us-ascii?Q?G/2J9/DHhJ3S/lRwerm70hOm/oe/hOp4l1ObJ2q4SMCCiVC7k17jkVMfWTDz?= =?us-ascii?Q?+QtooKqjVmEsN+JW+TUYepCfsgcY/HF0RVtLK2vY6YYfIx1wHJxF8XH4y7bP?= =?us-ascii?Q?3mAQtPJzUZYxoacUFzyy3HqdieF/PLrQNT6eEJ38LTBuiC1SGjO+AYOG8ivZ?= =?us-ascii?Q?r330QYgxEiTcE/pOTZYkk0Rkdl1FcmvSTFEQo93suRcD0RnWoQFYRKIF16gz?= =?us-ascii?Q?2lQWwL/odvkLfPXXN303Le0szCWBkrm30+WVhGkWfKCsVm/nx/4+JaIi269N?= =?us-ascii?Q?Ee//V2jsGOh6SVYIb7QQHhraF+iVbmTLNi00IyU+Qy1oM50ZZXamYKtrZ2KR?= =?us-ascii?Q?fcNkmlOpefUL/zwkOYxLfliPoNUoXxilNwwGo1VG52gGPvwRxm9SahoqpfGn?= =?us-ascii?Q?iYlEV5gqyZAv4gydKWxWqvA6WUxIm7pNM9vjHd6IXrmpYkta38pWvhIqxqYD?= =?us-ascii?Q?gY+yfgqkGJdzarIsyCEw/TU8nID1YCB9cLGLWQfelvsCGxMNUuUZlz4D7nDn?= =?us-ascii?Q?s/nJZaQcEgmwbW2OSRkjUE0MN9g0QCut6xP+XB1K2bT18bKbqMfvnX83ur3z?= =?us-ascii?Q?DS5OmMY7TuQlRWkcsFX0zIA8xGUlEG3CTLRP3QiMeMbWQDai/Zr4Jw35jchF?= =?us-ascii?Q?yD13AdKx35U3XYaGtECpAHZLHo6q1f22D3wCuG8Vv6Uf4F+emtsrTB/qnjT6?= =?us-ascii?Q?H9t7UDRJ9cln0lqPK/gcW/dJOVcV2jdvhaMLOFmltpTl2Ko1J7mA9+Kwnwt/?= =?us-ascii?Q?pkGwPjuc+JbbaGsGVz1cqEtXGy7NkOmX8Xw5+XOPQlg6Vz6TsAzdCnATHxdg?= =?us-ascii?Q?iYzXn+jolOjssOf+IvHFeOBXHpo63MP7iyjosAFU1zfa2mx15fmAI6CluuV+?= =?us-ascii?Q?kMLk/01p6MXlK+6xU+I4NQDgujZMqUKVjsz8L/QPrdDKh9tW78USd6UkL5jL?= =?us-ascii?Q?PwjBcbsibunp7UAZpTSQTQ8=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5696.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a67c366-e9e9-45c1-ee55-08d9f7305382 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2022 00:55:18.0122 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WSUPd+UYa9tUVW/zGLHCtRBFTW7yDhOW7fYpH+lFPIIQXS6B5eLwsnvOhXSRHZPTDeai0CPnL4Y5bCSaW+kApw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5600 Return-Path: guomin.jiang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Fish and Ray, Can you help review it? Thanks Guomin > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Guomin > Jiang > Sent: Tuesday, February 22, 2022 11:41 AM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Ni, Ray > Subject: [edk2-devel] [PATCH 2/2] EmulatorPkg/EmuGopDxe: Set ModeInfo > after Open successfully >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2668 >=20 > WindowOpen will fail in some case. for example, without XServer. >=20 > Shouldn't set ModeInfo in this case to avoid the caller use it incorrectl= y >=20 > Cc: Andrew Fish > Cc: Ray Ni > Signed-off-by: Guomin Jiang > --- > EmulatorPkg/EmuGopDxe/GopScreen.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) >=20 > diff --git a/EmulatorPkg/EmuGopDxe/GopScreen.c > b/EmulatorPkg/EmuGopDxe/GopScreen.c > index 41f748bc6402..ec5ef795d6e5 100644 > --- a/EmulatorPkg/EmuGopDxe/GopScreen.c > +++ b/EmulatorPkg/EmuGopDxe/GopScreen.c > @@ -108,10 +108,6 @@ EmuGopSetMode ( > } >=20 > ModeData =3D &Private-= >ModeData[ModeNumber]; > - This->Mode->Mode =3D ModeNumbe= r; > - Private->GraphicsOutput.Mode->Info->HorizontalResolution =3D ModeData- > >HorizontalResolution; > - Private->GraphicsOutput.Mode->Info->VerticalResolution =3D ModeData- > >VerticalResolution; > - Private->GraphicsOutput.Mode->Info->PixelsPerScanLine =3D ModeData- > >HorizontalResolution; >=20 > if (Private->HardwareNeedsStarting) { > Status =3D EmuGopStartWindow ( > @@ -128,6 +124,11 @@ EmuGopSetMode ( > Private->HardwareNeedsStarting =3D FALSE; > } >=20 > + This->Mode->Mode =3D ModeNumbe= r; > + Private->GraphicsOutput.Mode->Info->HorizontalResolution =3D ModeData- > >HorizontalResolution; > + Private->GraphicsOutput.Mode->Info->VerticalResolution =3D ModeData- > >VerticalResolution; > + Private->GraphicsOutput.Mode->Info->PixelsPerScanLine =3D ModeData- > >HorizontalResolution; > + > Status =3D Private->EmuGraphicsWindow->Size ( > Private->EmuGraphicsWindow, > ModeData->HorizontalResolution, > -- > 2.35.1.windows.2 >=20 >=20 >=20 >=20 >=20