[PATCH] UefiPayloadPkg/UefiPayloadPkg.fdf: Update DXE A Priori file

[PATCH] UefiPayloadPkg/UefiPayloadPkg.fdf: Update DXE A Priori file

[Gao]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3729

Platform desires to load ReportStatusCodeRouterRuntimeDxe and
StatusCodeHandlerRuntimeDxe early in DXE to make DEBUG() via serial
port work thereafter since DXE will use PeiDxeDebugLibReportStatusCode
as default DebugLib instance. However, with UefiPayload enabled by
default, UefiPayloadPkg will override platform's DXE A Priori file
and miss these two modules in its DXE A Priori file, so just add them
back.

Signed-off-by: Gao Cheng <gao.cheng@intel.com>
Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
Cc: devel@edk2.groups.io
---
 UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayloadPkg.fdf
index 2f5cb17f62..dd2dc1bf56 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.fdf
+++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
@@ -87,6 +87,8 @@ APRIORI DXE {
   INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
   INF  MdeModulePkg/Universal/PCD/Dxe/Pcd.inf
   INF  UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf
+  INF  MdeModulePkg/Universal/ReportStatusCodeRouter/RuntimeDxe/ReportStatusCodeRouterRuntimeDxe.inf
+  INF  MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandlerRuntimeDxe.inf
 }
 
 #
-- 
2.26.2.windows.1

Re: [PATCH] UefiPayloadPkg/UefiPayloadPkg.fdf: Update DXE A Priori file

[Ni, Ray]

Gao,
The patch content looks good to me.

However the commit message is misleading.

" UefiPayloadPkg will override platform's DXE A Priori file
and miss these two modules in its DXE A Priori file, so just add them
back."

Apriori file decides the dispatch order for each FV.
I don't think the UefiPayloadPkg will override platform's DXE apriori file.
How about following?

"Put ReportStatusCodeRouterRuntimeDxe and StatusCodeHandlerRuntimeDxe
in Apriori list to enable DEBUG() through PeiDxeDebugLibReportStatusCode
as early as possible".




-----Original Message-----
From: Cheng, Gao <gao.cheng@intel.com> 
Sent: Thursday, November 11, 2021 6:16 PM
To: devel@edk2.groups.io
Cc: Cheng, Gao <gao.cheng@intel.com>; Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Ma, Maurice <maurice.ma@intel.com>; You, Benjamin <benjamin.you@intel.com>
Subject: [PATCH] UefiPayloadPkg/UefiPayloadPkg.fdf: Update DXE A Priori file

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3729

Platform desires to load ReportStatusCodeRouterRuntimeDxe and
StatusCodeHandlerRuntimeDxe early in DXE to make DEBUG() via serial
port work thereafter since DXE will use PeiDxeDebugLibReportStatusCode
as default DebugLib instance. However, with UefiPayload enabled by
default, UefiPayloadPkg will override platform's DXE A Priori file
and miss these two modules in its DXE A Priori file, so just add them
back.

Signed-off-by: Gao Cheng <gao.cheng@intel.com>
Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
Cc: devel@edk2.groups.io
---
 UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayloadPkg.fdf
index 2f5cb17f62..dd2dc1bf56 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.fdf
+++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
@@ -87,6 +87,8 @@ APRIORI DXE {
   INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf

   INF  MdeModulePkg/Universal/PCD/Dxe/Pcd.inf

   INF  UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf

+  INF  MdeModulePkg/Universal/ReportStatusCodeRouter/RuntimeDxe/ReportStatusCodeRouterRuntimeDxe.inf

+  INF  MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandlerRuntimeDxe.inf

 }

 

 #

-- 
2.26.2.windows.1

Re: [PATCH] UefiPayloadPkg/UefiPayloadPkg.fdf: Update DXE A Priori file

[Gao]

Hi Ray,

Thanks for pointing this out. That makes sense.
I should make the commit message from community perspective instead of platform. I will make this change.

Best Regards,
Gao

-----Original Message-----
From: Ni, Ray <ray.ni@intel.com> 
Sent: Thursday, November 11, 2021 9:50 PM
To: Cheng, Gao <gao.cheng@intel.com>; devel@edk2.groups.io
Cc: Dong, Guo <guo.dong@intel.com>; Ma, Maurice <maurice.ma@intel.com>; You, Benjamin <benjamin.you@intel.com>
Subject: RE: [PATCH] UefiPayloadPkg/UefiPayloadPkg.fdf: Update DXE A Priori file

Gao,
The patch content looks good to me.

However the commit message is misleading.

" UefiPayloadPkg will override platform's DXE A Priori file and miss these two modules in its DXE A Priori file, so just add them back."

Apriori file decides the dispatch order for each FV.
I don't think the UefiPayloadPkg will override platform's DXE apriori file.
How about following?

"Put ReportStatusCodeRouterRuntimeDxe and StatusCodeHandlerRuntimeDxe in Apriori list to enable DEBUG() through PeiDxeDebugLibReportStatusCode as early as possible".




-----Original Message-----
From: Cheng, Gao <gao.cheng@intel.com>
Sent: Thursday, November 11, 2021 6:16 PM
To: devel@edk2.groups.io
Cc: Cheng, Gao <gao.cheng@intel.com>; Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Ma, Maurice <maurice.ma@intel.com>; You, Benjamin <benjamin.you@intel.com>
Subject: [PATCH] UefiPayloadPkg/UefiPayloadPkg.fdf: Update DXE A Priori file

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3729

Platform desires to load ReportStatusCodeRouterRuntimeDxe and StatusCodeHandlerRuntimeDxe early in DXE to make DEBUG() via serial port work thereafter since DXE will use PeiDxeDebugLibReportStatusCode as default DebugLib instance. However, with UefiPayload enabled by default, UefiPayloadPkg will override platform's DXE A Priori file and miss these two modules in its DXE A Priori file, so just add them back.

Signed-off-by: Gao Cheng <gao.cheng@intel.com>
Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
Cc: devel@edk2.groups.io
---
 UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayloadPkg.fdf
index 2f5cb17f62..dd2dc1bf56 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.fdf
+++ b/UefiPayloadPkg/UefiPayloadPkg.fdf
@@ -87,6 +87,8 @@ APRIORI DXE {
   INF  MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf

   INF  MdeModulePkg/Universal/PCD/Dxe/Pcd.inf

   INF  UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf

+  INF  
+ MdeModulePkg/Universal/ReportStatusCodeRouter/RuntimeDxe/ReportStatusC
+ odeRouterRuntimeDxe.inf

+  INF  
+ MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandlerR
+ untimeDxe.inf

 }

 

 #

--
2.26.2.windows.1