From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.10668.1636638602321346683 for ; Thu, 11 Nov 2021 05:50:02 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=b+KXMdct; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: ray.ni@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10164"; a="319113088" X-IronPort-AV: E=Sophos;i="5.87,226,1631602800"; d="scan'208";a="319113088" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2021 05:50:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,226,1631602800"; d="scan'208";a="492547960" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga007.jf.intel.com with ESMTP; 11 Nov 2021 05:50:01 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 11 Nov 2021 05:50:00 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 11 Nov 2021 05:50:00 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 11 Nov 2021 05:50:00 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 11 Nov 2021 05:50:00 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l5Mn/xS+APQN+adRBem5nh8Z0zDpUSgED7OIfSEUP5FF8fn16J174gP13d5tHKh/N4SLNvJ+75d7wV2jYn0W6rGMfHeTZbrbydIR9eGurA7ElWghuUKAWyEw4AyXQuQYJeDDBx+X0I6MSPweJ18pKSZs5KezGjQC5lZngwFpwG2NXc/ym8BVoWVxLFeK3doDSXR2Rd2pYPvdTpQSaXSa9Gi/NtYWe0/E/4hlDfGEzXr5CN/zhsn/u9kcXIfZ3j3P0a39xP/FQrbEUrZuvoYJimg4i2OD/IBlWv0MnM/bLeA+8yF5uUMQtLcUQIYmeASTxGa3XyCeUfB0njG+Lq46eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cMK2NlJgcwiE6TbBCq7cJA+QJNue8gh8A/8/1iYtKYQ=; b=GT2j3v0Fup2rmXfG3uI7Ur0JMoPIqnVn+8Pm0lMh2IYGZzzLb+5ar1c/ipjt2pfE1o11CMU/BP/OMwfBXCdEj5j+uvEEpADiJALe7D+WAk5EM1CHSVWQdxwQe4cXu4yrHImaP19Pm61M3nD/Mfh+XFGHhI7fbnXgtHMg69p1gljlvF39JUxM16xSEbSr5PR0MOrlDrj1jMEE+0WvSkEsQwoS1mqm9rZxjBmv0OuzAHcn5lNq802qi5WAqqmnW4g4hQtHll4Jgm75+vfrkYhLvQTKYV74N+QtYZSPv18LKk2ciohAOSEDGrYPtClBFcuMxc4TjgrB+oYT53fGqplEiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cMK2NlJgcwiE6TbBCq7cJA+QJNue8gh8A/8/1iYtKYQ=; b=b+KXMdctJwo2ifggbV+kjWyvDJQ+CUEa5or7XDlaAKXeOeIlYBGACeKi6/Cl8i0INiwsvweGAgoSZTAD/4Lh/YpL7AuKZ4NnkeumN+rQVpGwz0mlT8odIyQCzQhzWvRNc8dPY7pRwxJJpiwTLcpYIa4+lEGSO0p+x9cY/BgapPw= Received: from BN0PR11MB5696.namprd11.prod.outlook.com (2603:10b6:408:14b::11) by BN6PR11MB1523.namprd11.prod.outlook.com (2603:10b6:405:10::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.13; Thu, 11 Nov 2021 13:49:59 +0000 Received: from BN0PR11MB5696.namprd11.prod.outlook.com ([fe80::317e:de35:e920:7778]) by BN0PR11MB5696.namprd11.prod.outlook.com ([fe80::317e:de35:e920:7778%3]) with mapi id 15.20.4669.013; Thu, 11 Nov 2021 13:49:59 +0000 From: "Ni, Ray" To: "Cheng, Gao" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Ma, Maurice" , "You, Benjamin" Subject: Re: [PATCH] UefiPayloadPkg/UefiPayloadPkg.fdf: Update DXE A Priori file Thread-Topic: [PATCH] UefiPayloadPkg/UefiPayloadPkg.fdf: Update DXE A Priori file Thread-Index: AQHX1uU0ibcKVVBur06h43lu1vw1Tqv+Vldg Date: Thu, 11 Nov 2021 13:49:59 +0000 Message-ID: References: <3948c05d744ceaca2e5e4995120eda1b29a209db.1636622688.git.gao.cheng@intel.com> In-Reply-To: <3948c05d744ceaca2e5e4995120eda1b29a209db.1636622688.git.gao.cheng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 252f3792-9044-46dc-e62a-08d9a51a26f3 x-ms-traffictypediagnostic: BN6PR11MB1523: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:227; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dV9Anw94deWCOYsVanBGPhovMzg2/1SuQ2bbL0+kFylBxu1KhxdmbfqjPP54gKNWNQmExvDgHW47HZNyoAUmYfceQMfy0OCvlgsjvEfrvYEKf0pIXSIbSkIO+gZ0r5gosrOjPqxHb1I6pG8/S7tRvRiym2xtW6wrH4OiMDpETaQo4CvUCqmCDAgxDum9ZdDPaZjl4+NXQJL+EW6QG19tb7kmmRhm2/Hraa1FKZOC+TTBsoBxtsuH43rYOf12vkADGXyk4/VgzfdTIX0Un+dpMO3M02vtw6HRRl6OiaWF3mBvYX8bQYragWlsQeTeK2H2o9u9Mi9XPkWsoVV3eqLvGu4+v1gBz3amE1/12dCJzzLZfku7at2W7c2HUbufABuc/mAzwhgrzIAHpGRx1w6N7KLaf2mfxE1uMOOS67dTJzDczbpa0iWydBpLoMrlOnC923PoTBpI1qy37Gwls+TlBsx9oUnwj1Z1eyoPuE0FANcLa6kTTK/J7yGDfZhSlPILxCVq2vbhZJcLh41K3MKXvS4g1PxSUv4ra1/Y7mlJ/qwPM2vlWsVErOb6bQG8AQGvf7tOxeMp1R2m6P5oSb+hPsAsldCRuRW6QrxJx99mFFj4411AP4xSNe6p9IgKLqS4uA6orM/UwoG6UjlusvJ+Rwh5iKmf7BsZ3ygU0UXkH8DDme3sNDY6G2zgNrqxXrFnXnzj6TxqJDnERnI7/jLdqug1luyvgu3gnuLXSvDBxMcsaYTXQe2NMLbI7jTTQEYsKVcyVnlMpvN/e8eeGdYnVwhHzvMDFitR0r++q8RF4OM= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN0PR11MB5696.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(64756008)(71200400001)(86362001)(38070700005)(66476007)(66556008)(66446008)(5660300002)(66946007)(966005)(316002)(76116006)(107886003)(122000001)(110136005)(4326008)(6506007)(186003)(8936002)(82960400001)(52536014)(38100700002)(26005)(54906003)(15650500001)(2906002)(53546011)(7696005)(55016002)(508600001)(9686003)(83380400001)(8676002)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?66xms71sEU5DZ7JhY1J5LvJy03K71kUei60qCVEPg66+kKCM7h1UCEzuVzGS?= =?us-ascii?Q?OLrIj6E4Rk4wgzAJY7mPcv0vewFvdyudEM5MbDnYes0Oug8V+lARvpY89oS2?= =?us-ascii?Q?cvTYliRy2BP69juXhUadTiAPvuC5XVijtP4D7u+YtZ5dxT+2v1fZFr/0ZRFb?= =?us-ascii?Q?APaeYoLDcj7huflz9hPai2rUJWkhqrAOo87eeAYsgj4dhBLfHiQ1ZquSwNMR?= =?us-ascii?Q?xaA3nP/WXgaFjdjLSHzd7dRfUmabWjBHoTcJZVYmr1ksDxqGNOSTHcD50b3A?= =?us-ascii?Q?kbR1BUs8fVe2kzW0yEPaMi60aKtvxsL1gSyKSeiMoehxnB4BXM+ZN0DJhQrm?= =?us-ascii?Q?zHf9C5lI5U+p9SLax176dPq+gMdgcPwdnHhtabOMgjfAPE/K0KYSnCWIFP+g?= =?us-ascii?Q?c3mip7NFRJFe/yQi4C8zmFulMnAROq24tR8eub9RIfx5lZOZ7V3SBBUoDYOB?= =?us-ascii?Q?JGkTs87381D1NWEsVB5Z/Lyo/SxKAWLVxJ/gvh6gbZ8S5r4UZRrnEhB8lSUE?= =?us-ascii?Q?k0q8g4Sia71cTOF4JAhB1HTkb0y8+Q4Viq1GlakAXH0cLtIYrIqDiaZPgDvR?= =?us-ascii?Q?f13DlbrGCuKc/tbXjRzYkRskbp037lk1LC81N3Vv6actKSt75aUAue/5YFpT?= =?us-ascii?Q?QYwSklIURyJfUnXPl+2WgqZeYXDMto6JhFf8QR8XxILJ2/JdHloy17QGPcYu?= =?us-ascii?Q?Zqq8u1H0ZbrZV4yiD8KTsgw0bXCyhC4BF07RHXKUSOMIvShMmUImeM6TwxXM?= =?us-ascii?Q?xqxydxDXRjDlnpRsybZE5CCRHDGGBn3XcfFBV70jPfKfqyg57FRcT91G1CMx?= =?us-ascii?Q?0kbXpCYeUahA8DqJRYF70n/ZAjaUMly1F9k+2/gAnHH9qpRWMduhvAQgWOMb?= =?us-ascii?Q?f23APUJ0hYADX1vqHiv0vGPIhE5owPf2MmPFixc/8FoLC4pSdpuIwHf6xtXU?= =?us-ascii?Q?WYptCkF/Cpg4SSA5rVKp4hjDfqtg09rxsdkshOiKHA3Ms2PtG8Jk/TRZ3x4Z?= =?us-ascii?Q?f+/mFsZVFbGuNtepq8kuwwVLmb6u0nbiQIisP9kvaMpjktQRTzkFI+JCsNW0?= =?us-ascii?Q?dvbbjg1MsvJ2WfRowd2z7YxVCIVv2s/YsGjVE4Ovv6IRIdfYacp2WFUnSf9u?= =?us-ascii?Q?O/BtJBnASmuEohhYW6kBAxaITkmisipbxqZbkoZUu0cHe2MoziT70QeEVroI?= =?us-ascii?Q?/SV9CAA51oVOhREy/aTEKfKecmYle9vDlMfzgYRg2+fY3WJQyKPWV/AYyHZ1?= =?us-ascii?Q?6s6MpOSZwFSUE9l4UlL8GX2HYSxuSMApdRwWtk1kZ90F1AyzRPYCQerG/PEa?= =?us-ascii?Q?wABwbPWx4XkIV/tHBvSfWIZNTsi9NMMzybZt66/ekCarpJOfvE0ecl0Okwr6?= =?us-ascii?Q?M8KTZgxcB0WJCUpsHQA3LOxa3goQ6wRmvg8ZB1xD4K359o7DY1SjX7UIfd2h?= =?us-ascii?Q?BlQCquRuZIRR8Vn5P9dz1u2RY9UzUAQloQSOUH5ivFhqLNK/rPCA/jzNsUsd?= =?us-ascii?Q?myUsvfAYR6L997PcliJmtrz7Zl+M7Dafeor/1Uy4nwYQwk02Tby5GKU3h2Nq?= =?us-ascii?Q?pe6Xkk8ENKMzWAfhwviZQAR53jhHP+FBV5xtbYm3GOG17yiie2DsbotXhXpY?= =?us-ascii?Q?tHJ1NC/ANVCfWgEezWYiBxE=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5696.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 252f3792-9044-46dc-e62a-08d9a51a26f3 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2021 13:49:59.0468 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: urHOADtfCGIHb40ZzNMzNCVTbwz+azaz1TOj9H0ykcWWGwb+PLdkhXePWoqIUgV+boMTzkW/J+wNiY4a3m8Nag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1523 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Gao, The patch content looks good to me. However the commit message is misleading. " UefiPayloadPkg will override platform's DXE A Priori file and miss these two modules in its DXE A Priori file, so just add them back." Apriori file decides the dispatch order for each FV. I don't think the UefiPayloadPkg will override platform's DXE apriori file. How about following? "Put ReportStatusCodeRouterRuntimeDxe and StatusCodeHandlerRuntimeDxe in Apriori list to enable DEBUG() through PeiDxeDebugLibReportStatusCode as early as possible". -----Original Message----- From: Cheng, Gao =20 Sent: Thursday, November 11, 2021 6:16 PM To: devel@edk2.groups.io Cc: Cheng, Gao ; Dong, Guo ; Ni, R= ay ; Ma, Maurice ; You, Benjamin Subject: [PATCH] UefiPayloadPkg/UefiPayloadPkg.fdf: Update DXE A Priori fil= e REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3729 Platform desires to load ReportStatusCodeRouterRuntimeDxe and StatusCodeHandlerRuntimeDxe early in DXE to make DEBUG() via serial port work thereafter since DXE will use PeiDxeDebugLibReportStatusCode as default DebugLib instance. However, with UefiPayload enabled by default, UefiPayloadPkg will override platform's DXE A Priori file and miss these two modules in its DXE A Priori file, so just add them back. Signed-off-by: Gao Cheng Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: devel@edk2.groups.io --- UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayload= Pkg.fdf index 2f5cb17f62..dd2dc1bf56 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.fdf +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf @@ -87,6 +87,8 @@ APRIORI DXE { INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf INF UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf + INF MdeModulePkg/Universal/ReportStatusCodeRouter/RuntimeDxe/ReportStat= usCodeRouterRuntimeDxe.inf + INF MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandl= erRuntimeDxe.inf } =20 # --=20 2.26.2.windows.1