* [`edk2-devel][PATCH V2] UefiPayloadPkg: Fix the build issue for coreboot
@ 2021-10-15 5:07 Guo Dong
2021-10-15 5:52 ` Ni, Ray
2021-10-15 13:05 ` Ma, Maurice
0 siblings, 2 replies; 3+ messages in thread
From: Guo Dong @ 2021-10-15 5:07 UTC (permalink / raw)
To: devel; +Cc: Guo Dong, Ray Ni, Maurice Ma, Benjamin You
From: Guo Dong <guo.dong@intel.com>
V2: Fix GCC build issue.
There is typo in previous change caused coreboot build failue.
This patch fixed the build issue.
Cc: Ray Ni <ray.ni@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
Signed-off-by: Guo Dong <guo.dong@intel.com>
---
UefiPayloadPkg/Library/CbParseLib/CbParseLib.c | 4 ++--
UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c | 4 +++-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c b/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
index f81aa0f301..4be5d66ba5 100644
--- a/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
+++ b/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
@@ -194,8 +194,8 @@ GetParameterBase (
return NULL;
}
- PcdSet64S (PcdBootloaderParameter, (UINTN)CbTablePtr);
- ASSERT_EFI_STATUS (Status);
+ Status = PcdSet64S (PcdBootloaderParameter, (UINTN)CbTablePtr);
+ ASSERT_EFI_ERROR (Status);
return CbTablePtr;
}
diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c
index 5a1e578668..0e6dcf10f9 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c
+++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c
@@ -406,7 +406,9 @@ _ModuleEntryPoint (
SERIAL_PORT_INFO SerialPortInfo;
UNIVERSAL_PAYLOAD_SERIAL_PORT_INFO *UniversalSerialPort;
- PcdSet64S (PcdBootloaderParameter, BootloaderParameter);
+ Status = PcdSet64S (PcdBootloaderParameter, BootloaderParameter);
+ ASSERT_EFI_ERROR (Status);
+
// Initialize floating point operating environment to be compliant with UEFI spec.
InitializeFloatingPointUnits ();
--
2.32.0.windows.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [`edk2-devel][PATCH V2] UefiPayloadPkg: Fix the build issue for coreboot
2021-10-15 5:07 [`edk2-devel][PATCH V2] UefiPayloadPkg: Fix the build issue for coreboot Guo Dong
@ 2021-10-15 5:52 ` Ni, Ray
2021-10-15 13:05 ` Ma, Maurice
1 sibling, 0 replies; 3+ messages in thread
From: Ni, Ray @ 2021-10-15 5:52 UTC (permalink / raw)
To: Dong, Guo, devel@edk2.groups.io; +Cc: Ma, Maurice, You, Benjamin
Reviewed-by: Ray Ni <ray.ni@intel.com>
Thanks,
Ray
-----Original Message-----
From: Dong, Guo <guo.dong@intel.com>
Sent: Friday, October 15, 2021 1:08 PM
To: devel@edk2.groups.io
Cc: Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Ma, Maurice <maurice.ma@intel.com>; You, Benjamin <benjamin.you@intel.com>
Subject: [`edk2-devel][PATCH V2] UefiPayloadPkg: Fix the build issue for coreboot
From: Guo Dong <guo.dong@intel.com>
V2: Fix GCC build issue.
There is typo in previous change caused coreboot build failue.
This patch fixed the build issue.
Cc: Ray Ni <ray.ni@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
Signed-off-by: Guo Dong <guo.dong@intel.com>
---
UefiPayloadPkg/Library/CbParseLib/CbParseLib.c | 4 ++--
UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c | 4 +++-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c b/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
index f81aa0f301..4be5d66ba5 100644
--- a/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
+++ b/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
@@ -194,8 +194,8 @@ GetParameterBase (
return NULL;
}
- PcdSet64S (PcdBootloaderParameter, (UINTN)CbTablePtr);
- ASSERT_EFI_STATUS (Status);
+ Status = PcdSet64S (PcdBootloaderParameter, (UINTN)CbTablePtr);
+ ASSERT_EFI_ERROR (Status);
return CbTablePtr;
}
diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c
index 5a1e578668..0e6dcf10f9 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c
+++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c
@@ -406,7 +406,9 @@ _ModuleEntryPoint (
SERIAL_PORT_INFO SerialPortInfo;
UNIVERSAL_PAYLOAD_SERIAL_PORT_INFO *UniversalSerialPort;
- PcdSet64S (PcdBootloaderParameter, BootloaderParameter);
+ Status = PcdSet64S (PcdBootloaderParameter, BootloaderParameter);
+ ASSERT_EFI_ERROR (Status);
+
// Initialize floating point operating environment to be compliant with UEFI spec.
InitializeFloatingPointUnits ();
--
2.32.0.windows.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [`edk2-devel][PATCH V2] UefiPayloadPkg: Fix the build issue for coreboot
2021-10-15 5:07 [`edk2-devel][PATCH V2] UefiPayloadPkg: Fix the build issue for coreboot Guo Dong
2021-10-15 5:52 ` Ni, Ray
@ 2021-10-15 13:05 ` Ma, Maurice
1 sibling, 0 replies; 3+ messages in thread
From: Ma, Maurice @ 2021-10-15 13:05 UTC (permalink / raw)
To: Dong, Guo, devel@edk2.groups.io; +Cc: Ni, Ray, You, Benjamin
There is a typo ' failue' in the commit message. Other than that, looks good.
Reviewed-by: Maurice Ma <maurice.ma@intel.com>
> -----Original Message-----
> From: Dong, Guo <guo.dong@intel.com>
> Sent: Thursday, October 14, 2021 22:08
> To: devel@edk2.groups.io
> Cc: Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Ma,
> Maurice <maurice.ma@intel.com>; You, Benjamin
> <benjamin.you@intel.com>
> Subject: [`edk2-devel][PATCH V2] UefiPayloadPkg: Fix the build issue for
> coreboot
>
> From: Guo Dong <guo.dong@intel.com>
>
> V2: Fix GCC build issue.
>
> There is typo in previous change caused coreboot build failue.
> This patch fixed the build issue.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Benjamin You <benjamin.you@intel.com>
> Signed-off-by: Guo Dong <guo.dong@intel.com>
> ---
> UefiPayloadPkg/Library/CbParseLib/CbParseLib.c | 4 ++--
> UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c | 4 +++-
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
> b/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
> index f81aa0f301..4be5d66ba5 100644
> --- a/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
> +++ b/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
> @@ -194,8 +194,8 @@ GetParameterBase (
> return NULL;
>
> }
>
>
>
> - PcdSet64S (PcdBootloaderParameter, (UINTN)CbTablePtr);
>
> - ASSERT_EFI_STATUS (Status);
>
> + Status = PcdSet64S (PcdBootloaderParameter, (UINTN)CbTablePtr);
>
> + ASSERT_EFI_ERROR (Status);
>
>
>
> return CbTablePtr;
>
> }
>
> diff --git a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c
> b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c
> index 5a1e578668..0e6dcf10f9 100644
> --- a/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c
> +++ b/UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c
> @@ -406,7 +406,9 @@ _ModuleEntryPoint (
> SERIAL_PORT_INFO SerialPortInfo;
>
> UNIVERSAL_PAYLOAD_SERIAL_PORT_INFO *UniversalSerialPort;
>
>
>
> - PcdSet64S (PcdBootloaderParameter, BootloaderParameter);
>
> + Status = PcdSet64S (PcdBootloaderParameter, BootloaderParameter);
>
> + ASSERT_EFI_ERROR (Status);
>
> +
>
> // Initialize floating point operating environment to be compliant with UEFI
> spec.
>
> InitializeFloatingPointUnits ();
>
>
>
> --
> 2.32.0.windows.2
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-15 13:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-15 5:07 [`edk2-devel][PATCH V2] UefiPayloadPkg: Fix the build issue for coreboot Guo Dong
2021-10-15 5:52 ` Ni, Ray
2021-10-15 13:05 ` Ma, Maurice
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox