From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web08.4480.1645664193614296227 for ; Wed, 23 Feb 2022 16:56:33 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=TGTu5fVC; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: guomin.jiang@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645664193; x=1677200193; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=goi7ZUprobXZg1nBcw+m4R6PNvwCq7R87vvjBcOpUEY=; b=TGTu5fVC7QrrXtMm5+HY10lZC20TzxAKRX2hIu8TryzG78nBVWxCpOP/ ykelwBXI/N5wEsD24bDqG1OdEoeku6Pcg529VgMYdXYeKSIqb+T71IvzJ 4OXb0BEjq6Mq0Ybw/ExK6Vo+AEDz+5k8Ihs0Babxeo8WOChmgXNOhLSGL nvxZZ+7Cbhr7c6QPg4lBc5SI0n2L7TrNjl2Y3A8LXKp8rka/BC1doJUoY Pjbwt5tnKeMKnvWsxGjbTAz3YP0EMDCp3jOEa8TaYheLrsodKZK4WMB+Q wtytZwfJbBgGI9r319TcKfhxVixhABRoGaWrb7dj8KErDgoSYC1+D7l8e w==; X-IronPort-AV: E=McAfee;i="6200,9189,10267"; a="276743040" X-IronPort-AV: E=Sophos;i="5.88,392,1635231600"; d="scan'208";a="276743040" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2022 16:56:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,392,1635231600"; d="scan'208";a="707256959" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga005.jf.intel.com with ESMTP; 23 Feb 2022 16:56:32 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 23 Feb 2022 16:56:31 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 23 Feb 2022 16:56:31 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 23 Feb 2022 16:56:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OWxTezDpO+S4I0t9wZ4249YbGKDJV6aQSnoNXCRn8szwky7ObOiyg3ASgQUmufYzj4v2AtM47ga+fihk0Tl1RffpeS1z9WqmpaeIqFZLDObg2aIUtMaTEA5JL7uvwfLcWi37Rx0RcaJv9wjwRo7b4qlsKNdczt/Li6ZuCoitJ5B4sgf4o/BLPZg/3Eg7ghpVCry27CrjLMEE/zz4lxAyoIIHaY+ZaHTdXTQkBFCKJqCt4AB4ij538ZyNzvUwRIJLWtfANd9khyxdYM6qczreocgP7HulGtMUVMWcaIH0lQazDdhoAuf/ihXWQEqY6wviS2VXjzrakgckRgNgyYvFyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2EhD1tCRuzJmAZk04Q/STMGqTOTnAKl4IIkuNziV/d8=; b=Umgj4a1xHhHFjZqi8WQOKsShJZjqeCpFCUwDKyIRPnfMMmY7OdBDvtn/FQAKu7OXEuOvtuuzvgWcCqDRvb9jrTbJv0tYRl/5mfGDsQgtGsIkrdK+5OvkPJ5giOWrrra9fi55BA8ZvP9TpWeZMzAwqnUnp5mrkVwsR2deUX/2paAyiIuVAeXpAAnt74lfQ+cbQdGwtdzELvlE60Nqq3rVhzfiVR+I/rUy3NuvEG1YM7FfXz7x1ZtTEboCMxP/H5NB4G4qT6yb/vJ6onD/LfHHrvDPvo+07yG52qo2Gdj+DE7eHvoI/7vE36kfXtNZUif3J1AOCXX2BO01SQA8yuMpCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN0PR11MB5696.namprd11.prod.outlook.com (2603:10b6:408:14b::11) by SJ0PR11MB5600.namprd11.prod.outlook.com (2603:10b6:a03:3ab::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.23; Thu, 24 Feb 2022 00:56:29 +0000 Received: from BN0PR11MB5696.namprd11.prod.outlook.com ([fe80::f80c:f1ef:6d46:20ec]) by BN0PR11MB5696.namprd11.prod.outlook.com ([fe80::f80c:f1ef:6d46:20ec%2]) with mapi id 15.20.5017.022; Thu, 24 Feb 2022 00:56:29 +0000 From: "Guomin Jiang" To: "devel@edk2.groups.io" CC: "Wang, Jian J" , "Gao, Liming" , "Gao, Zhichao" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/GraphicsConsoleDxe: Check status to make sure no error Thread-Topic: [edk2-devel] [PATCH 1/2] MdeModulePkg/GraphicsConsoleDxe: Check status to make sure no error Thread-Index: AQHYJ54LRNotx1ywJkOBsM5Yww+lWKyh4z3Q Date: Thu, 24 Feb 2022 00:56:29 +0000 Message-ID: References: <20220222034038.966-1-guomin.jiang@intel.com> <16D5FEAC9A733E6B.24964@groups.io> In-Reply-To: <16D5FEAC9A733E6B.24964@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ed1cf7f2-a5f2-4577-9be5-08d9f7307e41 x-ms-traffictypediagnostic: SJ0PR11MB5600:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gof8VSDI/6SU6KeYLlKvN0i25unY3K/cMNuujdtehlImQ2AHFNS5uupNZXuWfWjhzGzE7Iyx9UrDuGO5GPkIW6O3DB9qfgK6FYU096olRNqwmgjpgMmc5AD4KLozzHZWMOnRERXswlMtGz1aI7QBJ1rilFWh5h9pLGCeZvofntlN+pe41q29DjPRw2PsNyjwwA0nroB3VRU9AZpHhIjhfvVV17YlYmEuu0BnBo/5sQw9g7XR5AmNe4C5HUZuyH9UIcY4B6zRlcUGOD54go7JB+jK8embEXC2yLLPnANnkStrjuMtLAQK+fvsKvwkY24J75/ucivVbcbc/qi9zB2ltI5BGikAYw6S7c1Y0WOzCUSNw6EHMgSm5XxnCw5ZXzuE5XFoMpjfsxtW+OfbCHjOxEKKFkny5dQmIB9lWBvyMqybOJ0uhxGBWic7lA6YtaWDxHlDPqiaZvGdBL57bNWmpXnxfrpxlV/OA/792yziEzwSp2+zZW+lfyjFYvncjQGoJfmRUcS0ewm1xceEQq/k56+Z6rKG8TbPAX4TmFX+iM9xQx/RfAfdKNoh2COt8gTR7EDlkC1XDqw7tb+v+xfFoz4A7Hs7Bndv7Y1EXeaAUqMsAlr3h+uvJg4a7+iZvMgtbszXDem8K78qL4i5zyshUAf0UKOutL2L3Yi7UI4AIXFBN5UXYySld/+VqS9EsBZGP74YuJWajpSlM6V2ks9J756I9YOdmOVf2su9398tQwkYJqLTRVLx45p5pN6UWMIzKm0YXufYbUrgI3dDcH91YwyL0BvIog+gNM7byi/CBpIe0qc9vbAyEdr4tvtKWGoc459RyvIiB070RBEqNW+/lA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN0PR11MB5696.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(84040400005)(2906002)(6916009)(38070700005)(86362001)(9686003)(54906003)(5660300002)(82960400001)(38100700002)(122000001)(76116006)(8936002)(52536014)(66946007)(66556008)(66476007)(66446008)(4326008)(64756008)(316002)(71200400001)(8676002)(966005)(508600001)(53546011)(7696005)(6506007)(186003)(55016003)(33656002)(107886003)(83380400001)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KJSPR8PK69RD4MJ3qE1JhnkeIMdWrE8PjcyUSlQKZgVpiDTXadWAepDRfqhj?= =?us-ascii?Q?HVrooXchFZupQBJ7GWrUQVnZI1mcbwVb4HyFiQFxGJiPR0QReXQ43KhJM/sk?= =?us-ascii?Q?hm/Yj90o6JyxzmlljKYfPx5qXi/73tqRUyxZLOhr68lTQI3ZZS8IMmrueFzH?= =?us-ascii?Q?KFJ7iTxIUkT09RpFO4wnA8nFhF8faeusAeG8Cxk3zeMFCs6t1O09pxVxCma6?= =?us-ascii?Q?eyZCtN9q4BcBdrlQGtwDcrhefucE+HxeK0/JkM46YkCiaWL/Ujb0VeF+tA/U?= =?us-ascii?Q?ym01hFPesdE0Df5quXV3i6voL6p0goI2oinPPYvUQM/eUXaUKRU2CMqhlKdX?= =?us-ascii?Q?4PD8m3D3AVxokXTePUpZwqLoYxydR+LjpO8XT4zrqgVMME9yUE7l1xH1fdYC?= =?us-ascii?Q?g+NhENtGh9dh6jajzU6mBWNQ2vaJ6TQ6bUvWr9cjzshy2ZPYLtS2ei5T1WFm?= =?us-ascii?Q?KjWDjt1H1awXLWIBdSBJk3tDkEtcrK0tyLTm/KqEaBVDvVrT4FxG24CIuc9F?= =?us-ascii?Q?Z1nJdqI0WporOwkrocSKGMPHNf10466cmocIOpa1Q5L19OMFIeU1NsVaNskk?= =?us-ascii?Q?aRFl/Hu64T7dQFw4eitfCiaKZ8rJKYXoOuJonfqOQUmK019D5g3nXm86lKHQ?= =?us-ascii?Q?3G9SengWgsXg/A/mU/Zql+0954LtlSMg6x+//rM+FBxT6IJ4KJICtYnPr/rw?= =?us-ascii?Q?FGUgciDyoJXH+vwmIvgsE6HTqxh3jR8j47RWIV3/LFICThv2TbJ7/LKSHytQ?= =?us-ascii?Q?vLrxug3TLFLQo6G/AEyQc/E4gpWqD5BrdF/tOl5sTB7ZxX3q/hcJmBR/ISGN?= =?us-ascii?Q?78f9y8DVeYdglzjmVIdSdAjDGFslywmzY0FniHIEeKBN2aRupInbJTD75ROP?= =?us-ascii?Q?9ap333JLcjHMDCxRMIXgGSuU+IHDU97kavxO2lWtLT3GDYoimD2eqPQSKwyM?= =?us-ascii?Q?lWhEvCPDLeMFpurV3oaNmfLnkE+HVFjuFPvj4fSS7yixhPCxodBirgCP7NLj?= =?us-ascii?Q?2mNpjvyMkeZcKbrczOw81AB6eHUBHc/ZpRvmYENROuRT8pBYEijD7Q9rtWK6?= =?us-ascii?Q?wtIc2fMquQ/2PCer26uFa45yWbBT+TRnBnc8L3mIqJLki76LiS+T+YLPeDvD?= =?us-ascii?Q?SkUedjVk+DK/VgYXJYkkhESZ1KzqcgLat4aURgJcQZL+hfL2bdQDI+FaL0y7?= =?us-ascii?Q?9NFDptUWZkTRk48Dnz6e1kLg5gwFDvdNRMCB/P5CCSpjL7n6zTrm/gh/dlBM?= =?us-ascii?Q?89G46bti5o1YU0Cvm+kp3J5fNoyT5mQwaT3xi+tBXp5k8PlJic+E0ck+6/tH?= =?us-ascii?Q?o17BvK1/7ejoGA8T1wldXIIebPkMvJRBj2SacL3WwN2WDXNzYLeLcb1yX+iC?= =?us-ascii?Q?eVDaCovrshBQ9NQft+xJIBdB1pFB3dcfbv5+8mHnwhsbW1WJY08ZHtdkmGnN?= =?us-ascii?Q?wwW23aL4JHxFenXUgpyoUbteY6gElwHXwhfCPp8/siydEVlYBu9fILRTdavG?= =?us-ascii?Q?zUn8gNyzTl2wziVD32ufpQUIiHrfpzoAAlibQQgR2THyXJXW5WNg/3Lg16xg?= =?us-ascii?Q?u0xpk54gsvHwTNawiuxgXN3x1Jp1mu9LjL2jqEV+aLIrv++JBdfqtqeaFMmg?= =?us-ascii?Q?fxoLPU8SpQPe5UVpxr3/yt0=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5696.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed1cf7f2-a5f2-4577-9be5-08d9f7307e41 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2022 00:56:29.6637 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /51EQcaNTI47U73sk+ul6p8P8i42E+wFWQCheujlLl5QJfzJsfL+gbxjQaBQJdvFhP9OzIUNboBJlWLdgqIo1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5600 Return-Path: guomin.jiang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Liming, Jian, Zhichao, Ray, Can you help review it? Thanks Guomin > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Guomin > Jiang > Sent: Tuesday, February 22, 2022 11:41 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Gao, Zhichao ; Ni, > Ray > Subject: [edk2-devel] [PATCH 1/2] MdeModulePkg/GraphicsConsoleDxe: > Check status to make sure no error >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2668 >=20 > SetMode will fail in some case. for example, without XServer. > Should handle these case when SetMode fail. >=20 > If we don't handle it, it will Segmentation fault. >=20 > Cc: Jian J Wang > Cc: Liming Gao > Cc: Zhichao Gao > Cc: Ray Ni > Signed-off-by: Guomin Jiang > --- > .../Console/GraphicsConsoleDxe/GraphicsConsole.c | 15 ++------------- > 1 file changed, 2 insertions(+), 13 deletions(-) >=20 > diff --git > a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole > .c > b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsol > e.c > index 1bdd1b8a6732..07436cbd15bf 100644 > --- > a/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole > .c > +++ > b/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsol > e.c > @@ -1,7 +1,7 @@ > /** @file > This is the main routine for initializing the Graphics Console support= routines. >=20 > -Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
> +Copyright (c) 2006 - 2022, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -518,7 +518,7 @@ GraphicsConsoleControllerDriverStart ( > } > } >=20 > - if (ModeNumber !=3D Private->GraphicsOutput->Mode->Mode) { > + if (EFI_ERROR (Status) || (ModeNumber !=3D Private->GraphicsOutput- > >Mode->Mode)) { > // > // Current graphics mode is not set or is not set to the mode whic= h we > have found, > // set the new graphic mode. > @@ -531,17 +531,6 @@ GraphicsConsoleControllerDriverStart ( > goto Error; > } > } > - > - // > - // Double confirm SetMode can success > - // > - Status =3D Private->GraphicsOutput->SetMode (Private->GraphicsOutput= , > ModeNumber); > - if (EFI_ERROR (Status)) { > - // > - // The mode set operation failed > - // > - goto Error; > - } > } else if (FeaturePcdGet (PcdUgaConsumeSupport)) { > // > // At first try to set user-defined resolution > -- > 2.35.1.windows.2 >=20 >=20 >=20 >=20 >=20