From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web09.392.1641864281786484994 for ; Mon, 10 Jan 2022 17:24:42 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=kpN49rBB; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: guomin.jiang@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641864281; x=1673400281; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=/5ALEGf4jDimzjknGe+Mso+rPZqJiXNQAmWePje0m6U=; b=kpN49rBBXZ6d2tyKXtfBJP0WVjIt1qLFIb+/eJE/q6/KkcNHqGBRpuXH EkpkmjnZ42NVh8TcDPer8tmOXp1Q97FbIfVw2uOdQkBkUALh93XgYnHh0 LCuFxAQf3zNarkFYLIYKlJ8LzarO897Zs1IEVApdfesegVsYPjLX/eQrl D5YAgLFOQlt4M+bg/KLgpKbQft7HROvxLlyQ4Dc/XXpr8gEt9J2f/5o6o ZPwUE5SsjueHiBAliAkV2WoG0SVMsv1IxfqVlAU1Y4ESqWbuXRamb8Qlw UDUUlWc8Ko7H7xCSp4byEy6My+uBwQwgNgrwwiD8TvQQ5+P2jb1hb9ITL g==; X-IronPort-AV: E=McAfee;i="6200,9189,10223"; a="243171614" X-IronPort-AV: E=Sophos;i="5.88,278,1635231600"; d="scan'208";a="243171614" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2022 17:24:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,278,1635231600"; d="scan'208";a="669643668" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga001.fm.intel.com with ESMTP; 10 Jan 2022 17:24:40 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 10 Jan 2022 17:24:39 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 10 Jan 2022 17:24:39 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 10 Jan 2022 17:24:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b8OtTQW7mye9hh+cFQWcDEElka3KRVVeR+h0TA74/JPlN4mQqPTWEixDdSf0EsjBhc/WVusnU6f36fqahiwIizNXsOf2S0We6B6XY32zujvnQn7XuyJjQf3uQzgJhfQmtWKWEzydCor+3PzSa9JN3WSN7PI4NXnjpmIjnczjAeV/2B2JOho3+5G20jm/96bAQ4KjZj8AjPtduewEv+if2y5uzf6taS8YjOgvaGEnOG0gvcVabUvs95dYKl+kBbf5p81fhotWvFNpVdndEm+nWChiax3nbiMTYTXkiGY/Sj6t02x0RTYA7vT/9PrXJejrVMToHxhSG2BeYG0p4oEaHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n7l5/KfK0cUfbngySabJDsU9yrp83XN8P5HPjjRCYkc=; b=RL1JoCxU4WDjxe/Ypc3I4oUAHe1Hls/62YfP4mVkLttIppbbH6BvPDpGj/hK/PwIkIF0bk6pRlWr7/L+b1F75bxBSwD6FjEBp9r2JsPkoiPtbNfyBAt2R4o2SVEng/Xn3L4F7mBN9OzyJoL5CS5hPFoCK9EwTWQ35Z/shT06aF9GxQHw+t+SfB1v2DAupo2AGzFQB8Gv3l5YjQYOvh47C77zJvy7hebjFu3wRlSYh75KBpEPb7KZ1MD5C8pmdn4FFacCPOB1JfBsMjotf4G312h+x9vBM/t7PiQ/oHqGX1Ml0du8+fkAzff3o9IGjPR0iaFLDWk6deiH9owJfaGdaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN0PR11MB5696.namprd11.prod.outlook.com (2603:10b6:408:14b::11) by BN6PR11MB1779.namprd11.prod.outlook.com (2603:10b6:404:100::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.7; Tue, 11 Jan 2022 01:24:38 +0000 Received: from BN0PR11MB5696.namprd11.prod.outlook.com ([fe80::e89b:8e63:96bc:e0eb]) by BN0PR11MB5696.namprd11.prod.outlook.com ([fe80::e89b:8e63:96bc:e0eb%4]) with mapi id 15.20.4867.012; Tue, 11 Jan 2022 01:24:38 +0000 From: "Guomin Jiang" To: "devel@edk2.groups.io" , "Liu, Zhiguang" CC: "Gao, Liming" Subject: Re: [edk2-devel] [PATCH] Wiki: Add optional steps for developer to run CI test before sending Thread-Topic: [edk2-devel] [PATCH] Wiki: Add optional steps for developer to run CI test before sending Thread-Index: AQHYBdHGZTJOmOprCkWj4MjjaPr7uaxdCBhg Date: Tue, 11 Jan 2022 01:24:38 +0000 Message-ID: References: <20220110032535.232-1-zhiguang.liu@intel.com> In-Reply-To: <20220110032535.232-1-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: be55151c-500f-4212-574d-08d9d4a12284 x-ms-traffictypediagnostic: BN6PR11MB1779:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1247; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kHngVMbADmIxGhUyOQoda8OPTPGrqgTJe608cvIi29qt+CjdJMnvH1/p6YWDDLMWFtAtup2q4TLIZL0clIXnMFSzznk+NhgMvOL8XB+rlRbpnXrzIOTAgqNc7xDVjmoazfGiPeSKsPWbwSN7mHUuq6ek9Z/Y3vLJMSJ6cQDVULJaDKjUHV7DDTR6Xlwbp5OQ/JxUJt+2Jqhk9wa4Fi12rvDvfqoNPHlf5KDoNs/4JMvvNoCOT+cl2Fa1LW++C/ZaYG1LvaWcuG8tzhe55izXcIWXIVbDYcouP5W6rlyE/b+ktHoekBwiQtMZgzBqaZ2H5VJ47/hDy83ld2bv9QqoFIlHCU5RPUmrqvt9Azemap3DjZRx/AtUuhqbWDygd+UwfWkEgFxQDrSxpwaB6M8uvAmg8GRmtZg4kHkp8JAzYgai6wZO2yCMXdEx2iGuEIiOq7YKZPV0Tn7w249raYejIPZ7GMUA+GVHvL0ohB/zrcBrr1JcSR6mBCOLV0ty8Gv02ET6+gk41xKPhgFD2xt+q8/Rp21IKNRJF/zV8PGDQTrrteaB1JqQaH5dvguMtsjONe5gi4ssTY8bpbyzXJ5bVWVUAH0nFIeUT9bqxpfzPaV0U73tBrvYFeZrbjp5sPWVrDAji36XlB3Bzfydg3/jVaudj9o9urAfSxuZyh5kBXPbL27S+2bhsS21P+HUvkq5UxiouXf4Jq7/q6ZJtoAa7+VEpe0Ir950vD48nhu1k+yLz7m9J0Klx3upndq5L3iQ3qT7+0kEk1muNleNOXITkOt4/cPXLZF0UgqULKVyfsziolFQB2KRDNRLTv6VKwTQDPyCU6LGHVFKHorbT7TIag== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN0PR11MB5696.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(5660300002)(33656002)(38070700005)(6506007)(83380400001)(66476007)(82960400001)(38100700002)(76116006)(66556008)(122000001)(66446008)(64756008)(66946007)(2906002)(52536014)(7696005)(6636002)(8936002)(508600001)(966005)(186003)(9686003)(26005)(71200400001)(4326008)(110136005)(53546011)(86362001)(55016003)(316002)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6qHeqcWkiV41muxNr1fgwmD/Fq3vQnCSLAtGFmdp8eS+RzEGVCAmgfl4FIx4?= =?us-ascii?Q?KJji+vnTQM142jwA4qh9k2ck9hYdWA+KrtTGvmJa1vx81TEtm+TTLTb9I8X2?= =?us-ascii?Q?uO5QjIBMSy8D9MHcynKFhv4fYJh1kiCsqDpRakSl+xzQWGrfmJGGd0MRCipB?= =?us-ascii?Q?rJrBtNv/JBnBqMB7doFg5LfuVia1FrzhORow3poEyhY0FS2aFoza58FQuN8n?= =?us-ascii?Q?2K615NxkV6eHtHdHQISSTZHsvKlUBd0q6snVf52HGVhnDnoHLfyWCJpYC6co?= =?us-ascii?Q?MnhiVcLL+QTNq7HDxNPrTGhSxvz2hlwPVzxx+eq7WiAxp7P9hcer7ILUDt6u?= =?us-ascii?Q?7wR7vxKPlnLAX3vAYEciBypJCChMsV35c6MywE7E/DcY6FzCJCOq7ed2wY73?= =?us-ascii?Q?WmmY/L2l6lkuQjrNw/6801FAcHAAOpHV/5bKV/RRpAktj8wxslIoNtYVYCmB?= =?us-ascii?Q?7+dLR1ncD/3FEGwwRq01ivWFJXZ2Bl8KxLBfzorqoEDUmHqx/o9sJldzHKLQ?= =?us-ascii?Q?3LQXd0j8TpsTZHKbyEKNhUDMwb4N+Jd0jRGNZ5zlOBraUMjsQ93LGe4attGM?= =?us-ascii?Q?pHL/uhxMHHMri1/Gj55gb79wRHgpBq2RDkzgxiPhxNrL2fvVgfxk4cZcDsw5?= =?us-ascii?Q?PUyNP0ZgP5DLK4Gv71SWZz1MvMUiodySp1Xm0uttJFawkhynBKxUxi37mZKG?= =?us-ascii?Q?SHJl9B8w2OOsdkH7vHetWgap2vD6NPfOF2BDFvS0tuVBjahh3xnaqrzWX4vj?= =?us-ascii?Q?L/ECvDInJHey8XWIPJvsmMPvZzgHKoRUCxwCXgoNi4jrTOOTNVtWr5ZFWChQ?= =?us-ascii?Q?gLZN62Ch14slrTO0kp/5ovnNaylgRh9KPrplKme0xQ+fG7j/0WiIchVaV+Kh?= =?us-ascii?Q?JbWn6WIPPGOUA4zp5gYIiyLJ57YzFM5QTcfaLWEiVix3DKlPK+06Mo9e23V/?= =?us-ascii?Q?bKKLRWjx4VuJQPfC7CngA+qxrDfraKoW77cnjghy9rEyYvGtMNuS6FV+sXYV?= =?us-ascii?Q?qvuha6TXJXzc39hSQsRqc9DQ3Aw5eb2OkHkKQXoUNj9mRiO61/W9PX934U/s?= =?us-ascii?Q?zznENYT1RF2w7ywDgcepq38iYiqYTIf9ANcYmq7Vl/gWHkiZOk2tQSdLzUcT?= =?us-ascii?Q?UFGwtoYHGNWVtH1PmzoXtdqw+mlmyoOdj2VEVGu1EXpogRrPXwP0kUFqDc/V?= =?us-ascii?Q?VTQsyYx6/baLzmW/8CvI2e6k2SLQTMHwrD5xAmOkcq22v1ZUcC9PfmuMeioP?= =?us-ascii?Q?Z93kWBLf4iLNQqERnLY9fgA6BNuqEbY/ARfi1wzxVtREKOeLrj1jtf43GwMg?= =?us-ascii?Q?EZM2m1fbM7ZH39eCC4VXdQUQiQi6FjnxjZMyluzJp95fTh211dB5T3ugNPG6?= =?us-ascii?Q?MMHnO4oNLlLNRbL94h8KLi+2esfNhDWt9GOu5u3J6ZXqPfMDUcmhs41UE8K6?= =?us-ascii?Q?fRdsJjV1J4Nd2XJtanarVkVN0LDwekgDG0fSAgBGzIYriP0/eqJaMQ93Hhdp?= =?us-ascii?Q?vYgM+9tDx+fwJn1wDvQX3yEZiV6DJu8SazkCUcqhUwvjF3aC37ahZqVc02wb?= =?us-ascii?Q?U/gpVHsSIyqCjzKevQB93DSThbZ5TRlz/QMw3rYT+psiL0Tc7LPNNdBFYfSM?= =?us-ascii?Q?/OT0J5UgPz1bRvp4FnBn66M=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5696.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: be55151c-500f-4212-574d-08d9d4a12284 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2022 01:24:38.2620 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HQChb/d4SWGMmcUV5Dr8t92yTLFLUNDpxbaO/DGw90E1w6wQQ1g51KrGBRJq5ptKSGF8Ko0fd5iCDeWzWMZl8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1779 Return-Path: guomin.jiang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Guomin Jiang Guomin > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Zhiguang Liu > Sent: Monday, January 10, 2022 11:26 AM > To: devel@edk2.groups.io > Cc: Gao, Liming > Subject: [edk2-devel] [PATCH] Wiki: Add optional steps for developer to r= un > CI test before sending >=20 > Cc: Liming Gao > Signed-off-by: Zhiguang Liu > --- > EDK-II-Development-Process.md | 60 > +++++++++++++++++++++++++++++++++++++++++++++--------------- > 1 file changed, 45 insertions(+), 15 deletions(-) >=20 > diff --git a/EDK-II-Development-Process.md b/EDK-II-Development- > Process.md > index 469a979..747c6e1 100644 > --- a/EDK-II-Development-Process.md > +++ b/EDK-II-Development-Process.md > @@ -59,20 +59,50 @@ The developer process for the EDK II project >=20 > `$ git rebase origin/master` >=20 > -9. Run the automated code formatting tool (Uncrustify) against your > changes >=20 > - >=20 > - - [EDK-II-Code-Formatting](EDK-II-Code-Formatting "wikilink") >=20 > - >=20 > - - The changes must pass local CI which includes a code formatting che= ck >=20 > - in order to be merged into the code base. >=20 > - >=20 > - - It is strongly recommended that you format the code after each comm= it. >=20 > - The code can then be easily amended with the formatted output. Some >=20 > - developers might also prefer to format frequently while writing the >=20 > - code using the plugin instructions described in the code formatting >=20 > - wiki page. >=20 > - >=20 > -10. Create patch (serial) to the [[edk2-devel]] mailing list >=20 > +9. Run the automated code formatting tool (Uncrustify) against your > changes > + > + - [EDK-II-Code-Formatting](EDK-II-Code-Formatting "wikilink") > + > + - The changes must pass local CI which includes a code formatting che= ck > + in order to be merged into the code base. > + > + - It is strongly recommended that you format the code after each comm= it. > + The code can then be easily amended with the formatted output. Some > + developers might also prefer to format frequently while writing the > + code using the plugin instructions described in the code formatting > + wiki page. > + > +10. (Optional) Push changes to the developer's fork of the EDK II projec= t > + repository. > + > + - How to create a [GitHub > fork](https://help.github.com/en/github/getting-started-with-github/fork- > a-repo) > + - **NOTE:** A GitHub fork can also be created using the command li= ne > + utility called [`hub`](https://github.com/github/hub/releases). = The > + `hub` usage information can be found > [here](https://hub.github.com/hub.1.html). > + > + - Add remote to the developer's fork of the EDK II project > + > + `$ git remote add https://github.com/ id>/edk2.git` > + > + - Push the integration branch. > + > + `$ git push ` > + > +11. (Optional) Create a GitHub pull request from the developer's > + to edk2/master to run CI check. > + > + - How to create a [GitHub pull > request](https://help.github.com/en/github/collaborating-with-issues-and- > pull-requests/creating-a-pull-request) > + - **NOTE:** A GitHub pull request can also be created using the > command > + line utility called [`hub`](https://github.com/github/hub/releas= es). > + The `hub` usage information can be found > [here](https://hub.github.com/hub.1.html). > + > + - Declare that it is for CI check test in the pull request title and > + description. > + > + - Resolve GitHub pull request issues if it fails. Please refrence st= ep 8 > + in the below **The maintainer process for the EDK II project** > + > +12. Create patch (serial) to the [[edk2-devel]] mailing list >=20 > - Clean out any old patches: `$ rm *.patch` >=20 > @@ -86,7 +116,7 @@ The developer process for the EDK II project >=20 > - `$ git send-email *.patch` >=20 > -11. Modify local commits based on the review feedbacks and repeat steps >=20 > +13. Modify local commits based on the review feedbacks and repeat steps > 3 to 9 >=20 > - For the latest commit, you can use `$ git commit --amend` > -- > 2.32.0.windows.2 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#85435): https://edk2.groups.io/g/devel/message/85435 > Mute This Topic: https://groups.io/mt/88316431/4399222 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [guomin.jiang@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20